50823 2010-12-10 09:33:16 -0800 Flaky Test: inspector/timeline-event-dispatch.html 2011-01-11 04:49:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 50856 1 commit-queue loislo apavlov beidson eric loislo pfeldman tony yurys oldest_to_newest 320205 0 commit-queue 2010-12-10 09:33:16 -0800 This is an automatically generated bug from the commit-queue. inspector/timeline-event-dispatch.html has been flaky on the commit-queue. inspector/timeline-event-dispatch.html was authored by beidson@apple.com and yurys@chromium.org. http://trac.webkit.org/browser/trunk/inspector/timeline-event-dispatch.html The commit-queue just saw inspector/timeline-event-dispatch.html flake while processing attachment 76198 on bug 46895. The bots will update this with information from each new failure. If you would like to track this test fix with another bug, please close this bug as a duplicate. 320304 1 tony 2010-12-10 12:07:18 -0800 If this is on chromium, this is probably bug 50722 *** This bug has been marked as a duplicate of bug 50722 *** 320308 2 eric 2010-12-10 12:10:46 -0800 No, this is on Snow Leopard. The commit-queue is always Snow Leopard. 320315 3 tony 2010-12-10 12:15:18 -0800 Ok, then not a dupe, although we see this test timeout a lot on chromium debug builds. 325667 4 commit-queue 2010-12-22 13:41:00 -0800 The commit-queue just saw inspector/timeline-event-dispatch.html flake while processing attachment 77158 on bug 51429. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 327606 5 77627 loislo 2010-12-29 10:03:34 -0800 Created attachment 77627 [patch] initial version 327609 6 loislo 2010-12-29 10:06:46 -0800 It was a problem with Chromium DRT. DevToolsAgent object instance was attached not only to the inspected page but to the DevTools window too. As result all the inspector files were interpreted as a content of inspected page and were transfered to the DevTools scripts panel for debugging etc. 327622 7 77627 pfeldman 2010-12-29 10:40:39 -0800 Comment on attachment 77627 [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=77627&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:568 > + WebView* view = WebView::create(host, attachDevTools ? m_drtDevToolsAgent.get() : 0); It is true that WebView for devtools should have 0 as WebDevToolsAgentClient. However, even after your fix, same m_drtDevToolsAgent is being reused for different WebViews (and hence encapsulated WebDevToolsAgent instances). This is not right since it results in same host id being used by different WebViews. Are we using this method to create exactly two WebViews - one for layout test and one for DevTools? If so, your fix is Ok. In either case, I'd rather have the views created explicitly and see no generic createNewWindow call that allows reusing the devtools agent client. 327638 8 eric 2010-12-29 11:36:48 -0800 This report was filed by snow leopard commit bots. It's fine to do your fix too, but your fix only affects Chromium (which is unrelated to this report). 327646 9 loislo 2010-12-29 11:45:12 -0800 (In reply to comment #8) > This report was filed by snow leopard commit bots. It's fine to do your fix too, but your fix only affects Chromium (which is unrelated to this report). It is not clear for me why this bug got this comment. ---------- The commit-queue just saw inspector/timeline-event-dispatch.html flake while processing attachment 77158 [details] on bug 51429. Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 ---------- As I understand this is a message from chromium bot on mac. But chromium inspector's test enabled only for Windows. Could you please throw an amount of light on this? 327649 10 eric 2010-12-29 11:51:51 -0800 (In reply to comment #9) > It is not clear for me why this bug got this comment. > ---------- > The commit-queue just saw inspector/timeline-event-dispatch.html flake while processing attachment 77158 [details] [details] on bug 51429. > Bot: cr-jail-3 Port: Mac Platform: Mac OS X 10.6.4 > ---------- > > As I understand this is a message from chromium bot on mac. > But chromium inspector's test enabled only for Windows. Sorry for any confusion. What that's saying is: "cr-jail-3" is the bot name. We run some of the commit-bots in the Chromium jail (a special section of a google datacenter. The port is "Mac" which is the Apple Mac port. I could make it say that more explicitly. Which is different from Chromium Mac. The Platform it was built on is 10.6.4, Snow Leopard. 327857 11 77627 loislo 2010-12-30 01:16:04 -0800 Comment on attachment 77627 [patch] initial version wrong bug 77627 2010-12-29 10:03:34 -0800 2010-12-30 01:16:03 -0800 [patch] initial version patch text/plain 2683 loislo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzMDAz ZjE4Li45MGQ4NzQ1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMjkgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDaHJvbWl1bV0gSW5zcGVjdG9yJ3MgdGVzdHMg YXJlIHZlcnkgc2xvdyBvbiBXaW4oRGJnKS4KKworICAgICAgICBJdCB3YXMgYSBwcm9ibGVtIHdp dGggQ2hyb21pdW0gRFJULiBEZXZUb29sc0FnZW50IG9iamVjdCBpbnN0YW5jZSB3YXMKKyAgICAg ICAgYXR0YWNoZWQgbm90IG9ubHkgdG8gdGhlIGluc3BlY3RlZCBwYWdlIGJ1dCB0byB0aGUgRGV2 VG9vbHMgd2luZG93IHRvby4KKyAgICAgICAgQXMgcmVzdWx0IGFsbCB0aGUgaW5zcGVjdG9yIGZp bGVzIHdlcmUgaW50ZXJwcmV0ZWQgYXMgYSBjb250ZW50IG9mIGluc3BlY3RlZCBwYWdlCisgICAg ICAgIGFuZCB3ZXJlIHRyYW5zZmVyZWQgdG8gdGhlIERldlRvb2xzIHNjcmlwdHMgcGFuZWwgZm9y IGRlYnVnZ2luZyBldGMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUwODIzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpzaG93RGV2VG9vbHMpOgorICAgICAgICAo VGVzdFNoZWxsOjpjcmVhdGVOZXdXaW5kb3cpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RTaGVsbC5oOgorCiAyMDEwLTEyLTI5ICBLZW50IEhhbnNlbiAgPGtlbnQuaGFu c2VuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmluZGV4IDIxZjQyMDgu LjE1MzhlMDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RT aGVsbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNw cApAQCAtMTM0LDcgKzEzNCw3IEBAIHZvaWQgVGVzdFNoZWxsOjpzaG93RGV2VG9vbHMoKQogICAg ICAgICAgICAgQVNTRVJUKGZhbHNlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQot ICAgICAgICBtX2RldlRvb2xzID0gY3JlYXRlTmV3V2luZG93KHVybCk7CisgICAgICAgIG1fZGV2 VG9vbHMgPSBjcmVhdGVOZXdXaW5kb3codXJsLCBmYWxzZSk7CiAgICAgICAgIEFTU0VSVChtX2Rl dlRvb2xzKTsKICAgICAgICAgY3JlYXRlRFJURGV2VG9vbHNDbGllbnQobV9kcnREZXZUb29sc0Fn ZW50LmdldCgpKTsKICAgICB9CkBAIC01NjIsMTAgKzU2MiwxMCBAQCBXZWJWaWV3SG9zdCogVGVz dFNoZWxsOjpjcmVhdGVXZWJWaWV3KCkKICAgICByZXR1cm4gY3JlYXRlTmV3V2luZG93KFdlYlVS TCgpKTsKIH0KIAotV2ViVmlld0hvc3QqIFRlc3RTaGVsbDo6Y3JlYXRlTmV3V2luZG93KGNvbnN0 IFdlYlVSTCYgdXJsKQorV2ViVmlld0hvc3QqIFRlc3RTaGVsbDo6Y3JlYXRlTmV3V2luZG93KGNv bnN0IFdlYlVSTCYgdXJsLCBib29sIGF0dGFjaERldlRvb2xzKQogewogICAgIFdlYlZpZXdIb3N0 KiBob3N0ID0gbmV3IFdlYlZpZXdIb3N0KHRoaXMpOwotICAgIFdlYlZpZXcqIHZpZXcgPSBXZWJW aWV3OjpjcmVhdGUoaG9zdCwgbV9kcnREZXZUb29sc0FnZW50LmdldCgpKTsKKyAgICBXZWJWaWV3 KiB2aWV3ID0gV2ViVmlldzo6Y3JlYXRlKGhvc3QsIGF0dGFjaERldlRvb2xzID8gbV9kcnREZXZU b29sc0FnZW50LmdldCgpIDogMCk7CiAgICAgaG9zdC0+c2V0V2ViV2lkZ2V0KHZpZXcpOwogICAg IG1fcHJlZnMuYXBwbHlUbyh2aWV3KTsKICAgICB2aWV3LT5pbml0aWFsaXplTWFpbkZyYW1lKGhv c3QpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxs LmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaAppbmRleCAxZGE0 ZTE3Li42N2IwYjk0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwu aApAQCAtMTUyLDcgKzE1Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldER1bXBXaGVuRmluaXNo ZWQoYm9vbCBkdW1wV2hlbkZpbmlzaGVkKSB7IG1fZHVtcFdoZW5GaW5pc2hlZCA9IGR1bXBXaGVu RmluaXNoZWQ7IH0KIAogICAgIFdlYlZpZXdIb3N0KiBjcmVhdGVXZWJWaWV3KCk7Ci0gICAgV2Vi Vmlld0hvc3QqIGNyZWF0ZU5ld1dpbmRvdyhjb25zdCBXZWJLaXQ6OldlYlVSTCYpOworICAgIFdl YlZpZXdIb3N0KiBjcmVhdGVOZXdXaW5kb3coY29uc3QgV2ViS2l0OjpXZWJVUkwmLCBib29sIGF0 dGFjaERldlRvb2xzID0gdHJ1ZSk7CiAgICAgdm9pZCBjbG9zZVdpbmRvdyhXZWJWaWV3SG9zdCop OwogICAgIHZvaWQgY2xvc2VSZW1haW5pbmdXaW5kb3dzKCk7CiAgICAgaW50IHdpbmRvd0NvdW50 KCk7Cg==