50805 2010-12-10 01:34:52 -0800 [GStreamer] un-needed methods 2010-12-10 02:34:52 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 320022 0 pnormand 2010-12-10 01:34:52 -0800 We should remove: - startEndPointTimerIfNeeded - endPointTimerFired - cancelSeek They are not used anywhere and not part of the MediaPlayer API. Probably sizeChanged could be removed too. 320040 1 76178 pnormand 2010-12-10 02:23:08 -0800 Created attachment 76178 proposed patch 320046 2 pnormand 2010-12-10 02:28:38 -0800 sizeChanged is part of the MediaPlayer API and we should implement it at some point, I think :) 320047 3 76178 xan.lopez 2010-12-10 02:29:06 -0800 Comment on attachment 76178 proposed patch Bam. 320051 4 pnormand 2010-12-10 02:34:52 -0800 Committed r73705: <http://trac.webkit.org/changeset/73705> 76178 2010-12-10 02:23:08 -0800 2010-12-10 02:29:06 -0800 proposed patch proposed-patch.patch text/plain 2632 pnormand RnJvbSAwNzViNWM4NzFlZjMwZmJhODk1NjZkZTI0YzY5ODEwMThlN2RkOTUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDEwIERlYyAyMDEwIDExOjIyOjQzICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgIDE1IC0tLS0tLS0tLS0tLS0tLQogLi4u L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCAgICAgICAgfCAgICAzIC0t LQogMyBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGJi YzQ4NWIuLjdmMmUxMTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMTAgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtHU3RyZWFtZXJdIHVuLW5lZWRlZCBtZXRob2RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDgwNQorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgY29kZSBjbGVhbnVwIG9ubHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmg6CisKIDIwMTAtMTItMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwCmluZGV4IGYxZmRmNjkuLmU5Nzc5ZjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNTMxLDIxICs1MzEsNiBAQCB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lcjo6c2VlayhmbG9hdCB0aW1lKQogICAgIH0KIH0KIAotdm9pZCBNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnN0YXJ0RW5kUG9pbnRUaW1lcklmTmVlZGVkKCkKLXsK LSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQotCi12b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lcjo6Y2FuY2VsU2VlaygpCi17Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLX0KLQotdm9pZCBN ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmVuZFBvaW50VGltZXJGaXJlZChUaW1lcjxNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXI+KikKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotfQot CiBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6cGF1c2VkKCkgY29uc3QKIHsKICAg ICByZXR1cm4gbV9wYXVzZWQ7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCmluZGV4 IDQ2OTQzYWMuLjExZWI4MWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBA IC0xNDcsMTAgKzE0Nyw3IEBAIGNsYXNzIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lciA6IHB1 YmxpYyBNZWRpYVBsYXllclByaXZhdGVJbnRlcmZhY2UgewogCiAgICAgICAgICAgICB2b2lkIGNh Y2hlRHVyYXRpb24oKTsKICAgICAgICAgICAgIHZvaWQgdXBkYXRlU3RhdGVzKCk7Ci0gICAgICAg ICAgICB2b2lkIGNhbmNlbFNlZWsoKTsKLSAgICAgICAgICAgIHZvaWQgZW5kUG9pbnRUaW1lckZp cmVkKFRpbWVyPE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcj4qKTsKICAgICAgICAgICAgIGZs b2F0IG1heFRpbWVMb2FkZWQoKSBjb25zdDsKLSAgICAgICAgICAgIHZvaWQgc3RhcnRFbmRQb2lu dFRpbWVySWZOZWVkZWQoKTsKIAogICAgICAgICAgICAgdm9pZCBjcmVhdGVHU1RQbGF5QmluKCk7 CiAgICAgICAgICAgICBib29sIGNoYW5nZVBpcGVsaW5lU3RhdGUoR3N0U3RhdGUgc3RhdGUpOwot LSAKMS43LjMuMw==