50797 2010-12-09 18:40:22 -0800 canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6.html fails 2012-08-21 15:01:56 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip naginenis ap cmarcelo gyuyoung.kim kling koivisto macpherson mdelaney7 menard naginenis rakuco webkit.review.bot oldest_to_newest 319861 0 mihaip 2010-12-09 18:40:22 -0800 This tests checks that we don't allow the invalid color value "rgba(255, 0, 0, 1.)" to be used as fillStyle. We actually allow this, even though 1. is not a valid CSS <alphavalue> (which is a <number>, which is defined as "A <number> can either be an <integer>, or it can be zero or more digits followed by a dot (.) followed by one or more digits." at http://www.w3.org/TR/css3-values/#numbers). Since this would involve making our CSS color parser stricter, I'm not sure that this is worth fixing. 691461 1 naginenis 2012-08-09 08:56:00 -0700 *** Bug 93493 has been marked as a duplicate of this bug. *** 691466 2 157462 naginenis 2012-08-09 09:00:29 -0700 Created attachment 157462 Patch 694925 3 kling 2012-08-14 07:02:54 -0700 (In reply to comment #0) > Since this would involve making our CSS color parser stricter, I'm not sure that this is worth fixing. Indeed, I wonder the same thing. What are other browsers doing? 695027 4 naginenis 2012-08-14 09:11:05 -0700 (In reply to comment #3) > Indeed, I wonder the same thing. What are other browsers doing? Looks like other browsers (FireFox and Opera) are treating 1. is an invalid CSS alpha value, so the test is passing. Full parser doing the same in our case also. The issue is only with the fast-path color parser. 700597 5 naginenis 2012-08-21 04:02:13 -0700 Kling, could you please have a look at this bug again? 700795 6 157462 kling 2012-08-21 08:32:58 -0700 Comment on attachment 157462 Patch Okay. 701157 7 157462 webkit.review.bot 2012-08-21 15:01:49 -0700 Comment on attachment 157462 Patch Clearing flags on attachment: 157462 Committed r126192: <http://trac.webkit.org/changeset/126192> 701158 8 webkit.review.bot 2012-08-21 15:01:56 -0700 All reviewed patches have been landed. Closing bug. 157462 2012-08-09 09:00:29 -0700 2012-08-21 15:01:49 -0700 Patch 50797.patch text/plain 6266 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmMWRkMDBmLi4yODk3ODMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDgt MDkgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuaW52 YWxpZC5yZ2JhLTYuaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTA3OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVbnNraXBwZWQgdGVzdHMgdGhhdCBhcmUgbm93IHBhc3NpbmcgYWZ0ZXIg dGhpcyBmaXggYW5kIHJlbW92ZWQKKyAgICAgICAgd3JvbmcgZXhwZWN0YXRpb25zLgorCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJzZS5pbnZh bGlkLnJnYmEtNi1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAgICogcGxhdGZvcm0vZWZs L1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAg ICAgICogcGxhdGZvcm0vbWFjL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNl LmludmFsaWQucmdiYS02LWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9xdC9Ta2lwcGVkOgorCiAyMDEyLTA4LTA5ICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZzogdXBk YXRlZCByZXN1bHRzIGZvciAxMjUxNjcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0vVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwYTdjMDM1Li45OWYwN2VjIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE4NjksOSArMTg2 OSw2IEBAIEJVR1dLNDU5OTEgOiBwbGF0Zm9ybS9jaHJvbWl1bS92aXJ0dWFsL2dwdS9jYW52YXMv cGhpbGlwL3Rlc3RzLzJkLnBhdHRlcm4uaW1hZ2UuCiBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNh bnZhcy9waGlsaXAvdGVzdHMvMmQudGV4dC5kcmF3LmJhc2VsaW5lLmlkZW9ncmFwaGljLmh0bWwg PSBURVhUCiBCVUdXSzQ1OTkxIExJTlVYIEFORFJPSUQgV0lOIDogcGxhdGZvcm0vY2hyb21pdW0v dmlydHVhbC9ncHUvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC50ZXh0LmRyYXcuYmFzZWxpbmUuaWRl b2dyYXBoaWMuaHRtbCA9IFRFWFQKIAotQlVHV0s1MDc5NyA6IGNhbnZhcy9waGlsaXAvdGVzdHMv MmQuZmlsbFN0eWxlLnBhcnNlLmludmFsaWQucmdiYS02Lmh0bWwgPSBURVhUCi1CVUdXSzUwNzk3 IDogcGxhdGZvcm0vY2hyb21pdW0vdmlydHVhbC9ncHUvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5m aWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYuaHRtbCA9IFRFWFQKLQogLy8gVXBkYXRlIGNh bnZhcy9waGlsaXAgaW4gV0sgcjcxNDgxCiBCVUdDUjYyMzAxIDogY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5kcmF3SW1hZ2UuaW1hZ2UuaW5jb21wbGV0ZS5vbWl0dGVkLmh0bWwgPSBURVhUCiBCVUdD UjYyMzAxIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UucmdiLWVvZi5o dG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5maWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYtZXhwZWN0ZWQudHh0CmRlbGV0ZWQg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCA4NjMzMzlmLi4wMDAwMDAwCi0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNl LmludmFsaWQucmdiYS02LWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xICswLDAgQEAK LVBhc3NlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAppbmRleCBkZGI5MWJkLi42M2M4MDRhIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtMzA1LDcgKzMwNSw2IEBAIGNhbnZhcy9waGls aXAvdGVzdHMvMmQuY29tcG9zaXRlLm9wZXJhdGlvbi5jbGVhci5odG1sCiBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmNvbXBvc2l0ZS5vcGVyYXRpb24uZGFya2VyLmh0bWwKIGNhbnZhcy9waGlsaXAv dGVzdHMvMmQuZHJhd0ltYWdlLmJyb2tlbi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRy YXdJbWFnZS5pbWFnZS5pbmNvbXBsZXRlLm9taXR0ZWQuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5maWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYuaHRtbAogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UucmdiLWVvZi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3Rz LzJkLmZpbGxTdHlsZS5wYXJzZS5yZ2JhLWVvZi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJk LmltYWdlRGF0YS5jcmVhdGUxLnR5cGUuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVz dEV4cGVjdGF0aW9ucwppbmRleCAxMTU0OGM0Li43NzI3NTZiIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtODc4LDcgKzg3OCw2IEBAIEJVR1dLR1RLIDog Y2FudmFzL3BoaWxpcC90ZXN0cy8yZC5jb21wb3NpdGUub3BlcmF0aW9uLmNsZWFyLmh0bWwgPSBU RVhUCiBCVUdXS0dUSyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuY29tcG9zaXRlLm9wZXJhdGlv bi5kYXJrZXIuaHRtbCA9IFRFWFQKIEJVR1dLR1RLIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5k cmF3SW1hZ2UuYnJva2VuLmh0bWwgPSBURVhUCiBCVUdXS0dUSyA6IGNhbnZhcy9waGlsaXAvdGVz dHMvMmQuZHJhd0ltYWdlLmltYWdlLmluY29tcGxldGUub21pdHRlZC5odG1sID0gVEVYVAotQlVH V0tHVEsgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJzZS5pbnZhbGlkLnJn YmEtNi5odG1sID0gVEVYVAogQlVHV0tHVEsgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxT dHlsZS5wYXJzZS5yZ2ItZW9mLmh0bWwgPSBURVhUCiBCVUdXS0dUSyA6IGNhbnZhcy9waGlsaXAv dGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNlLnJnYmEtZW9mLmh0bWwgPSBURVhUCiBCVUdXS0dUSyA6 IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuaW1hZ2VEYXRhLmNyZWF0ZTEudHlwZS5odG1sID0gVEVY VApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NhbnZhcy9waGlsaXAvdGVz dHMvMmQuZmlsbFN0eWxlLnBhcnNlLmludmFsaWQucmdiYS02LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJz ZS5pbnZhbGlkLnJnYmEtNi1leHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IGUzYTcxMjQuLjAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NhbnZh cy9waGlsaXAvdGVzdHMvMmQuZmlsbFN0eWxlLnBhcnNlLmludmFsaWQucmdiYS02LWV4cGVjdGVk LnR4dAorKysgL2Rldi9udWxsCkBAIC0xICswLDAgQEAKLUZhaWxlZCBhc3NlcnRpb246IGdvdCBw aXhlbCBbMjU1LDAsMCwyNTVdIGF0ICg1MCwyNSksIGV4cGVjdGVkIFswLDI1NSwwLDI1NV0KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDg4OWNkNzQuLjY0MjZlZTQgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZApAQCAtMjEyNiw3ICsyMTI2LDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy90eXBl LnByb3RvdHlwZS5odG1sCiAKICMgRmFpbGluZyB0ZXN0cyBhZnRlciBzeW5jIHdpdGggUGhpbGlw IFRheWxvcidzIHVwc3RyZWFtIHRlc3RzCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFn ZS5pbWFnZS5pbmNvbXBsZXRlLm9taXR0ZWQuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5m aWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8y ZC5maWxsU3R5bGUucGFyc2UucmdiLWVvZi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZp bGxTdHlsZS5wYXJzZS5yZ2JhLWVvZi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdl RGF0YS5wdXQud3Jvbmd0eXBlLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZTBlYmQwLi44MzJiN2Y5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMDkgIFN1ZGFyc2FuYSBOYWdpbmVu aSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgY2FudmFz L3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UuaW52YWxpZC5yZ2JhLTYuaHRtbCBmYWls cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA3OTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBj aGVjayBpbiBmYXN0LXBhdGggcGFyc2VBbHBoYVZhbHVlKCkgdG8gcmV0dXJuIGVhcmx5CisgICAg ICAgIGlmIHRoZSBDU1MgPGFscGhhdmFsdWU+IGVuZGVkIHdpdGggYW4gaW52YWxpZCBkaWdpdC4K KworICAgICAgICBUZXN0OiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmZpbGxTdHlsZS5wYXJzZS5p bnZhbGlkLnJnYmEtNi5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnBhcnNlQWxwaGFWYWx1ZSk6CisKIDIwMTItMDgtMDkgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZ2Vu ZXJhdGUgcHJldmlldyBmb3IgdGhlIG9iamVjdHMgZHVtcGVkIGludG8gdGhlIGNvbnNvbGUgdXBv biBsb2dnaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA2OTVjZDg4Li4zNzlkODRm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtNTM0NCw3ICs1MzQ0LDcgQEAgc3RhdGlj IGlubGluZSBib29sIHBhcnNlQWxwaGFWYWx1ZShjb25zdCBVQ2hhciomIHN0cmluZywgY29uc3Qg VUNoYXIqIGVuZCwgY29uc3QKICAgICBpZiAobGVuZ3RoIDwgMikKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCi0gICAgaWYgKHN0cmluZ1tsZW5ndGggLSAxXSAhPSB0ZXJtaW5hdG9yKQorICAgIGlm IChzdHJpbmdbbGVuZ3RoIC0gMV0gIT0gdGVybWluYXRvciB8fCAhaXNBU0NJSURpZ2l0KHN0cmlu Z1tsZW5ndGggLSAyXSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChzdHJpbmdb MF0gIT0gJzAnICYmIHN0cmluZ1swXSAhPSAnMScgJiYgc3RyaW5nWzBdICE9ICcuJykgewo=