50781 2010-12-09 12:41:53 -0800 [Qt] enable orientation flag when QtMobility available 2011-05-09 07:52:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 0 qi.2.zhang qi.2.zhang ademar commit-queue cshu kenneth laszlo.gombos ossy suresh.voruganti oldest_to_newest 319663 0 qi.2.zhang 2010-12-09 12:41:53 -0800 When QtMobility is available, enable orientation by default. 319667 1 76114 qi.2.zhang 2010-12-09 12:53:24 -0800 Created attachment 76114 patch Enable orientation flag by default if QtMobility is available. 319926 2 commit-queue 2010-12-09 22:21:20 -0800 The commit-queue encountered the following flaky tests while processing attachment 76114: inspector/debugger-expand-scope.html Please file bugs against the tests. These tests were authored by yurys@chromium.org. The commit-queue is continuing to process your patch. 319927 3 76114 commit-queue 2010-12-09 22:22:00 -0800 Comment on attachment 76114 patch Clearing flags on attachment: 76114 Committed r73687: <http://trac.webkit.org/changeset/73687> 319928 4 commit-queue 2010-12-09 22:22:05 -0800 All reviewed patches have been landed. Closing bug. 320021 5 ossy 2010-12-10 01:34:36 -0800 (In reply to comment #3) > Committed r73687: <http://trac.webkit.org/changeset/73687> I have some problem with this patch: (1) This kind of patches always break the incremental build, because adding or removing a define doesn't trigger rebuilding files. See the following bugs for details: https://bugs.webkit.org/show_bug.cgi?id=42027 (comment25,26) https://bugs.webkit.org/show_bug.cgi?id=38054#c25 Unfortunately there isn't a correct way to fix this bug. Plese ping me next time before landing a similar patch and I will force a clean rebuild on buildbots. (2) Please run layout tests before landing a patch not to break any test. Unfortunately I had to do it after landing: http://trac.webkit.org/changeset/73693. (3) There was a similar previously r+ -ed, but not landed patch to fix layout tests and enable DeviceOrientation: https://bugs.webkit.org/show_bug.cgi?id=47490 320109 6 qi.2.zhang 2010-12-10 05:51:34 -0800 Thanks and sorry for the inconvenience. 321387 7 suresh.voruganti 2010-12-13 13:59:25 -0800 Fix required for Qtwebkit 2.1/2.2. Developer has also attached the back ported version of the patch for Qtwebkit 2.1/2.2 321388 8 suresh.voruganti 2010-12-13 14:00:46 -0800 Qi, do we need back ported version of patch for integrating Qtwebkit 2.1/2.2 ? 321925 9 qi.2.zhang 2010-12-14 05:48:59 -0800 I already created in back ported version in bug 50685, I means I used one patch to cover 50685 and 50781. 323234 10 ademar 2010-12-16 10:00:53 -0800 (In reply to comment #9) > I already created in back ported version in bug 50685, I means I used one patch to cover 50685 and 50781. Please avoid doing that when backporting patches. We try to keep the same patches (same description, changelog and bug references) on the stabilization branches so that people (and tools) can easily find out what is part of a release. That said, don't worry about this particular patch, I'll split it myself based on the patches from trunk (the conflicts are easy to solve). 323735 11 qi.2.zhang 2010-12-17 06:08:16 -0800 Sorry for inconvenience. 324531 12 ademar 2010-12-20 13:07:09 -0800 Revision r73687 cherry-picked into qtwebkit-2.2 with commit 3570f27 <http://gitorious.org/webkit/qtwebkit/commit/3570f27> 324533 13 ademar 2010-12-20 13:10:56 -0800 Revision r73693 cherry-picked into qtwebkit-2.2 with commit c08c19f <http://gitorious.org/webkit/qtwebkit/commit/c08c19f> (fix for tests, patch from Ossy, see c#5) 400347 14 92759 laszlo.gombos 2011-05-08 22:43:19 -0700 Created attachment 92759 Fix LayoutTests for the 2.1.x branch Cherry-picking revision r73693 into qtwebkit-2.1.x (formerly known as qtwebkit-2.2) with commit c08c19f was too ambitious as this commit assumes that DeviceMotion is supported (which is the case on trunk but not on qtwebkit-2.1.x). Attached patch fixes the test expectations for qtwebkit-2.1.x. Ademar, can you please commit it to 2.1.x ? 76114 2010-12-09 12:53:24 -0800 2010-12-09 22:22:00 -0800 patch bug50781.patch text/plain 1833 qi.2.zhang SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzYzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMDkgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBlbmFibGUgb3JpZW50YXRpb24gZmxhZyB3aGVuIFF0TW9iaWxpdHkgYXZhaWxhYmxlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDc4MQorCisgICAg ICAgIFdoZW4gUXRNb2JpbGl0eSBhdmFpbGFibGUsIGVuYWJsZSBvcmllbnRhdGlvbiBmbGFnIGJ5 IGRlZmF1bHQuCisKKyAgICAgICAgKiBmZWF0dXJlcy5wcmk6CisKIDIwMTAtMTItMDkgIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJl YXMgS2xpbmcuCkluZGV4OiBXZWJDb3JlL2ZlYXR1cmVzLnByaQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2ZlYXR1cmVzLnByaQkocmV2aXNpb24gNzM2MTQpCisrKyBXZWJDb3JlL2ZlYXR1cmVzLnBy aQkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNiBAQCBjb250YWlucyhERUZJTkVTLCBFTkFC TEVfU0lOR0xFX1RIUkVBREVECiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RPTV9TVE9SQUdF PS4pOiBERUZJTkVTICs9IEVOQUJMRV9ET01fU1RPUkFHRT0xCiAhY29udGFpbnMoREVGSU5FUywg RU5BQkxFX0lDT05EQVRBQkFTRT0uKTogREVGSU5FUyArPSBFTkFCTEVfSUNPTkRBVEFCQVNFPTEK ICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9Lik6IERFRklORVMg Kz0gRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HPTEKLSFjb250YWlucyhERUZJTkVTLCBFTkFCTEVf T1JJRU5UQVRJT05fRVZFTlRTPS4pOiBERUZJTkVTICs9IEVOQUJMRV9PUklFTlRBVElPTl9FVkVO VFM9MAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9ESVJFQ1RPUllfVVBMT0FEPS4pOiBERUZJ TkVTICs9IEVOQUJMRV9ESVJFQ1RPUllfVVBMT0FEPTAKICFjb250YWlucyhERUZJTkVTLCBFTkFC TEVfRklMRV9TWVNURU09Lik6IERFRklORVMgKz0gRU5BQkxFX0ZJTEVfU1lTVEVNPTAKIApAQCAt MTIxLDYgKzEyMCwxNCBAQCBjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVE CiAgICAgfQogfQogCisjIG9yaWVudGF0aW9uIHN1cHBvcnQgaWYgUXRNb2JpbGl0eSBleGlzdHMK K2NvbnRhaW5zKE1PQklMSVRZX0NPTkZJRywgc2Vuc29ycykgeworICAgIWNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9Lik6IERFRklORVMgKz0gRU5BQkxFX09SSUVO VEFUSU9OX0VWRU5UUz0xCisgICAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0RFVklDRV9PUklF TlRBVElPTj0uKTogREVGSU5FUyArPSBFTkFCTEVfREVWSUNFX09SSUVOVEFUSU9OPTEKKyAgIENP TkZJRyAqPSBtb2JpbGl0eQorICAgTU9CSUxJVFkgKj0gc2Vuc29ycworfQorCiAjIEJlYXJlciBt YW5hZ2VtZW50IGlzIHBhcnQgb2YgUXQgNC43CiAjIGZvciBvbGRlciB2ZXJzaW9uLCBjaGVjayBm b3IgbW9iaWxpdHkgd2l0aCBiZWFyZXIKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfUVRfQkVB UkVSPS4pIHsK 92759 2011-05-08 22:43:19 -0700 2011-05-08 22:43:19 -0700 Fix LayoutTests for the 2.1.x branch 50781.patch text/plain 4046 laszlo.gombos ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxZmQ2NDdmLi5lMmYwZGMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUt MDkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg IEZpeCBjMDhjMTlmLgorCisgICAgICAgIFtRdF0gZW5hYmxlIG9yaWVudGF0aW9uIGZsYWcgd2hl biBRdE1vYmlsaXR5IGF2YWlsYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTA3ODEKKworICAgICAgICAqIHBsYXRmb3JtL3F0L2Zhc3QvZG9tL1dp bmRvdy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHBsYXRmb3JtL3F0L2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS1leHBlY3RlZC50eHQ6 CisgICAgICAgICogcGxhdGZvcm0vcXQvZmFzdC9qcy9nbG9iYWwtY29uc3RydWN0b3JzLWV4cGVj dGVkLnR4dDoKKwogMjAxMC0wOC0yMCAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktZGVz Y3JpcHRvcnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9kb20v V2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKaW5kZXggNzQw ZmNiZS4uMzhkMzliNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9k b20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1k ZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKQEAgLTQxLDcgKzQxLDYgQEAgUEFTUyB0eXBlb2YgT2Jq ZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdET01QYXJzZXInKSBpcyAnb2Jq ZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3cs ICdET01TdHJpbmdMaXN0JykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Q cm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnRE9NU3RyaW5nTWFwJykgaXMgJ29iamVjdCcKIFBB U1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnRGF0ZScp IGlzICdvYmplY3QnCi1QQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9y KHdpbmRvdywgJ0RldmljZU1vdGlvbkV2ZW50JykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9i amVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnRGV2aWNlT3JpZW50YXRpb25F dmVudCcpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNj cmlwdG9yKHdpbmRvdywgJ0RvY3VtZW50JykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVj dC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnRG9jdW1lbnRGcmFnbWVudCcpIGlz ICdvYmplY3QnCkBAIC0zNjMsNyArMzYyLDYgQEAgUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blBy b3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdvbmNoYW5nZScpIGlzICdvYmplY3QnCiBQQVNTIHR5 cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ29uY2xpY2snKSBp cyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3 aW5kb3csICdvbmNvbnRleHRtZW51JykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5n ZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnb25kYmxjbGljaycpIGlzICdvYmplY3Qn Ci1QQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ29u ZGV2aWNlbW90aW9uJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9w ZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnb25kcmFnJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9m IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnb25kcmFnZW5kJykgaXMg J29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2lu ZG93LCAnb25kcmFnZW50ZXInKSBpcyAnb2JqZWN0JwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS1l eHBlY3RlZC50eHQKaW5kZXggZjI2NzAzZi4uNTQ2OWFkOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJp dGFuY2UtZXhwZWN0ZWQudHh0CkBAIC03OSw2ICs3OSw4IEBAIFBBU1MgaW5uZXIuRE9NU3RyaW5n TWFwLmlzSW5uZXIgaXMgdHJ1ZQogUEFTUyBpbm5lci5ET01TdHJpbmdNYXAuY29uc3RydWN0b3Iu aXNJbm5lciBpcyB0cnVlCiBQQVNTIGlubmVyLkRhdGUuaXNJbm5lciBpcyB0cnVlCiBQQVNTIGlu bmVyLkRhdGUuY29uc3RydWN0b3IuaXNJbm5lciBpcyB0cnVlCitQQVNTIGlubmVyLkRldmljZU9y aWVudGF0aW9uRXZlbnQuaXNJbm5lciBpcyB0cnVlCitQQVNTIGlubmVyLkRldmljZU9yaWVudGF0 aW9uRXZlbnQuY29uc3RydWN0b3IuaXNJbm5lciBpcyB0cnVlCiBQQVNTIGlubmVyLkRvY3VtZW50 LmlzSW5uZXIgaXMgdHJ1ZQogUEFTUyBpbm5lci5Eb2N1bWVudC5jb25zdHJ1Y3Rvci5pc0lubmVy IGlzIHRydWUKIFBBU1MgaW5uZXIuRG9jdW1lbnRGcmFnbWVudC5pc0lubmVyIGlzIHRydWUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVj dG9ycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2pzL2dsb2Jh bC1jb25zdHJ1Y3RvcnMtZXhwZWN0ZWQudHh0CmluZGV4IGIyMzk1ZDcuLmIyYmE4YmMgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVjdG9y cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvZmFzdC9qcy9nbG9i YWwtY29uc3RydWN0b3JzLWV4cGVjdGVkLnR4dApAQCAtMzgsNyArMzgsNiBAQCBQQVNTIERPTUlt cGxlbWVudGF0aW9uLnRvU3RyaW5nKCkgaXMgJ1tvYmplY3QgRE9NSW1wbGVtZW50YXRpb25Db25z dHJ1Y3Rvcl0nCiBQQVNTIERPTVBhcnNlci50b1N0cmluZygpIGlzICdbb2JqZWN0IERPTVBhcnNl ckNvbnN0cnVjdG9yXScKIFBBU1MgRE9NU3RyaW5nTGlzdC50b1N0cmluZygpIGlzICdbb2JqZWN0 IERPTVN0cmluZ0xpc3RDb25zdHJ1Y3Rvcl0nCiBQQVNTIERPTVN0cmluZ01hcC50b1N0cmluZygp IGlzICdbb2JqZWN0IERPTVN0cmluZ01hcENvbnN0cnVjdG9yXScKLVBBU1MgRGV2aWNlTW90aW9u RXZlbnQudG9TdHJpbmcoKSBpcyAnW29iamVjdCBEZXZpY2VNb3Rpb25FdmVudENvbnN0cnVjdG9y XScKIFBBU1MgRGV2aWNlT3JpZW50YXRpb25FdmVudC50b1N0cmluZygpIGlzICdbb2JqZWN0IERl dmljZU9yaWVudGF0aW9uRXZlbnRDb25zdHJ1Y3Rvcl0nCiBQQVNTIERvY3VtZW50LnRvU3RyaW5n KCkgaXMgJ1tvYmplY3QgRG9jdW1lbnRDb25zdHJ1Y3Rvcl0nCiBQQVNTIERvY3VtZW50RnJhZ21l bnQudG9TdHJpbmcoKSBpcyAnW29iamVjdCBEb2N1bWVudEZyYWdtZW50Q29uc3RydWN0b3JdJwo=