50761 2010-12-09 07:28:45 -0800 [Qt] Crash sometimes in QNetworkReplyHandler::finish() 2010-12-10 11:46:10 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P3 Normal --- 1 jturcotte webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 319452 0 jturcotte 2010-12-09 07:28:45 -0800 I would see problems where the QNetworkReply would be deleted in the other thread, but a new QNetworkReply would be allocated by the heap at the same address and would break the comparison code path. Another problem would be that didFinishLoading would eventually call abort on the ResourceHandle, which would call deleteLater on the reply (if in a different thread). Calling deleteLater on oldReply would then cause a crash. 319453 1 76061 jturcotte 2010-12-09 07:32:08 -0800 Created attachment 76061 Patch 319719 2 76061 commit-queue 2010-12-09 14:28:39 -0800 Comment on attachment 76061 Patch Rejecting patch 76061 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf', 'apply-attachment', '--force-clean', '--non-interactive', 76061]" exit_code: 2 Last 500 characters of output: 'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/network/qt/QNetworkReplyHandler.cpp Hunk #1 FAILED at 300. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/qt/QNetworkReplyHandler.cpp.rej Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6943017 320058 3 jturcotte 2010-12-10 02:44:38 -0800 Committed r73708: <http://trac.webkit.org/changeset/73708> 320284 4 webkit.review.bot 2010-12-10 11:46:10 -0800 http://trac.webkit.org/changeset/73708 might have broken GTK Linux 32-bit Debug 76061 2010-12-09 07:32:08 -0800 2010-12-09 14:28:39 -0800 Patch fixQnetworkreplyhandlerFinish.patch text/plain 3224 jturcotte ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjQzY2RlMS4uNGM0NTY0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gUmVmYWN0b3IgUU5ldHdvcmtSZXBseUhhbmRs ZXI6OmZpbmlzaCgpIHRvIHByZXZlbnQgY3Jhc2hlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNzYxCisKKyAgICAgICAgVGhpcyBwYXRjaCBjaGFu Z2UgdGhlIG9yZGVyIHRvIGNoZWNrIGlmIG1fcmVwbHkgaXMgbnVsbCBpbnN0ZWFkLAorICAgICAg ICBleHBsaWNpdGx5IGRlbGV0aW5nIHRoZSByZXBseSBiZWZvcmUgY2FsbGluZyBzdGFydCgpIGZv ciBhIHJlZGlyZWN0LAorICAgICAgICBvciBhZnRlciBjYWxsaW5nIGRpZEZpbmlzaExvYWRpbmco KS9kaWRGYWlsKCkgaW4gb3RoZXIgY2FzZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3Jr UmVwbHlIYW5kbGVyOjpmaW5pc2gpOgorCisyMDEwLTEyLTA5ICBKb2NlbHluIFR1cmNvdHRlICA8 am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKICAgICAgICAgW1F0XSBNYWtlIHN1cmUgd2Ugc2VuZCB0aGUgcmVzcG9uc2Ug YmVmb3JlIGFueSBkYXRhLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTA3NjAKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0 L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9R TmV0d29ya1JlcGx5SGFuZGxlci5jcHAKaW5kZXggMDBkNzRmMC4uNWMwNWZhNiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3Bw CkBAIC0zMDAsMjkgKzMwMCwzMyBAQCB2b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpmaW5pc2go KQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgUU5ldHdvcmtSZXBseSogb2xkUmVwbHkg PSBtX3JlcGx5OworICAgIGlmICghbV9yZWRpcmVjdGVkKSB7CisgICAgICAgIGlmICghbV9yZXBs eS0+ZXJyb3IoKSB8fCBpZ25vcmVIdHRwRXJyb3IobV9yZXBseSwgbV9yZXNwb25zZUNvbnRhaW5z RGF0YSkpIHsKKyAgICAgICAgICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhtX3Jlc291cmNl SGFuZGxlLCAwKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIFFVcmwgdXJsID0gbV9y ZXBseS0+dXJsKCk7CisgICAgICAgICAgICBpbnQgaHR0cFN0YXR1c0NvZGUgPSBtX3JlcGx5LT5h dHRyaWJ1dGUoUU5ldHdvcmtSZXF1ZXN0OjpIdHRwU3RhdHVzQ29kZUF0dHJpYnV0ZSkudG9JbnQo KTsKIAotICAgIGlmIChtX3JlZGlyZWN0ZWQpIHsKLSAgICAgICAgcmVzZXRTdGF0ZSgpOwotICAg ICAgICBzdGFydCgpOwotICAgIH0gZWxzZSBpZiAoIW1fcmVwbHktPmVycm9yKCkgfHwgaWdub3Jl SHR0cEVycm9yKG1fcmVwbHksIG1fcmVzcG9uc2VDb250YWluc0RhdGEpKSB7Ci0gICAgICAgIGNs aWVudC0+ZGlkRmluaXNoTG9hZGluZyhtX3Jlc291cmNlSGFuZGxlLCAwKTsKKyAgICAgICAgICAg IGlmIChodHRwU3RhdHVzQ29kZSkgeworICAgICAgICAgICAgICAgIFJlc291cmNlRXJyb3IgZXJy b3IoIkhUVFAiLCBodHRwU3RhdHVzQ29kZSwgdXJsLnRvU3RyaW5nKCksIG1fcmVwbHktPmF0dHJp YnV0ZShRTmV0d29ya1JlcXVlc3Q6Okh0dHBSZWFzb25QaHJhc2VBdHRyaWJ1dGUpLnRvU3RyaW5n KCkpOworICAgICAgICAgICAgICAgIGNsaWVudC0+ZGlkRmFpbChtX3Jlc291cmNlSGFuZGxlLCBl cnJvcik7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIFJlc291cmNlRXJy b3IgZXJyb3IoIlF0TmV0d29yayIsIG1fcmVwbHktPmVycm9yKCksIHVybC50b1N0cmluZygpLCBt X3JlcGx5LT5lcnJvclN0cmluZygpKTsKKyAgICAgICAgICAgICAgICBjbGllbnQtPmRpZEZhaWwo bV9yZXNvdXJjZUhhbmRsZSwgZXJyb3IpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAg ICAgIGlmIChtX3JlcGx5KSB7CisgICAgICAgICAgICBtX3JlcGx5LT5kZWxldGVMYXRlcigpOwor ICAgICAgICAgICAgbV9yZXBseSA9IDA7CisgICAgICAgIH0KICAgICB9IGVsc2UgewotICAgICAg ICBRVXJsIHVybCA9IG1fcmVwbHktPnVybCgpOwotICAgICAgICBpbnQgaHR0cFN0YXR1c0NvZGUg PSBtX3JlcGx5LT5hdHRyaWJ1dGUoUU5ldHdvcmtSZXF1ZXN0OjpIdHRwU3RhdHVzQ29kZUF0dHJp YnV0ZSkudG9JbnQoKTsKLQotICAgICAgICBpZiAoaHR0cFN0YXR1c0NvZGUpIHsKLSAgICAgICAg ICAgIFJlc291cmNlRXJyb3IgZXJyb3IoIkhUVFAiLCBodHRwU3RhdHVzQ29kZSwgdXJsLnRvU3Ry aW5nKCksIG1fcmVwbHktPmF0dHJpYnV0ZShRTmV0d29ya1JlcXVlc3Q6Okh0dHBSZWFzb25QaHJh c2VBdHRyaWJ1dGUpLnRvU3RyaW5nKCkpOwotICAgICAgICAgICAgY2xpZW50LT5kaWRGYWlsKG1f cmVzb3VyY2VIYW5kbGUsIGVycm9yKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIFJl c291cmNlRXJyb3IgZXJyb3IoIlF0TmV0d29yayIsIG1fcmVwbHktPmVycm9yKCksIHVybC50b1N0 cmluZygpLCBtX3JlcGx5LT5lcnJvclN0cmluZygpKTsKLSAgICAgICAgICAgIGNsaWVudC0+ZGlk RmFpbChtX3Jlc291cmNlSGFuZGxlLCBlcnJvcik7CisgICAgICAgIGlmIChtX3JlcGx5KSB7Cisg ICAgICAgICAgICBtX3JlcGx5LT5kZWxldGVMYXRlcigpOworICAgICAgICAgICAgbV9yZXBseSA9 IDA7CiAgICAgICAgIH0KKyAgICAgICAgcmVzZXRTdGF0ZSgpOworICAgICAgICBzdGFydCgpOwog ICAgIH0KLQotICAgIG9sZFJlcGx5LT5kZWxldGVMYXRlcigpOwotICAgIGlmIChvbGRSZXBseSA9 PSBtX3JlcGx5KQotICAgICAgICBtX3JlcGx5ID0gMDsKIH0KIAogdm9pZCBRTmV0d29ya1JlcGx5 SGFuZGxlcjo6c2VuZFJlc3BvbnNlSWZOZWVkZWQoKQo=