50741 2010-12-09 02:51:23 -0800 [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails 2010-12-09 03:08:59 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 319355 0 pnormand 2010-12-09 02:51:23 -0800 In the configure.ac PKG_CHECK_MODULES call for gstreamer the action-if-not-found we have is to set $have_gstreamer to "no". The consequence is that in this case the build will fail. So if HTML5 media is enabled at configure time and if the pkg-config gstreamer check fails the configure script should error out, which is the default action-if-not-found of PKG_CHECK_MODULES. 319358 1 76030 pnormand 2010-12-09 02:55:38 -0800 Created attachment 76030 proposed patch 319365 2 76030 xan.lopez 2010-12-09 03:02:50 -0800 Comment on attachment 76030 proposed patch r=me 319370 3 pnormand 2010-12-09 03:08:59 -0800 Committed r73600: <http://trac.webkit.org/changeset/73600> 76030 2010-12-09 02:55:38 -0800 2010-12-09 03:02:50 -0800 proposed patch proposed-patch.patch text/plain 1356 pnormand RnJvbSBkZGY0Y2EwM2RhMWI4ZjMyN2U4NDI5YTNlMjAzZjc1ZWIxYTM3MTE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDkgRGVjIDIwMTAgMTE6NTQ6MTIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBDaGFuZ2VMb2cgICAgfCAgICA5ICsrKysrKysrKwogY29uZmln dXJlLmFjIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDMy NzZjMDMuLjRhOTQ0YTMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxMC0xMi0wOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gY29uZmlndXJlOiBlcnJvciBvdXQgaWYgdmlkZW8gaXMgZW5hYmxlZCBhbmQgZ3N0 cmVhbWVyIHBrZy1jb25maWcgY2hlY2sgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNzQxCisKKyAgICAgICAgKiBjb25maWd1cmUuYWM6CisK IDIwMTAtMTItMDcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5h YyBiL2NvbmZpZ3VyZS5hYwppbmRleCA5ZTJkZjQwLi5kNDE4NGEzIDEwMDY0NAotLS0gYS9jb25m aWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC04NzUsOCArODc1LDggQEAgaWYgdGVzdCAi JGVuYWJsZV92aWRlbyIgPSAieWVzIjsgdGhlbgogICAgICAgICAgICAgICAgICAgICAgZ3N0cmVh bWVyLXBidXRpbHMtMC4xMAogICAgICAgICAgICAgICAgICAgICAgZ3N0cmVhbWVyLXBsdWdpbnMt YmFzZS0wLjEwID49ICRHU1RSRUFNRVJfUExVR0lOU19CQVNFX1JFUVVJUkVEX1ZFUlNJT04KICAg ICAgICAgICAgICAgICAgICAgIGdzdHJlYW1lci12aWRlby0wLjEwXSwKLSAgICAgICAgICAgICAg ICAgICAgIFtoYXZlX2dzdHJlYW1lcj15ZXNdLAotICAgICAgICAgICAgICAgICAgICAgW2hhdmVf Z3N0cmVhbWVyPW5vXSkKKyAgICAgICAgICAgICAgICAgICAgIFtoYXZlX2dzdHJlYW1lcj15ZXNd CisgICAgICAgICAgICAgICAgICAgICApCiAKICAgIEFDX1NVQlNUKFtHU1RSRUFNRVJfQ0ZMQUdT XSkKICAgIEFDX1NVQlNUKFtHU1RSRUFNRVJfTElCU10pCi0tIAoxLjcuMy4z