50738 2010-12-09 01:54:25 -0800 [GTK] Choose a dictionary in case there is no one defined or the env LANG does not propose one 2010-12-10 09:37:50 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 50739 1 alex webkit-unassigned mrobinson oldest_to_newest 319333 0 alex 2010-12-09 01:54:25 -0800 Currently we are not setting any dictionary and this is causing that the DRT in case the LANG is set to C does not take any dict and spelling tests fail. 319335 1 76025 alex 2010-12-09 02:06:22 -0800 Created attachment 76025 Proposed patch 319339 2 76025 mrobinson 2010-12-09 02:14:53 -0800 Comment on attachment 76025 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=76025&action=review Yay! Thanks for fixing this. > WebKit/gtk/webkit/webkitwebsettings.cpp:953 > +static void get_avail_dicts_cb(const char * const lang_tag, const char * const provider_name, const char * const provider_desc, const char * const provider_file, void * data) Should be in WebKit style (camelCase), asterisks with the typenames and use full words instead of abbreviations. :) > WebKit/gtk/webkit/webkitwebsettings.cpp:1079 > + // No dictionaries selected, we get one from the list > + enchant_broker_list_dicts(broker, get_avail_dicts_cb, &dicts); > + if (dicts) { > + GSList* tmp; Instead of passing a GSList* it might simplify things to pass a point to a Vector<CString> like: Vector<CString> allDictionaries; enchant_broker_list_dicts(broker, getAvilableDictionariesCallback, &allDictionaries); if (!allDictionaries.empty()) { ... } 319391 3 alex 2010-12-09 04:14:24 -0800 (In reply to comment #2) > (From update of attachment 76025 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=76025&action=review > > Yay! Thanks for fixing this. > Thanks for the review, I like your proposal. 319392 4 76043 alex 2010-12-09 04:15:47 -0800 Created attachment 76043 Proposed patch 319398 5 76043 mrobinson 2010-12-09 04:33:31 -0800 Comment on attachment 76043 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=76043&action=review Thank you! Please fix the remaining minor issues before landing. > WebKit/gtk/webkit/webkitwebsettings.cpp:953 > +static void getAvilableDictionariesCallback(const char* const lang_tag, const char* const provider_name, const char* const provider_desc, const char* const provider_file, void* data) Please change lang_tag to languageTag before landing. You should actually omit provider_name, provider_desc, and provider_file to avoid a warning here too. > WebKit/gtk/webkit/webkitwebsettings.cpp:955 > + Vector<CString>* dicts = static_cast< Vector<CString>* >(data); Please remove the extra space after the static_cast< before landing. 320208 6 alex 2010-12-10 09:37:50 -0800 Landed http://trac.webkit.org/changeset/73737 76025 2010-12-09 02:06:22 -0800 2010-12-09 04:15:47 -0800 Proposed patch spell_get_dict.patch text/plain 3119 alex ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNWFhNWU4Yy4uODc1NmNmYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0wOSAg QWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBDaG9vc2UgYSBkaWN0aW9uYXJ5 IGluIGNhc2UgdGhlcmUgaXMgbm8gb25lIGRlZmluZWQgb3IgdGhlCisgICAgICAgIGVudiBMQU5H IGRvZXMgbm90IHByb3Bvc2Ugb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MDczOAorCisgICAgICAgIEluIGNhc2Ugbm8gZGljdCBpcyBzZXQgYW5k IHdlIGNhbiBub3QgZmluZCBvbmUgdXNpbmcgdGhlCisgICAgICAgIGVudmlyb25tZW50IGp1c3Qg Z2V0IHRoZSBmaXJzdCBkaWN0aW9uYXJ5IGluc3RhbGxlZCBpbiB0aGUgbGlzdC4KKworICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChnZXRfYXZhaWxfZGlj dHNfY2IpOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19zZXRfcHJvcGVydHkpOgorCiAy MDEwLTEyLTA4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi b3JhLmNvLnVrPgogCiAgICAgICAgIEJ1aWxkIGZpeC4gVGFrZSB3ZWJWaWV3e0VudGVyLEV4aXR9 RnVsbHNjcmVlbiBiYWNrIG91dCBvZiB0aGUKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRp bmdzLmNwcAppbmRleCAyNjYxYjgyLi4zYzc3NTlkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vic2V0dGluZ3MuY3BwCkBAIC05NTAsNiArOTUwLDEzIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfc2V0dGluZ3NfZmluYWxpemUoR09iamVjdCogb2JqZWN0KQogICAgIEdfT0JKRUNUX0NMQVNT KHdlYmtpdF93ZWJfc2V0dGluZ3NfcGFyZW50X2NsYXNzKS0+ZmluYWxpemUob2JqZWN0KTsKIH0K IAorc3RhdGljIHZvaWQgZ2V0X2F2YWlsX2RpY3RzX2NiKGNvbnN0IGNoYXIgKiBjb25zdCBsYW5n X3RhZywgY29uc3QgY2hhciAqIGNvbnN0IHByb3ZpZGVyX25hbWUsIGNvbnN0IGNoYXIgKiBjb25z dCBwcm92aWRlcl9kZXNjLCBjb25zdCBjaGFyICogY29uc3QgcHJvdmlkZXJfZmlsZSwgdm9pZCAq IGRhdGEpCit7CisgICAgR1NMaXN0ICoqZGljdHMgPSBzdGF0aWNfY2FzdDxHU0xpc3QgKio+KGRh dGEpOworCisgICAgKmRpY3RzID0gZ19zbGlzdF9hcHBlbmQoKmRpY3RzLCBzdGF0aWNfY2FzdDxn cG9pbnRlcj4oZ19zdHJkdXAobGFuZ190YWcpKSk7Cit9CisKIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwg Y29uc3QgR1ZhbHVlKiB2YWx1ZSwgR1BhcmFtU3BlYyogcHNwZWMpCiB7CiAgICAgV2ViS2l0V2Vi U2V0dGluZ3MqIHdlYl9zZXR0aW5ncyA9IFdFQktJVF9XRUJfU0VUVElOR1Mob2JqZWN0KTsKQEAg LTk1Nyw2ICs5NjQsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX3NldF9wcm9w ZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIGNvbgogICAgIEVuY2hhbnRCcm9r ZXIqIGJyb2tlcjsKICAgICBFbmNoYW50RGljdCogZGljdDsKICAgICBHU0xpc3QqIHNwZWxsRGlj dGlvbmFyaWVzID0gMDsKKyAgICBHU0xpc3QqIGRpY3RzID0gMDsKIAogICAgIHN3aXRjaChwcm9w X2lkKSB7CiAgICAgY2FzZSBQUk9QX0RFRkFVTFRfRU5DT0RJTkc6CkBAIC0xMDY0LDcgKzEwNzIs MjIgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19zZXRfcHJvcGVydHkoR09iamVj dCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBjb24KICAgICAgICAgICAgIGlmIChlbmNoYW50X2Jy b2tlcl9kaWN0X2V4aXN0cyhicm9rZXIsIGxhbmd1YWdlKSkgewogICAgICAgICAgICAgICAgIGRp Y3QgPSBlbmNoYW50X2Jyb2tlcl9yZXF1ZXN0X2RpY3QoYnJva2VyLCBsYW5ndWFnZSk7CiAgICAg ICAgICAgICAgICAgc3BlbGxEaWN0aW9uYXJpZXMgPSBnX3NsaXN0X2FwcGVuZChzcGVsbERpY3Rp b25hcmllcywgZGljdCk7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIC8v IE5vIGRpY3Rpb25hcmllcyBzZWxlY3RlZCwgd2UgZ2V0IG9uZSBmcm9tIHRoZSBsaXN0CisgICAg ICAgICAgICAgICAgZW5jaGFudF9icm9rZXJfbGlzdF9kaWN0cyhicm9rZXIsIGdldF9hdmFpbF9k aWN0c19jYiwgJmRpY3RzKTsKKyAgICAgICAgICAgICAgICBpZiAoZGljdHMpIHsKKyAgICAgICAg ICAgICAgICAgICAgR1NMaXN0KiB0bXA7CisgICAgICAgICAgICAgICAgICAgIGRpY3QgPSBlbmNo YW50X2Jyb2tlcl9yZXF1ZXN0X2RpY3QoYnJva2VyLCBzdGF0aWNfY2FzdDxjb25zdCBjaGFyICo+ KGRpY3RzLT5kYXRhKSk7CisgICAgICAgICAgICAgICAgICAgIHNwZWxsRGljdGlvbmFyaWVzID0g Z19zbGlzdF9hcHBlbmQoc3BlbGxEaWN0aW9uYXJpZXMsIGRpY3QpOworICAgICAgICAgICAgICAg ICAgICB0bXAgPSBkaWN0czsKKyAgICAgICAgICAgICAgICAgICAgd2hpbGUgKHRtcCkgeworICAg ICAgICAgICAgICAgICAgICAgICAgZ19mcmVlKHRtcC0+ZGF0YSk7CisgICAgICAgICAgICAgICAg ICAgICAgICB0bXAgPSBnX3NsaXN0X25leHQodG1wKTsKKyAgICAgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgICAgICAgICBnX3NsaXN0X2ZyZWUoZGljdHMpOworICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0KKwogICAgICAgICB9CiAgICAgICAgIGdfc2xpc3RfZm9yZWFjaChw cml2LT5lbmNoYW50X2RpY3RzLCBmcmVlX3NwZWxsX2NoZWNraW5nX2xhbmd1YWdlLCAwKTsKICAg ICAgICAgZ19zbGlzdF9mcmVlKHByaXYtPmVuY2hhbnRfZGljdHMpOwo= 76043 2010-12-09 04:15:47 -0800 2010-12-09 04:33:31 -0800 Proposed patch add_defuault_dicts.patch text/plain 2608 alex ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNWFhNWU4Yy4uZGRiOWQ1ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0wOSAg QWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBDaG9vc2UgYSBkaWN0aW9uYXJ5 IGluIGNhc2UgdGhlcmUgaXMgbm8gb25lIGRlZmluZWQgb3IgdGhlCisgICAgICAgIGVudiBMQU5H IGRvZXMgbm90IHByb3Bvc2Ugb25lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MDczOAorCisgICAgICAgIEluIGNhc2Ugbm8gZGljdCBpcyBzZXQgYW5k IHdlIGNhbiBub3QgZmluZCBvbmUgdXNpbmcgdGhlCisgICAgICAgIGVudmlyb25tZW50IGp1c3Qg Z2V0IHRoZSBmaXJzdCBkaWN0aW9uYXJ5IGluc3RhbGxlZCBpbiB0aGUgbGlzdC4KKworICAgICAg ICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAgIChnZXRBdmlsYWJsZURp Y3Rpb25hcmllc0NhbGxiYWNrKToKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3By b3BlcnR5KToKKwogMjAxMC0xMi0wOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5u b3JvbmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBCdWlsZCBmaXguIFRha2Ugd2ViVmll d3tFbnRlcixFeGl0fUZ1bGxzY3JlZW4gYmFjayBvdXQgb2YgdGhlCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJzZXR0aW5ncy5jcHAKaW5kZXggMjY2MWI4Mi4uYmYwMDU0MCAxMDA2NDQKLS0tIGEv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCisrKyBiL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApAQCAtOTUwLDYgKzk1MCwxMyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX2ZpbmFsaXplKEdPYmplY3QqIG9iamVjdCkKICAgICBH X09CSkVDVF9DTEFTUyh3ZWJraXRfd2ViX3NldHRpbmdzX3BhcmVudF9jbGFzcyktPmZpbmFsaXpl KG9iamVjdCk7CiB9CiAKK3N0YXRpYyB2b2lkIGdldEF2aWxhYmxlRGljdGlvbmFyaWVzQ2FsbGJh Y2soY29uc3QgY2hhciogY29uc3QgbGFuZ190YWcsIGNvbnN0IGNoYXIqIGNvbnN0IHByb3ZpZGVy X25hbWUsIGNvbnN0IGNoYXIqIGNvbnN0IHByb3ZpZGVyX2Rlc2MsIGNvbnN0IGNoYXIqIGNvbnN0 IHByb3ZpZGVyX2ZpbGUsIHZvaWQqIGRhdGEpCit7CisgICAgVmVjdG9yPENTdHJpbmc+KiBkaWN0 cyA9IHN0YXRpY19jYXN0PCBWZWN0b3I8Q1N0cmluZz4qID4oZGF0YSk7CisKKyAgICBkaWN0cy0+ YXBwZW5kKGxhbmdfdGFnKTsKK30KKwogc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zZXR0aW5nc19z ZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBjb25zdCBHVmFsdWUq IHZhbHVlLCBHUGFyYW1TcGVjKiBwc3BlYykKIHsKICAgICBXZWJLaXRXZWJTZXR0aW5ncyogd2Vi X3NldHRpbmdzID0gV0VCS0lUX1dFQl9TRVRUSU5HUyhvYmplY3QpOwpAQCAtMTA2NCw2ICsxMDcx LDE0IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KEdPYmpl Y3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwgY29uCiAgICAgICAgICAgICBpZiAoZW5jaGFudF9i cm9rZXJfZGljdF9leGlzdHMoYnJva2VyLCBsYW5ndWFnZSkpIHsKICAgICAgICAgICAgICAgICBk aWN0ID0gZW5jaGFudF9icm9rZXJfcmVxdWVzdF9kaWN0KGJyb2tlciwgbGFuZ3VhZ2UpOwogICAg ICAgICAgICAgICAgIHNwZWxsRGljdGlvbmFyaWVzID0gZ19zbGlzdF9hcHBlbmQoc3BlbGxEaWN0 aW9uYXJpZXMsIGRpY3QpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAv LyBObyBkaWN0aW9uYXJpZXMgc2VsZWN0ZWQsIHdlIGdldCBvbmUgZnJvbSB0aGUgbGlzdAorICAg ICAgICAgICAgICAgIFZlY3RvcjxDU3RyaW5nPiBhbGxEaWN0aW9uYXJpZXM7CisgICAgICAgICAg ICAgICAgZW5jaGFudF9icm9rZXJfbGlzdF9kaWN0cyhicm9rZXIsIGdldEF2aWxhYmxlRGljdGlv bmFyaWVzQ2FsbGJhY2ssICZhbGxEaWN0aW9uYXJpZXMpOworICAgICAgICAgICAgICAgIGlmICgh YWxsRGljdGlvbmFyaWVzLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgICAgICAgICBkaWN0ID0g ZW5jaGFudF9icm9rZXJfcmVxdWVzdF9kaWN0KGJyb2tlciwgYWxsRGljdGlvbmFyaWVzWzBdLmRh dGEoKSk7CisgICAgICAgICAgICAgICAgICAgIHNwZWxsRGljdGlvbmFyaWVzID0gZ19zbGlzdF9h cHBlbmQoc3BlbGxEaWN0aW9uYXJpZXMsIGRpY3QpOworICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBnX3NsaXN0X2ZvcmVhY2gocHJpdi0+ZW5jaGFu dF9kaWN0cywgZnJlZV9zcGVsbF9jaGVja2luZ19sYW5ndWFnZSwgMCk7Cg==