50736 2010-12-08 23:54:34 -0800 Unable to paste in input[type="text"] with last-child selector 2011-03-10 16:40:15 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 1 rikard webkit-unassigned abarth adele ap darin enrica eric matiasnu ojan rniwa tkent tony webkit.review.bot oldest_to_newest 319298 0 rikard 2010-12-08 23:54:34 -0800 The last-child css selector will in some way interfere with paste in Chrome 8,Safari 5 and Chromium. It is not possible to paste text into a textbox that has existing data in it if the :last-child selector is present on the page. This works better with Chromium but the problem still exists in some cases. See attachements. 319299 1 76020 rikard 2010-12-09 00:00:02 -0800 Created attachment 76020 For chrome 8 and Safari 5 319300 2 76021 rikard 2010-12-09 00:01:04 -0800 Created attachment 76021 For chromium 334204 3 78916 matiasnu 2011-01-14 02:22:04 -0800 Created attachment 78916 Two input fields to demonstrate that the first field works as expected It's only the last input field that is affected as you can see from the new attachment but It gets even weirder; 1) Select part of the word Chrome. 2) Paste in first field works. Paste in last field does not work. 3) Select the whole word Chrome by double clicking it. 4) Both first and last field pasting works! 334215 4 matiasnu 2011-01-14 02:34:37 -0800 The chromium attachment seems to work as expected in Chromium 10, so it's possible all issues have been fixed. 364758 5 rniwa 2011-03-09 14:07:43 -0800 Confirmed that this bug reproduces on Safari 5 but doesn't reproduce on TOT. 364784 6 85237 rniwa 2011-03-09 14:35:41 -0800 Created attachment 85237 adds regression tests 365026 7 85237 ojan 2011-03-10 00:18:27 -0800 Comment on attachment 85237 adds regression tests View in context: https://bugs.webkit.org/attachment.cgi?id=85237&action=review > LayoutTests/editing/input/div-first-child-rule-input.html:11 > +// The bug only reproduces on Safari 5 when input is the last element in body Nit: mentioning a specific Safari version is not useful. All layout tests only reproduce in some previous Safari version. Just because this test was committed after doesn't change what the comment should say. All I'm saying is s/on Safari 5//. > LayoutTests/editing/input/div-first-child-rule-textarea.html:11 > +// The bug only reproduces on Safari 5 when textarea is the last element in body Ditto > LayoutTests/editing/input/div-first-child-rule-textarea.html:22 > + if (input.value == 'hello world') > + input.parentNode.insertBefore(document.createTextNode('PASS'), input); > + else > + input.parentNode.insertBefore(document.createTextNode('FAIL'), input); While I'm nitpicking, it would be more readable to do: var success = (input.value == 'hello world') ? 'PASS' : 'FAIL'; input.parentNode.insertBefore(document.createTextNode(success), input); 365317 8 rniwa 2011-03-10 10:59:42 -0800 Thanks for the review! Will fix both issues before landing it. 365340 9 rniwa 2011-03-10 11:22:59 -0800 Committed r80737: <http://trac.webkit.org/changeset/80737> 365648 10 webkit.review.bot 2011-03-10 16:40:15 -0800 http://trac.webkit.org/changeset/80737 might have broken GTK Linux 32-bit Debug and GTK Linux 64-bit Debug The following tests are not passing: fast/js/large-expressions.html jquery/effects.html 76020 2010-12-09 00:00:02 -0800 2010-12-09 00:00:02 -0800 For chrome 8 and Safari 5 chrome8-safari5.htm text/html 373 rikard 77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9F TiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPg0K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KPGhlYWQ+DQogICAg PHN0eWxlIHR5cGU9InRleHQvY3NzIj4NCiAgICAgICAgZGl2Omxhc3QtY2hpbGQge30NCiAgICA8 L3N0eWxlPg0KPC9oZWFkPg0KPGJvZHk+DQogICAgPHNwYW4+Rm9yIHNhZmFyaSA1IGFuZCBjaHJv bWUgODwvc3Bhbj4NCiAgICA8aW5wdXQgdHlwZT0idGV4dCIgdmFsdWU9InRyeSBhcHBlbmQgd2l0 aCBwYXN0ZSIgLz4NCjwvYm9keT4NCjwvaHRtbD4NCg== 76021 2010-12-09 00:01:04 -0800 2010-12-09 00:01:04 -0800 For chromium chromium.htm text/html 398 rikard 77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9F TiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPg0K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KPGhlYWQ+DQogICAg PHN0eWxlIHR5cGU9InRleHQvY3NzIj4NCiAgICAgICAgZGl2Omxhc3QtY2hpbGQge30NCiAgICA8 L3N0eWxlPg0KPC9oZWFkPg0KPGJvZHk+DQogICAgPHNwYW4+Rm9yIGNocm9taXVtPC9zcGFuPg0K ICAgIDxpbnB1dCB0eXBlPSJ0ZXh0IiB2YWx1ZT0icGFzdGUgd29ya3MiIC8+DQogICAgPHRleHRh cmVhPnRyeSBhcHBlbmQgd2l0aCBwYXN0ZTwvdGV4dGFyZWE+DQo8L2JvZHk+DQo8L2h0bWw+DQo= 78916 2011-01-14 02:22:04 -0800 2011-01-14 02:22:04 -0800 Two input fields to demonstrate that the first field works as expected chrome8-safari5-dual.htm text/html 387 matiasnu 77u/PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9F TiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPg0K PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KPGhlYWQ+DQogICAg PHN0eWxlIHR5cGU9InRleHQvY3NzIj4NCiAgICAgICAgZGl2Omxhc3QtY2hpbGQge30NCiAgICA8 L3N0eWxlPg0KPC9oZWFkPg0KPGJvZHk+DQogICAgPHNwYW4+Rm9yIHNhZmFyaSA1IGFuZCBjaHJv bWUgODwvc3Bhbj4NCiAgICA8aW5wdXQgdHlwZT0idGV4dCIgdmFsdWU9IngiIC8+DQoJPGlucHV0 IHR5cGU9InRleHQiIHZhbHVlPSJ4IiAvPg0KPC9ib2R5Pg0KPC9odG1sPg0K 85237 2011-03-09 14:35:41 -0800 2011-03-10 00:18:27 -0800 adds regression tests bug-50736-20110309143540.patch text/plain 4476 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDgwNjY1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDMtMDkgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5hYmxlIHRvIHBhc3RlIGluIGlucHV0W3R5cGU9InRleHQiXSB3aXRoIGxhc3Qt Y2hpbGQgc2VsZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUwNzM2CisKKyAgICAgICAgQWRkZWQgcmVncmVzc2lvbnMgdGVzdHMgc2luY2UgdGhp cyBidWcgbm8gbG9uZ2VyIHJlcHJvZHVjZXMgb24gVE9UIFdlYktpdC4KKworICAgICAgICAqIGVk aXRpbmcvaW5wdXQvZGl2LWZpcnN0LWNoaWxkLXJ1bGUtaW5wdXQtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBlZGl0aW5nL2lucHV0L2Rpdi1maXJzdC1jaGlsZC1ydWxlLWlucHV0Lmh0 bWw6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvaW5wdXQvZGl2LWZpcnN0LWNoaWxkLXJ1bGUt dGV4dGFyZWEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2lucHV0L2Rp di1maXJzdC1jaGlsZC1ydWxlLXRleHRhcmVhLmh0bWw6IEFkZGVkLgorCiAyMDExLTAzLTA5ICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgS2VubmV0aCBSdXNzZWxsLgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9kaXYt Zmlyc3QtY2hpbGQtcnVsZS1pbnB1dC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZWRpdGluZy9pbnB1dC9kaXYtZmlyc3QtY2hpbGQtcnVsZS1pbnB1dC1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L2Rpdi1maXJzdC1j aGlsZC1ydWxlLWlucHV0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBA CitUaGlzIHRlc3QgZW5zdXJlcyBXZWJLaXQgY2FuIHBhc3RlIGNvbnRlbnQgaW5zaWRlIGFuIGlu cHV0IGVsZW1lbnQgZXZlbiB3aGVuIHRoZXJlIGlzIGRpdjpsYXN0LWNoaWxkIHt9LgorCitQQVNT CkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L2Rpdi1maXJzdC1jaGlsZC1ydWxlLWlu cHV0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9kaXYtZmly c3QtY2hpbGQtcnVsZS1pbnB1dC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRp dGluZy9pbnB1dC9kaXYtZmlyc3QtY2hpbGQtcnVsZS1pbnB1dC5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDMzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxoZWFkPgorPHN0eWxlIHR5cGU9InRl eHQvY3NzIj4KK2RpdjpsYXN0LWNoaWxkIHt9Cis8L3N0eWxlPgorPHNjcmlwdD4KKworaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1w QXNUZXh0KCk7CisKKy8vIFRoZSBidWcgb25seSByZXByb2R1Y2VzIG9uIFNhZmFyaSA1IHdoZW4g aW5wdXQgaXMgdGhlIGxhc3QgZWxlbWVudCBpbiBib2R5CisvLyBTbyB3ZSBoYXZlIG5vIGNob2lj ZSBidXQgdG8gcnVuIHRoZSB0ZXN0IG9uIHBhZ2UgbG9hZC4KK2Z1bmN0aW9uIHJ1blRlc3QoKSB7 CisgICAgdmFyIGlucHV0ID0gZG9jdW1lbnQuYm9keS5nZXRFbGVtZW50c0J5VGFnTmFtZSgnaW5w dXQnKVswXTsKKyAgICBpbnB1dC5mb2N1cygpOworICAgIGlucHV0LnNlbGVjdGlvblN0YXJ0ID0g NTsKKyAgICBpbnB1dC5zZWxlY3Rpb25FbmQgPSA1OworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5k KCdJbnNlcnRIVE1MJywgZmFsc2UsICc8ZGl2PiB3b3JsZDwvZGl2PicpOworICAgIGlmIChpbnB1 dC52YWx1ZSA9PSAnaGVsbG8gd29ybGQnKQorICAgICAgICBpbnB1dC5wYXJlbnROb2RlLmluc2Vy dEJlZm9yZShkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnUEFTUycpLCBpbnB1dCk7CisgICAgZWxz ZQorICAgICAgICBpbnB1dC5wYXJlbnROb2RlLmluc2VydEJlZm9yZShkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZSgnRkFJTCcpLCBpbnB1dCk7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKKyAgICAgICAgaW5wdXQucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChpbnB1dCk7Cit9CisK Kzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+VGhpcyB0 ZXN0IGVuc3VyZXMgV2ViS2l0IGNhbiBwYXN0ZSBjb250ZW50IGluc2lkZSBhbiBpbnB1dCBlbGVt ZW50IGV2ZW4gd2hlbiB0aGVyZSBpcyBkaXY6bGFzdC1jaGlsZCB7fS48L3A+Cis8aW5wdXQgdHlw ZT0idGV4dCIgdmFsdWU9ImhlbGxvIj4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRl c3RzL2VkaXRpbmcvaW5wdXQvZGl2LWZpcnN0LWNoaWxkLXJ1bGUtdGV4dGFyZWEtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvZGl2LWZpcnN0LWNo aWxkLXJ1bGUtdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9pbnB1dC9kaXYtZmlyc3QtY2hpbGQtcnVsZS10ZXh0YXJlYS1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0IGVuc3VyZXMgV2ViS2l0 IGNhbiBwYXN0ZSBjb250ZW50IGluc2lkZSBhbiB0ZXh0YXJlYSBlbGVtZW50IGV2ZW4gd2hlbiB0 aGVyZSBpcyBkaXY6bGFzdC1jaGlsZCB7fS4KKworUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZWRp dGluZy9pbnB1dC9kaXYtZmlyc3QtY2hpbGQtcnVsZS10ZXh0YXJlYS5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvZGl2LWZpcnN0LWNoaWxkLXJ1bGUtdGV4dGFy ZWEuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvZGl2LWZp cnN0LWNoaWxkLXJ1bGUtdGV4dGFyZWEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMyBA QAorPCFET0NUWVBFIGh0bWw+Cis8aGVhZD4KKzxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CitkaXY6 bGFzdC1jaGlsZCB7fQorPC9zdHlsZT4KKzxzY3JpcHQ+CisKK2lmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisv LyBUaGUgYnVnIG9ubHkgcmVwcm9kdWNlcyBvbiBTYWZhcmkgNSB3aGVuIHRleHRhcmVhIGlzIHRo ZSBsYXN0IGVsZW1lbnQgaW4gYm9keQorLy8gU28gd2UgaGF2ZSBubyBjaG9pY2UgYnV0IHRvIHJ1 biB0aGUgdGVzdCBvbiBwYWdlIGxvYWQuCitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIHZhciBp bnB1dCA9IGRvY3VtZW50LmJvZHkuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3RleHRhcmVhJylbMF07 CisgICAgaW5wdXQuZm9jdXMoKTsKKyAgICBpbnB1dC5zZWxlY3Rpb25TdGFydCA9IDU7CisgICAg aW5wdXQuc2VsZWN0aW9uRW5kID0gNTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0 SFRNTCcsIGZhbHNlLCAnPGRpdj4gd29ybGQ8L2Rpdj4nKTsKKyAgICBpZiAoaW5wdXQudmFsdWUg PT0gJ2hlbGxvIHdvcmxkJykKKyAgICAgICAgaW5wdXQucGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUo ZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ1BBU1MnKSwgaW5wdXQpOworICAgIGVsc2UKKyAgICAg ICAgaW5wdXQucGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo J0ZBSUwnKSwgaW5wdXQpOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgIGlucHV0LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoaW5wdXQpOworfQorCis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPlRoaXMgdGVzdCBlbnN1 cmVzIFdlYktpdCBjYW4gcGFzdGUgY29udGVudCBpbnNpZGUgYW4gdGV4dGFyZWEgZWxlbWVudCBl dmVuIHdoZW4gdGhlcmUgaXMgZGl2Omxhc3QtY2hpbGQge30uPC9wPgorPHRleHRhcmVhPmhlbGxv PC90ZXh0YXJlYT4KKzwvYm9keT4KKzwvaHRtbD4K