50730 2010-12-08 19:32:19 -0800 Spatial Navigation: Crash when handling iframe of size 0. 2010-12-13 12:25:32 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 46905 1 yael webkit-unassigned ademar commit-queue tonikitoo oldest_to_newest 319221 0 yael 2010-12-08 19:32:19 -0800 While adding more new tests I noticed that if we have a frame of size 0, we would get into infinite loop and eventually crash. The reason is that when the algorithm sees a starting rect of size 0, it assumes that there is no focused node, thus restarts itself. 319225 1 76005 yael 2010-12-08 19:39:33 -0800 Created attachment 76005 Patch. 319455 2 76005 tonikitoo 2010-12-09 07:33:44 -0800 Comment on attachment 76005 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=76005&action=review > WebCore/page/FocusController.cpp:422 > // Ignore iframes that don't have a src attribute Please also update comment. 319476 3 76005 commit-queue 2010-12-09 08:26:13 -0800 Comment on attachment 76005 Patch. Rejecting patch 76005 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6948010 319622 4 76005 commit-queue 2010-12-09 11:37:00 -0800 Comment on attachment 76005 Patch. Clearing flags on attachment: 76005 Committed r73634: <http://trac.webkit.org/changeset/73634> 319623 5 commit-queue 2010-12-09 11:37:06 -0800 All reviewed patches have been landed. Closing bug. 321261 6 ademar 2010-12-13 11:14:30 -0800 I can't just cherry-pick it to qtwebkit-2.1 because of changes from bug 47142. I'll fix the conflict as below. Yael/Antonio, could you please confirm it's OK? - if (candidate.node->isFrameOwnerElement() && !static_cast<HTMLFrameOwnerElement*>(candidate.node)->contentFrame()) + if (candidate.node->isFrameOwnerElement() && (!static_cast<HTMLFrameOwnerElement*>(candidate.node)->contentFrame() || candidate.rect.isEmpty())) 321309 7 yael 2010-12-13 12:01:14 -0800 (In reply to comment #6) > I can't just cherry-pick it to qtwebkit-2.1 because of changes from bug 47142. > > I'll fix the conflict as below. Yael/Antonio, could you please confirm it's OK? > > - if (candidate.node->isFrameOwnerElement() && !static_cast<HTMLFrameOwnerElement*>(candidate.node)->contentFrame()) > + if (candidate.node->isFrameOwnerElement() && (!static_cast<HTMLFrameOwnerElement*>(candidate.node)->contentFrame() || candidate.rect.isEmpty())) Looks good to me. thanks! 321323 8 ademar 2010-12-13 12:24:53 -0800 Revision r73634 cherry-picked into qtwebkit-2.1 with commit 7bebc59 <http://gitorious.org/webkit/qtwebkit/commit/7bebc59> 76005 2010-12-08 19:39:33 -0800 2010-12-09 11:37:00 -0800 Patch. 50730.patch text/plain 5004 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzU4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTItMDggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNwYXRpYWwgTmF2aWdhdGlvbjogQ3Jhc2ggd2hlbiBoYW5kbGluZyBpZnJhbWUgb2Ygc2l6ZSAw LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA3MzAK KworICAgICAgICBpZiB3ZSBoYXZlIGEgZnJhbWUgb2Ygc2l6ZSAwLCB3ZSB3b3VsZCBnZXQgaW50 byBpbmZpbml0ZSBsb29wIGFuZCBldmVudHVhbGx5IGNyYXNoLiBUaGUgcmVhc29uIGlzCisgICAg ICAgIHRoYXQgd2hlbiB0aGUgYWxnb3JpdGhtIHNlZXMgYSBzdGFydGluZyByZWN0IG9mIHNpemUg MCwgaXQgYXNzdW1lcyB0aGF0IHRoZXJlIGlzIG5vIGZvY3VzZWQgbm9kZSwKKyAgICAgICAgdGh1 cyByZXN0YXJ0cyBpdHNlbGYuIFRoZSBzb2x1dGlvbiBpcyB0byBhdm9pZCBjb25zaWRlcmluZyBp ZnJhbWVzIHdpdGggc2l6ZSAwIGZvciB0aGUgc3BhdGlhbAorICAgICAgICBuYXZpZ2F0aW9uIGFs Z29yaXRobS4KKworICAgICAgICBUZXN0OiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWhp ZGRlbi1pZnJhbWUtemVyby1zaXplLmh0bWwKKworICAgICAgICAqIHBhZ2UvRm9jdXNDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZUZvY3VzQ2FuZGlkYXRlSWZOZWVkZWQp OgorCiAyMDEwLTEyLTA4ICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xs YWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpJbmRl eDogV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDczNTg1KQorKysgV2ViQ29yZS9w YWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyMCw3ICs0MjAsNyBA QCB2b2lkIHVwZGF0ZUZvY3VzQ2FuZGlkYXRlSWZOZWVkZWQoRm9jdXNECiAgICAgICAgIHJldHVy bjsKIAogICAgIC8vIElnbm9yZSBpZnJhbWVzIHRoYXQgZG9uJ3QgaGF2ZSBhIHNyYyBhdHRyaWJ1 dGUKLSAgICBpZiAoY2FuZGlkYXRlLnZpc2libGVOb2RlLT5pc0ZyYW1lT3duZXJFbGVtZW50KCkg JiYgIXN0YXRpY19jYXN0PEhUTUxGcmFtZU93bmVyRWxlbWVudCo+KGNhbmRpZGF0ZS52aXNpYmxl Tm9kZSktPmNvbnRlbnRGcmFtZSgpKQorICAgIGlmIChjYW5kaWRhdGUudmlzaWJsZU5vZGUtPmlz RnJhbWVPd25lckVsZW1lbnQoKSAmJiAoIXN0YXRpY19jYXN0PEhUTUxGcmFtZU93bmVyRWxlbWVu dCo+KGNhbmRpZGF0ZS52aXNpYmxlTm9kZSktPmNvbnRlbnRGcmFtZSgpIHx8IGNhbmRpZGF0ZS5y ZWN0LmlzRW1wdHkoKSkpCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIElnbm9yZSBvZmYgc2Ny ZWVuIGNoaWxkIG5vZGVzIG9mIGNvbnRhaW5lcnMgdGhhdCBkbyBub3Qgc2Nyb2xsIChvdmVyZmxv dzpoaWRkZW4pCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MzU4NykKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEyLTA4ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTcGF0aWFsIE5hdmlnYXRpb246IENyYXNoIHdoZW4gaGFu ZGxpbmcgaWZyYW1lIG9mIHNpemUgMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTUwNzMwCisKKyAgICAgICAgKiBmYXN0L3NwYXRpYWwtbmF2aWdhdGlv bi9zbmF2LWhpZGRlbi1pZnJhbWUtemVyby1zaXplLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1oaWRkZW4taWZyYW1lLXplcm8tc2l6 ZS5odG1sOiBBZGRlZC4KKwogMjAxMC0xMi0wOCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3RhdGlvbiB1cGRhdGUuCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWhpZGRlbi1pZnJh bWUtemVyby1zaXplLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWhpZGRlbi1pZnJhbWUtemVyby1zaXplLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9u L3NuYXYtaGlkZGVuLWlmcmFtZS16ZXJvLXNpemUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDkgQEAKK1RoaXMgaXMgbGlua18xLgorCisKK1RoaXMgaXMgCithbiBpZnJhbWUg d2l0aCBzaXplIDAuCitUaGlzIGlzIGxpbmtfMi4KKworUEFTUyBnRm9jdXNlZERvY3VtZW50LmFj dGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJlbmQiCitUaGlzIHRlc3QgaXMgdG8g dGVzdCB0aGF0IGFuIGlmcmFtZSB3aXRoIHNpemUgMCBkb2VzIG5vdCBnZXQgZm9jdXMsIGFuZCBu ZWl0aGVyIGRvIGl0cyBkZXNjZW5kYW50cy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc3BhdGlh bC1uYXZpZ2F0aW9uL3NuYXYtaGlkZGVuLWlmcmFtZS16ZXJvLXNpemUuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWhpZGRlbi1pZnJh bWUtemVyby1zaXplLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NwYXRp YWwtbmF2aWdhdGlvbi9zbmF2LWhpZGRlbi1pZnJhbWUtemVyby1zaXplLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNTIgQEAKKzxodG1sPgorICA8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNy Yz0icmVzb3VyY2VzL3NwYXRpYWwtbmF2aWdhdGlvbi11dGlscy5qcyI+PC9zY3JpcHQ+CisgICAg PHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9qYXZhc2NyaXB0Ij4KKworICAgIHZhciByZXN1bHRN YXAgPSBbCisgICAgICBbIkRvd24iLCAiZW5kIl0sCisgICAgICBbIkRPTkUiLCAiRE9ORSJdCisg ICAgXTsKKworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCh0cnVlKTsKKyAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0VGFiVG9MaW5rc1ByZWZlcmVuY2VL ZXkiLCAxKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAg ICB9CisKKyAgICBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICB7CisgICAgICAvLyBzdGFydGluZyB0 aGUgdGVzdCBpdHNlbGY6IGdldCB0byBhIGtub3duIHBsYWNlLgorICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInN0YXJ0IikuZm9jdXMoKTsKKworICAgICAgaW5pdFRlc3QocmVzdWx0TWFw LCB0ZXN0Q29tcGxldGVkKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiB0ZXN0Q29tcGxldGVkKCkK KyAgICB7CisgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQorCisgICAgd2luZG93Lm9u bG9hZCA9IHJ1blRlc3Q7CisKKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0ianMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CisgIDwvaGVhZD4KKworICA8Ym9keSBp ZD0ic29tZS1jb250ZW50IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+Cisg ICAgICA8cD5UaGlzIGlzIDxhIGlkPSJzdGFydCIgaHJlZj0iYSI+bGlua18xPC9hPi48L3A+Cisg ICAgICAgPGJyPlRoaXMgaXMgPGlmcmFtZSBpZD0iMSIgd2lkdGg9MCBoZWlnaHQ9MCAgc3JjPSJk YXRhOnRleHQvaHRtbCwKKyAgICAgICAgPGJvZHk+CisgICAgICAgICAgPGEgaWQ9JzExJyBocmVm PSdodHRwOi8vYSc+YjwvYT4KKyAgICAgICAgICA8YSBpZD0nMTInIGhyZWY9J2h0dHA6Ly9hJz5j PC9hPgorICAgICAgICAgIDxhIGlkPScxMycgaHJlZj0naHR0cDovL2EnPmQ8L2E+CisgICAgICAg IDwvYm9keT4KKyAgICAgICAgIj48L2lmcmFtZT48YnI+IGFuIGlmcmFtZSB3aXRoIHNpemUgMC48 YnI+CisgICAgIDxwPlRoaXMgaXMgPGEgaWQ9ImVuZCIgaHJlZj0iYSI+bGlua18yPC9hPi48L3A+ CisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisgICAgPHA+VGhpcyB0ZXN0IGlzIHRvIHRl c3QgdGhhdCBhbiBpZnJhbWUgd2l0aCBzaXplIDAgZG9lcyBub3QgZ2V0IGZvY3VzLCBhbmQgbmVp dGhlciBkbyBpdHMgZGVzY2VuZGFudHMuCisgIDwvYm9keT4KKzwvaHRtbD4K