50724 2010-12-08 16:57:53 -0800 WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame 2010-12-09 00:35:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 319135 0 andersca 2010-12-08 16:57:53 -0800 WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame 319136 1 75987 andersca 2010-12-08 16:58:52 -0800 Created attachment 75987 Patch 319141 2 75987 darin 2010-12-08 17:04:01 -0800 Comment on attachment 75987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75987&action=review > WebKit2/UIProcess/WebFrameProxy.cpp:96 > + Vector<String> mimeTypes = WebContext::pdfAndPostScriptMIMETypes(); > + for (size_t i = 0; i < mimeTypes.size(); ++i) { > + if (equalIgnoringCase(mimeTypes[i], mimeType)) > + return true; > + } Seems really ugly to write out the loop like this. One benefit of using a set is that you don’t need to write the loop. You should factor the loop into a helper function so it’s easier to see what the code is doing. 319147 3 andersca 2010-12-08 17:09:40 -0800 Committed r73569: <http://trac.webkit.org/changeset/73569> 319312 4 webkit.review.bot 2010-12-09 00:35:02 -0800 http://trac.webkit.org/changeset/73569 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/css/input-search-padding.html fast/css/text-input-with-webkit-border-radius.html fast/forms/box-shadow-override.html fast/forms/control-restrict-line-height.html fast/forms/input-appearance-height.html fast/forms/placeholder-pseudo-style.html fast/forms/placeholder-set-value.html fast/forms/search-cancel-button-style-sharing.html fast/forms/search-placeholder-value-changed.html fast/forms/search-rtl.html fast/forms/search-styled.html fast/forms/search-transformed.html fast/forms/search-vertical-alignment.html fast/forms/search-zoomed.html fast/forms/searchfield-heights.html 75987 2010-12-08 16:58:52 -0800 2010-12-08 17:04:01 -0800 Patch bug-50724-20101208165851.patch text/plain 3202 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NTI0OWE1OWZmYTY2MzFlYzU1YjQ5NmY4OTRiNWVmN2I1ZDI4ODFkNS4uZjJlNzg2OTg5MmY4MzI2 ZWFiMTY2OWFjZWNjZWI4YjllMjg3ODcyMiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0xMi0wOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkZyYW1lUHJveHk6OmNhblNob3dNSU1FVHlw ZSBzaG91bGQgcmV0dXJuIHRydWUgZm9yIFBERiBNSU1FIHR5cGVzIGluIHRoZSBtYWluIGZyYW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDcyNAor CisgICAgICAgICogVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJDb250ZXh0OjpwZGZBbmRQb3N0U2NyaXB0TUlNRVR5cGVzKToKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViQ29udGV4dC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJGcmFtZVByb3h5LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVQcm94eTo6Y2FuU2hvd01JTUVUeXBlKToKKworMjAx MC0xMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAg IFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCiAKICAgICAgICAgTW92ZSBjYW5TaG93TUlNRVR5cGUg dG8gRnJhbWUKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwIGIv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKaW5kZXggNjQxOWM2YzFiMTc3NjAzNmNm MGQ1YzU4YmIyYTA1MzRiMzk4NTdhYS4uY2JmNDRjNDM5NWMwNjY4YTc0ODhjMWNjODczMmE4Nzcw YzkxNWJjYyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKKysr IGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKQEAgLTQxMSw2ICs0MTEsMTggQEAg dm9pZCBXZWJDb250ZXh0Ojpkb3dubG9hZEZpbmlzaGVkKERvd25sb2FkUHJveHkqIGRvd25sb2Fk UHJveHkpCiAgICAgbV9kb3dubG9hZHMucmVtb3ZlKGRvd25sb2FkUHJveHktPmRvd25sb2FkSUQo KSk7CiB9CiAKKy8vIEZJWE1FOiBUaGlzIGlzIG5vdCB0aGUgaWRlYWwgcGxhY2UgZm9yIHRoaXMg ZnVuY3Rpb24uCitWZWN0b3I8U3RyaW5nPiBXZWJDb250ZXh0OjpwZGZBbmRQb3N0U2NyaXB0TUlN RVR5cGVzKCkKK3sKKyAgICBWZWN0b3I8U3RyaW5nPiBtaW1lVHlwZXM7CisKKyAgICBtaW1lVHlw ZXMuYXBwZW5kKCJhcHBsaWNhdGlvbi9wZGYiKTsKKyAgICBtaW1lVHlwZXMuYXBwZW5kKCJhcHBs aWNhdGlvbi9wb3N0c2NyaXB0Iik7CisgICAgbWltZVR5cGVzLmFwcGVuZCgidGV4dC9wZGYiKTsK KyAgICAKKyAgICByZXR1cm4gbWltZVR5cGVzOworfQorCiB2b2lkIFdlYkNvbnRleHQ6OmRpZFJl Y2VpdmVNZXNzYWdlKENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24sIENvcmVJUEM6Ok1l c3NhZ2VJRCBtZXNzYWdlSUQsIENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciogYXJndW1lbnRzKQog ewogICAgIGlmIChtZXNzYWdlSUQuaXM8Q29yZUlQQzo6TWVzc2FnZUNsYXNzV2ViQ29udGV4dD4o KSkgewpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oIGIvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCmluZGV4IDZhMjZjNjQyNjFmZGE3YzM3NTg4M2EwN2Q1 MzIwMzVjOTc0ZWVlMjguLjVhNGQ5NjYwYmUyNzY1ODVkMWQ5YTIxYWFmNWM1ZjE0ODBiNmU1ZDAg MTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAorKysgYi9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgKQEAgLTEyMiw2ICsxMjIsOCBAQCBwdWJsaWM6CiAgICAg V2ViRG93bmxvYWRDbGllbnQmIGRvd25sb2FkQ2xpZW50KCkgeyByZXR1cm4gbV9kb3dubG9hZENs aWVudDsgfQogICAgIHZvaWQgZG93bmxvYWRGaW5pc2hlZChEb3dubG9hZFByb3h5Kik7CiAKKyAg ICBzdGF0aWMgVmVjdG9yPFN0cmluZz4gcGRmQW5kUG9zdFNjcmlwdE1JTUVUeXBlcygpOworCiBw cml2YXRlOgogICAgIFdlYkNvbnRleHQoUHJvY2Vzc01vZGVsLCBjb25zdCBTdHJpbmcmIGluamVj dGVkQnVuZGxlUGF0aCk7CiAKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL1dlYkZyYW1l UHJveHkuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAKaW5kZXggZjVi NTczMWIwNTQ2MGMyNjBjMzVmYWNjNzA1ZThhN2IyZDBiODJlYS4uMzFhZjZjOGIxZTNiYjBhNjcw MGUyZGMyMTc1MjRlMDk4ZTQ3OGQxMiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi RnJhbWVQcm94eS5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRnJhbWVQcm94eS5jcHAK QEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJXZWJGcmFtZVByb3h5LmgiCiAKICNpbmNsdWRl ICJXZWJDZXJ0aWZpY2F0ZUluZm8uaCIKKyNpbmNsdWRlICJXZWJDb250ZXh0LmgiCiAjaW5jbHVk ZSAiV2ViRm9ybVN1Ym1pc3Npb25MaXN0ZW5lclByb3h5LmgiCiAjaW5jbHVkZSAiV2ViRnJhbWVQ b2xpY3lMaXN0ZW5lclByb3h5LmgiCiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCkBAIC04Niw2 ICs4NywxNiBAQCBib29sIFdlYkZyYW1lUHJveHk6OmNhblNob3dNSU1FVHlwZShjb25zdCBTdHJp bmcmIG1pbWVUeXBlKSBjb25zdAogICAgIGlmIChtX3BhZ2UtPmNhblNob3dNSU1FVHlwZShtaW1l VHlwZSkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisjaWYgUExBVEZPUk0oTUFDKQorICAgIGlm IChpc01haW5GcmFtZSgpKSB7CisgICAgICAgIFZlY3RvcjxTdHJpbmc+IG1pbWVUeXBlcyA9IFdl YkNvbnRleHQ6OnBkZkFuZFBvc3RTY3JpcHRNSU1FVHlwZXMoKTsKKyAgICAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBtaW1lVHlwZXMuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgICAgIGlmIChl cXVhbElnbm9yaW5nQ2FzZShtaW1lVHlwZXNbaV0sIG1pbWVUeXBlKSkKKyAgICAgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgIH0KKyNlbmRpZgorCiAgICAgcmV0dXJuIGZh bHNlOwogfQogCg==