50715 2010-12-08 14:03:39 -0800 webkit-patch should warn users when they're using a 32-bit git on a 64-bit system 2010-12-14 01:44:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric abarth commit-queue eric kling mihaip ojan oldest_to_newest 319014 0 eric 2010-12-08 14:03:39 -0800 webkit-patch should warn users when they're using a 32-bit git on a 64-bit system 319026 1 75960 eric 2010-12-08 14:17:33 -0800 Created attachment 75960 Patch 319033 2 75960 eric 2010-12-08 14:22:52 -0800 Comment on attachment 75960 Patch Hmm... Nevermind, platform.architecture() is not working as expected. Investigating. 319060 3 75974 eric 2010-12-08 14:55:23 -0800 Created attachment 75974 Patch 319071 4 75977 eric 2010-12-08 15:13:06 -0800 Created attachment 75977 move _check_git_architecture to after SCM.__init__ 319076 5 75977 mihaip 2010-12-08 15:22:46 -0800 Comment on attachment 75977 move _check_git_architecture to after SCM.__init__ View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > WebKitTools/ChangeLog:19 > + This message will print twice during 'webkit-patch upload', You could keep track of whether or not you printed out the message in a static, so that it only shows up once. 319090 6 eric 2010-12-08 15:46:32 -0800 (In reply to comment #5) > (From update of attachment 75977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > > > WebKitTools/ChangeLog:19 > > + This message will print twice during 'webkit-patch upload', > > You could keep track of whether or not you printed out the message in a static, so that it only shows up once. webkit-patch calls out to check-webkit-style (a separate process). 319523 7 75977 ojan 2010-12-09 09:53:06 -0800 Comment on attachment 75977 move _check_git_architecture to after SCM.__init__ View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > WebKitTools/ChangeLog:23 > + the code is. I considered writing a test for the log message, but it seemed not worth it. I think testing _check_git_architecture is worthwhile just to ensure that the code actually runs. Don't even need to verify the output. It helps avoid simple programming errors (e.g. typos). 319580 8 eric 2010-12-09 10:49:46 -0800 (In reply to comment #7) > (From update of attachment 75977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75977&action=review > > > WebKitTools/ChangeLog:23 > > + the code is. I considered writing a test for the log message, but it seemed not worth it. > > I think testing _check_git_architecture is worthwhile just to ensure that the code actually runs. Don't even need to verify the output. It helps avoid simple programming errors (e.g. typos). Possible, however having git installed is not required for WebKit. So I could check that it throws an OSError or returns a value? 321762 9 commit-queue 2010-12-14 01:26:10 -0800 The commit-queue encountered the following flaky tests while processing attachment 75977: fast/dom/onerror-img.html bug 51019 fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 321802 10 commit-queue 2010-12-14 01:42:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 75977: http/tests/xmlhttprequest/cross-site-denied-response-sync.html bug 51020 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 321806 11 75977 commit-queue 2010-12-14 01:44:01 -0800 Comment on attachment 75977 move _check_git_architecture to after SCM.__init__ Clearing flags on attachment: 75977 Committed r74008: <http://trac.webkit.org/changeset/74008> 321808 12 commit-queue 2010-12-14 01:44:08 -0800 All reviewed patches have been landed. Closing bug. 75960 2010-12-08 14:17:33 -0800 2010-12-08 14:55:17 -0800 Patch bug-50715-20101208141731.patch text/plain 3286 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZWQ1YWM3MmUxNDg2OTE3MDE0YzdlZDg5Nzg1MmI2ZGIyYTYzYTJjLi4zMDRmYWVj ZWFiOTU2ZDEyZmY4ODE1MjRlNTNjYjA5MDU3YjMwOThkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAK KzIwMTAtMTItMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBzaG91bGQg d2FybiB1c2VycyB3aGVuIHRoZXkncmUgdXNpbmcgYSAzMi1iaXQgZ2l0IG9uIGEgNjQtYml0IHN5 c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA3 MTUKKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHdlYmtpdC1wYXRjaCBwcmludCB0aGUgZm9s bG93aW5nOgorCisgICAgICAgIFdhcm5pbmc6IFRoaXMgbWFjaGluZSBpcyA2NC1iaXQsIGJ1dCB0 aGUgZ2l0IGJpbmFyeSAoL3Vzci9sb2NhbC9naXQvYmluL2dpdCkgZG9lcyBub3Qgc3VwcG9ydCA2 NC1iaXQuCisgICAgICAgIEluc3RhbGwgYSA2NC1iaXQgZ2l0IGZvciBiZXR0ZXIgcGVyZm9ybWFu Y2UsIHNlZToKKyAgICAgICAgaHR0cHM6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJr aXQtZGV2LzIwMTAtRGVjZW1iZXIvMDE1MjQ5Lmh0bWwKKworICAgICAgICBJIHdyb3RlIHRoaXMg bW9zdGx5IGJlY2F1c2UgSSBoYXZlIGxpa2UgOCBtYWNoaW5lcyB0aGF0IEkgdXNlCisgICAgICAg IGFuZCBtYWtpbmcgc3VyZSBlYWNoIG9uZSBpcyB1c2luZyBhIGdvb2QgR2l0IGluc3RhbGwgc2Vl bWVkIGZvbGx5LgorICAgICAgICB3ZWJraXQtcGF0Y2ggbWFrZXMgYSBsb3Qgb2YgZ2l0IGNhbGxz LCBzbyB1c2luZyBhIGZhc3QgZ2l0IGNhbiBzaGF2ZQorICAgICAgICBzZXZlcmFsIHNlY29uZHMg aW4gZXZlcnkgaW52b2NhdGlvbi4gIFNlZSB0aGUgd2Via2l0LWRldiB0aHJlYWQgZm9yIG1vcmUg aW5mby4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5IHRoZXJlIGlzIG5vIGdvb2Qgd2F5IHRvIHRl c3QgdGhpcyBkdWUgdG8gaG93IG1hY2hpbmUtZGVwZW5kYW50CisgICAgICAgIHRoZSBjb2RlIGlz LiAgSSBjb25zaWRlcmVkIHdyaXRpbmcgYSB0ZXN0IGZvciB0aGUgbG9nIG1lc3NhZ2UsIGJ1dCBp dCBzZWVtZWQgbm90IHdvcnRoIGl0LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vY2hlY2tvdXQvc2NtLnB5OgorCiAyMDEwLTEyLTA4ICBKZXNzaWUgQmVybGluICA8amJlcmxp bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQppbmRl eCBlZTJiYjQxMmJhMDU1Y2FiZDIyMjFjNmYxNWJiNjNmODliMjdhMDFmLi4wMTBmNGU2MzczMzNi ODZkN2IyN2MwNDlhYmI3MjMxMWM2MmNjODM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CkBAIC01NzQsOCArNTc0LDMwIEBA IGNsYXNzIFNWTihTQ00pOgogIyBBbGwgZ2l0LXNwZWNpZmljIGxvZ2ljIHNob3VsZCBnbyBoZXJl LgogY2xhc3MgR2l0KFNDTSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGN3ZCk6CisgICAgICAg IHNlbGYuX2NoZWNrX2dpdF9hcmNoaXRlY3R1cmUoKQogICAgICAgICBTQ00uX19pbml0X18oc2Vs ZiwgY3dkKQogCisgICAgZGVmIF9jaGVja19naXRfYXJjaGl0ZWN0dXJlKHNlbGYpOgorICAgICAg ICBpbXBvcnQgcGxhdGZvcm0KKyAgICAgICAgIyBUaGlzIG9ubHkgaXMgdGVzdGVkIG9uIE1hYy4K KyAgICAgICAgaWYgbm90IHBsYXRmb3JtLm1hY192ZXIoKVswXToKKyAgICAgICAgICAgIHJldHVy bgorCisgICAgICAgICMgVGhpcyBpcyBjaGVja2luZyB0aGUgYXJjaGl0ZWN0dXJlIG9mIHRoZSBw eXRob24gZXhlY3V0YWJsZSwKKyAgICAgICAgIyBvbiBTbm93IExlb2FwcmQsIC91c3IvYmluL3B5 dGhvbiBpcyA2NC1iaXQsIHNvIGlmIHRoZQorICAgICAgICAjIG1hY2hpbmUgaXMgNjQtYml0IHRo aXMgd2lsIHJldHVybiAoJzY0Yml0JywgJycpCisgICAgICAgICMgQWx0ZXJuYXRpdmVseSB3ZSBj b3VsZCBjaGVjayAnc3lzY3RsIC1uIGh3LmNwdTY0Yml0X2NhcGFibGUnIG9uIE1hYworICAgICAg ICAjIGlmIHdlIG5lZWRlZCB0byBzdXBwb3J0IDY0LWJpdCBNYWMgbWFjaGluZXMgd2l0aCBhIDMy LWJpdCBweXRob24uCisgICAgICAgIGlmIHBsYXRmb3JtLmFyY2hpdGVjdHVyZSgpWzBdICE9ICc2 NGJpdCc6CisgICAgICAgICAgICByZXR1cm4KKworICAgICAgICAjIFdlIGNvdWxkIHBhdGgtc2Vh cmNoIGVudGlyZWx5IGluIHB5dGhvbiBvciB3aXRoCisgICAgICAgICMgd2hpY2gucHkgKGh0dHA6 Ly9jb2RlLmdvb2dsZS5jb20vcC93aGljaCksIGJ1dCB0aGlzIGlzIGVhc2llcjoKKyAgICAgICAg Z2l0X3BhdGggPSBzZWxmLnJ1bihbJ3doaWNoJywgJ2dpdCddKS5yc3RyaXAoKQorICAgICAgICB3 ZWJraXRfZGV2X3RoZWFkX3VybCA9ICJodHRwczovL2xpc3RzLndlYmtpdC5vcmcvcGlwZXJtYWls L3dlYmtpdC1kZXYvMjAxMC1EZWNlbWJlci8wMTUyNDkuaHRtbCIKKyAgICAgICAgaWYgcGxhdGZv cm0uYXJjaGl0ZWN0dXJlKGdpdF9wYXRoKSAhPSAnNjRiaXQnOgorICAgICAgICAgICAgbG9nKCJX YXJuaW5nOiBUaGlzIG1hY2hpbmUgaXMgNjQtYml0LCBidXQgdGhlIGdpdCBiaW5hcnkgKCVzKSBk b2VzIG5vdCBzdXBwb3J0IDY0LWJpdC5cbkluc3RhbGwgYSA2NC1iaXQgZ2l0IGZvciBiZXR0ZXIg cGVyZm9ybWFuY2UsIHNlZTpcbiVzXG4iICUgKGdpdF9wYXRoLCB3ZWJraXRfZGV2X3RoZWFkX3Vy bCkpCisKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgaW5fd29ya2luZ19kaXJlY3RvcnkoY2xz LCBwYXRoKToKICAgICAgICAgcmV0dXJuIHJ1bl9jb21tYW5kKFsnZ2l0JywgJ3Jldi1wYXJzZScs ICctLWlzLWluc2lkZS13b3JrLXRyZWUnXSwgY3dkPXBhdGgsIGVycm9yX2hhbmRsZXI9RXhlY3V0 aXZlLmlnbm9yZV9lcnJvcikucnN0cmlwKCkgPT0gInRydWUiCg== 75974 2010-12-08 14:55:23 -0800 2010-12-08 15:13:02 -0800 Patch bug-50715-20101208145521.patch text/plain 3816 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZWQ1YWM3MmUxNDg2OTE3MDE0YzdlZDg5Nzg1MmI2ZGIyYTYzYTJjLi5jNTc2Y2Zh ZmU1OTdkM2RlMjFjMjkzZDc3MjBjNTkyNjkzNmZjN2ZhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAK KzIwMTAtMTItMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBzaG91bGQg d2FybiB1c2VycyB3aGVuIHRoZXkncmUgdXNpbmcgYSAzMi1iaXQgZ2l0IG9uIGEgNjQtYml0IHN5 c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA3 MTUKKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHdlYmtpdC1wYXRjaCBwcmludCB0aGUgZm9s bG93aW5nOgorCisgICAgICAgIFdhcm5pbmc6IFRoaXMgbWFjaGluZSBpcyA2NC1iaXQsIGJ1dCB0 aGUgZ2l0IGJpbmFyeSAoL3Vzci9sb2NhbC9naXQvYmluL2dpdCkgZG9lcyBub3Qgc3VwcG9ydCA2 NC1iaXQuCisgICAgICAgIEluc3RhbGwgYSA2NC1iaXQgZ2l0IGZvciBiZXR0ZXIgcGVyZm9ybWFu Y2UsIHNlZToKKyAgICAgICAgaHR0cHM6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJr aXQtZGV2LzIwMTAtRGVjZW1iZXIvMDE1MjQ5Lmh0bWwKKworICAgICAgICBJIHdyb3RlIHRoaXMg bW9zdGx5IGJlY2F1c2UgSSBoYXZlIGFwcHJveGltYXRlbHkgOCBtYWNoaW5lcyB0aGF0IEkgdXNl CisgICAgICAgIGFuZCBtYWtpbmcgc3VyZSBlYWNoIG9uZSBpcyB1c2luZyBhIGdvb2QgR2l0IGlu c3RhbGwgc2VlbWVkIGZvbGx5LgorICAgICAgICB3ZWJraXQtcGF0Y2ggbWFrZXMgYSBsb3Qgb2Yg Z2l0IGNhbGxzLCBzbyB1c2luZyBhIGZhc3QgZ2l0IGNhbiBzaGF2ZQorICAgICAgICBzZXZlcmFs IHNlY29uZHMgaW4gZXZlcnkgaW52b2NhdGlvbi4gIFNlZSB0aGUgd2Via2l0LWRldiB0aHJlYWQg Zm9yIG1vcmUgaW5mby4KKworICAgICAgICBUaGlzIG1lc3NhZ2Ugd2lsbCBwcmludCB0d2ljZSBk dXJpbmcgJ3dlYmtpdC1wYXRjaCB1cGxvYWQnLAorICAgICAgICBvbmNlIGZyb20gd2Via2l0LXBh dGNoIGFuZCBvbmNlIGZyb20gY2hlY2std2Via2l0LXN0eWxlLgorCisgICAgICAgIFVuZm9ydHVu YXRlbHkgdGhlcmUgaXMgbm8gZ29vZCB3YXkgdG8gdGVzdCB0aGlzIGR1ZSB0byBob3cgbWFjaGlu ZS1kZXBlbmRlbnQKKyAgICAgICAgdGhlIGNvZGUgaXMuICBJIGNvbnNpZGVyZWQgd3JpdGluZyBh IHRlc3QgZm9yIHRoZSBsb2cgbWVzc2FnZSwgYnV0IGl0IHNlZW1lZCBub3Qgd29ydGggaXQuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHk6CisKIDIw MTAtMTItMDggIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CmluZGV4IGVlMmJiNDEyYmEwNTVjYWJkMjIyMWM2 ZjE1YmI2M2Y4OWIyN2EwMWYuLjYyZjFlMWM1Yzc3YjhlMjBmZmI1ZDEzNWY0NmU3MzJiM2ZjMTZl YjggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9zY20ucHkKQEAgLTU3NCw4ICs1NzQsNDAgQEAgY2xhc3MgU1ZOKFNDTSk6CiAjIEFsbCBn aXQtc3BlY2lmaWMgbG9naWMgc2hvdWxkIGdvIGhlcmUuCiBjbGFzcyBHaXQoU0NNKToKICAgICBk ZWYgX19pbml0X18oc2VsZiwgY3dkKToKKyAgICAgICAgc2VsZi5fY2hlY2tfZ2l0X2FyY2hpdGVj dHVyZSgpCiAgICAgICAgIFNDTS5fX2luaXRfXyhzZWxmLCBjd2QpCiAKKyAgICBkZWYgX21hY2hp bmVfaXNfNjRiaXQoc2VsZik6CisgICAgICAgIGltcG9ydCBwbGF0Zm9ybQorICAgICAgICAjIFRo aXMgb25seSBpcyB0ZXN0ZWQgb24gTWFjLgorICAgICAgICBpZiBub3QgcGxhdGZvcm0ubWFjX3Zl cigpWzBdOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAgIyBwbGF0Zm9ybS5h cmNoaXRlY3R1cmUoKVswXSBjYW4gYmUgJzY0Yml0JyBldmVuIGlmIHRoZSBtYWNoaW5lIGlzIDMy Yml0OgorICAgICAgICAjIGh0dHA6Ly9tYWlsLnB5dGhvbi5vcmcvcGlwZXJtYWlsL3B5dGhvbm1h Yy1zaWcvMjAwOS1TZXB0ZW1iZXIvMDIxNjQ4Lmh0bWwKKyAgICAgICAgIyBVc2UgdGhlIHN5c2N0 bCBjb21tYW5kIHRvIGZpbmQgb3V0IHdoYXQgdGhlIHByb2Nlc3NvciBhY3R1YWxseSBzdXBwb3J0 cy4KKyAgICAgICAgcmV0dXJuIHNlbGYucnVuKFsnc3lzY3RsJywgJy1uJywgJ2h3LmNwdTY0Yml0 X2NhcGFibGUnXSkucnN0cmlwKCkgPT0gJzEnCisKKyAgICBkZWYgX2V4ZWN1dGFibGVfaXNfNjRi aXQoc2VsZiwgcGF0aCk6CisgICAgICAgICMgQWdhaW4sIHBsYXRmb3JtLmFyY2hpdGVjdHVyZSgp IGZhaWxzIHVzLiAgT24gbXkgbWFjaGluZQorICAgICAgICAjIGdpdF9iaXRzID0gcGxhdGZvcm0u YXJjaGl0ZWN0dXJlKGV4ZWN1dGFibGU9Z2l0X3BhdGgsIGJpdHM9J2RlZmF1bHQnKVswXQorICAg ICAgICAjIGdpdF9iaXRzIGlzIGp1c3QgJ2RlZmF1bHQnLCBtZWFuaW5nIHRoZSBjYWxsIGZhaWxl ZC4KKyAgICAgICAgZmlsZV9vdXRwdXQgPSBzZWxmLnJ1bihbJ2ZpbGUnLCBwYXRoXSkKKyAgICAg ICAgcmV0dXJuIHJlLnNlYXJjaCgneDg2XzY0JywgZmlsZV9vdXRwdXQpCisKKyAgICBkZWYgX2No ZWNrX2dpdF9hcmNoaXRlY3R1cmUoc2VsZik6CisgICAgICAgIGlmIG5vdCBzZWxmLl9tYWNoaW5l X2lzXzY0Yml0KCk6CisgICAgICAgICAgICByZXR1cm4KKworICAgICAgICAjIFdlIGNvdWxkIHBh dGgtc2VhcmNoIGVudGlyZWx5IGluIHB5dGhvbiBvciB3aXRoCisgICAgICAgICMgd2hpY2gucHkg KGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC93aGljaCksIGJ1dCB0aGlzIGlzIGVhc2llcjoKKyAg ICAgICAgZ2l0X3BhdGggPSBzZWxmLnJ1bihbJ3doaWNoJywgJ2dpdCddKS5yc3RyaXAoKQorICAg ICAgICBpZiBzZWxmLl9leGVjdXRhYmxlX2lzXzY0Yml0KGdpdF9wYXRoKToKKyAgICAgICAgICAg IHJldHVybgorCisgICAgICAgIHdlYmtpdF9kZXZfdGhlYWRfdXJsID0gImh0dHBzOi8vbGlzdHMu d2Via2l0Lm9yZy9waXBlcm1haWwvd2Via2l0LWRldi8yMDEwLURlY2VtYmVyLzAxNTI0OS5odG1s IgorICAgICAgICBsb2coIldhcm5pbmc6IFRoaXMgbWFjaGluZSBpcyA2NC1iaXQsIGJ1dCB0aGUg Z2l0IGJpbmFyeSAoJXMpIGRvZXMgbm90IHN1cHBvcnQgNjQtYml0LlxuSW5zdGFsbCBhIDY0LWJp dCBnaXQgZm9yIGJldHRlciBwZXJmb3JtYW5jZSwgc2VlOlxuJXNcbiIgJSAoZ2l0X3BhdGgsIHdl YmtpdF9kZXZfdGhlYWRfdXJsKSkKKwogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBpbl93b3Jr aW5nX2RpcmVjdG9yeShjbHMsIHBhdGgpOgogICAgICAgICByZXR1cm4gcnVuX2NvbW1hbmQoWydn aXQnLCAncmV2LXBhcnNlJywgJy0taXMtaW5zaWRlLXdvcmstdHJlZSddLCBjd2Q9cGF0aCwgZXJy b3JfaGFuZGxlcj1FeGVjdXRpdmUuaWdub3JlX2Vycm9yKS5yc3RyaXAoKSA9PSAidHJ1ZSIK 75977 2010-12-08 15:13:06 -0800 2010-12-14 01:44:01 -0800 move _check_git_architecture to after SCM.__init__ bug-50715-20101208151306.patch text/plain 3632 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZWQ1YWM3MmUxNDg2OTE3MDE0YzdlZDg5Nzg1MmI2ZGIyYTYzYTJjLi5jNTc2Y2Zh ZmU1OTdkM2RlMjFjMjkzZDc3MjBjNTkyNjkzNmZjN2ZhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAK KzIwMTAtMTItMDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHdlYmtpdC1wYXRjaCBzaG91bGQg d2FybiB1c2VycyB3aGVuIHRoZXkncmUgdXNpbmcgYSAzMi1iaXQgZ2l0IG9uIGEgNjQtYml0IHN5 c3RlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA3 MTUKKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHdlYmtpdC1wYXRjaCBwcmludCB0aGUgZm9s bG93aW5nOgorCisgICAgICAgIFdhcm5pbmc6IFRoaXMgbWFjaGluZSBpcyA2NC1iaXQsIGJ1dCB0 aGUgZ2l0IGJpbmFyeSAoL3Vzci9sb2NhbC9naXQvYmluL2dpdCkgZG9lcyBub3Qgc3VwcG9ydCA2 NC1iaXQuCisgICAgICAgIEluc3RhbGwgYSA2NC1iaXQgZ2l0IGZvciBiZXR0ZXIgcGVyZm9ybWFu Y2UsIHNlZToKKyAgICAgICAgaHR0cHM6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJr aXQtZGV2LzIwMTAtRGVjZW1iZXIvMDE1MjQ5Lmh0bWwKKworICAgICAgICBJIHdyb3RlIHRoaXMg bW9zdGx5IGJlY2F1c2UgSSBoYXZlIGFwcHJveGltYXRlbHkgOCBtYWNoaW5lcyB0aGF0IEkgdXNl CisgICAgICAgIGFuZCBtYWtpbmcgc3VyZSBlYWNoIG9uZSBpcyB1c2luZyBhIGdvb2QgR2l0IGlu c3RhbGwgc2VlbWVkIGZvbGx5LgorICAgICAgICB3ZWJraXQtcGF0Y2ggbWFrZXMgYSBsb3Qgb2Yg Z2l0IGNhbGxzLCBzbyB1c2luZyBhIGZhc3QgZ2l0IGNhbiBzaGF2ZQorICAgICAgICBzZXZlcmFs IHNlY29uZHMgaW4gZXZlcnkgaW52b2NhdGlvbi4gIFNlZSB0aGUgd2Via2l0LWRldiB0aHJlYWQg Zm9yIG1vcmUgaW5mby4KKworICAgICAgICBUaGlzIG1lc3NhZ2Ugd2lsbCBwcmludCB0d2ljZSBk dXJpbmcgJ3dlYmtpdC1wYXRjaCB1cGxvYWQnLAorICAgICAgICBvbmNlIGZyb20gd2Via2l0LXBh dGNoIGFuZCBvbmNlIGZyb20gY2hlY2std2Via2l0LXN0eWxlLgorCisgICAgICAgIFVuZm9ydHVu YXRlbHkgdGhlcmUgaXMgbm8gZ29vZCB3YXkgdG8gdGVzdCB0aGlzIGR1ZSB0byBob3cgbWFjaGlu ZS1kZXBlbmRlbnQKKyAgICAgICAgdGhlIGNvZGUgaXMuICBJIGNvbnNpZGVyZWQgd3JpdGluZyBh IHRlc3QgZm9yIHRoZSBsb2cgbWVzc2FnZSwgYnV0IGl0IHNlZW1lZCBub3Qgd29ydGggaXQuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHk6CisKIDIw MTAtMTItMDggIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CmluZGV4IGVlMmJiNDEyYmEwNTVjYWJkMjIyMWM2 ZjE1YmI2M2Y4OWIyN2EwMWYuLmNhNzYyMTQzMzNkMTI2OGY3ODA5NTM4Y2YxNTAyYzVmNDQxY2Vi YzAgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9zY20ucHkKQEAgLTU3NSw2ICs1NzUsMzggQEAgY2xhc3MgU1ZOKFNDTSk6CiBjbGFzcyBH aXQoU0NNKToKICAgICBkZWYgX19pbml0X18oc2VsZiwgY3dkKToKICAgICAgICAgU0NNLl9faW5p dF9fKHNlbGYsIGN3ZCkKKyAgICAgICAgc2VsZi5fY2hlY2tfZ2l0X2FyY2hpdGVjdHVyZSgpCisK KyAgICBkZWYgX21hY2hpbmVfaXNfNjRiaXQoc2VsZik6CisgICAgICAgIGltcG9ydCBwbGF0Zm9y bQorICAgICAgICAjIFRoaXMgb25seSBpcyB0ZXN0ZWQgb24gTWFjLgorICAgICAgICBpZiBub3Qg cGxhdGZvcm0ubWFjX3ZlcigpWzBdOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAg ICAgIyBwbGF0Zm9ybS5hcmNoaXRlY3R1cmUoKVswXSBjYW4gYmUgJzY0Yml0JyBldmVuIGlmIHRo ZSBtYWNoaW5lIGlzIDMyYml0OgorICAgICAgICAjIGh0dHA6Ly9tYWlsLnB5dGhvbi5vcmcvcGlw ZXJtYWlsL3B5dGhvbm1hYy1zaWcvMjAwOS1TZXB0ZW1iZXIvMDIxNjQ4Lmh0bWwKKyAgICAgICAg IyBVc2UgdGhlIHN5c2N0bCBjb21tYW5kIHRvIGZpbmQgb3V0IHdoYXQgdGhlIHByb2Nlc3NvciBh Y3R1YWxseSBzdXBwb3J0cy4KKyAgICAgICAgcmV0dXJuIHNlbGYucnVuKFsnc3lzY3RsJywgJy1u JywgJ2h3LmNwdTY0Yml0X2NhcGFibGUnXSkucnN0cmlwKCkgPT0gJzEnCisKKyAgICBkZWYgX2V4 ZWN1dGFibGVfaXNfNjRiaXQoc2VsZiwgcGF0aCk6CisgICAgICAgICMgQWdhaW4sIHBsYXRmb3Jt LmFyY2hpdGVjdHVyZSgpIGZhaWxzIHVzLiAgT24gbXkgbWFjaGluZQorICAgICAgICAjIGdpdF9i aXRzID0gcGxhdGZvcm0uYXJjaGl0ZWN0dXJlKGV4ZWN1dGFibGU9Z2l0X3BhdGgsIGJpdHM9J2Rl ZmF1bHQnKVswXQorICAgICAgICAjIGdpdF9iaXRzIGlzIGp1c3QgJ2RlZmF1bHQnLCBtZWFuaW5n IHRoZSBjYWxsIGZhaWxlZC4KKyAgICAgICAgZmlsZV9vdXRwdXQgPSBzZWxmLnJ1bihbJ2ZpbGUn LCBwYXRoXSkKKyAgICAgICAgcmV0dXJuIHJlLnNlYXJjaCgneDg2XzY0JywgZmlsZV9vdXRwdXQp CisKKyAgICBkZWYgX2NoZWNrX2dpdF9hcmNoaXRlY3R1cmUoc2VsZik6CisgICAgICAgIGlmIG5v dCBzZWxmLl9tYWNoaW5lX2lzXzY0Yml0KCk6CisgICAgICAgICAgICByZXR1cm4KKworICAgICAg ICAjIFdlIGNvdWxkIHBhdGgtc2VhcmNoIGVudGlyZWx5IGluIHB5dGhvbiBvciB3aXRoCisgICAg ICAgICMgd2hpY2gucHkgKGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC93aGljaCksIGJ1dCB0aGlz IGlzIGVhc2llcjoKKyAgICAgICAgZ2l0X3BhdGggPSBzZWxmLnJ1bihbJ3doaWNoJywgJ2dpdCdd KS5yc3RyaXAoKQorICAgICAgICBpZiBzZWxmLl9leGVjdXRhYmxlX2lzXzY0Yml0KGdpdF9wYXRo KToKKyAgICAgICAgICAgIHJldHVybgorCisgICAgICAgIHdlYmtpdF9kZXZfdGhlYWRfdXJsID0g Imh0dHBzOi8vbGlzdHMud2Via2l0Lm9yZy9waXBlcm1haWwvd2Via2l0LWRldi8yMDEwLURlY2Vt YmVyLzAxNTI0OS5odG1sIgorICAgICAgICBsb2coIldhcm5pbmc6IFRoaXMgbWFjaGluZSBpcyA2 NC1iaXQsIGJ1dCB0aGUgZ2l0IGJpbmFyeSAoJXMpIGRvZXMgbm90IHN1cHBvcnQgNjQtYml0Llxu SW5zdGFsbCBhIDY0LWJpdCBnaXQgZm9yIGJldHRlciBwZXJmb3JtYW5jZSwgc2VlOlxuJXNcbiIg JSAoZ2l0X3BhdGgsIHdlYmtpdF9kZXZfdGhlYWRfdXJsKSkKIAogICAgIEBjbGFzc21ldGhvZAog ICAgIGRlZiBpbl93b3JraW5nX2RpcmVjdG9yeShjbHMsIHBhdGgpOgo=