50713 2010-12-08 13:43:41 -0800 [Qt] Move to BUILDING_WEBKIT flag as used by other ports (and away from BUILD_WEBKIT) 2010-12-09 04:37:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P3 Minor --- 1 s.mathur s.mathur abarth ademar commit-queue eric hausmann webkit.review.bot oldest_to_newest 318997 0 s.mathur 2010-12-08 13:43:41 -0800 All Webkit ports except Qt use BUILDING_WEBKIT to signal that Webkit's shared library/DLL is being compiled. We should preferably stick to this convention and not use our own BUILD_WEBKIT 319215 1 76003 s.mathur 2010-12-08 19:21:42 -0800 Created attachment 76003 Patch 319297 2 76003 laszlo.gombos 2010-12-08 23:54:16 -0800 Comment on attachment 76003 Patch LGTM, r+. Next time please add "[Qt] " as a prefix of the title of the ChangeLog/bug if the change is specific to the Qt port. 319371 3 commit-queue 2010-12-09 03:11:23 -0800 The commit-queue encountered the following flaky tests while processing attachment 76003: http/tests/appcache/update-cache.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. 319373 4 76003 commit-queue 2010-12-09 03:13:09 -0800 Comment on attachment 76003 Patch Clearing flags on attachment: 76003 Committed r73602: <http://trac.webkit.org/changeset/73602> 319374 5 commit-queue 2010-12-09 03:13:14 -0800 All reviewed patches have been landed. Closing bug. 319402 6 webkit.review.bot 2010-12-09 04:37:33 -0800 http://trac.webkit.org/changeset/73602 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html 76003 2010-12-08 19:21:42 -0800 2010-12-09 03:13:09 -0800 Patch 50713.patch text/plain 1962 s.mathur ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjZlMjMwMC4uNjdmOTQ3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMi0wOCAgU2lkZGhhcnRoIE1h dGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBCVUlMRElOR19XRUJLSVQgbGlrZSBvdGhl ciBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTA3MTMKKworICAgICAgICAqIFdlYkNvcmUucHJvOiBDaGFuZ2UgQlVJTERfV0VCS0lUIHRvIEJV SUxESU5HX1dFQktJVAorCiAyMDEwLTEyLTA4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L1dlYkNvcmUucHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCAwZjg4NTM4Li4wZWFmZjVh IDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5w cm8KQEAgLTEyNSw3ICsxMjUsNyBAQCBDT05GSUcocmVsZWFzZSk6IUNPTkZJRyhzdGFuZGFsb25l X3BhY2thZ2UpIHsKICAgICB1bml4OmNvbnRhaW5zKFFUX0NPTkZJRywgcmVkdWNlX3JlbG9jYXRp b25zKTpDT05GSUcgKz0gYnN5bWJvbGljX2Z1bmN0aW9ucwogfQogCi1ERUZJTkVTICs9IEJVSUxE X1dFQktJVAorREVGSU5FUyArPSBCVUlMRElOR19XRUJLSVQKIAogIyBSZW1vdmUgd2hvbGUgcHJv Z3JhbSBvcHRpbWl6YXRpb25zIGR1ZSB0byBtaXNjb21waWxhdGlvbnMKIHdpbjMyLW1zdmMyMDA1 fHdpbjMyLW1zdmMyMDA4fHdpbmNlKjp7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJr aXRnbG9iYWwuaCBiL1dlYktpdC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCmluZGV4IGE2YmU1NzEu LjdlZTU2ZGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCisrKyBi L1dlYktpdC9xdC9BcGkvcXdlYmtpdGdsb2JhbC5oCkBAIC0yOSw3ICsyOSw3IEBACiAjZGVmaW5l IFFUV0VCS0lUX1ZFUlNJT05fQ0hFQ0sobWFqb3IsIG1pbm9yLCBwYXRjaCkgKChtYWpvcjw8MTYp fChtaW5vcjw8OCl8KHBhdGNoKSkKIAogI2lmIGRlZmluZWQoUVRfTUFLRURMTCkgICAgICAgIC8q IGNyZWF0ZSBhIFF0IERMTCBsaWJyYXJ5ICovCi0jICBpZiBkZWZpbmVkKEJVSUxEX1dFQktJVCkK KyMgIGlmIGRlZmluZWQoQlVJTERJTkdfV0VCS0lUKQogIyAgICAgIGRlZmluZSBRV0VCS0lUX0VY UE9SVCBRX0RFQ0xfRVhQT1JUCiAjICBlbHNlCiAjICAgICAgZGVmaW5lIFFXRUJLSVRfRVhQT1JU IFFfREVDTF9JTVBPUlQKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQv cXQvQ2hhbmdlTG9nCmluZGV4IDQ1ZDQxNmQuLjM5MGYzMjEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9x dC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDEwLTEyLTA4ICBTaWRkaGFydGggTWF0aHVyICA8c2lkZGhhcnRoLm1hdGh1ckBub2tpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIEJV SUxESU5HX1dFQktJVCBsaWtlIG90aGVyIHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDcxMworCisgICAgICAgICogQXBpL3F3ZWJraXRnbG9i YWwuaDogY2hhbmdlIEJVSUxEX1dFQktJVCB0byBCVUlMRElOR19XRUJLSVQKKwogMjAxMC0xMi0w NyAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgSm9obiBTdWxsaXZhbi4K