5071 2005-09-20 15:15:56 -0700 TOT WebKit doesn't compile with GCC 4.0.1 (5226) 2005-09-24 04:02:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 webkit-bugs justin.garcia eric oldest_to_newest 20100 0 webkit-bugs 2005-09-20 15:15:56 -0700 /Volumes/Apostasy/rosyna/WebCore/kwq/KWQPainter.mm: In member function 'void QPainter::drawFloatPixmap(float, float, float, float, const QPixmap&, float, float, float, float, int, CGContext*)': /Volumes/Apostasy/rosyna/WebCore/kwq/KWQPainter.mm:518: warning: argument 'w' might be clobbered by 'longjmp' or 'vfork' /Volumes/Apostasy/rosyna/WebCore/kwq/KWQPainter.mm:518: warning: argument 'h' might be clobbered by 'longjmp' or 'vfork' /Volumes/Apostasy/rosyna/WebCore/kwq/KWQPainter.mm:518: warning: argument 'sw' might be clobbered by 'longjmp' or 'vfork' /Volumes/Apostasy/rosyna/WebCore/kwq/KWQPainter.mm:518: warning: argument 'sh' might be clobbered by 'longjmp' or 'vfork' Kind of odd considering they are all arguments to the function 20101 1 webkit-bugs 2005-09-20 15:18:14 -0700 GCC 4.0.1 build 5226 is used. 20102 2 darin 2005-09-20 15:22:16 -0700 Most people have an older version of gcc, so this doesn't affect everyone. 20103 3 justin.garcia 2005-09-20 15:26:11 -0700 xenon and I made a workaround for this, I'll post it 20167 4 3989 justin.garcia 2005-09-21 11:42:49 -0700 Created attachment 3989 Patch This is compiler bug <rdar://problem/4266497>. Only happens with -Os on 5226+. I made temporary variables for sw, sh, w, and h. I had to move KWQ_BLOCK_EXCEPTIONS as well, I'm not sure if that's OK. 20172 5 3989 eric 2005-09-21 13:25:33 -0700 Comment on attachment 3989 Patch Looks fine. I still need to get around to investigating the @try/@catch change more, as hopefully that would allow us to avoid these silly warnings. r=me. 20346 6 darin 2005-09-23 18:08:18 -0700 Eric, note that Justin and Tim *did* investigate the @try/@catch approach. When they tried, it caused even more of these types of problems. 3989 2005-09-21 11:42:49 -0700 2005-09-21 13:25:33 -0700 Patch painterpatch.txt text/plain 1336 justin.garcia SW5kZXg6IGt3cS9LV1FQYWludGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJDb3JlL2t3cS9LV1FQYWludGVyLm1tLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEzOQpkaWZm IC11IC1yMS4xMzkgS1dRUGFpbnRlci5tbQotLS0ga3dxL0tXUVBhaW50ZXIubW0JMTYgU2VwIDIw MDUgMjM6MDk6NTkgLTAwMDAJMS4xMzkKKysrIGt3cS9LV1FQYWludGVyLm1tCTIxIFNlcCAyMDA1 IDAxOjU1OjQxIC0wMDAwCkBAIC01MTksMjEgKzUxOSwyNyBAQAogewogICAgIGlmIChkYXRhLT5z dGF0ZS5wYWludGluZ0Rpc2FibGVkKQogICAgICAgICByZXR1cm47CisJCQorCUtXUV9CTE9DS19F WENFUFRJT05TOworCQorCWZsb2F0IHRzdyA9IHN3OworCWZsb2F0IHRzaCA9IHNoOworCWZsb2F0 IHR3ID0gdzsKKwlmbG9hdCB0aCA9IGg7CiAgICAgICAgIAotICAgIGlmIChzdyA9PSAtMSkKLSAg ICAgICAgc3cgPSBwaXhtYXAud2lkdGgoKTsKLSAgICBpZiAoc2ggPT0gLTEpCi0gICAgICAgIHNo ID0gcGl4bWFwLmhlaWdodCgpOwotCi0gICAgaWYgKHcgPT0gLTEpCi0gICAgICAgIHcgPSBwaXht YXAud2lkdGgoKTsKLSAgICBpZiAoaCA9PSAtMSkKLSAgICAgICAgaCA9IHBpeG1hcC5oZWlnaHQo KTsKKyAgICBpZiAodHN3ID09IC0xKQorICAgICAgICB0c3cgPSBwaXhtYXAud2lkdGgoKTsKKyAg ICBpZiAodHNoID09IC0xKQorICAgICAgICB0c2ggPSBwaXhtYXAuaGVpZ2h0KCk7CisKKyAgICBp ZiAodHcgPT0gLTEpCisgICAgICAgIHR3ID0gcGl4bWFwLndpZHRoKCk7CisgICAgaWYgKHRoID09 IC0xKQorICAgICAgICB0aCA9IHBpeG1hcC5oZWlnaHQoKTsKIAotICAgIE5TUmVjdCBpblJlY3Qg PSBOU01ha2VSZWN0KHgsIHksIHcsIGgpOwotICAgIE5TUmVjdCBmcm9tUmVjdCA9IE5TTWFrZVJl Y3Qoc3gsIHN5LCBzdywgc2gpOworICAgIE5TUmVjdCBpblJlY3QgPSBOU01ha2VSZWN0KHgsIHks IHR3LCB0aCk7CisgICAgTlNSZWN0IGZyb21SZWN0ID0gTlNNYWtlUmVjdChzeCwgc3ksIHRzdywg dHNoKTsKICAgICAKLSAgICBLV1FfQkxPQ0tfRVhDRVBUSU9OUzsKICAgICBbcGl4bWFwLmltYWdl UmVuZGVyZXIgZHJhd0ltYWdlSW5SZWN0OmluUmVjdAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBmcm9tUmVjdDpmcm9tUmVjdCBjb21wb3NpdGVPcGVyYXRvcjooTlNDb21w b3NpdGluZ09wZXJhdGlvbiljb21wb3NpdGVPcGVyYXRvciBjb250ZXh0OmNvbnRleHRdOwogICAg IEtXUV9VTkJMT0NLX0VYQ0VQVElPTlM7Cg==