50706 2010-12-08 12:02:15 -0800 [GTK] media/video-controls-transformed.html fails 2011-05-03 02:31:47 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned atwilson eric.carlson eric oldest_to_newest 318928 0 pnormand 2010-12-08 12:02:15 -0800 A CSS rotation is applied to a video element and the event sender clicks at a fixed position supposed to be the play button. But this depends on the controls. So we should instead calculate the position depending on the video dimensions and rotation angle. 318931 1 75942 pnormand 2010-12-08 12:05:35 -0800 Created attachment 75942 proposed patch 318932 2 75942 pnormand 2010-12-08 12:06:34 -0800 Comment on attachment 75942 proposed patch Would something like this make sense Eric? If so can you please check the test still passes on mac? 326709 3 75942 eric.carlson 2010-12-24 12:06:15 -0800 Comment on attachment 75942 proposed patch This doesn't work on the Mac. The mouse is clicked at {2,182}, but the center of the play/pause button is at about {194,24}. I think the only way to make this work for all ports will be for DRT to get the location of the control elements from the shadow tree at runtime. 397013 4 pnormand 2011-05-03 02:13:03 -0700 r85015 fixed this test like Eric suggested. I'll unskip it on GTK since it passes fine now! *** This bug has been marked as a duplicate of bug 58590 *** 397017 5 pnormand 2011-05-03 02:31:47 -0700 Committed r85594: <http://trac.webkit.org/changeset/85594> 75942 2010-12-08 12:05:35 -0800 2010-12-24 12:06:15 -0800 proposed patch proposed-patch.patch text/plain 2895 pnormand RnJvbSA3MDJkODAzMDU3ZWNiNDBiNjg1MDUwOTAzZGNiZTdhNzNmOGNjYTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDggRGVjIDIwMTAgMjE6MDQ6NTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1jb250cm9scy10cmFuc2Zvcm1lZC5odG1sIHwgICAxMCArKysrKysrLS0tCiBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgIHwgICAgMSAtCiAzIGZpbGVz IGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY0NDg2 ZjEuLjMwOGMyYzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0xMi0wOCAgUGhpbGlwcGUg Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gbWVkaWEvdmlkZW8tY29udHJvbHMtdHJhbnNm b3JtZWQuaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTA3MDYKKworICAgICAgICBSZWZhY3RvcmVkIHRoZSB0ZXN0IHNvIHRoZSBldmVu dC1zZW5kZXIgZG9lc24ndCBjbGljayBvbiBhIGZ1bGwKKyAgICAgICAgZml4ZWQgcG9zaXRpb24g dG8gaGl0IHRoZSB0cmFuc2Zvcm1lZCBwbGF5IGJ1dHRvbi4KKworICAgICAgICAqIG1lZGlhL3Zp ZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Nr aXBwZWQ6CisKKzIwMTAtMTItMDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KIAogICAg ICAgICBbR1RLXSBtZWRpYS9mdWxsc2NyZWVuKiBmYWlsaW5nIG9uIDY0LWJpdHMgRGVidWcKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0 bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9scy10cmFuc2Zvcm1lZC5odG1sCmlu ZGV4IGUzZmYxMjAuLmZlMTUxMjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVv LWNvbnRyb2xzLXRyYW5zZm9ybWVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t Y29udHJvbHMtdHJhbnNmb3JtZWQuaHRtbApAQCAtMywxMyArMywxMyBAQAogICA8dGl0bGU+VGVz dCBjb250cm9scyBvbiB0cmFuc2Zvcm1lZCB2aWRlbzwvdGl0bGU+CiAgIDxzdHlsZSB0eXBlPSJ0 ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CiAgICAgdmlkZW8gewotICAgICAgbWFyZ2luOiA1MHB4 OworICAgICAgbWFyZ2luOiA3cHg7CiAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlKDIw ZGVnKTsKICAgICB9CiAgIDwvc3R5bGU+CiA8L2hlYWQ+CiA8Ym9keT4KLSAgICA8dmlkZW8gY29u dHJvbHM+PC92aWRlbz4KKyAgICA8dmlkZW8gaWQ9InZpZGVvIiBjb250cm9scz48L3ZpZGVvPgog ICAgIDxwPlRlc3QgY29udHJvbHMgb24gdHJhbnNmb3JtZWQgdmlkZW8uPC9wPgogICAgIDxwPlRo aXMgdGVzdCBvbmx5IHJ1bnMgaW4gRFJUITwvcD4KICAgICA8c2NyaXB0IHNyYz1tZWRpYS1maWxl LmpzPjwvc2NyaXB0PgpAQCAtMTksNyArMTksMTEgQEAKICAgICAgICAgd2FpdEZvckV2ZW50KCdj YW5wbGF5dGhyb3VnaCcsIGZ1bmN0aW9uICgpIHsKICAgICAgICAgICAgIGlmICh3aW5kb3cuZXZl bnRTZW5kZXIpIAogICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1v dXNlTW92ZVRvKDU0LDI0MCk7IC8vIG92ZXIgcGxheSBidXR0b24KKyAgICAgICAgICAgICAgICB2 aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ2aWRlbyIpOworICAgICAgICAgICAgICAg IC8vIG92ZXIgcGxheSBidXR0b24KKyAgICAgICAgICAgICAgICB2YXIgeSA9IHZpZGVvLm9mZnNl dEhlaWdodCAqIE1hdGguY29zKDM0MCk7CisgICAgICAgICAgICAgICAgdmFyIHggPSAyOworICAg ICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkpOwogICAgICAgICAgICAg ICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwogICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlVXAoKTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXgg YTEyYjVmMy4uN2YwMDE4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTI4MzAsNyAr MjgzMCw2IEBAIGh0dHAvdGVzdHMvd2ViYXJjaGl2ZS90ZXN0LXByZWxvYWQtcmVzb3VyY2VzLmh0 bWwKIAogIyBUZXN0cyBpbiBtZWRpYS8gZGlyZWN0b3J5CiAjICAgVGVzdHMgZmFpbGluZwotbWVk aWEvdmlkZW8tY29udHJvbHMtdHJhbnNmb3JtZWQuaHRtbAogbWVkaWEvdmlkZW8tY29udHJvbHMt em9vbWVkLmh0bWwKIG1lZGlhL3ZpZGVvLXNpemUtaW50cmluc2ljLXNjYWxlLmh0bWwKIG1lZGlh L3ZpZGVvLXNlZWstcGFzdC1lbmQtcGxheWluZy5odG1sCi0tIAoxLjcuMy4z