50705 2010-12-08 12:01:52 -0800 [GTK] DRT needs layoutTestController.setCacheModel 2010-12-10 11:41:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 42684 0 joone webkit-unassigned commit-queue mrobinson webkit.review.bot oldest_to_newest 318927 0 joone 2010-12-08 12:01:52 -0800 Releated change set: http://trac.webkit.org/changeset/44591 318937 1 75944 joone 2010-12-08 12:19:19 -0800 Created attachment 75944 Proposed Patch 319317 2 webkit.review.bot 2010-12-09 01:04:22 -0800 Attachment 75944 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:569: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 319329 3 75944 mrobinson 2010-12-09 01:42:10 -0800 Comment on attachment 75944 Proposed Patch Okay. It seems that the one test that uses this is already passing. It's good to have an implementation though. 319433 4 commit-queue 2010-12-09 06:22:51 -0800 The commit-queue encountered the following flaky tests while processing attachment 75944: animations/suspend-resume-animation.html fast/preloader/script.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and cmarrin@apple.com. The commit-queue is continuing to process your patch. 319437 5 75944 commit-queue 2010-12-09 06:34:28 -0800 Comment on attachment 75944 Proposed Patch Rejecting patch 75944 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: ociatedElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameLoader.o /Projects/CommitQueue/WebCore/loader/FrameLoader.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameView.o /Projects/CommitQueue/WebCore/page/FrameView.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (22 failures) Full output: http://queues.webkit.org/results/6975006 319478 6 commit-queue 2010-12-09 08:36:01 -0800 The commit-queue encountered the following flaky tests while processing attachment 75944: fast/loader/recursive-before-unload-crash.html fast/images/load-img-with-empty-src.html Please file bugs against the tests. These tests were authored by beidson@apple.com, eric@webkit.org, and mitz@webkit.org. The commit-queue is continuing to process your patch. 320211 7 76213 joone 2010-12-10 10:00:56 -0800 Created attachment 76213 Proposed Patch2 I don't understand why Mac buildbot failed to build WebKit due to this patch. Anyway, I submitted the patch again. 320214 8 webkit.review.bot 2010-12-10 10:03:53 -0800 Attachment 76213 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:568: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 320222 9 76215 joone 2010-12-10 10:19:13 -0800 Created attachment 76215 Proposed Patch3 Fixed the style error. 320273 10 76215 commit-queue 2010-12-10 11:41:13 -0800 Comment on attachment 76215 Proposed Patch3 Clearing flags on attachment: 76215 Committed r73751: <http://trac.webkit.org/changeset/73751> 320274 11 commit-queue 2010-12-10 11:41:19 -0800 All reviewed patches have been landed. Closing bug. 75944 2010-12-08 12:19:19 -0800 2010-12-10 10:00:56 -0800 Proposed Patch cache_model_drt.patch text/plain 1483 joone ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5Y2FiYzA4Li45Zjg2ZjRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTIt MDggIEpvb25lIEh1ciAgPGpvb25lQGtsZHAub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIERSVCBuZWVkcyBsYXlvdXRUZXN0Q29udHJv bGxlci5zZXRDYWNoZU1vZGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MDcwNQorICAgICAgICAKKyAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2Rl KCkgaXMgY2FsbGVkIHRvIHNldCB0aGUgY2FjaGUgbW9kZWwuCisgICAgICAgIAorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAg IChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FjaGVNb2RlbCk6IFNldCB0aGUgY2FjaGUgbW9k ZWwuIAorCiAyMDEwLTEyLTA3ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAgYi9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwCmluZGV4IDgz ODc0ZjQuLjY3Y2U0ZjggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcApAQCAtNTY0LDkgKzU2NCwxMiBA QCBib29sIExheW91dFRlc3RDb250cm9sbGVyOjppc0NvbW1hbmRFbmFibGVkKEpTU3RyaW5nUmVm IG5hbWUpCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0Q2FjaGVNb2RlbChpbnQpCit2b2lkIExheW91dFRlc3RDb250cm9sbGVyOjpzZXRDYWNo ZU1vZGVsKGludCBjYWNoZU1vZGVsKQogewotICAgIC8vIEZJWE1FOiBpbXBsZW1lbnQKKyAgICBp ZiAoY2FjaGVNb2RlbCA9PSAwKSAvLyBXZWJDYWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXIKKyAgICAg ICAgd2Via2l0X3NldF9jYWNoZV9tb2RlbChXRUJLSVRfQ0FDSEVfTU9ERUxfRE9DVU1FTlRfVklF V0VSKTsgCisgICAgZWxzZSAKKyAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2RlbChXRUJLSVRf Q0FDSEVfTU9ERUxfV0VCX0JST1dTRVIpOyAKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6c2V0UGVyc2lzdGVudFVzZXJTdHlsZVNoZWV0TG9jYXRpb24oSlNTdHJpbmdSZWYganNVUkwp Cg== 76213 2010-12-10 10:00:56 -0800 2010-12-10 10:19:13 -0800 Proposed Patch2 cache_model_drt2.patch text/plain 1514 joone ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlNGZhMTQzLi4zOGZhOGY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTIt MTAgIEpvb25lIEh1ciAgPGpvb25lQGtsZHAub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIERSVCBuZWVkcyBsYXlvdXRUZXN0Q29udHJv bGxlci5zZXRDYWNoZU1vZGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MDcwNQorICAgICAgICAKKyAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2Rl KCkgaXMgY2FsbGVkIHRvIHNldCB0aGUgY2FjaGUgbW9kZWwuCisgICAgICAgIAorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAg IChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FjaGVNb2RlbCk6IFNldCB0aGUgY2FjaGUgbW9k ZWwuIAorCiAyMDEwLTEyLTEwICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVz dENvbnRyb2xsZXJHdGsuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91 dFRlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCAzZWNjODQ0Li43MDM2NjVhIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJv bGxlckd0ay5jcHAKQEAgLTU2Myw5ICs1NjMsMTIgQEAgYm9vbCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6aXNDb21tYW5kRW5hYmxlZChKU1N0cmluZ1JlZiBuYW1lKQogICAgIHJldHVybiByZXN1bHQ7 CiB9CiAKLXZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwoaW50KQordm9p ZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FjaGVNb2RlbChpbnQgY2FjaGVNb2RlbCkKIHsK LSAgICAvLyBGSVhNRTogaW1wbGVtZW50CisgICAgaWYgKGNhY2hlTW9kZWwgPT0gMCkgLy8gV2Vi Q2FjaGVNb2RlbERvY3VtZW50Vmlld2VyCisgICAgICAgIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwo V0VCS0lUX0NBQ0hFX01PREVMX0RPQ1VNRU5UX1ZJRVdFUik7IAorICAgIGVsc2UgCisgICAgICAg IHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwoV0VCS0lUX0NBQ0hFX01PREVMX1dFQl9CUk9XU0VSKTsg CiB9CiAKIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFBlcnNpc3RlbnRVc2VyU3R5bGVT aGVldExvY2F0aW9uKEpTU3RyaW5nUmVmIGpzVVJMKQo= 76215 2010-12-10 10:19:13 -0800 2010-12-10 11:41:13 -0800 Proposed Patch3 cache_model_drt3.patch text/plain 1510 joone ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlNGZhMTQzLi4zOGZhOGY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTIt MTAgIEpvb25lIEh1ciAgPGpvb25lQGtsZHAub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIERSVCBuZWVkcyBsYXlvdXRUZXN0Q29udHJv bGxlci5zZXRDYWNoZU1vZGVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD01MDcwNQorICAgICAgICAKKyAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2Rl KCkgaXMgY2FsbGVkIHRvIHNldCB0aGUgY2FjaGUgbW9kZWwuCisgICAgICAgIAorICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAg IChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FjaGVNb2RlbCk6IFNldCB0aGUgY2FjaGUgbW9k ZWwuIAorCiAyMDEwLTEyLTEwICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVz dENvbnRyb2xsZXJHdGsuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0xheW91 dFRlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCAzZWNjODQ0Li41ZjI5NTFjIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJv bGxlckd0ay5jcHAKQEAgLTU2Myw5ICs1NjMsMTIgQEAgYm9vbCBMYXlvdXRUZXN0Q29udHJvbGxl cjo6aXNDb21tYW5kRW5hYmxlZChKU1N0cmluZ1JlZiBuYW1lKQogICAgIHJldHVybiByZXN1bHQ7 CiB9CiAKLXZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldENhY2hlTW9kZWwoaW50KQordm9p ZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FjaGVNb2RlbChpbnQgY2FjaGVNb2RlbCkKIHsK LSAgICAvLyBGSVhNRTogaW1wbGVtZW50CisgICAgaWYgKCFjYWNoZU1vZGVsKSAvLyBXZWJDYWNo ZU1vZGVsRG9jdW1lbnRWaWV3ZXIKKyAgICAgICAgd2Via2l0X3NldF9jYWNoZV9tb2RlbChXRUJL SVRfQ0FDSEVfTU9ERUxfRE9DVU1FTlRfVklFV0VSKTsgCisgICAgZWxzZSAKKyAgICAgICAgd2Vi a2l0X3NldF9jYWNoZV9tb2RlbChXRUJLSVRfQ0FDSEVfTU9ERUxfV0VCX0JST1dTRVIpOyAKIH0K IAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0UGVyc2lzdGVudFVzZXJTdHlsZVNoZWV0 TG9jYXRpb24oSlNTdHJpbmdSZWYganNVUkwpCg==