50700 2010-12-08 10:57:55 -0800 Fix some clang++ warnings (one of which was an actual bug) 2010-12-08 13:31:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 318889 0 andersca 2010-12-08 10:57:55 -0800 Fix some clang++ warnings (some of which were actual bugs) 318953 1 75949 andersca 2010-12-08 12:55:42 -0800 Created attachment 75949 Patch 318958 2 75949 darin 2010-12-08 13:02:44 -0800 Comment on attachment 75949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75949&action=review > WebCore/page/mac/DragControllerMac.mm:57 > + if (!m_documentUnderMouse || (![[m_page->mainFrame()->view()->getOuterView() window] attachedSheet] > + && [dragData->platformData() draggingSource] != m_page->mainFrame()->view()->getOuterView())) This one was not a bug. You should not call it a bug in the change log. > WebCore/page/mac/EventHandlerMac.mm:762 > + if (applicationIsSafari() && (document->url().protocolIs("feed") || document->url().protocolIs("feeds"))) This one was! 318981 3 andersca 2010-12-08 13:31:05 -0800 Committed r73543: <http://trac.webkit.org/changeset/73543> 75949 2010-12-08 12:55:42 -0800 2010-12-08 13:02:44 -0800 Patch bug-50700-20101208125541.patch text/plain 3421 andersca ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjFjNzcwMTk3NWZiNWZiMGE2YTQ5YjA3MDBmMWJjZWQyMjBiOTQxYy4uMWMwMzg5MjAzZDdjNWI5 ZmMzN2ZjOGVkMTU2ZWI5NzQxOTJhODcwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMi0wOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBzb21lIGNsYW5nKysgd2FybmluZ3MgKHNv bWUgb2Ygd2hpY2ggd2VyZSBhY3R1YWwgYnVncykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNzAwCisKKyAgICAgICAgKiBwYWdlL21hYy9EcmFnQ29u dHJvbGxlck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjpkcmFnT3Bl cmF0aW9uKToKKyAgICAgICAgKiBwYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW06CisgICAgICAg IChXZWJDb3JlOjpFdmVudEhhbmRsZXI6Om5lZWRzS2V5Ym9hcmRFdmVudERpc2FtYmlndWF0aW9u UXVpcmtzKToKKyAgICAgICAgRml4IHx8IHZzICYmIHByZWNlZGVuY2UgYnVncyB1bmNvdmVyZWQg YnkgY2xhbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3ND b250ZXh0M0RPcGVuR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6 OnJlc2hhcGUpOgorICAgICAgICBVc2UgYW4gZWFybHkgcmV0dXJuIHRvIGF2b2lkIGEgd2Fybmlu Zy4KKwogMjAxMC0xMi0wNyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCB0aGUgbGFzdCBjbGFuZysrIGJ1aWxkIGVycm9yLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wYWdlL21hYy9EcmFnQ29udHJvbGxlck1hYy5tbSBiL1dlYkNvcmUvcGFnZS9tYWMv RHJhZ0NvbnRyb2xsZXJNYWMubW0KaW5kZXggYTA5YzQxODE2MjFmZDU1ZjRkYTQ3ZDU2ZGFmYmRh NWY4ODE1ZDkxYS4uMDVjOGUwOWZiOTg4MTkxODQ4NjhmMTU3Y2FlYWUxYjhiM2ZkMzM0NCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wYWdlL21hYy9EcmFnQ29udHJvbGxlck1hYy5tbQorKysgYi9XZWJD b3JlL3BhZ2UvbWFjL0RyYWdDb250cm9sbGVyTWFjLm1tCkBAIC01Myw4ICs1Myw4IEBAIERyYWdP cGVyYXRpb24gRHJhZ0NvbnRyb2xsZXI6OmRyYWdPcGVyYXRpb24oRHJhZ0RhdGEqIGRyYWdEYXRh KQogICAgIGlmIChbTlNBcHAgbW9kYWxXaW5kb3ddIHx8ICFkcmFnRGF0YS0+Y29udGFpbnNVUkwo KSkKICAgICAgICAgcmV0dXJuIERyYWdPcGVyYXRpb25Ob25lOwogCi0gICAgaWYgKCFtX2RvY3Vt ZW50VW5kZXJNb3VzZSB8fCAhW1ttX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCktPmdldE91dGVy VmlldygpIHdpbmRvd10gYXR0YWNoZWRTaGVldF0gCi0gICAgICAgICYmIFtkcmFnRGF0YS0+cGxh dGZvcm1EYXRhKCkgZHJhZ2dpbmdTb3VyY2VdICE9IG1fcGFnZS0+bWFpbkZyYW1lKCktPnZpZXco KS0+Z2V0T3V0ZXJWaWV3KCkpCisgICAgaWYgKCFtX2RvY3VtZW50VW5kZXJNb3VzZSB8fCAoIVtb bV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpLT5nZXRPdXRlclZpZXcoKSB3aW5kb3ddIGF0dGFj aGVkU2hlZXRdIAorICAgICAgICAmJiBbZHJhZ0RhdGEtPnBsYXRmb3JtRGF0YSgpIGRyYWdnaW5n U291cmNlXSAhPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT52aWV3KCktPmdldE91dGVyVmlldygpKSkK ICAgICAgICAgcmV0dXJuIERyYWdPcGVyYXRpb25Db3B5OwogCiAgICAgcmV0dXJuIERyYWdPcGVy YXRpb25Ob25lOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMu bW0gYi9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQppbmRleCAyZGI3MTNmNzY4 ZWNhOTJiNDk1MmE2ZjFiZmVjOGFkMTg3MGIwZWZhLi4yZDRkODZiNjkwYTgxYjlkMDc2MjdjZTRm OTc1YzIyYjczNDgzZGQ1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxl ck1hYy5tbQorKysgYi9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQpAQCAtNzU5 LDcgKzc1OSw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpuZWVkc0tleWJvYXJkRXZlbnREaXNhbWJp Z3VhdGlvblF1aXJrcygpIGNvbnN0CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gbV9mcmFtZS0+ ZG9jdW1lbnQoKTsKIAogICAgIC8vIFJTUyB2aWV3IG5lZWRzIGFycm93IGtleSBrZXlwcmVzcyBl dmVudHMuCi0gICAgaWYgKGFwcGxpY2F0aW9uSXNTYWZhcmkoKSAmJiBkb2N1bWVudC0+dXJsKCku cHJvdG9jb2xJcygiZmVlZCIpIHx8IGRvY3VtZW50LT51cmwoKS5wcm90b2NvbElzKCJmZWVkcyIp KQorICAgIGlmIChhcHBsaWNhdGlvbklzU2FmYXJpKCkgJiYgKGRvY3VtZW50LT51cmwoKS5wcm90 b2NvbElzKCJmZWVkIikgfHwgZG9jdW1lbnQtPnVybCgpLnByb3RvY29sSXMoImZlZWRzIikpKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSBtX2ZyYW1lLT5z ZXR0aW5ncygpOwogICAgIGlmICghc2V0dGluZ3MpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKaW5k ZXggZDI5NWFiYjA5YmNjM2IxYTRjNDViOTAxOGYwMzY2ZjBiNDQ3ODk1NC4uYWYxYzhjZGY4MTYx Yjc5NDgwM2IzNTE4MmFmNTM2OTY1YWI2MmQzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcApA QCAtMTI1LDcgKzEyNSwxMCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpwYWludFJlbmRlcmlu Z1Jlc3VsdHNUb0NhbnZhcyhDYW52YXNSZW5kZXJpbmdDb250ZXh0KiBjbwogCiB2b2lkIEdyYXBo aWNzQ29udGV4dDNEOjpyZXNoYXBlKGludCB3aWR0aCwgaW50IGhlaWdodCkKIHsKLSAgICBpZiAo d2lkdGggPT0gbV9jdXJyZW50V2lkdGggJiYgaGVpZ2h0ID09IG1fY3VycmVudEhlaWdodCB8fCAh bV9jb250ZXh0T2JqKQorICAgIGlmICghbV9jb250ZXh0T2JqKQorICAgICAgICByZXR1cm47CisK KyAgICBpZiAod2lkdGggPT0gbV9jdXJyZW50V2lkdGggJiYgaGVpZ2h0ID09IG1fY3VycmVudEhl aWdodCkKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIG1fY3VycmVudFdpZHRoID0gd2lkdGg7 Cg==