50691 2010-12-08 07:57:27 -0800 Rolling out r73494, it makes mac and gtk debug bots crash 2010-12-08 15:35:27 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 50380 1 alex webkit-unassigned aroben dmikurube tkent oldest_to_newest 318786 0 alex 2010-12-08 07:57:27 -0800 Backtrace in the gtk bots can be found here: http://webkit-bots.igalia.com/amd64/svn_73518.core-when_1291823604-_-who_DumpRenderTree-_-why_11.trace.html This is an excerpt: #0 0x00002b3b7812fe75 in WebCore::HTMLFormControlElement::isValidFormControlElement (this=0x3e0b690) at ../../WebCore/html/HTMLFormControlElement.cpp:343 #1 0x00002b3b77f16c8f in WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector (this=0x3ca9ac0, sel=0x3dd5090, e=0x3e0b690, selectorAttrs=0x3ca9b70, dynamicPseudo=@0x3ca9ab8, isSubSelector=false, elementStyle=0x3e08490, elementParentStyle=0x3de3550) at ../../WebCore/css/CSSStyleSelector.cpp:2564 #2 0x00002b3b77f13e8f in WebCore::CSSStyleSelector::SelectorChecker::checkSelector (this=0x3ca9ac0, sel=0x3dd5090, e=0x3e0b690, selectorAttrs=0x3ca9b70, dynamicPseudo=@0x3ca9ab8, isSubSelector=false, encounteredLink=false, elementStyle=0x3e08490, elementParentStyle=0x3de3550) at ../../WebCore/css/CSSStyleSelector.cpp:1901 #3 0x00002b3b77f13d88 in WebCore::CSSStyleSelector::checkSelector (this=0x3ca9620, sel=0x3dd5090) at ../../WebCore/css/CSSStyleSelector.cpp:1876 #4 0x00002b3b77f0f08b in WebCore::CSSStyleSelector::matchRulesForList (this=0x3ca9620, rules=0x3d4d980, firstRuleIndex=@0x7fffdf5702ac, lastRuleIndex=@0x7fffdf5702a8, includeEmptyRules=false) at ../../WebCore/css/CSSStyleSelector.cpp:636 #5 0x00002b3b77f0ee07 in WebCore::CSSStyleSelector::matchRules (this=0x3ca9620, rules=0x3d6f5f0, firstRuleIndex=@0x7fffdf5702ac, lastRuleIndex=@0x7fffdf5702a8, includeEmptyRules=false) at ../../WebCore/css/CSSStyleSelector.cpp:605 #6 0x00002b3b77f114fa in WebCore::CSSStyleSelector::styleForElement (this=0x3ca9620, e=0x3e0b690, defaultParent=0x0, allowSharing=true, resolveForRootDefault=false, matchVisitedPseudoClass=false) at ../../WebCore/css/CSSStyleSelector.cpp:1254 #7 0x00002b3b77ffa915 in WebCore::Node::styleForRenderer (this=0x3e0b690) at ../../WebCore/dom/Node.cpp:1366 #8 0x00002b3b77ffa70e in WebCore::Node::createRendererIfNeeded (this=0x3e0b690) at ../../WebCore/dom/Node.cpp:1343 #9 0x00002b3b77fde467 in WebCore::Element::attach (this=0x3e0b690) at ../../WebCore/dom/Element.cpp:909 #10 0x00002b3b7812f0db in WebCore::HTMLFormControlElement::attach (this=0x3e0b690) at ../../WebCore/html/HTMLFormControlElement.cpp:126 #11 0x00002b3b78031976 in WebCore::SelectElement::parseMultipleAttribute (data=..., element=0x3e0b690, attribute=0x3e08300) at ../../WebCore/dom/SelectElement.cpp:458 #12 0x00002b3b78169946 in WebCore::HTMLSelectElement::parseMappedAttribute (this=0x3e0b690, attr=0x3e08300) at ../../WebCore/html/HTMLSelectElement.cpp:268 #13 0x00002b3b780370d7 in WebCore::StyledElement::attributeChanged (this=0x3e0b690, attr=0x3e08300, preserveDecls=false) at ../../WebCore/dom/StyledElement.cpp:186 #14 0x00002b3b781301c3 in WebCore::HTMLFormControlElement::attributeChanged (this=0x3e0b690, attr=0x3e08300, preserveDecls=false) at ../../WebCore/html/HTMLFormControlElement.cpp:403 #15 0x00002b3b77ff4f79 in WebCore::NamedNodeMap::addAttribute (this=0x3e01690, prpAttribute=...) at ../../WebCore/dom/NamedNodeMap.cpp:261 #16 0x00002b3b77fdd36a in WebCore::Element::setAttribute (this=0x3e0b690, name=..., value=...) at ../../WebCore/dom/Element.cpp:656 #17 0x00002b3b77fdb5d8 in WebCore::Element::setAttribute (this=0x3e0b690, name=..., value=...) at ../../WebCore/dom/Element.cpp:194 #18 0x00002b3b7816a16e in WebCore::HTMLSelectElement::setMultiple (this=0x3e0b690, multiple=true) at ../../WebCore/html/HTMLSelectElement.cpp:431 #19 0x00002b3b7893b1f1 in WebCore::setJSHTMLSelectElementMultiple (exec=0x2b3c0fe43038, thisObject=0x2b3c10289180, value=...) at DerivedSources/WebCore/JSHTMLSelectElement.cpp:433 #20 0x00002b3b7893c2e4 in JSC::lookupPut<WebCore::JSHTMLSelectElement> (exec=0x2b3c0fe43038, propertyName=..., value=..., table=0x2b3b7a1b6540, thisObj=0x2b3c10289180) at ../../JavaScriptCore/runtime/Lookup.h:318 ... 318790 1 alex 2010-12-08 08:03:32 -0800 Landed rollout: http://trac.webkit.org/changeset/73519 318797 2 dmikurube 2010-12-08 08:32:16 -0800 (In reply to comment #1) Thank you for rolling out. I'll check it... 318799 3 aroben 2010-12-08 08:37:57 -0800 Here's a Windows crash log, too: http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r73517%20(23287)/CrashLog_0f24_2010-12-08_07-54-06-734.txt Looks like this assertion is failing: bool HTMLFormControlElement::isValidFormControlElement() { // If the following assertion fails, setNeedsValidityCheck() is not called // correctly when something which changes validity is updated. ASSERT(m_isValid == validity()->valid()); return m_isValid; } 319084 4 tkent 2010-12-08 15:35:27 -0800 Closing this because the rollout was landed, and reopening Bug 50380.