<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>50688</bug_id>
          
          <creation_ts>2010-12-08 07:33:07 -0800</creation_ts>
          <short_desc>check-webkit-style failed with a false-positive error</short_desc>
          <delta_ts>2010-12-14 22:18:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Cosmin Truta">ctruta</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>eric</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>318776</commentid>
    <comment_count>0</comment_count>
    <who name="Cosmin Truta">ctruta</who>
    <bug_when>2010-12-08 07:33:07 -0800</bug_when>
    <thetext>check-webkit-style failed, indicating an error that is a false positive. My patch cannot go further because of that.


Quote from bug 50310:


Attachment 75857 [details] did not pass style-queue:

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2
Updating OpenSource
Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061

Died at WebKitTools/Scripts/update-webkit line 132.

If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318973</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-12-08 13:21:38 -0800</bug_when>
    <thetext>Yes, we&apos;re working on fixing the machine.  Thank you for the bug!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>319209</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-12-08 19:16:18 -0800</bug_when>
    <thetext>I&apos;m very sorry about these issues.  As you can tell, we&apos;re not expert sysadmins...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>319239</commentid>
    <comment_count>3</comment_count>
    <who name="Cosmin Truta">ctruta</who>
    <bug_when>2010-12-08 20:31:38 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; I&apos;m very sorry about these issues.  As you can tell, we&apos;re not expert sysadmins...

No problemo -- but may I have some help to land the patch 75857 from bug 50310, which seems to be stuck because of this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>319246</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-12-08 20:39:05 -0800</bug_when>
    <thetext>Not really.  The bubbles are just advisory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>319251</commentid>
    <comment_count>5</comment_count>
    <who name="Cosmin Truta">ctruta</who>
    <bug_when>2010-12-08 20:48:57 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Not really.  The bubbles are just advisory.

Aha, good to know. And thanks for r+/cq+. Now I won&apos;t have to worry about that red bubble which might scare off potential reviewers ;-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>322503</commentid>
    <comment_count>6</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-12-14 22:18:30 -0800</bug_when>
    <thetext>The issue as stated is fixed or invalid. (check-webkit-style wasn&apos;t giving a false positive really. It was the bot which had issues.)

Anyway, there is no bug to fix anyone, so I&apos;m resolving.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>