50683 2010-12-08 06:33:39 -0800 REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab 2010-12-11 10:37:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 kevin bweinstein aone.jga ap beidson bweinstein Chris.J.Leung dbculp eriktoh j.c.schumacher marcelo.alves sam subach.pavel sullivan tarmangani oldest_to_newest 318749 0 kevin 2010-12-08 06:33:39 -0800 Some of the contextual menu items are non-functional: Open Link in New Tab Download Linked File As... Add Link to Bookmarks... Open Image in New Tab Save Image As... Save Image to "Downloads" These still work: Open Link in New Window Download Linked File Copy Link Open Image in New Window 318990 1 ap 2010-12-08 13:39:59 -0800 *** Bug 50686 has been marked as a duplicate of this bug. *** 318993 2 ap 2010-12-08 13:41:25 -0800 Sam, was this broken by WebKit2 work? 319005 3 beidson 2010-12-08 13:56:52 -0800 Kevin, is this in WK2, or in normal WebKit? 319022 4 ap 2010-12-08 14:08:49 -0800 This is about WebKit nightlies, so WebKit1. 319023 5 beidson 2010-12-08 14:10:06 -0800 I saw no indication it was about WebKit Nightlies. If it broke somewhere in this range since yesterday, it was almost certainly some refactoring from Brian. 319030 6 bweinstein 2010-12-08 14:19:52 -0800 (In reply to comment #5) > I saw no indication it was about WebKit Nightlies. > > If it broke somewhere in this range since yesterday, it was almost certainly some refactoring from Brian. I believe it could be a manifestation of: https://bugs.webkit.org/show_bug.cgi?id=50665 Testing my patch to see if it fixes this issue. 319066 7 ap 2010-12-08 15:07:53 -0800 *** Bug 50694 has been marked as a duplicate of this bug. *** 319068 8 ap 2010-12-08 15:09:37 -0800 *** Bug 50693 has been marked as a duplicate of this bug. *** 319073 9 75978 bweinstein 2010-12-08 15:15:19 -0800 Created attachment 75978 [PATCH] Fix 319074 10 bweinstein 2010-12-08 15:22:25 -0800 <rdar://problem/8746500> 319083 11 bweinstein 2010-12-08 15:34:56 -0800 Landed in r73560. 319533 12 ap 2010-12-09 10:00:42 -0800 *** Bug 50765 has been marked as a duplicate of this bug. *** 319932 13 ap 2010-12-09 22:25:09 -0800 *** Bug 50798 has been marked as a duplicate of this bug. *** 320254 14 ap 2010-12-10 10:58:34 -0800 *** Bug 50812 has been marked as a duplicate of this bug. *** 320700 15 ap 2010-12-11 10:37:22 -0800 *** Bug 50870 has been marked as a duplicate of this bug. *** 75978 2010-12-08 15:15:19 -0800 2010-12-08 15:32:41 -0800 [PATCH] Fix new_tab_not_functional.patch text/plain 1372 bweinstein SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA3MzU1NikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTItMDggIEJyaWFuIFdlaW5zdGVpbiAgPGJ3 ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJFR1JFU1NJT046IHI3MzQyOS1yNzM0OTA6IFNvbWUgQ29udGV4dHVhbCBt ZW51IGl0ZW1zIG5vbi1mdW5jdGlvbmFsLCBzdWNoIGFzIE9wZW4gTGluayBpbiBOZXcgVGFiCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDY4MworICAg ICAgICAKKyAgICAgICAgSWYgb3VyIGNvbnRleHQgbWVudSBpdGVtIGFscmVhZHkgaGFzIGFuIGFj dGlvbiwgZG9uJ3Qgb3ZlcndyaXRlIHRoZSBhY3Rpb24gd2l0aCB0aGUgY29udGV4dCBtZW51Cisg ICAgICAgIGZvcndhcmRlci4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06Cisg ICAgICAgIChzZXRNZW51SXRlbVRhcmdldCk6CisKIDIwMTAtMTItMDggIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgYW4gdW51c2VkIHZhcmlh YmxlLgpJbmRleDogV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQkocmV2aXNpb24gNzM1MzUpCisr KyBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTMy NzIsNiArMzI3MiwxMSBAQCAtICh2b2lkKXJpZ2h0TW91c2VVcDooTlNFdmVudCAqKWV2ZW50CiAK IHN0YXRpYyB2b2lkIHNldE1lbnVJdGVtVGFyZ2V0KE5TTWVudUl0ZW0qIG1lbnVJdGVtKQogewor ICAgIC8vIERvbid0IHNldCB0aGUgbWVudSBpdGVtJ3MgYWN0aW9uIHRvIHRoZSBjb250ZXh0IG1l bnUgYWN0aW9uIGZvcndhcmRlciBpZiB3ZSBhbHJlYWR5CisgICAgLy8gaGF2ZSBhbiBhY3Rpb24u CisgICAgaWYgKFttZW51SXRlbSBhY3Rpb25dKQorICAgICAgICByZXR1cm47CisKICAgICBbbWVu dUl0ZW0gc2V0VGFyZ2V0OltXZWJNZW51VGFyZ2V0IHNoYXJlZE1lbnVUYXJnZXRdXTsKICAgICBb bWVudUl0ZW0gc2V0QWN0aW9uOkBzZWxlY3Rvcihmb3J3YXJkQ29udGV4dE1lbnVBY3Rpb246KV07 CiB9Cg==