50670 2010-12-07 22:56:28 -0800 HttpServerBase should not raise OSError when it fails to delete stale log files 2010-12-08 18:35:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED DUPLICATE 50712 P2 Normal --- 1 yutak yutak aroben eric tony oldest_to_newest 318662 0 yutak 2010-12-07 22:56:28 -0800 Chromium Windows bots sometimes fail to delete stale log files (in HttpServerBase.remove_log_files), especially when it restarts the test to check flakiness. I think we should just log the issue when we have failed to delete files and continue running, rather than die with an exception. Stack trace: 2010-12-07 21:21:44,023 3044 run_webkit_tests.py:619 INFO Exception raised, exiting Traceback (most recent call last): File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests", line 38, in <module> sys.exit(run_webkit_tests.main()) File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1636, in main return run(port_obj, options, args) File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1328, in run num_unexpected_results = test_runner.run(result_summary) No handlers could be found for logger "webkitpy.common.system" File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 722, in run self._run_tests(failures.keys(), retry_summary) File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 612, in _run_tests message_broker.run_message_loop() File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 337, in _covered_run self._run(test_runner=None, result_summary=None) File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 414, in _run self._start_servers_with_lock() File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 550, in _start_servers_with_lock self._port.start_websocket_server() File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\base.py", line 548, in start_websocket_server self._websocket_server.start() File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\websocket_server.py", line 153, in start self.remove_log_files(self._output_dir, log_prefix) File "e:\b\build\slave\webkit-rel-webkit-org\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\http_server_base.py", line 81, in remove_log_files os.remove(full_path) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'e:\\b\\build\\slave\\webkit-rel-webkit-org\\build\\src\\webkit\\Release\\..\\../../layout-test-results\\pywebsocket.ws.log-07Dec2010-211346-out.txt' 318663 1 75874 yutak 2010-12-07 23:00:52 -0800 Created attachment 75874 Patch 318664 2 yutak 2010-12-07 23:03:55 -0800 Eric, could you take a look at this patch? 318876 3 eric 2010-12-08 10:41:50 -0800 The example you give is one where some other httpd server is still running. Ignoring that case seems like a bad idea. We should stop the other httpd server or fail. 319105 4 tony 2010-12-08 16:13:12 -0800 *** This bug has been marked as a duplicate of bug 50712 *** 319186 5 yutak 2010-12-08 18:35:27 -0800 Tony, thank you for taking care of this failure. 75874 2010-12-07 23:00:52 -0800 2010-12-08 16:56:44 -0800 Patch bug-50670-20101208160050.patch text/plain 1459 yutak ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5Y2FiYzA4YjIyZjc3NGI0NzIxMmNmNzAyYmE5ZGMwNTBiNTA4MGQzLi43ZDQ0ZmMw YTg3NDI0NmYzNzU2MTIyYmY4NzhkYzhhN2Q5NGQxZjNkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMDcgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSHR0cFNlcnZlckJhc2Ug c2hvdWxkIG5vdCByYWlzZSBPU0Vycm9yIHdoZW4gaXQgZmFpbHMgdG8gZGVsZXRlIHN0YWxlIGxv ZyBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTA2NzAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0 cF9zZXJ2ZXJfYmFzZS5weToKKwogMjAxMC0xMi0wNyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVy X2Jhc2UucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2h0dHBfc2VydmVyX2Jhc2UucHkKaW5kZXggMjc0NWNjZTQ0ZDRhMzE2MmQ0NWRlMmE4MmVjYjlk NGMzMjI3ZDI2OC4uMzVkZWQ0NTg0ZmYzM2I4ZTJiZThhZDRhZDg4OTI4YjE3NmViMGIyNCAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9o dHRwX3NlcnZlcl9iYXNlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXJfYmFzZS5weQpAQCAtNzgsNCArNzgsOCBAQCBjbGFz cyBIdHRwU2VydmVyQmFzZShvYmplY3QpOgogICAgICAgICBmb3IgZmlsZSBpbiBmaWxlczoKICAg ICAgICAgICAgIGlmIGZpbGUuc3RhcnRzd2l0aChzdGFydHNfd2l0aCk6CiAgICAgICAgICAgICAg ICAgZnVsbF9wYXRoID0gb3MucGF0aC5qb2luKGZvbGRlciwgZmlsZSkKLSAgICAgICAgICAgICAg ICBvcy5yZW1vdmUoZnVsbF9wYXRoKQorICAgICAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAg ICAgICAgICAgb3MucmVtb3ZlKGZ1bGxfcGF0aCkKKyAgICAgICAgICAgICAgICBleGNlcHQgT1NF cnJvciwgZXJyb3I6CisgICAgICAgICAgICAgICAgICAgIF9sb2cud2FybmluZygiRmFpbGVkIHRv IGRlbGV0ZSBzdGFsZSBsb2cgZmlsZSBcIiVzXCI6ICVzIiAlCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoZnVsbF9wYXRoLCBlcnJvcikpCg==