50665 2010-12-07 22:02:12 -0800 WebMenuTarget implemented in both WebKit and WebKit2 2010-12-09 00:34:51 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein abarth beidson eric mrowe webkit.review.bot oldest_to_newest 318647 0 bweinstein 2010-12-07 22:02:12 -0800 It shouldn't be, it can cause warnings to be logged. <rdar://problem/8742640> 318649 1 75870 bweinstein 2010-12-07 22:07:39 -0800 Created attachment 75870 [PATCH] Fix 318651 2 75871 bweinstein 2010-12-07 22:16:44 -0800 Created attachment 75871 [PATCH] WK2 Fix This patch renames the class in WebKit2 instead of the one in WebKit. 319046 3 beidson 2010-12-08 14:37:07 -0800 Lets do just the WK2 one. 319140 4 bweinstein 2010-12-08 17:03:23 -0800 Landed in r73567. 319310 5 webkit.review.bot 2010-12-09 00:34:51 -0800 http://trac.webkit.org/changeset/73567 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/css/input-search-padding.html fast/css/text-input-with-webkit-border-radius.html fast/forms/box-shadow-override.html fast/forms/control-restrict-line-height.html fast/forms/input-appearance-height.html fast/forms/placeholder-pseudo-style.html fast/forms/placeholder-set-value.html fast/forms/search-cancel-button-style-sharing.html fast/forms/search-placeholder-value-changed.html fast/forms/search-rtl.html fast/forms/search-styled.html fast/forms/search-transformed.html fast/forms/search-vertical-alignment.html fast/forms/search-zoomed.html fast/forms/searchfield-heights.html 75870 2010-12-07 22:07:39 -0800 2010-12-08 14:36:57 -0800 [PATCH] Fix rename_menutarget.patch text/plain 2551 bweinstein SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA3MzQ5MCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMDcgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3 ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYk1lbnVUYXJnZXQgaW1wbGVtZW50ZWQgaW4gYm90aCBXZWJLaXQgYW5k IFdlYktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUwNjY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzQyNjQwPgorICAgICAgICAKKyAgICAg ICAgUmVuYW1lIFdlYk1lbnVUYXJnZXQgdG8gV2ViS2l0TWVudVRhcmdldCB0byBwcmV2ZW50IHRo aXMgd2FybmluZy4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAgICAg ICgrW1dlYktpdE1lbnVUYXJnZXQgc2hhcmVkTWVudVRhcmdldF0pOgorICAgICAgICAoc2V0TWVu dUl0ZW1UYXJnZXQpOgorICAgICAgICAoLVtXZWJIVE1MVmlldyBtZW51Rm9yRXZlbnQ6XSk6CisK IDIwMTAtMTItMDcgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBXZWJLaXQvbWFjL1dlYlZp ZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhU TUxWaWV3Lm1tCShyZXZpc2lvbiA3MzQ2OSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1M Vmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTI5LDI0ICsxMjksMjQgQEAgdXNpbmcgbmFtZXNw YWNlIEhUTUxOYW1lczsKIHVzaW5nIG5hbWVzcGFjZSBXVEY7CiB1c2luZyBuYW1lc3BhY2Ugc3Rk OwogCi1AaW50ZXJmYWNlIFdlYk1lbnVUYXJnZXQgOiBOU09iamVjdCB7CitAaW50ZXJmYWNlIFdl YktpdE1lbnVUYXJnZXQgOiBOU09iamVjdCB7CiAgICAgV2ViQ29yZTo6Q29udGV4dE1lbnVDb250 cm9sbGVyKiBfbWVudUNvbnRyb2xsZXI7CiB9Ci0rIChXZWJNZW51VGFyZ2V0KilzaGFyZWRNZW51 VGFyZ2V0OworKyAoV2ViS2l0TWVudVRhcmdldCopc2hhcmVkTWVudVRhcmdldDsKIC0gKFdlYkNv cmU6OkNvbnRleHRNZW51Q29udHJvbGxlciopbWVudUNvbnRyb2xsZXI7CiAtICh2b2lkKXNldE1l bnVDb250cm9sbGVyOihXZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xsZXIqKW1lbnVDb250cm9s bGVyOwogLSAodm9pZClmb3J3YXJkQ29udGV4dE1lbnVBY3Rpb246KGlkKXNlbmRlcjsKIC0gKEJP T0wpdmFsaWRhdGVNZW51SXRlbTooTlNNZW51SXRlbSAqKWl0ZW07CiBAZW5kCiAKLXN0YXRpYyBX ZWJNZW51VGFyZ2V0KiB0YXJnZXQ7CitzdGF0aWMgV2ViS2l0TWVudVRhcmdldCogdGFyZ2V0Owog Ci1AaW1wbGVtZW50YXRpb24gV2ViTWVudVRhcmdldAorQGltcGxlbWVudGF0aW9uIFdlYktpdE1l bnVUYXJnZXQKIAotKyAoV2ViTWVudVRhcmdldCopc2hhcmVkTWVudVRhcmdldAorKyAoV2ViS2l0 TWVudVRhcmdldCopc2hhcmVkTWVudVRhcmdldAogewogICAgIGlmICghdGFyZ2V0KQotICAgICAg ICB0YXJnZXQgPSBbW1dlYk1lbnVUYXJnZXQgYWxsb2NdIGluaXRdOworICAgICAgICB0YXJnZXQg PSBbW1dlYktpdE1lbnVUYXJnZXQgYWxsb2NdIGluaXRdOwogICAgIHJldHVybiB0YXJnZXQ7CiB9 CiAKQEAgLTMyNzIsNyArMzI3Miw3IEBAIC0gKHZvaWQpcmlnaHRNb3VzZVVwOihOU0V2ZW50ICop ZXZlbnQKIAogc3RhdGljIHZvaWQgc2V0TWVudUl0ZW1UYXJnZXQoTlNNZW51SXRlbSogbWVudUl0 ZW0pCiB7Ci0gICAgW21lbnVJdGVtIHNldFRhcmdldDpbV2ViTWVudVRhcmdldCBzaGFyZWRNZW51 VGFyZ2V0XV07CisgICAgW21lbnVJdGVtIHNldFRhcmdldDpbV2ViS2l0TWVudVRhcmdldCBzaGFy ZWRNZW51VGFyZ2V0XV07CiAgICAgW21lbnVJdGVtIHNldEFjdGlvbjpAc2VsZWN0b3IoZm9yd2Fy ZENvbnRleHRNZW51QWN0aW9uOildOwogfQogCkBAIC0zMzM2LDcgKzMzMzYsNyBAQCAtIChOU01l bnUgKiltZW51Rm9yRXZlbnQ6KE5TRXZlbnQgKilldmVuCiAgICAgICAgIFttZW51IGFkZEl0ZW06 W21lbnVJdGVtcyBvYmplY3RBdEluZGV4OmldXTsKICAgICBzZXRNZW51VGFyZ2V0cyhtZW51KTsK ICAgICAKLSAgICBbW1dlYk1lbnVUYXJnZXQgc2hhcmVkTWVudVRhcmdldF0gc2V0TWVudUNvbnRy b2xsZXI6cGFnZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCldOworICAgIFtbV2ViS2l0TWVudVRh cmdldCBzaGFyZWRNZW51VGFyZ2V0XSBzZXRNZW51Q29udHJvbGxlcjpwYWdlLT5jb250ZXh0TWVu dUNvbnRyb2xsZXIoKV07CiAgICAgCiAgICAgcmV0dXJuIG1lbnU7CiB9Cg== 75871 2010-12-07 22:16:44 -0800 2010-12-08 14:36:19 -0800 [PATCH] WK2 Fix wk_menutarget_rename.patch text/plain 2543 bweinstein SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzQ5MCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMDcgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlYk1lbnVUYXJnZXQgaW1wbGVtZW50ZWQgaW4gYm90aCBXZWJLaXQgYW5kIFdlYktpdDIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNjY1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NzQyNjQwPgorICAgICAgICAKKyAgICAgICAgUmVuYW1l IFdlYk1lbnVUYXJnZXQgdG8gV0tNZW51VGFyZ2V0IHRvIHByZXZlbnQgdGhpcyB3YXJuaW5nIGFu ZCBzdGF5IGNvbnNpc3RlbnQgd2l0aAorICAgICAgICBvdGhlciBXZWJLaXQyIG5hbWluZ3MuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW06CisgICAg ICAgICgrW1dLTWVudVRhcmdldCBzaGFyZWRNZW51VGFyZ2V0XSk6CisgICAgICAgIChXZWJLaXQ6 Om5zTWVudUl0ZW1WZWN0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5 TWFjOjpzaG93Q29udGV4dE1lbnUpOgorCiAyMDEwLTEyLTA3ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5k ZXg6IFdlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1t CShyZXZpc2lvbiA3MzQ2OSkKKysrIFdlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVu dVByb3h5TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02MCwyMCArNjAsMjAgQEAgLSAoV2ViS2l0 OjpBUElPYmplY3QqKXVzZXJEYXRhCiAKIEBlbmQKIAotQGludGVyZmFjZSBXZWJNZW51VGFyZ2V0 IDogTlNPYmplY3QgeworQGludGVyZmFjZSBXS01lbnVUYXJnZXQgOiBOU09iamVjdCB7CiAgICAg V2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5TWFjKiBfbWVudVByb3h5OwogfQotKyAoV2ViTWVu dVRhcmdldCopc2hhcmVkTWVudVRhcmdldDsKKysgKFdLTWVudVRhcmdldCopc2hhcmVkTWVudVRh cmdldDsKIC0gKFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eU1hYyopbWVudVByb3h5OwogLSAo dm9pZClzZXRNZW51UHJveHk6KFdlYktpdDo6V2ViQ29udGV4dE1lbnVQcm94eU1hYyopbWVudVBy b3h5OwogLSAodm9pZClmb3J3YXJkQ29udGV4dE1lbnVBY3Rpb246KGlkKXNlbmRlcjsKIEBlbmQK IAotQGltcGxlbWVudGF0aW9uIFdlYk1lbnVUYXJnZXQKK0BpbXBsZW1lbnRhdGlvbiBXS01lbnVU YXJnZXQKIAotKyAoV2ViTWVudVRhcmdldCopc2hhcmVkTWVudVRhcmdldAorKyAoV0tNZW51VGFy Z2V0KilzaGFyZWRNZW51VGFyZ2V0CiB7Ci0gICAgc3RhdGljIFdlYk1lbnVUYXJnZXQqIHRhcmdl dCA9IFtbV2ViTWVudVRhcmdldCBhbGxvY10gaW5pdF07CisgICAgc3RhdGljIFdLTWVudVRhcmdl dCogdGFyZ2V0ID0gW1tXS01lbnVUYXJnZXQgYWxsb2NdIGluaXRdOwogICAgIHJldHVybiB0YXJn ZXQ7CiB9CiAKQEAgLTE3NSw3ICsxNzUsNyBAQCBzdGF0aWMgVmVjdG9yPFJldGFpblB0cjxOU01l bnVJdGVtPiA+IG5zCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBXZWJNZW51VGFyZ2V0KiB0YXJn ZXQgPSBbV2ViTWVudVRhcmdldCBzaGFyZWRNZW51VGFyZ2V0XTsKKyAgICBXS01lbnVUYXJnZXQq IHRhcmdldCA9IFtXS01lbnVUYXJnZXQgc2hhcmVkTWVudVRhcmdldF07CiAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IHNpemU7ICsraSkKICAgICAgICAgW3Jlc3VsdFtpXS5nZXQoKSBzZXRU YXJnZXQ6dGFyZ2V0XTsKICAgICAKQEAgLTE5OSw3ICsxOTksNyBAQCB2b2lkIFdlYkNvbnRleHRN ZW51UHJveHlNYWM6OnBvcHVsYXRlKGNvCiB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlNYWM6OnNo b3dDb250ZXh0TWVudShjb25zdCBJbnRQb2ludCYgbWVudUxvY2F0aW9uLCBjb25zdCBWZWN0b3I8 V2ViQ29udGV4dE1lbnVJdGVtRGF0YT4mIGl0ZW1zKQogewogICAgIHBvcHVsYXRlKGl0ZW1zKTsK LSAgICBbW1dlYk1lbnVUYXJnZXQgc2hhcmVkTWVudVRhcmdldF0gc2V0TWVudVByb3h5OnRoaXNd OworICAgIFtbV0tNZW51VGFyZ2V0IHNoYXJlZE1lbnVUYXJnZXRdIHNldE1lbnVQcm94eTp0aGlz XTsKICAgICAKICAgICBOU1JlY3QgbWVudVJlY3QgPSBOU01ha2VSZWN0KG1lbnVMb2NhdGlvbi54 KCksIG1lbnVMb2NhdGlvbi55KCksIDAsIDApOwogICAgIAo=