50631 2010-12-07 08:20:38 -0800 GeneratedImage::drawPattern() crashes when it fails to create ImageBuffer 2010-12-09 11:05:27 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned abarth commit-queue eric staikos webkit.review.bot oldest_to_newest 318195 0 yong.li.webkit 2010-12-07 08:20:38 -0800 void GeneratedImage::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransform, const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator compositeOp, const FloatRect& destRect) { ... OwnPtr<ImageBuffer> imageBuffer = ImageBuffer::create(adjustedSize); ASSERT(imageBuffer.get()); Why do we assert here? ImageBuffer::create() is allowed to return 0: static PassOwnPtr<ImageBuffer> create(const IntSize& size, ImageColorSpace colorSpace = DeviceRGB) { bool success = false; OwnPtr<ImageBuffer> buf(new ImageBuffer(size, colorSpace, success)); if (success) return buf.release(); return 0; } 318243 1 75822 yong.li.webkit 2010-12-07 09:23:15 -0800 Created attachment 75822 the patch 318260 2 75822 darin 2010-12-07 09:42:22 -0800 Comment on attachment 75822 the patch I silently drawing nothing the most useful behavior? Do callers need to know nothing was drawn? 318277 3 webkit.review.bot 2010-12-07 10:00:48 -0800 Attachment 75822 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style. 318322 4 yong.li.webkit 2010-12-07 10:59:03 -0800 (In reply to comment #2) > (From update of attachment 75822 [details]) > I silently drawing nothing the most useful behavior? Do callers need to know nothing was drawn? ImageBuffer::create() rarely fails currently. Probably the best solution is never let ImageBuffer::create() fail, and let it do some alternative job when it cannot create platform resource. 318324 5 webkit.review.bot 2010-12-07 11:01:55 -0800 Attachment 75822 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style. 318376 6 webkit.review.bot 2010-12-07 12:03:15 -0800 Attachment 75822 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style. 318609 7 webkit.review.bot 2010-12-07 21:41:13 -0800 Attachment 75822 did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061 Died at WebKitTools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style. 318685 8 75822 commit-queue 2010-12-08 00:18:17 -0800 Comment on attachment 75822 the patch Rejecting patch 75822 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6730115 319512 9 commit-queue 2010-12-09 09:32:39 -0800 The commit-queue encountered the following flaky tests while processing attachment 75822: webarchive/test-link-rel-icon.html http/tests/loading/basic-credentials-sent-automatically.html Please file bugs against the tests. These tests were authored by beidson@apple.com and ddkilzer@webkit.org. The commit-queue is continuing to process your patch. 319555 10 75822 commit-queue 2010-12-09 10:27:05 -0800 Comment on attachment 75822 the patch Clearing flags on attachment: 75822 Committed r73622: <http://trac.webkit.org/changeset/73622> 319556 11 commit-queue 2010-12-09 10:27:10 -0800 All reviewed patches have been landed. Closing bug. 319602 12 webkit.review.bot 2010-12-09 11:05:27 -0800 http://trac.webkit.org/changeset/73622 might have broken GTK Linux 64-bit Debug 75822 2010-12-07 09:23:15 -0800 2010-12-09 10:27:04 -0800 the patch 50631.patch text/plain 1392 yong.li.webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTUyZmUxZi4uZWQ3Y2E1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0wNyAgWW9uZyBMaSAgPHlv bGlAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIEltYWdlQnVmZmVyOjpjcmVhdGUoKQorICAg ICAgICB0byBhdm9pZCBjcmFzaCB3aGVuIEltYWdlQnVmZmVyOjpjcmVhdGUoKSBmYWlscy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNjMxCisKKyAg ICAgICAgTm8gbmV3IHRlc3QgYmVjYXVzZSBpdCByZWxpZXMgb24gdGhlIHBsYXRmb3JtIGltcGxl bWVudGF0aW9uCisgICAgICAgIG9mIEltYWdlQnVmZmVyLiBJdCBpcyBoYXJkIHRvIG1ha2UgSW1h Z2VCdWZmZXI6OmNyZWF0ZSgpIGZhaWwKKyAgICAgICAgaW4gbW9zdCBwb3J0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dlbmVyYXRlZEltYWdlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdlbmVyYXRlZEltYWdlOjpkcmF3UGF0dGVybik6CisKIDIwMTAtMTItMDcgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2 ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR2VuZXJh dGVkSW1hZ2UuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HZW5lcmF0ZWRJbWFnZS5j cHAKaW5kZXggNWRmMjYwOC4uZjJjMTc1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HZW5lcmF0ZWRJbWFnZS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HZW5lcmF0ZWRJbWFnZS5jcHAKQEAgLTU3LDcgKzU3LDggQEAgdm9pZCBHZW5lcmF0ZWRJbWFn ZTo6ZHJhd1BhdHRlcm4oR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFJlY3Qm IHNyY1IKIAogICAgIC8vIENyZWF0ZSBhIEJpdG1hcEltYWdlIGFuZCBjYWxsIGRyYXdQYXR0ZXJu IG9uIGl0LgogICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gaW1hZ2VCdWZmZXIgPSBJbWFnZUJ1ZmZl cjo6Y3JlYXRlKGFkanVzdGVkU2l6ZSk7Ci0gICAgQVNTRVJUKGltYWdlQnVmZmVyLmdldCgpKTsK KyAgICBpZiAoIWltYWdlQnVmZmVyKQorICAgICAgICByZXR1cm47CiAKICAgICAvLyBGaWxsIHdp dGggdGhlIGdyYWRpZW50LgogICAgIEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpY3NDb250ZXh0ID0g aW1hZ2VCdWZmZXItPmNvbnRleHQoKTsK