50629 2010-12-07 07:18:52 -0800 [GTK] testwebdatasource - unreachable test is broken 2010-12-07 08:15:11 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 318175 0 gustavo 2010-12-07 07:18:52 -0800 The unreachable test is not testing what it needs to test, because it uses an incorrect condition in the load status notification callback, and unfortunately, after that is fixed the test does not pass. While I figure the problem out, I'll post a patch that fixes the test and disables it. 318178 1 75814 gustavo 2010-12-07 07:27:29 -0800 Created attachment 75814 proposed patch 318191 2 75814 gustavo 2010-12-07 08:14:55 -0800 Comment on attachment 75814 proposed patch Xan reviewed the patch in person over my shoulder. 318192 3 gustavo 2010-12-07 08:15:11 -0800 Landed as 73442. 75814 2010-12-07 07:27:29 -0800 2010-12-07 08:14:55 -0800 proposed patch 0001-Proposed-patch.patch text/plain 3621 gustavo RnJvbSA5MGZiM2Y1MTAyOTM0MDE0MDhlMDZjMDQzOTE1MGUzNzkyNTcyOTYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgNyBEZWMgMjAxMCAxNjoyMToyNyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFBy b3Bvc2VkIHBhdGNoCgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8 ICAgMTUgKysrKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJkYXRhc291cmNl LmMgfCAgIDMwICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAzMCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGFlMDA2MmEuLmUzOTg5 ZTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMTItMDcgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gdGVzdHdlYmRhdGFzb3VyY2UgLSB1 bnJlYWNoYWJsZSB0ZXN0IGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTA2MjkKKworICAgICAgICBGaXgsIGFuZCBkaXNhYmxlIHRlc3R3 ZWJkYXRhc291cmNlJ3MgdW5yZWFjaGFibGUgdGVzdCAoaXQgaXMgbm90CisgICAgICAgIHBhc3Np bmcgbm93IHRoYXQgaXQgYWN0dWFsbHkgdGVzdHMgd2hhdCBpdCBzaG91bGQpLiBUaGlzIGFsc28K KyAgICAgICAgZml4ZXMgdGhlIHdhaXQgdGltZXIgdG8gYWN0dWFsbHkgd29yayBhcyBleHBlY3Rl ZC4KKworICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJkYXRhc291cmNlLmM6CisgICAgICAgIChub3Rp ZnlfbG9hZF9zdGF0dXNfdW5yZWFjaGFibGVfY2IpOgorICAgICAgICAobm90aWZ5X2xvYWRfc3Rh dHVzX2NiKToKKwogMjAxMC0xMi0wNCAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYktp dC9ndGsvdGVzdHMvdGVzdHdlYmRhdGFzb3VyY2UuYyBiL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdl YmRhdGFzb3VyY2UuYwppbmRleCA1YzA1NjhlLi4zMTYyNmRlIDEwMDY0NAotLS0gYS9XZWJLaXQv Z3RrL3Rlc3RzL3Rlc3R3ZWJkYXRhc291cmNlLmMKKysrIGIvV2ViS2l0L2d0ay90ZXN0cy90ZXN0 d2ViZGF0YXNvdXJjZS5jCkBAIC02MCwxMyArNjAsMTAgQEAgc3RhdGljIHZvaWQgbm90aWZ5X2xv YWRfc3RhdHVzX3VucmVhY2hhYmxlX2NiKFdlYktpdFdlYlZpZXcqIHZpZXcsIEdQYXJhbVNwZWMq IHAKICAgICBXZWJLaXRMb2FkU3RhdHVzIHN0YXR1cyA9IHdlYmtpdF93ZWJfdmlld19nZXRfbG9h ZF9zdGF0dXMgKHZpZXcpOwogICAgIFdlYktpdFdlYkZyYW1lKiBmcmFtZSA9IHdlYmtpdF93ZWJf dmlld19nZXRfbWFpbl9mcmFtZSh2aWV3KTsKIAotICAgIGlmIChzdGF0dXMgIT0gV0VCS0lUX0xP QURfRklOSVNIRUQpCi0gICAgICAgIHJldHVybjsKKyAgICBnX2Fzc2VydChzdGF0dXMgIT0gV0VC S0lUX0xPQURfRklOSVNIRUQpOwogCi0gICAgaWYgKHdhaXRUaW1lcikgewotICAgICAgICBnX3Nv dXJjZV9yZW1vdmUod2FpdFRpbWVyKTsKLSAgICAgICAgd2FpdFRpbWVyID0gMDsKLSAgICB9Cisg ICAgaWYgKHN0YXR1cyAhPSBXRUJLSVRfTE9BRF9GQUlMRUQpCisgICAgICAgIHJldHVybjsKIAog ICAgIFdlYktpdFdlYkRhdGFTb3VyY2UqIGRhdGFzb3VyY2UgPSB3ZWJraXRfd2ViX2ZyYW1lX2dl dF9kYXRhX3NvdXJjZShmcmFtZSk7CiAKQEAgLTg5LDExICs4Niw2IEBAIHN0YXRpYyB2b2lkIG5v dGlmeV9sb2FkX3N0YXR1c19jYihXZWJLaXRXZWJWaWV3KiB2aWV3LCBHUGFyYW1TcGVjKiBwc3Bl YywgR01haW5MCiAgICAgZWxzZSBpZiAoc3RhdHVzICE9IFdFQktJVF9MT0FEX0ZJTklTSEVEKQog ICAgICAgICByZXR1cm47CiAKLSAgICBpZiAod2FpdFRpbWVyKSB7Ci0gICAgICAgIGdfc291cmNl X3JlbW92ZSh3YWl0VGltZXIpOwotICAgICAgICB3YWl0VGltZXIgPSAwOwotICAgIH0KLQogICAg IC8qIFRlc3QgZ2V0X3JlcXVlc3QgKi8KICAgICBnX3Rlc3RfbWVzc2FnZSgiVGVzdGluZyB3ZWJr aXRfd2ViX2RhdGFfc291cmNlX2dldF9yZXF1ZXN0Iik7CiAgICAgV2ViS2l0TmV0d29ya1JlcXVl c3QqIHJlcXVlc3QgPSB3ZWJraXRfd2ViX2RhdGFfc291cmNlX2dldF9yZXF1ZXN0KGRhdGFTb3Vy Y2UpOwpAQCAtMTUyLDEwICsxNDQsMTUgQEAgc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX2Rh dGFfc291cmNlX3VucmVhY2hhYmxlX3VyaSgpCiAgICAgZ19zaWduYWxfY29ubmVjdCh2aWV3LCAi bm90aWZ5Ojpsb2FkLXN0YXR1cyIsIEdfQ0FMTEJBQ0sobm90aWZ5X2xvYWRfc3RhdHVzX3VucmVh Y2hhYmxlX2NiKSwgbG9vcCk7CiAgICAgd2Via2l0X3dlYl92aWV3X2xvYWRfdXJpKHZpZXcsICJo dHRwOi8vdGhpcy5ob3N0LmRvZXMubm90LmV4aXN0L2RvaXJlYWxseWV4aXN0Lmh0bWwiKTsKIAot ICAgIGlmICghd2FpdFRpbWVyKQotICAgICAgICB3YWl0VGltZXIgPSBnX3RpbWVvdXRfYWRkX3Nl Y29uZHMoZGVmYXVsdFRpbWVvdXQsIChHU291cmNlRnVuYyl3YWl0X3RpbWVyX2ZpcmVkLCBsb29w KTsKKyAgICB3YWl0VGltZXIgPSBnX3RpbWVvdXRfYWRkX3NlY29uZHMoZGVmYXVsdFRpbWVvdXQs IChHU291cmNlRnVuYyl3YWl0X3RpbWVyX2ZpcmVkLCBsb29wKTsKIAogICAgIGdfbWFpbl9sb29w X3J1bihsb29wKTsKKworICAgIGlmICh3YWl0VGltZXIpCisgICAgICAgIGdfc291cmNlX3JlbW92 ZSh3YWl0VGltZXIpOworCisgICAgd2FpdFRpbWVyID0gMDsKKwogICAgIGdfb2JqZWN0X3VucmVm KHZpZXcpOwogfQogCkBAIC0xNzAsOCArMTY3LDExIEBAIGludCBtYWluKGludCBhcmdjLCBjaGFy KiogYXJndikKICAgICAgICAgICAgICAgICAgICAgdGVzdF93ZWJraXRfd2ViX2RhdGFfc291cmNl X2dldF9pbml0aWFsX3JlcXVlc3QpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJk YXRhc291cmNlL2FwaSIsCiAgICAgICAgICAgICAgICAgICAgIHRlc3Rfd2Via2l0X3dlYl9kYXRh X3NvdXJjZSk7Ci0gICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYmRhdGFzb3VyY2UvdW5y ZWFjaGFibGVfdXJpIiwKLSAgICAgICAgICAgICAgICAgICAgdGVzdF93ZWJraXRfd2ViX2RhdGFf c291cmNlX3VucmVhY2hhYmxlX3VyaSk7CisKKyAgICAvKiBGSVhNRTogdGhpcyB0ZXN0IGZhaWxz IGN1cnJlbnRseS4KKyAgICAgKiBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvd2ViZGF0YXNvdXJj ZS91bnJlYWNoYWJsZV91cmkiLAorICAgICAqICAgICAgICAgICAgICAgICB0ZXN0X3dlYmtpdF93 ZWJfZGF0YV9zb3VyY2VfdW5yZWFjaGFibGVfdXJpKTsKKyAgICAgKi8KICAgICByZXR1cm4gZ190 ZXN0X3J1biAoKTsKIH0KIAotLSAKMS43LjIuMwoK