<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>50614</bug_id>
          
          <creation_ts>2010-12-06 20:23:56 -0800</creation_ts>
          <short_desc>[chromium] compositor lost context recovery fix</short_desc>
          <delta_ts>2010-12-07 18:48:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Marinichev">amarinichev</reporter>
          <assigned_to name="Alexey Marinichev">amarinichev</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>jamesr</cc>
    
    <cc>kbr</cc>
    
    <cc>vangelis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>318030</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Marinichev">amarinichev</who>
    <bug_when>2010-12-06 20:23:56 -0800</bug_when>
    <thetext>[chromium] compositor lost context recovery fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318034</commentid>
    <comment_count>1</comment_count>
      <attachid>75779</attachid>
    <who name="Alexey Marinichev">amarinichev</who>
    <bug_when>2010-12-06 20:27:57 -0800</bug_when>
    <thetext>Created attachment 75779
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318040</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Marinichev">amarinichev</who>
    <bug_when>2010-12-06 20:36:26 -0800</bug_when>
    <thetext>LayerChromium::setNeedsDisplay was not resetting x and y.  When 3D context is restored after having been lost, this function is called recursively from LayerChromium::setLayerRenderer.  If x and y are not reset, this effectively makes the layer larger, which triggers an assert later on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318043</commentid>
    <comment_count>3</comment_count>
      <attachid>75779</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-12-06 20:48:46 -0800</bug_when>
    <thetext>Comment on attachment 75779
Patch

OK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318498</commentid>
    <comment_count>4</comment_count>
      <attachid>75779</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-12-07 16:50:31 -0800</bug_when>
    <thetext>Comment on attachment 75779
Patch

Will land by hand</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318500</commentid>
    <comment_count>5</comment_count>
      <attachid>75779</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-12-07 16:53:21 -0800</bug_when>
    <thetext>Comment on attachment 75779
Patch

Clearing flags on attachment: 75779

Committed r73479: &lt;http://trac.webkit.org/changeset/73479&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318501</commentid>
    <comment_count>6</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-12-07 16:53:25 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>318541</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-12-07 18:48:09 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 75779:

fast/preloader/script.html
animations/combo-transform-translate+scale.html

Please file bugs against the tests.  These tests were authored by abarth@webkit.org, cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>75779</attachid>
            <date>2010-12-06 20:27:57 -0800</date>
            <delta_ts>2010-12-07 16:53:21 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-50614-20101206202755.patch</filename>
            <type>text/plain</type>
            <size>1503</size>
            <attacher name="Alexey Marinichev">amarinichev</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
YzBjYWVhMDljOGM0ZGE5NmM4MzA2YmM3ODE5Yzk0YzQyMDMwY2RmOS4uY2E2NTZhMmY3OTMxNGJm
N2ZjMWNhYzVlNDNkOGY5MGU4NzE0MWNhMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0wNiAgQWxl
eGV5IE1hcmluaWNoZXYgIDxhbWFyaW5pY2hldkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBjb21wb3NpdG9y
IGxvc3QgY29udGV4dCByZWNvdmVyeSBmaXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTUwNjE0CisKKyAgICAgICAgVG8gdGVzdCwgbG9hZCBhIHBhZ2Ug
dGhhdCB0cmlnZ2VycyB0aGUgY29tcG9zaXRvciwga2lsbCB0aGUgR1BVCisgICAgICAgIHByb2Nl
c3MgYW5kIGhvdmVyIG92ZXIgYSBsaW5rIHRvIHJlZHJhdyBhbmQgdGh1cyByZXN0YXJ0IHRoZSBH
UFUKKyAgICAgICAgcHJvY2Vzcy4gIFdpdGhvdXQgdGhpcyBwYXRjaCBpdCB3aWxsIGFzc2VydCBp
bgorICAgICAgICBDb250ZW50TGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4dHVyZVJlY3Q7IHdpdGgg
dGhpcyBwYXRjaCBpdCB3aWxsIG5vdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No
cm9taXVtL0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJDaHJvbWl1
bTo6c2V0TmVlZHNEaXNwbGF5KToKKwogMjAxMC0xMi0wNiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl
aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZm
IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVt
LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5j
cHAKaW5kZXggZGRjYmE3NmEwNDE3ZDFiYzQwNGZiOWIzYjYwY2Q4ODNhMTY5Y2U1Zi4uYjdhYjA5
ODljN2ZkZGJlYjJlOWVhYjc2NjVjNmIzM2NiYTlhZmYzMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmNwcAorKysgYi9XZWJDb3Jl
L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uY3BwCkBAIC0zODMsNiAr
MzgzLDcgQEAgdm9pZCBMYXllckNocm9taXVtOjpzZXROZWVkc0Rpc3BsYXkoY29uc3QgRmxvYXRS
ZWN0JiBkaXJ0eVJlY3QpCiAKIHZvaWQgTGF5ZXJDaHJvbWl1bTo6c2V0TmVlZHNEaXNwbGF5KCkK
IHsKKyAgICBtX2RpcnR5UmVjdC5zZXRMb2NhdGlvbihGbG9hdFBvaW50KCkpOwogICAgIG1fZGly
dHlSZWN0LnNldFNpemUobV9ib3VuZHMpOwogICAgIG1fY29udGVudHNEaXJ0eSA9IHRydWU7CiAg
ICAgc2V0TmVlZHNDb21taXQoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>