50607 2010-12-06 18:10:25 -0800 Remove stale include of Document.h in V8DOMWrapper.h 2010-12-14 04:03:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 creis webkit-unassigned commit-queue japhet vitalyr webkit.review.bot oldest_to_newest 317986 0 creis 2010-12-06 18:10:25 -0800 An include of Document.h was added to V8DOMWrapper.h in http://trac.webkit.org/changeset/47921, but it appears this is no longer needed since the convertNodeToV8Object function that was using it is gone. (Same for the include of V8DOMMap.h.) I'd like to remove the stale include(s) to avoid a circular include chain introduced by the combination of Nate Chapin's change to Document.h (http://trac.webkit.org/changeset/73392) and my pending patch to NavigationAction.h (https://bugs.webkit.org/attachment.cgi?id=75044&action=review). Specifically, after Nate includes DocumentLoader from Document and I include HistoryItem from NavigationAction, it's possible for V8DOMWrapper to transitively include V8Proxy. That leads to this compile error: CXX(target) out/Debug/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources8.o In file included from third_party/WebKit/WebCore/bindings/v8/ScriptValue.h:41, from third_party/WebKit/WebCore/bindings/v8/SerializedScriptValue.h:34, from third_party/WebKit/WebCore/history/HistoryItem.h:31, from third_party/WebKit/WebCore/loader/NavigationAction.h:34, from third_party/WebKit/WebCore/loader/DocumentLoader.h:34, from third_party/WebKit/WebCore/dom/Document.h:36, from third_party/WebKit/WebCore/bindings/v8/V8DOMWrapper.h:34, from out/Debug/obj/gen/webkit/bindings/V8BeforeProcessEvent.h:25, from out/Debug/obj/gen/webcore/bindings/V8BeforeProcessEvent.cpp:22, from out/Debug/obj/gen/webkit/bindings/V8DerivedSources3.cpp:31: third_party/WebKit/WebCore/bindings/v8/V8Proxy.h: In static member function 'static v8::Handle<v8::Value> WebCore::V8Proxy::constructDOMObject(const v8::Arguments&, WebCore::WrapperTypeInfo*)': third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:362: error: 'V8DOMWrapper' has not been declared third_party/WebKit/WebCore/bindings/v8/V8Proxy.h:364: error: 'V8DOMWrapper' has not been declared 317997 1 75771 creis 2010-12-06 18:18:38 -0800 Created attachment 75771 Patch 317999 2 webkit.review.bot 2010-12-06 18:21:59 -0800 Attachment 75771 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style. 318009 3 webkit.review.bot 2010-12-06 19:23:07 -0800 Attachment 75771 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'HEAD']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'HEAD'. If any of these errors are false positives, please file a bug against check-webkit-style. 318196 4 webkit.review.bot 2010-12-07 08:23:10 -0800 Attachment 75771 did not pass style-queue: Failed to run "[u'git', u'reset', u'--hard', u'refs/remotes/trunk']" exit_code: 128 error: Could not write new index file. fatal: Could not reset index file to revision 'refs/remotes/trunk'. If any of these errors are false positives, please file a bug against check-webkit-style. 321757 5 75771 eric 2010-12-14 01:25:39 -0800 Comment on attachment 75771 Patch I'm surprised Charlie isn't a committer yet. 321871 6 commit-queue 2010-12-14 03:43:19 -0800 The commit-queue encountered the following flaky tests while processing attachment 75771: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 321876 7 75771 commit-queue 2010-12-14 04:03:32 -0800 Comment on attachment 75771 Patch Clearing flags on attachment: 75771 Committed r74014: <http://trac.webkit.org/changeset/74014> 321877 8 commit-queue 2010-12-14 04:03:37 -0800 All reviewed patches have been landed. Closing bug. 75771 2010-12-06 18:18:38 -0800 2010-12-14 04:03:32 -0800 Patch bug-50607-20101206181837.patch text/plain 1226 creis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzQyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMDYgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW1vdmUgc3RhbGUgaW5jbHVkZSBvZiBEb2N1bWVudC5oIGluIFY4RE9NV3JhcHBlci5oCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDYwNworCisgICAg ICAgIFdlIG5vIGxvbmdlciBuZWVkIHRvIGluY2x1ZGUgRG9jdW1lbnQuaCBvciBWOERPTU1hcC5o IGluCisgICAgICAgIFY4RE9NV3JhcHBlci4gIFJlbW92aW5nIHRoZW0gdG8gYXZvaWQgZGVwZW5k ZW5jaWVzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmg6CisKIDIwMTAt MTItMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu aAkocmV2aXNpb24gNzM0MjIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0zMSwxNCArMzEsMTIgQEAKICNpZm5kZWYgVjhET01XcmFwcGVy X2gKICNkZWZpbmUgVjhET01XcmFwcGVyX2gKIAotI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5j bHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJJc29sYXRlZFdvcmxkLmgiCiAjaW5jbHVkZSAiTm9k ZS5oIgogI2luY2x1ZGUgIk5vZGVGaWx0ZXIuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5o IgogI2luY2x1ZGUgIlY4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmgiCi0jaW5jbHVkZSAiVjhET01N YXAuaCIKICNpbmNsdWRlICJWOEV2ZW50LmgiCiAjaW5jbHVkZSAiVjhVdGlsaXRpZXMuaCIKICNp bmNsdWRlICJWOFhQYXRoTlNSZXNvbHZlci5oIgo=