50577 2010-12-06 11:27:42 -0800 [GTK] WebKitSoupCache fails to load resources when cache contents are externally removed 2010-12-07 20:33:26 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 svillar webkit-unassigned commit-queue oldest_to_newest 317743 0 svillar 2010-12-06 11:27:42 -0800 The cache silently fails to retrieve resources that are supposedly cached when it cannot create streams for them. That could happen if for example cache files are accidentally removed by any other actor but the cache. 317749 1 75716 svillar 2010-12-06 11:34:35 -0800 Created attachment 75716 Patch 318116 2 75716 danw 2010-12-07 03:30:26 -0800 Comment on attachment 75716 Patch xan asked me to review this. It looks right to me 318556 3 commit-queue 2010-12-07 19:52:52 -0800 The commit-queue encountered the following flaky tests while processing attachment 75716: fast/css/font-face-download-error.html compositing/reflections/animation-inside-reflection.html Please file bugs against the tests. These tests were authored by simon.fraser@apple.com and yuzo@google.com. The commit-queue is continuing to process your patch. 318573 4 75716 commit-queue 2010-12-07 20:33:21 -0800 Comment on attachment 75716 Patch Clearing flags on attachment: 75716 Committed r73489: <http://trac.webkit.org/changeset/73489> 318574 5 commit-queue 2010-12-07 20:33:26 -0800 All reviewed patches have been landed. Closing bug. 75716 2010-12-06 11:34:35 -0800 2010-12-07 20:33:21 -0800 Patch bug-50577-20101206203432.patch text/plain 5988 svillar ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDdhYmE5NjNjN2I3YjdmZWJhYzAzM2NjNDcxNWE5OGNlNzgzOGNjOS4uZGU2ZmFmYzUwNjA3MmZl OWQ5NGY3YTQ0OTU1YjI3MDM4YzkxNDExYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxMC0xMi0wNiAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAorICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBXZWJLaXRTb3VwQ2FjaGUgZmFp bHMgdG8gbG9hZCByZXNvdXJjZXMgd2hlbiBjYWNoZSBjb250ZW50cyBhcmUgZXh0ZXJuYWxseSBy ZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MDU3NworCisgICAgICAgIFRyeSB0byBkb3dubG9hZCBjYWNoZWQgcmVzb3VyY2VzIGFnYWluIGlm IHRoZXkgYXJlIG5vIGxvbmdlcgorICAgICAgICBhY2Nlc2libGUgYnkgdGhlIGNhY2hlLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3NvdXAtcmVxdWVzdC1odHRwLmM6 CisgICAgICAgIChzZW5kX2FzeW5jX2NiKToKKyAgICAgICAgKHdlYmtpdF9zb3VwX3JlcXVlc3Rf aHR0cF9zZW5kX2FzeW5jKToKKworMjAxMC0xMi0wNiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24u CiAKICAgICAgICAgW0dUS10gTGVhayBpbiB3ZWJraXRfc291cF9jYWNoZV9sb2FkIGlmIGZpbGUg Y29udGVudHMgbG9hZCBmYWlscwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvY2FjaGUvc291cC1yZXF1ZXN0LWh0dHAuYyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL2NhY2hlL3NvdXAtcmVxdWVzdC1odHRwLmMKaW5kZXggZjNmZTJlY2Q1NTE1MWQxMzhm MzNhZjE2MjAyNDdjYmNmN2Q2ZWUzZS4uNzc3ZmQ3MjlmMTIwYjc3OTc2ZmZjZWRlYjdiM2JmMTQ0 YjRmYzI1YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUv c291cC1yZXF1ZXN0LWh0dHAuYworKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9j YWNoZS9zb3VwLXJlcXVlc3QtaHR0cC5jCkBAIC0xODgsNiArMTg4LDcgQEAgdHlwZWRlZiBzdHJ1 Y3QgewogCVdlYktpdFNvdXBSZXF1ZXN0SFRUUCAqaHR0cDsKIAlHQXN5bmNSZWFkeUNhbGxiYWNr IGNhbGxiYWNrOwogCWdwb2ludGVyIHVzZXJfZGF0YTsKKwlXZWJLaXRTb3VwSFRUUElucHV0U3Ry ZWFtICpodHRwc3RyZWFtOwogfSBTZW5kQXN5bmNIZWxwZXI7CiAKIHN0YXRpYyB2b2lkIHdlYmtp dF9zb3VwX3JlcXVlc3RfaHR0cF9zZW5kX2FzeW5jIChXZWJLaXRTb3VwUmVxdWVzdCAgICAgICAg ICAqcmVxdWVzdCwKQEAgLTE5OSw0NSArMjAwLDM0IEBAIHN0YXRpYyBnYm9vbGVhbgogc2VuZF9h c3luY19jYiAoZ3BvaW50ZXIgZGF0YSkKIHsKIAlHU2ltcGxlQXN5bmNSZXN1bHQgKnNpbXBsZTsK LQlXZWJLaXRTb3VwSFRUUElucHV0U3RyZWFtICpodHRwc3RyZWFtOwotCVNvdXBTZXNzaW9uICpz ZXNzaW9uOwotCVdlYktpdFNvdXBDYWNoZSAqY2FjaGU7CiAJU2VuZEFzeW5jSGVscGVyICpoZWxw ZXIgPSAoU2VuZEFzeW5jSGVscGVyICopZGF0YTsKKwljb25zdCBnY2hhciAqY29udGVudF90eXBl OwogCi0Jc2Vzc2lvbiA9IHdlYmtpdF9zb3VwX3JlcXVlc3RfZ2V0X3Nlc3Npb24gKFdFQktJVF9T T1VQX1JFUVVFU1QgKGhlbHBlci0+aHR0cCkpOwotCWNhY2hlID0gKFdlYktpdFNvdXBDYWNoZSAq KXNvdXBfc2Vzc2lvbl9nZXRfZmVhdHVyZSAoc2Vzc2lvbiwgV0VCS0lUX1RZUEVfU09VUF9DQUNI RSk7Ci0KLQlodHRwc3RyZWFtID0gKFdlYktpdFNvdXBIVFRQSW5wdXRTdHJlYW0gKil3ZWJraXRf c291cF9jYWNoZV9zZW5kX3Jlc3BvbnNlIChjYWNoZSwgU09VUF9NRVNTQUdFIChoZWxwZXItPmh0 dHAtPnByaXYtPm1zZykpOwotCi0JaWYgKGh0dHBzdHJlYW0pIHsKLQkJY29uc3QgZ2NoYXIgKmNv bnRlbnRfdHlwZTsKLQotCQlzaW1wbGUgPSBnX3NpbXBsZV9hc3luY19yZXN1bHRfbmV3IChHX09C SkVDVCAoaGVscGVyLT5odHRwKSwKLQkJCQkJCSAgICBoZWxwZXItPmNhbGxiYWNrLCBoZWxwZXIt PnVzZXJfZGF0YSwKLQkJCQkJCSAgICB3ZWJraXRfc291cF9yZXF1ZXN0X2h0dHBfc2VuZF9hc3lu Yyk7Ci0JCWdfc2ltcGxlX2FzeW5jX3Jlc3VsdF9zZXRfb3BfcmVzX2dwb2ludGVyIChzaW1wbGUs IGh0dHBzdHJlYW0sIGdfb2JqZWN0X3VucmVmKTsKKwlzaW1wbGUgPSBnX3NpbXBsZV9hc3luY19y ZXN1bHRfbmV3IChHX09CSkVDVCAoaGVscGVyLT5odHRwKSwKKwkJCQkJICAgIGhlbHBlci0+Y2Fs bGJhY2ssIGhlbHBlci0+dXNlcl9kYXRhLAorCQkJCQkgICAgd2Via2l0X3NvdXBfcmVxdWVzdF9o dHRwX3NlbmRfYXN5bmMpOworCWdfc2ltcGxlX2FzeW5jX3Jlc3VsdF9zZXRfb3BfcmVzX2dwb2lu dGVyIChzaW1wbGUsIGhlbHBlci0+aHR0cHN0cmVhbSwgZ19vYmplY3RfdW5yZWYpOwogCi0JCS8q IFVwZGF0ZSBtZXNzYWdlIHN0YXR1cyAqLwotCQlzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyAoaGVs cGVyLT5odHRwLT5wcml2LT5tc2csIFNPVVBfU1RBVFVTX09LKTsKKwkvKiBVcGRhdGUgbWVzc2Fn ZSBzdGF0dXMgKi8KKwlzb3VwX21lc3NhZ2Vfc2V0X3N0YXR1cyAoaGVscGVyLT5odHRwLT5wcml2 LT5tc2csIFNPVVBfU1RBVFVTX09LKTsKIAotCQkvKiBJc3N1ZSBzaWduYWxzICAqLwotCQlzb3Vw X21lc3NhZ2VfZ290X2hlYWRlcnMgKGhlbHBlci0+aHR0cC0+cHJpdi0+bXNnKTsKKwkvKiBJc3N1 ZSBzaWduYWxzICAqLworCXNvdXBfbWVzc2FnZV9nb3RfaGVhZGVycyAoaGVscGVyLT5odHRwLT5w cml2LT5tc2cpOwogCi0JCS8qIEZJWE1FOiBVbmNvbW1lbnQgdGhpcyB3aGVuIHRoaXMgYmVjb21l cyBwYXJ0IG9mIGxpYnNvdXAKLQkJICogaWYgKCFzb3VwX21lc3NhZ2VfZGlzYWJsZXNfZmVhdHVy ZShoZWxwZXItPmh0dHAtPnByaXYtPm1zZywgU09VUF9UWVBFX0NPTlRFTlRfU05JRkZFUikpIHsK LQkJICoJY29uc3QgZ2NoYXIgKmNvbnRlbnRfdHlwZSA9IHNvdXBfbWVzc2FnZV9oZWFkZXJzX2dl dF9jb250ZW50X3R5cGUgKGhlbHBlci0+aHR0cC0+cHJpdi0+bXNnLT5yZXNwb25zZV9oZWFkZXJz LCBOVUxMKTsKLQkJICoJc291cF9tZXNzYWdlX2NvbnRlbnRfc25pZmZlZCAoaGVscGVyLT5odHRw LT5wcml2LT5tc2csIGNvbnRlbnRfdHlwZSwgTlVMTCk7Ci0JCSAqIH0KLQkJICovCi0JCWNvbnRl bnRfdHlwZSA9IHNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9jb250ZW50X3R5cGUgKGhlbHBlci0+ aHR0cC0+cHJpdi0+bXNnLT5yZXNwb25zZV9oZWFkZXJzLCBOVUxMKTsKLQkJc291cF9tZXNzYWdl X2NvbnRlbnRfc25pZmZlZCAoaGVscGVyLT5odHRwLT5wcml2LT5tc2csIGNvbnRlbnRfdHlwZSwg TlVMTCk7CisJLyogRklYTUU6IFVuY29tbWVudCB0aGlzIHdoZW4gdGhpcyBiZWNvbWVzIHBhcnQg b2YgbGlic291cAorCSAqIGlmICghc291cF9tZXNzYWdlX2Rpc2FibGVzX2ZlYXR1cmUoaGVscGVy LT5odHRwLT5wcml2LT5tc2csIFNPVVBfVFlQRV9DT05URU5UX1NOSUZGRVIpKSB7CisJICoJY29u c3QgZ2NoYXIgKmNvbnRlbnRfdHlwZSA9IHNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9jb250ZW50 X3R5cGUgKGhlbHBlci0+aHR0cC0+cHJpdi0+bXNnLT5yZXNwb25zZV9oZWFkZXJzLCBOVUxMKTsK KwkgKglzb3VwX21lc3NhZ2VfY29udGVudF9zbmlmZmVkIChoZWxwZXItPmh0dHAtPnByaXYtPm1z ZywgY29udGVudF90eXBlLCBOVUxMKTsKKwkgKiB9CisJICovCisJY29udGVudF90eXBlID0gc291 cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X2NvbnRlbnRfdHlwZSAoaGVscGVyLT5odHRwLT5wcml2LT5t c2ctPnJlc3BvbnNlX2hlYWRlcnMsIE5VTEwpOworCXNvdXBfbWVzc2FnZV9jb250ZW50X3NuaWZm ZWQgKGhlbHBlci0+aHR0cC0+cHJpdi0+bXNnLCBjb250ZW50X3R5cGUsIE5VTEwpOwogCi0JCWdf c2ltcGxlX2FzeW5jX3Jlc3VsdF9jb21wbGV0ZSAoc2ltcGxlKTsKKwlnX3NpbXBsZV9hc3luY19y ZXN1bHRfY29tcGxldGUgKHNpbXBsZSk7CiAKLQkJc291cF9tZXNzYWdlX2ZpbmlzaGVkIChoZWxw ZXItPmh0dHAtPnByaXYtPm1zZyk7CisJc291cF9tZXNzYWdlX2ZpbmlzaGVkIChoZWxwZXItPmh0 dHAtPnByaXYtPm1zZyk7CiAKLQkJZ19vYmplY3RfdW5yZWYgKHNpbXBsZSk7Ci0JfQorCWdfb2Jq ZWN0X3VucmVmIChzaW1wbGUpOwogCiAJZ19vYmplY3RfdW5yZWYgKGhlbHBlci0+aHR0cCk7CiAJ Z19zbGljZV9mcmVlIChTZW5kQXN5bmNIZWxwZXIsIGhlbHBlcik7CkBAIC0yNjUsMTcgKzI1NSwy OCBAQCB3ZWJraXRfc291cF9yZXF1ZXN0X2h0dHBfc2VuZF9hc3luYyAoV2ViS2l0U291cFJlcXVl c3QgICAgICAgICAgKnJlcXVlc3QsCiAKIAkJcmVzcG9uc2UgPSB3ZWJraXRfc291cF9jYWNoZV9o YXNfcmVzcG9uc2UgKGNhY2hlLCBodHRwLT5wcml2LT5tc2cpOwogCQlpZiAocmVzcG9uc2UgPT0g V0VCS0lUX1NPVVBfQ0FDSEVfUkVTUE9OU0VfRlJFU0gpIHsKLQkJCS8qIERvIHJldHVybiB0aGUg c3RyZWFtIGFzeW5jaHJvbm91c2x5IGFzIGluCi0JCQkgICB0aGUgb3RoZXIgY2FzZXMuIEl0J3Mg bm90IGVub3VnaCB0byB1c2UKLQkJCSAgIGdfc2ltcGxlX2FzeW5jX3Jlc3VsdF9jb21wbGV0ZV9p bl9pZGxlIGFzCi0JCQkgICB0aGUgc2lnbmFscyBtdXN0IGJlIGFsc28gZW1pdHRlZAotCQkJICAg YXN5bmNocm9ub3VzbHkgKi8KLQkJCVNlbmRBc3luY0hlbHBlciAqaGVscGVyID0gZ19zbGljZV9u ZXcgKFNlbmRBc3luY0hlbHBlcik7Ci0JCQloZWxwZXItPmh0dHAgPSBnX29iamVjdF9yZWYgKGh0 dHApOwotCQkJaGVscGVyLT5jYWxsYmFjayA9IGNhbGxiYWNrOwotCQkJaGVscGVyLT51c2VyX2Rh dGEgPSB1c2VyX2RhdGE7Ci0JCQlnX3RpbWVvdXRfYWRkICgwLCBzZW5kX2FzeW5jX2NiLCBoZWxw ZXIpOwotCQkJcmV0dXJuOworCQkJV2ViS2l0U291cEhUVFBJbnB1dFN0cmVhbSAqaHR0cHN0cmVh bTsKKworCQkJaHR0cHN0cmVhbSA9IChXZWJLaXRTb3VwSFRUUElucHV0U3RyZWFtICopCisJCQkJ d2Via2l0X3NvdXBfY2FjaGVfc2VuZF9yZXNwb25zZSAoY2FjaGUsIFNPVVBfTUVTU0FHRSAoaHR0 cC0+cHJpdi0+bXNnKSk7CisKKwkJCS8qIENhY2hlZCByZXNvdXJjZSBmaWxlIGNvdWxkIGhhdmUg YmVlbiBkZWxldGVkIG91dHNpZGUKKwkJCSAqLworCQkJaWYgKGh0dHBzdHJlYW0pIHsKKwkJCQkv KiBEbyByZXR1cm4gdGhlIHN0cmVhbSBhc3luY2hyb25vdXNseSBhcyBpbgorCQkJCSAqIHRoZSBv dGhlciBjYXNlcy4gSXQncyBub3QgZW5vdWdoIHRvIHVzZQorCQkJCSAqIGdfc2ltcGxlX2FzeW5j X3Jlc3VsdF9jb21wbGV0ZV9pbl9pZGxlIGFzCisJCQkJICogdGhlIHNpZ25hbHMgbXVzdCBiZSBh bHNvIGVtaXR0ZWQKKwkJCQkgKiBhc3luY2hyb25vdXNseQorCQkJCSAqLworCQkJCVNlbmRBc3lu Y0hlbHBlciAqaGVscGVyID0gZ19zbGljZV9uZXcgKFNlbmRBc3luY0hlbHBlcik7CisJCQkJaGVs cGVyLT5odHRwID0gZ19vYmplY3RfcmVmIChodHRwKTsKKwkJCQloZWxwZXItPmNhbGxiYWNrID0g Y2FsbGJhY2s7CisJCQkJaGVscGVyLT51c2VyX2RhdGEgPSB1c2VyX2RhdGE7CisJCQkJaGVscGVy LT5odHRwc3RyZWFtID0gaHR0cHN0cmVhbTsKKwkJCQlnX3RpbWVvdXRfYWRkICgwLCBzZW5kX2Fz eW5jX2NiLCBoZWxwZXIpOworCQkJCXJldHVybjsKKwkJCX0KIAkJfSBlbHNlIGlmIChyZXNwb25z ZSA9PSBXRUJLSVRfU09VUF9DQUNIRV9SRVNQT05TRV9ORUVEU19WQUxJREFUSU9OKSB7CiAJCQlT b3VwTWVzc2FnZSAqY29uZGl0aW9uYWxfbXNnOwogCQkJQ29uZGl0aW9uYWxIZWxwZXIgKmhlbHBl cjsK