50541 2010-12-05 11:30:27 -0800 [GTK] using shadows leaks memory 2010-12-06 08:02:35 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED http://droppy.lophus.org/cvDCE-index.html P2 Major --- 0 kris.kleine webkit-unassigned alex sbillaudelle oldest_to_newest 317397 0 75634 kris.kleine 2010-12-05 11:30:27 -0800 Created attachment 75634 archive with some example apps to reproduce the bug WebkitGtk seems to leak memory when using css shadows. On my machine with webkit-nightly (72146) it leaks about 0.3 Mb/s when doing some moderate clicking on the element in the example. To reproduce do: 1) Load the url (http://droppy.lophus.org/cvDCE-index.html) in Epiphany and click or hover the element and watch the memory increase. 2) see the attached examples (./build.sh to compile and ./example or python example.py to run). The symptoms are the same here, when clicking or hovering. 317398 1 sbillaudelle 2010-12-05 11:40:17 -0800 Same for me here! With Midori, Epiphany and the examples attached by Krisoffer. 317605 2 75690 alex 2010-12-06 07:13:58 -0800 Created attachment 75690 Proposed patch Thanks for reporting, I've fixed the two leaks in the shadows code found with valgrind. 317615 3 75690 mrobinson 2010-12-06 07:40:23 -0800 Comment on attachment 75690 Proposed patch Awesome. Thanks! 317629 4 alex 2010-12-06 08:02:35 -0800 landed http://trac.webkit.org/changeset/73367 75634 2010-12-05 11:30:27 -0800 2010-12-05 11:30:27 -0800 archive with some example apps to reproduce the bug example.tar.bz2 application/x-bzip 1397 kris.kleine QlpoOTFBWSZTWcLWFXAABQt/nczUAER6////Ds/F6v///+oAAIACAACABAAIUAWPFTma1VYFaalr FsJJEaaAQAVP2qemmmk2IU9MoaaZpGg0e0ptQ009I9Q4aGTTQ0yNDTIyDIyNDIDE0ZNAGTIxDCRI TVPFT8k1D9KeoBoaAA0GTTQAD1NANA0OGhk00NMjQ0yMgyMjQyAxNGTQBkyMQwkRCE0amET1Mp4o 9MU8U8oGRkGQ9TaQGg0NMjy8Edvy7vfd5lraeyihDDhgGehINXHyNyREM9pyVy1SOXXKNoYCGNiG CICECbQdev1+9J1eunXVNOFCN6fTM3GxX2gqe7fYMK1Lohl1ICJbhVICAoQnDjoQihRer0xUeGQI 0oaQC+KGQCCRJIGQb6+urBf/bFajxEEVMkLbYEsgd6BVTsJpgqAwUJgoABjCazBRSC7yhvFzd2fX etle/wpbNkg/wO9p/HFPHHfWCiX25aITsKa0ZqKZ8aERzrJCNc8ad2DURn36HHWez1vknLXH0WJf 8SaRWX82e4+PdZfnc5RPXpyUvqwRU2K1kogjg4G28Cc/wY11tjTMw3o0M9G08GRVPaOU+8xQRKRM Lr7bsM1hddx3BwZ7PfOiRB5U6o8KDUQQmsRoIJIFACkgBlFs9xXKpgZNJHZrlf419pf0qfKr1t78 JC1SmFZdFfam5LpJq1F7BE9UA8zzioentu326/Rj3zXorJEuOWC31duAcgjjSO05jn4S1QYfXS+J DoCopBQoSLGI54JiNR8d/7bqSoIrCM0hEozKcDIR3d0CRNTpXd3F+KMYvGEIxvQORFCTKEK0Y2mm mmJgqGRQlvUFoUNa1bXst4qlwCsCmyrHJJGLsWoQT3yAofKVRZFDMsCZc0MajSxlgKjrdBRkZ2CC 1OlLagqjAWotaNKUli8kx0IYhosQab1BZZZQQxuf19ba/OsK5uXlphJB3VKemcXQ2/c7IyDc+U5+ qP25tbfe6d7me5fdhFh7cY6NkrU4+qMOxuaWUkhL8J/R07Ho/JlfNbvsymTgSDjg39d8ZiBSiH8Z /j+CMOzQOpno2ttIEUZiceVoeaH2pCokcHsrJMm3cHavcLWrSm02oBxMWIgqlQT4D4VXqFBBP0Zv kUg5IXuDmrYkQfNa/xkh9a978/Ow+oP3ZwY+ppyBM+NZNom0mO4JTKy4qLuOyZQU+NJ2ZWUr8FoD j9RxSHBwEIOJ0ao+MzL+w5kEGrZqc3CIuxFxUTaU1ljOxasJWqEBrYjNOWjAQV11/TcS4f9t8Oc2 b3kSagOhcoFivGa8AwS6L0KYQoHRgvvx1swDLwxbJNLdMCyXpcTE9NTtPAxlTGhaT5jC6PPsctxu bnOVyvnPuVayqy7JxndwGYZhhhmMsDDcI7OTe5XAH+klN8vLOND8DEdhAbUHMjSjsRiGFmWDY0Vt oXtYSaofKLcitenlVJVqMLLAT6HHXctvVuI6mh0QGlZuF6hyQ2wganHQEoMxoIC8YXLvQASPBBQf 851sXt2mS4ahEhsM/I7351blGiH+06RMRUhUZqimijJI0i0GE+k0Aji2t+YvaIGLVC3yRDTGxMTT TG2hgtUy/HAu0oZk2lydfvLpV/GPxTGTskqEiUUoQ3COSvqTVBUpZ4L7KWEZK4ioWmnPiaFABlrW fSoMFSpxTY5XCNebYdHyat0om0JrPnZjVyENgNj6SPfm6Rw1rFMniMtxBs8EZbmjeO1jbbMTnEbq 3xcJeWS0IGCQzx2rKZ/JYbgswF7l9TZPJHdSELmNRNcn1GeXIGFcgo022G7bJFTITJ45AhFFVQu7 AwaB0sSU+GwzdCapbnX9wNCP/F3JFOFCQwtYVcA= 75690 2010-12-06 07:13:58 -0800 2010-12-06 07:40:22 -0800 Proposed patch leak_shadow.patch text/plain 2934 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjA4OGQ5Yi4uOTk0YmM2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMi0wNiAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1c2luZyBzaGFkb3dzIGxlYWtzIG1lbW9yeQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA1NDEKKworICAg ICAgICBGaXhlZCBsZWFrcyBpbiB0aGUgc2hhZG93IGNvZGUuCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vQ2Fpcm9VdGlsaXRpZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZHJh d1BhdHRlcm5Ub0NhaXJvQ29udGV4dCk6IGFkb3B0UmVmIGluc3RlYWQgb2YganVzdAorICAgICAg ICBnZXR0aW5nIGEgbmV3IHJlZmVyZW5jZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkcmF3UGF0 aFNoYWRvdyk6IGhhbmRsZSBjYWlyb19wYXRoX3Qgd2l0aCBzbWFydAorICAgICAgICBwb2ludGVy cy4KKwogMjAxMC0xMi0wNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gUnVuIHNvcnQtWGNvZGUtcHJvamVjdC1maWxlLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9DYWlyb1V0aWxpdGllcy5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0NhaXJvVXRpbGl0aWVzLmNwcAppbmRleCA3 MDllZThmLi4wMTNhNGFmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0NhaXJvVXRpbGl0aWVzLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0NhaXJvVXRpbGl0aWVzLmNwcApAQCAtMTMwLDcgKzEzMCw3IEBAIHZvaWQgZHJhd1BhdHRl cm5Ub0NhaXJvQ29udGV4dChjYWlyb190KiBjciwgY2Fpcm9fc3VyZmFjZV90KiBpbWFnZSwgY29u c3QgSW50U2l6CiAgICAgaWYgKHRpbGVSZWN0LnNpemUoKSAhPSBpbWFnZVNpemUpIHsKICAgICAg ICAgSW50UmVjdCBpbWFnZVJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KHRpbGVSZWN0KTsKICAgICAg ICAgY2xpcHBlZEltYWdlU3VyZmFjZSA9IGFkb3B0UmVmKGNhaXJvX2ltYWdlX3N1cmZhY2VfY3Jl YXRlKENBSVJPX0ZPUk1BVF9BUkdCMzIsIGltYWdlUmVjdC53aWR0aCgpLCBpbWFnZVJlY3QuaGVp Z2h0KCkpKTsKLSAgICAgICAgUmVmUHRyPGNhaXJvX3Q+IGNsaXBwZWRJbWFnZUNvbnRleHQoY2Fp cm9fY3JlYXRlKGNsaXBwZWRJbWFnZVN1cmZhY2UuZ2V0KCkpKTsKKyAgICAgICAgUmVmUHRyPGNh aXJvX3Q+IGNsaXBwZWRJbWFnZUNvbnRleHQgPSBhZG9wdFJlZihjYWlyb19jcmVhdGUoY2xpcHBl ZEltYWdlU3VyZmFjZS5nZXQoKSkpOwogICAgICAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2Uo Y2xpcHBlZEltYWdlQ29udGV4dC5nZXQoKSwgaW1hZ2UsIC10aWxlUmVjdC54KCksIC10aWxlUmVj dC55KCkpOwogICAgICAgICBjYWlyb19wYWludChjbGlwcGVkSW1hZ2VDb250ZXh0LmdldCgpKTsK ICAgICAgICAgaW1hZ2UgPSBjbGlwcGVkSW1hZ2VTdXJmYWNlLmdldCgpOwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNw cAppbmRleCA2YmI3NjMzLi5lNGZmODJmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcApAQCAtMTQ0LDcgKzE0 NCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBkcmF3UGF0aFNoYWRvdyhHcmFwaGljc0NvbnRleHQq IGNvbnRleHQsIEdyYXBoaWNzQ29udGV4dFByaXZhCiAKICAgICAvLyBDYWxjdWxhdGUgdGhlIGV4 dGVudHMgb2YgdGhlIHJlbmRlcmVkIHNvbGlkIHBhdGhzLgogICAgIGNhaXJvX3QqIGNhaXJvQ29u dGV4dCA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpOwotICAgIGNhaXJvX3BhdGhfdCogcGF0 aCA9IGNhaXJvX2NvcHlfcGF0aChjYWlyb0NvbnRleHQpOworICAgIE93blB0cjxjYWlyb19wYXRo X3Q+IHBhdGgoY2Fpcm9fY29weV9wYXRoKGNhaXJvQ29udGV4dCkpOwogCiAgICAgRmxvYXRSZWN0 IHNvbGlkRmlndXJlRXh0ZW50czsKICAgICBkb3VibGUgeDAgPSAwOwpAQCAtMTY4LDcgKzE2OCw3 IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBkcmF3UGF0aFNoYWRvdyhHcmFwaGljc0NvbnRleHQqIGNv bnRleHQsIEdyYXBoaWNzQ29udGV4dFByaXZhCiAgICAgLy8gSXQncyBpbXBvcnRhbnQgdG8gY29w eSB0aGUgY29udGV4dCBwcm9wZXJ0aWVzIHRvIHRoZSBuZXcgc2hhZG93CiAgICAgLy8gY29udGV4 dCB0byBwcmVzZXJ2ZSB0aGluZ3Mgc3VjaCBhcyB0aGUgZmlsbCBydWxlIGFuZCBzdHJva2Ugd2lk dGguCiAgICAgY29weUNvbnRleHRQcm9wZXJ0aWVzKGNhaXJvQ29udGV4dCwgc2hhZG93Q29udGV4 dCk7Ci0gICAgY2Fpcm9fYXBwZW5kX3BhdGgoc2hhZG93Q29udGV4dCwgcGF0aCk7CisgICAgY2Fp cm9fYXBwZW5kX3BhdGgoc2hhZG93Q29udGV4dCwgcGF0aC5nZXQoKSk7CiAKICAgICBpZiAoZHJh d2luZ1N0eWxlICYgRmlsbCkKICAgICAgICAgc2V0UGxhdGZvcm1GaWxsKGNvbnRleHQsIHNoYWRv d0NvbnRleHQsIGNvbnRleHRQcml2YXRlKTsK