50540 2010-12-05 10:52:49 -0800 MathML: update baselinePosition() call in RenderMathMLBlock.cpp 2010-12-10 02:17:24 -0800 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 0 sausset webkit-unassigned commit-queue oldest_to_newest 317393 0 sausset 2010-12-05 10:52:49 -0800 The call of baselinePosition() is outdated: new arguments should be added. 317394 1 75633 sausset 2010-12-05 10:59:17 -0800 Created attachment 75633 Patch 317551 2 75633 ossy 2010-12-06 04:27:50 -0800 Comment on attachment 75633 Patch You shouldn't add your own copyright entry for a one line change. Adding copyright entry needs more than 10 (significant) line change. 317563 3 75676 sausset 2010-12-06 04:51:57 -0800 Created attachment 75676 Revised patch Remove the copyright. 319989 4 75676 eric 2010-12-10 00:06:34 -0800 Comment on attachment 75676 Revised patch OK. 320036 5 75676 commit-queue 2010-12-10 02:17:19 -0800 Comment on attachment 75676 Revised patch Clearing flags on attachment: 75676 Committed r73698: <http://trac.webkit.org/changeset/73698> 320037 6 commit-queue 2010-12-10 02:17:24 -0800 All reviewed patches have been landed. Closing bug. 75633 2010-12-05 10:59:17 -0800 2010-12-06 04:51:57 -0800 Patch MathML_Block-paint.patch text/plain 1603 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzM0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMDUgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWF0aE1MOiB1cGRhdGUgYmFzZWxpbmVQb3NpdGlvbigpIGNhbGwgaW4gUmVuZGVyTWF0aE1M QmxvY2suY3BwIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTA1NDAKKworICAgICAgICBUaGUgY2FsbCBvZiBiYXNlbGluZVBvc2l0aW9uKCkgaXMgb3V0 ZGF0ZWQ6IG5ldyBhcmd1bWVudHMgYWRkZWQuCisKKyAgICAgICAgKiBtYXRobWwvUmVuZGVyTWF0 aE1MQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTWF0aE1MQmxvY2s6OnBhaW50 KToKKwogMjAxMC0xMi0wNSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBXZWJDb3JlL21h dGhtbC9SZW5kZXJNYXRoTUxCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYXRobWwv UmVuZGVyTWF0aE1MQmxvY2suY3BwCShyZXZpc2lvbiA3MzI2MykKKysrIFdlYkNvcmUvbWF0aG1s L1JlbmRlck1hdGhNTEJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDYgQEAKIC8q CiAgKiBDb3B5cmlnaHQgKEMpIDIwMDkgQWxleCBNaWxvd3NraSAoYWxleEBtaWxvd3NraS5jb20p LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEwIEZyYW7Dp29pcyBT YXVzc2V0IChzYXVzc2V0QGdtYWlsLmNvbSkuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICog UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEwMiw3ICsxMDMsNyBAQCB2b2lkIFJlbmRlck1h dGhNTEJsb2NrOjpwYWludChQYWludEluZm8mCiAgICAgCiAgICAgaW5mby5jb250ZXh0LT5kcmF3 TGluZShJbnRQb2ludCh0eCwgdHkgKyB0b3BTdGFydCksIEludFBvaW50KHR4ICsgb2Zmc2V0V2lk dGgoKSwgdHkgKyB0b3BTdGFydCkpOwogICAgIAotICAgIGludCBiYXNlbGluZSA9IGJhc2VsaW5l UG9zaXRpb24odHJ1ZSk7CisgICAgaW50IGJhc2VsaW5lID0gYmFzZWxpbmVQb3NpdGlvbihBbHBo YWJldGljQmFzZWxpbmUsIHRydWUsIEhvcml6b250YWxMaW5lKTsKICAgICAKICAgICBpbmZvLmNv bnRleHQtPnNldFN0cm9rZUNvbG9yKENvbG9yKDI1NSwgMCwgMCksIENvbG9yU3BhY2VTUkdCKTsK ICAgICAKCg== 75676 2010-12-06 04:51:57 -0800 2010-12-10 02:17:19 -0800 Revised patch MathML_Block-paint.patch text/plain 1274 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzM0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMDYgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWF0aE1MOiB1cGRhdGUgYmFzZWxpbmVQb3NpdGlvbigpIGNhbGwgaW4gUmVuZGVyTWF0aE1M QmxvY2suY3BwIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTA1NDAKKworICAgICAgICBUaGUgY2FsbCBvZiBiYXNlbGluZVBvc2l0aW9uKCkgaXMgb3V0 ZGF0ZWQ6IG5ldyBhcmd1bWVudHMgYWRkZWQuCisKKyAgICAgICAgKiBtYXRobWwvUmVuZGVyTWF0 aE1MQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTWF0aE1MQmxvY2s6OnBhaW50 KToKKwogMjAxMC0xMi0wNSAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCkluZGV4OiBXZWJDb3JlL21h dGhtbC9SZW5kZXJNYXRoTUxCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYXRobWwv UmVuZGVyTWF0aE1MQmxvY2suY3BwCShyZXZpc2lvbiA3MzI2MykKKysrIFdlYkNvcmUvbWF0aG1s L1JlbmRlck1hdGhNTEJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAyLDcgKzEwMiw3IEBA IHZvaWQgUmVuZGVyTWF0aE1MQmxvY2s6OnBhaW50KFBhaW50SW5mbyYKICAgICAKICAgICBpbmZv LmNvbnRleHQtPmRyYXdMaW5lKEludFBvaW50KHR4LCB0eSArIHRvcFN0YXJ0KSwgSW50UG9pbnQo dHggKyBvZmZzZXRXaWR0aCgpLCB0eSArIHRvcFN0YXJ0KSk7CiAgICAgCi0gICAgaW50IGJhc2Vs aW5lID0gYmFzZWxpbmVQb3NpdGlvbih0cnVlKTsKKyAgICBpbnQgYmFzZWxpbmUgPSBiYXNlbGlu ZVBvc2l0aW9uKEFscGhhYmV0aWNCYXNlbGluZSwgdHJ1ZSwgSG9yaXpvbnRhbExpbmUpOwogICAg IAogICAgIGluZm8uY29udGV4dC0+c2V0U3Ryb2tlQ29sb3IoQ29sb3IoMjU1LCAwLCAwKSwgQ29s b3JTcGFjZVNSR0IpOwogICAgIAo=