50539 2010-12-05 09:45:15 -0800 [Qt] Report zero width for zero size fonts 2010-12-06 11:26:36 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 robert webkit-qt-unassigned kling ossy oldest_to_newest 317389 0 robert 2010-12-05 09:45:15 -0800 . 317391 1 75632 robert 2010-12-05 09:55:25 -0800 Created attachment 75632 Patch 317411 2 75632 kenneth 2010-12-05 14:03:34 -0800 Comment on attachment 75632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75632&action=review pls fix before landing > WebCore/platform/graphics/qt/FontQt.cpp:266 > + return 0.0f; this should be 0 according to the style guide > WebCore/platform/graphics/qt/FontQt.cpp:291 > + return 0.0f; here as well 317501 3 75632 ossy 2010-12-06 02:26:28 -0800 Comment on attachment 75632 Patch Fixed patch landed in http://trac.webkit.org/changeset/73352 317742 4 robert 2010-12-06 11:26:36 -0800 Andreas/Kenneth, Is there a bit of a disconnect between Font::drawTextCommon and the actual size of the font (according to webkit)? It uses FontMetrics which may not be appropriate in the case of zero-sized fonts. I suspect QtWebKit is rendering the font full-sized rather than 'no-sized' because of this. What do you think? 75632 2010-12-05 09:55:25 -0800 2010-12-06 02:26:28 -0800 Patch bug-50539-20101205175524.patch text/plain 1846 robert ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTYwMTE2MTM0M2E2MzkxMzc2M2JmZjhjZGEyYTU1ZDMzMmJjM2FlMi4uYWUwZjI5YzUyZTE2NGQw MjFjN2NmNzA0MTcyMjA1NDM2OTRkMWIwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0xMi0wNSAgUm9i ZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZXBvcnQgemVybyB3aWR0aCBmb3IgemVybyBz aXplIGZvbnRzCisKKyAgICAgICAgUmVwb3J0IHplcm8gd2lkdGggd2hlbiBmb250IHNpemUgaXMg emVyby4KKworICAgICAgICBGaXhlcyBmYXN0L3RleHQvZm9udC1zaXplLXplcm8uaHRtbAorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDUzOQorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZvbnQ6OmZsb2F0V2lkdGhGb3JTaW1wbGVUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OkZv bnQ6OmZsb2F0V2lkdGhGb3JDb21wbGV4VGV4dCk6CisKKzIwMTAtMTItMDUgIFJvYmVydCBIb2dh biAgPHJvYmVydEB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xp bmcuCiAKICAgICAgICAgW1F0XSBaZXJvLXNpemVkIGZvbnQgZG9lcyBub3QgeWV0IHdvcmsKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcCBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFF0LmNwcAppbmRleCAxZWUyYjI5M2EzYTNjZGIz MzhlZjEwMjUyYzUxMDA4YjIyY2RkMzhkLi5jMmZkMzlmNDQ4YTEwZWI4MzZiM2QyMzZkNzg5MTc0 MGIyZmY3MGU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRR dC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UXQuY3BwCkBAIC0y NjIsNiArMjYyLDkgQEAgdm9pZCBGb250OjpkcmF3Q29tcGxleFRleHQoR3JhcGhpY3NDb250ZXh0 KiBjdHgsIGNvbnN0IFRleHRSdW4mIHJ1biwgY29uc3QgRmxvYXQKIAogZmxvYXQgRm9udDo6Zmxv YXRXaWR0aEZvclNpbXBsZVRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBHbHlwaEJ1ZmZlciogZ2x5 cGhCdWZmZXIsIEhhc2hTZXQ8Y29uc3QgU2ltcGxlRm9udERhdGEqPiogZmFsbGJhY2tGb250cywg R2x5cGhPdmVyZmxvdyogZ2x5cGhPdmVyZmxvdykgY29uc3QKIHsKKyAgICBpZiAoIXByaW1hcnlG b250KCktPnBsYXRmb3JtRGF0YSgpLnNpemUoKSkKKyAgICAgICAgcmV0dXJuIDAuMGY7CisKICNp ZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNywgMCkKICAgICBpZiAoIXJ1bi5s ZW5ndGgoKSkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0yODQsNiArMjg3LDkgQEAgZmxvYXQgRm9u dDo6ZmxvYXRXaWR0aEZvclNpbXBsZVRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBHbHlwaEJ1ZmZl ciogZ2x5cGhCdWZmZXIKIAogZmxvYXQgRm9udDo6ZmxvYXRXaWR0aEZvckNvbXBsZXhUZXh0KGNv bnN0IFRleHRSdW4mIHJ1biwgSGFzaFNldDxjb25zdCBTaW1wbGVGb250RGF0YSo+KiwgR2x5cGhP dmVyZmxvdyopIGNvbnN0CiB7CisgICAgaWYgKCFwcmltYXJ5Rm9udCgpLT5wbGF0Zm9ybURhdGEo KS5zaXplKCkpCisgICAgICAgIHJldHVybiAwLjBmOworCiAgICAgaWYgKCFydW4ubGVuZ3RoKCkp CiAgICAgICAgIHJldHVybiAwOwogCg==