50523 2010-12-04 12:43:10 -0800 [WINCE] Adds a build slave. 2011-01-03 13:51:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 51642 1 paroga paroga eric wsiegrist oldest_to_newest 317304 0 paroga 2010-12-04 12:43:10 -0800 see patch 317305 1 75614 paroga 2010-12-04 12:58:02 -0800 Created attachment 75614 Patch 320779 2 eric 2010-12-12 02:31:27 -0800 _wms should "review" this. 321081 3 75614 ossy 2010-12-13 06:13:22 -0800 Comment on attachment 75614 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83 > def appendCustomBuildFlags(step, platform): > - if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'): > + if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'): > step.setCommand(step.command + ['--' + platform]) It would pass --wince option to the build-webkit script. But I can't find if build-webkit handles wince option. 321082 4 paroga 2010-12-13 06:17:30 -0800 (In reply to comment #3) > (From update of attachment 75614 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=75614&action=review > > > WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg:83 > > def appendCustomBuildFlags(step, platform): > > - if platform in ('gtk', 'wx', 'qt', 'chromium', 'wincairo', 'efl'): > > + if platform in ('chromium', 'efl', 'gtk', 'qt', 'wincairo', 'wince', 'wx'): > > step.setCommand(step.command + ['--' + platform]) > > It would pass --wince option to the build-webkit script. > But I can't find if build-webkit handles wince option. I didn't added the --wince option to build-webkit (I need to take care of the EFL port, which uses CMake too). 328698 5 75614 ddkilzer 2011-01-03 12:01:18 -0800 Comment on attachment 75614 Patch r=me I'll let Patrick set the cq+ flag since this depends on Bug 51642 landing first. 328726 6 75614 paroga 2011-01-03 13:11:25 -0800 Comment on attachment 75614 Patch Clearing flags on attachment: 75614 Manually committed r74930: <http://trac.webkit.org/changeset/74930> 328727 7 paroga 2011-01-03 13:11:52 -0800 All reviewed patches have been landed. Closing bug. 328768 8 wsiegrist 2011-01-03 13:51:32 -0800 Buildbot updated. 75614 2010-12-04 12:58:02 -0800 2011-01-03 13:11:25 -0800 Patch bug-50523.patch text/plain 3523 paroga ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL2NvbmZpZy5qc29uIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KaW5kZXggZDQ2YjE0MC4uNDMzNjI2NCAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvY29uZmlnLmpzb24KKysrIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KQEAgLTU2LDYgKzU2LDggQEAKICAg ICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJnb29nbGUtbmV3LXRlc3RzIiwgInBsYXRmb3Jt IjogIm1hYy1sZW9wYXJkIiB9LAogCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAid2lu Y2Fpcm8tMSIsICJwbGF0Zm9ybSI6ICJ3aW5jYWlybyIgfSwKKworICAgICAgICAgICAgICAgICAg ICB7ICJuYW1lIjogIndpbmNlLTEiLCAicGxhdGZvcm0iOiAid2luY2UiIH0sCiAgICAgICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImVmbC1saW51eC1zbGF2 ZS0xIiwgInBsYXRmb3JtIjogImVmbCIgfQogICAgICAgICAgICAgICAgICAgXSwKQEAgLTIxMyw2 ICsyMTUsMTEgQEAKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsid2luY2Fp cm8tMSJdCiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsKKyAg ICAgICAgICAgICAgICAgICAgICAibmFtZSI6ICJXaW5DRSBSZWxlYXNlIChCdWlsZCkiLCAidHlw ZSI6ICJCdWlsZCIsICJidWlsZGRpciI6ICJ3aW5jZS1yZWxlYXNlIiwKKyAgICAgICAgICAgICAg ICAgICAgICAicGxhdGZvcm0iOiAid2luY2UiLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwg ImFyY2hpdGVjdHVyZXMiOiBbImkzODYiXSwKKyAgICAgICAgICAgICAgICAgICAgICAic2xhdmVu YW1lcyI6IFsid2luY2UtMSJdCisgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAg ICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgICAibmFtZSI6ICJFRkwgTGludXggUmVsZWFz ZSAoQnVpbGQpIiwgInR5cGUiOiAiQnVpbGQiLCAiYnVpbGRkaXIiOiAiZWZsLWxpbnV4LXJlbGVh c2UiLAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJlZmwiLCAiY29uZmlndXJh dGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbImkzODYiXSwKICAgICAgICAgICAg ICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsiZWZsLWxpbnV4LXNsYXZlLTEiXQpAQCAtMjI3LDcg KzIzNCw3IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiUXQgV2lu ZG93cyAzMi1iaXQgUmVsZWFzZSIsICJRdCBXaW5kb3dzIDMyLWJpdCBEZWJ1ZyIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiQ2hyb21pdW0gV2luIFJlbGVhc2UiLCAi Q2hyb21pdW0gTWFjIFJlbGVhc2UiLCAiQ2hyb21pdW0gTGludXggUmVsZWFzZSIsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiQ2hyb21pdW0gV2luIFJlbGVhc2UgKFRl c3RzKSIsICJDaHJvbWl1bSBNYWMgUmVsZWFzZSAoVGVzdHMpIiwgIkNocm9taXVtIExpbnV4IFJl bGVhc2UgKFRlc3RzKSIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi V2luQ2Fpcm8gRGVidWcgKEJ1aWxkKSIsICJFRkwgTGludXggUmVsZWFzZSAoQnVpbGQpIl0KKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJXaW5DYWlybyBEZWJ1ZyAoQnVp bGQpIiwgIldpbkNFIFJlbGVhc2UgKEJ1aWxkKSIsICJFRkwgTGludXggUmVsZWFzZSAoQnVpbGQp Il0KICAgICAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICAgICAgeyAidHlwZSI6 ICJQbGF0Zm9ybVNwZWNpZmljU2NoZWR1bGVyIiwgInBsYXRmb3JtIjogIndpbiIsICJicmFuY2gi OiAidHJ1bmsiLCAidHJlZVN0YWJsZVRpbWVyIjogNDUuMCwKICAgICAgICAgICAgICAgICAgICAg ICAiYnVpbGRlck5hbWVzIjogWyJXaW5kb3dzIFJlbGVhc2UgKEJ1aWxkKSIsICJXaW5kb3dzIERl YnVnIChCdWlsZCkiXQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZyBiL1dlYktpdFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKaW5kZXggYzI4YWJi Ni4uOTA5NjljNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZworKysgYi9XZWJLaXRUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCkBAIC03OSw3ICs3 OSw3IEBAIGNsYXNzIENsZWFudXBDaHJvbWl1bUxpbnV4Q3Jhc2hMb2dzKHNoZWxsLlNoZWxsQ29t bWFuZCk6CiAKIAogZGVmIGFwcGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc3RlcCwgcGxhdGZvcm0pOgot ICAgIGlmIHBsYXRmb3JtIGluICgnZ3RrJywgJ3d4JywgJ3F0JywgJ2Nocm9taXVtJywgJ3dpbmNh aXJvJywgJ2VmbCcpOgorICAgIGlmIHBsYXRmb3JtIGluICgnY2hyb21pdW0nLCAnZWZsJywgJ2d0 aycsICdxdCcsICd3aW5jYWlybycsICd3aW5jZScsICd3eCcpOgogICAgICAgICBzdGVwLnNldENv bW1hbmQoc3RlcC5jb21tYW5kICsgWyctLScgKyBwbGF0Zm9ybV0pCiAKIApkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IDg1MWU5 Y2UuLmE0YzgxMjQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0wNCAgUGF0cmljayBH YW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIEFkZHMgYSBidWlsZCBzbGF2ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNTIzCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNv bjogQWRkIGFuCisgICAgICAgIGVudHJ5IGZvciBhIHJlbGVhc2UgYnVpbGQgb2YgdGhlIFdpbkNF IHBvcnQuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZzogQWRkIHBsYXRmb3JtCisgICAgICAgIGZsYWcgdG8gYnVpbGQgdGhlIFdp bkNFIHBvcnQuCisKIDIwMTAtMTItMDQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCg==