50512 2010-12-03 21:10:00 -0800 API Documentation referencing depreciated GTK_WIDGET_TOPLEVEL 2010-12-06 03:23:23 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 djw8605 webkit-unassigned djw8605 mrobinson oldest_to_newest 317225 0 djw8605 2010-12-03 21:10:00 -0800 On the API page describing WebKitWebView (http://webkitgtk.org/reference/webkitgtk-webkitwebview.html) in the API reference, an example uses the depreciated GTK_WIDGET_TOPLEVEL. https://bugs.webkit.org/show_bug.cgi?id=33486 fixed the bug, but not the in-code documentation. 317226 1 75594 djw8605 2010-12-03 21:14:56 -0800 Created attachment 75594 Proposed Patch 317227 2 75595 djw8605 2010-12-03 21:19:58 -0800 Created attachment 75595 Proposed Patch Updated patch with bug link. 317332 3 mrobinson 2010-12-04 18:55:59 -0800 Seems reasonable to me, but do you mind attaching a ChangeLog to your patch? See here: http://webkit.org/coding/contributing.html 317345 4 75625 djw8605 2010-12-04 21:32:33 -0800 Created attachment 75625 Proposed Patch Proposed patch with ChangeLog. 317507 5 75625 mrobinson 2010-12-06 02:51:52 -0800 Comment on attachment 75625 Proposed Patch Thanks! 317520 6 mrobinson 2010-12-06 03:23:23 -0800 Committed r73354: <http://trac.webkit.org/changeset/73354> 75594 2010-12-03 21:14:56 -0800 2010-12-03 21:19:58 -0800 Proposed Patch 0001-Change-the-documentation-to-replace-the-depreciated-.patch text/plain 922 djw8605 RnJvbSAxZmM0MjU1OWM2NDkxNTQ3M2I0YmRhMWVjOGI1MDVmMGI0OTU4M2M0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZb3VyIE5hbWUgPHlvdUBleGFtcGxlLmNvbT4KRGF0ZTogRnJp LCAzIERlYyAyMDEwIDIzOjExOjI3IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gQ2hhbmdlIHRoZSBk b2N1bWVudGF0aW9uIHRvIHJlcGxhY2UgdGhlIGRlcHJlY2lhdGVkIEdUS19XSURHRVRfVE9QTEVW RUwgd2l0aCBHVEtfV0lORE9XX1RPUExFVkVMCgotLS0KIFdlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwIHwgICAgMiArLQogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi dmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAwZGIz MmQ4Li5lNGFhYzU3IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTAzLDcg KzEwMyw3IEBACiAgKgogICogPHByb2dyYW1saXN0aW5nPgogICogLzwhLS0gLS0+KiBDcmVhdGUg dGhlIHdpZGdldHMgKjwhLS0gLS0+LwotICogR3RrV2lkZ2V0ICptYWluX3dpbmRvdyA9IGd0a193 aW5kb3dfbmV3IChHVEtfV0lER0VUX1RPUExFVkVMKTsKKyAqIEd0a1dpZGdldCAqbWFpbl93aW5k b3cgPSBndGtfd2luZG93X25ldyAoR1RLX1dJTkRPV19UT1BMRVZFTCk7CiAgKiBHdGtXaWRnZXQg KnNjcm9sbGVkX3dpbmRvdyA9IGd0a19zY3JvbGxlZF93aW5kb3dfbmV3IChOVUxMLCBOVUxMKTsK ICAqIEd0a1dpZGdldCAqd2ViX3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3ICgpOwogICoKLS0g CjEuNy4zLjIKCg== 75595 2010-12-03 21:19:58 -0800 2010-12-04 21:32:33 -0800 Proposed Patch 0001-Change-the-documentation-to-replace-the-depreciated-.patch text/plain 928 djw8605 RnJvbSAxMjlmNTA5ZjJlMGJhOTRjZDQyMTU2MThjNmNjYmM3Y2Y4YjBjNGI1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEZXJlayBXZWl0emVsIDxkanc4NjA1QGdtYWlsLmNvbT4KRGF0 ZTogRnJpLCAzIERlYyAyMDEwIDIzOjExOjI3IC0wNjAwClN1YmplY3Q6IFtQQVRDSF0gQ2hhbmdl IHRoZSBkb2N1bWVudGF0aW9uIHRvIHJlcGxhY2UgdGhlIGRlcHJlY2lhdGVkIEdUS19XSURHRVRf VE9QTEVWRUwgd2l0aCBHVEtfV0lORE9XX1RPUExFVkVMCgotLS0KIFdlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXcuY3BwIHwgICAgMiArLQogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRl eCAwZGIzMmQ4Li5lNGFhYzU3IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAt MTAzLDcgKzEwMyw3IEBACiAgKgogICogPHByb2dyYW1saXN0aW5nPgogICogLzwhLS0gLS0+KiBD cmVhdGUgdGhlIHdpZGdldHMgKjwhLS0gLS0+LwotICogR3RrV2lkZ2V0ICptYWluX3dpbmRvdyA9 IGd0a193aW5kb3dfbmV3IChHVEtfV0lER0VUX1RPUExFVkVMKTsKKyAqIEd0a1dpZGdldCAqbWFp bl93aW5kb3cgPSBndGtfd2luZG93X25ldyAoR1RLX1dJTkRPV19UT1BMRVZFTCk7CiAgKiBHdGtX aWRnZXQgKnNjcm9sbGVkX3dpbmRvdyA9IGd0a19zY3JvbGxlZF93aW5kb3dfbmV3IChOVUxMLCBO VUxMKTsKICAqIEd0a1dpZGdldCAqd2ViX3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3ICgpOwog ICoKLS0gCjEuNy4zLjIKCg== 75625 2010-12-04 21:32:33 -0800 2010-12-06 03:20:05 -0800 Proposed Patch 0003-Fixed-reference-to-GTK_WIDGET_TOPLEVEL.patch text/plain 1491 djw8605 RnJvbSA0OWE2NmU1ZDBkYjY2MThiMDRjY2M1MWEyY2QwMzNjMGZmYmM4ZjEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEZXJlayBXZWl0emVsIDxkanc4NjA1QGdtYWlsLmNvbT4KRGF0 ZTogU2F0LCA0IERlYyAyMDEwIDIzOjI3OjU3IC0wNjAwClN1YmplY3Q6IFtQQVRDSCAzLzNdIEZp eGVkIHJlZmVyZW5jZSB0byBHVEtfV0lER0VUX1RPUExFVkVMCgotLS0KIFdlYktpdC9ndGsvQ2hh bmdlTG9nICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9DaGFuZ2VM b2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBkMzBkYWZhLi5lNDg2NWFlIDEwMDY0NAot LS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDEwLTEyLTA0ICBEZXJlayBXZWl0emVsICA8ZGp3ODYwNUBnbWFpbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dU S10gQVBJIERvY3VtZW50YXRpb24gcmVmZXJlbmNpbmcgZGVwcmVjaWF0ZWQgR1RLX1dJREdFVF9U T1BMRVZFTAorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDUxMgor CisgICAgICAgIEZpeGVkIHJlZmVyZW5jZSB0byBkZXByZWNpYXRlZCBHVEtfV0lER0VUX1RPUExF VkVMLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorCiAyMDEwLTA2LTE1 ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBH dXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDBkYjMy ZDguLmU0YWFjNTcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xMDMsNyAr MTAzLDcgQEAKICAqCiAgKiA8cHJvZ3JhbWxpc3Rpbmc+CiAgKiAvPCEtLSAtLT4qIENyZWF0ZSB0 aGUgd2lkZ2V0cyAqPCEtLSAtLT4vCi0gKiBHdGtXaWRnZXQgKm1haW5fd2luZG93ID0gZ3RrX3dp bmRvd19uZXcgKEdUS19XSURHRVRfVE9QTEVWRUwpOworICogR3RrV2lkZ2V0ICptYWluX3dpbmRv dyA9IGd0a193aW5kb3dfbmV3IChHVEtfV0lORE9XX1RPUExFVkVMKTsKICAqIEd0a1dpZGdldCAq c2Nyb2xsZWRfd2luZG93ID0gZ3RrX3Njcm9sbGVkX3dpbmRvd19uZXcgKE5VTEwsIE5VTEwpOwog ICogR3RrV2lkZ2V0ICp3ZWJfdmlldyA9IHdlYmtpdF93ZWJfdmlld19uZXcgKCk7CiAgKgotLSAK MS43LjMuMgoK