50487 2010-12-03 14:41:28 -0800 [Qt] Flash plugins should work in windowless mode on QGraphicsWebView 2011-01-03 05:31:20 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 1 ostap73 ostap73 ademar commit-queue eric girish hui_huang laszlo.gombos oldest_to_newest 317064 0 ostap73 2010-12-03 14:41:28 -0800 Flash plugins should work in windowless mode on QGraphicsWebView. Default mode for Nokia flash plugin will be windowless. Generally, #ifdef introduced by commit r69396 should be removed. 317076 1 75548 ostap73 2010-12-03 15:05:43 -0800 Created attachment 75548 Remove #ifdef OS(SYMBIAN) 318289 2 75548 laszlo.gombos 2010-12-07 10:16:15 -0800 Comment on attachment 75548 Remove #ifdef OS(SYMBIAN) Looks good to me, r+. However I'd like to hear from Hui that he is OK committing the change; cq- for now. 318298 3 hui_huang 2010-12-07 10:28:36 -0800 The reason to disable the code to force Flash plugin to run in Windowless mode on Symbian was based on the comments from Symbian Flash Player developers that Symbian Flash Player works better in Windowed mode. Simon already commented about the problems with windowed plugin in Qt Graphics View. If running in Windowless mode is no longer a problem for Symbian Flash Player, I don't have any problem with this patch. 321754 4 eric 2010-12-14 01:25:08 -0800 Sounds like this should be cq+'d now? 322028 5 hui_huang 2010-12-14 10:07:47 -0800 I think so. 322151 6 75548 laszlo.gombos 2010-12-14 13:15:26 -0800 Comment on attachment 75548 Remove #ifdef OS(SYMBIAN) cq+. Laszlo 322167 7 75548 commit-queue 2010-12-14 13:35:49 -0800 Comment on attachment 75548 Remove #ifdef OS(SYMBIAN) Clearing flags on attachment: 75548 Committed r74057: <http://trac.webkit.org/changeset/74057> 322168 8 commit-queue 2010-12-14 13:35:55 -0800 All reviewed patches have been landed. Closing bug. 328537 9 ademar 2011-01-03 05:30:42 -0800 Revision r74057 cherry-picked into qtwebkit-2.2 with commit cc20929 <http://gitorious.org/webkit/qtwebkit/commit/cc20929> 75548 2010-12-03 15:05:43 -0800 2010-12-14 13:35:49 -0800 Remove #ifdef OS(SYMBIAN) symbian_windowless_ifdef.diff text/plain 1616 ostap73 SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzMzMDcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTItMDMgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAg PG9zdGFwZW5rby52aWF0Y2hlc2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGbGFzaCBwbHVnaW5zIHNob3VsZCBiZSB3 aW5kb3dsZXNzIG9uIFFHcmFwaGljc1dlYlZpZXcgb24gU3ltYmlhbgorICAgICAgICBSZW1vdmUg I2lkZWYgU1lNQklBTiBpbnRyb2R1Y2VkIGJ5IHI2OTM5Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNDg3CisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9h ZGVyQ2xpZW50UXQ6OmNyZWF0ZVBsdWdpbik6CisKIDIwMTAtMTItMDEgIEppYSBQdSAgPGpwdUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCShyZXZp c2lvbiA3MzI2NikKKysrIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUzMyw3ICsxNTMzLDYgQEAgUGFzc1JlZlB0cjxX aWRnZXQ+IEZyYW1lTG9hZGVyQ2xpZW50UXQ6OgogICAgIGVsc2UgeyAvLyBOUEFQSSBQbHVnaW5z CiAgICAgICAgIFZlY3RvcjxTdHJpbmc+IHBhcmFtcyA9IHBhcmFtTmFtZXM7CiAgICAgICAgIFZl Y3RvcjxTdHJpbmc+IHZhbHVlcyA9IHBhcmFtVmFsdWVzOwotI2lmICFPUyhTWU1CSUFOKQogICAg ICAgICBpZiAobWltZVR5cGUgPT0gImFwcGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIikgewog ICAgICAgICAgICAgUVdlYlBhZ2VDbGllbnQqIGNsaWVudCA9IG1fd2ViRnJhbWUtPnBhZ2UoKS0+ ZC0+Y2xpZW50OwogICAgICAgICAgICAgY29uc3QgYm9vbCBpc1FXZWJWaWV3ID0gY2xpZW50ICYm IHFvYmplY3RfY2FzdDxRV2lkZ2V0Kj4oY2xpZW50LT5wbHVnaW5QYXJlbnQoKSk7CkBAIC0xNTU5 LDcgKzE1NTgsNiBAQCBQYXNzUmVmUHRyPFdpZGdldD4gRnJhbWVMb2FkZXJDbGllbnRRdDo6CiAg ICAgICAgICAgICB9CiAjZW5kaWYKICAgICAgICAgfQotI2VuZGlmCiAKICAgICAgICAgUmVmUHRy PFBsdWdpblZpZXc+IHBsdWdpblZpZXcgPSBQbHVnaW5WaWV3OjpjcmVhdGUobV9mcmFtZSwgcGx1 Z2luU2l6ZSwgZWxlbWVudCwgdXJsLAogICAgICAgICAgICAgcGFyYW1zLCB2YWx1ZXMsIG1pbWVU eXBlLCBsb2FkTWFudWFsbHkpOwo=