50486 2010-12-03 14:10:21 -0800 WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows 2010-12-03 14:36:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein aroben oldest_to_newest 317045 0 bweinstein 2010-12-03 14:10:21 -0800 This was added to support using WebKit that supported the Inspect Element context menu item with a Safari that didn't have that functionality. We don't support that old of a Safari anymore, so we can get rid of that code path. 317048 1 75543 bweinstein 2010-12-03 14:15:49 -0800 Created attachment 75543 [PATCH] Fix 317056 2 75543 beidson 2010-12-03 14:32:37 -0800 Comment on attachment 75543 [PATCH] Fix I like the amount of red. 317061 3 bweinstein 2010-12-03 14:36:45 -0800 Landed in r73305. 75543 2010-12-03 14:15:49 -0800 2010-12-03 14:32:37 -0800 [PATCH] Fix no_fixmenu.patch text/plain 3257 bweinstein SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA3MzMwMSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTItMDMgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3 ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYkNvbnRleHRNZW51Q2xpZW50OjpmaXhNZW51UmVjZWl2ZWRGcm9tT2xk U2FmYXJpIGlzIG5vIGxvbmdlciBuZWVkZWQgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA0ODYKKyAgICAgICAgCisgICAgICAgIFJl bW92ZSB0aGUgc3RhdGljIGZpeE1lbnVSZWNlaXZlZEZyb21PbGRTYWZhcmkgYW5kIGlzUHJlSW5z cGVjdEVsZW1lbnRUYWdTYWZhcmkgbWV0aG9kcyAKKyAgICAgICAgZnJvbSBXZWJDb250ZXh0TWVu dUNsaWVudC4gVGhlcmUgd2VyZSB0aGVyZSBmb3Igd2hlbiBXZWJLaXQgaGFkIHRoZSBJbnNwZWN0 IEVsZW1lbnQgY29udGV4dCBtZW51CisgICAgICAgIGl0ZW0sIGJ1dCBTYWZhcmkgZGlkbid0IHN1 cHBvcnQgaXQuIFdlIGRvbid0IHN1cHBvcnQgdGhhdCBvbGQgU2FmYXJpLCBzbyB0aGF0IGNvZGUg Y2FuIGdvLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQu Y3BwOgorICAgICAgICAoV2ViQ29udGV4dE1lbnVDbGllbnQ6OmdldEN1c3RvbU1lbnVGcm9tRGVm YXVsdEl0ZW1zKToKKwogMjAxMC0xMi0wMiAgSm9obiBLbm90dGVuYmVsdCAgPGprbm90dGVuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTdGV2ZSBCbG9jay4KSW5kZXg6IFdl YktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQuY3Bw CShyZXZpc2lvbiA3MzE2OSkKKysrIFdlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4 dE1lbnVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCw0NCArNTQsNiBAQCB2b2lkIFdl YkNvbnRleHRNZW51Q2xpZW50Ojpjb250ZXh0TWVudURlCiAgICAgZGVsZXRlIHRoaXM7CiB9CiAK LXN0YXRpYyBib29sIGlzUHJlSW5zcGVjdEVsZW1lbnRUYWdTYWZhcmkoSVdlYlVJRGVsZWdhdGUq IHVpRGVsZWdhdGUpCi17Ci0gICAgaWYgKCF1aURlbGVnYXRlKQotICAgICAgICByZXR1cm4gZmFs c2U7Ci0KLSAgICBUQ0hBUiBtb2R1bGVQYXRoW01BWF9QQVRIXTsKLSAgICBEV09SRCBsZW5ndGgg PSA6OkdldE1vZHVsZUZpbGVOYW1lKDAsIG1vZHVsZVBhdGgsIFdURl9BUlJBWV9MRU5HVEgobW9k dWxlUGF0aCkpOwotICAgIGlmICghbGVuZ3RoKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg ICByZXR1cm4gU3RyaW5nKG1vZHVsZVBhdGgsIGxlbmd0aCkuZW5kc1dpdGgoIlNhZmFyaS5leGUi LCBmYWxzZSk7Ci19Ci0KLXN0YXRpYyBITUVOVSBmaXhNZW51UmVjZWl2ZWRGcm9tT2xkU2FmYXJp KElXZWJVSURlbGVnYXRlKiB1aURlbGVnYXRlLCBDb250ZXh0TWVudSogb3JpZ2luYWxNZW51LCBI TUVOVSBtZW51RnJvbUNsaWVudCkKLXsKLSAgICBBU1NFUlRfQVJHKG9yaWdpbmFsTWVudSwgb3Jp Z2luYWxNZW51KTsKLSAgICBpZiAoIWlzUHJlSW5zcGVjdEVsZW1lbnRUYWdTYWZhcmkodWlEZWxl Z2F0ZSkpCi0gICAgICAgIHJldHVybiBtZW51RnJvbUNsaWVudDsKLQotICAgIGludCBjb3VudCA9 IDo6R2V0TWVudUl0ZW1Db3VudChvcmlnaW5hbE1lbnUtPnBsYXRmb3JtRGVzY3JpcHRpb24oKSk7 Ci0gICAgaWYgKGNvdW50IDwgMSkKLSAgICAgICAgcmV0dXJuIG1lbnVGcm9tQ2xpZW50OwotCi0g ICAgaWYgKDo6R2V0TWVudUl0ZW1JRChvcmlnaW5hbE1lbnUtPnBsYXRmb3JtRGVzY3JpcHRpb24o KSwgY291bnQgLSAxKSAhPSBXZWJNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50KQotICAgICAgICBy ZXR1cm4gbWVudUZyb21DbGllbnQ7Ci0KLSAgICBjb3VudCA9IDo6R2V0TWVudUl0ZW1Db3VudCht ZW51RnJvbUNsaWVudCk7Ci0gICAgaWYgKGNvdW50IDwgMSkKLSAgICAgICAgcmV0dXJuIG1lbnVG cm9tQ2xpZW50OwotCi0gICAgaWYgKDo6R2V0TWVudUl0ZW1JRChtZW51RnJvbUNsaWVudCwgY291 bnQgLSAxKSA9PSBXZWJNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50KQotICAgICAgICByZXR1cm4g bWVudUZyb21DbGllbnQ7Ci0KLSAgICBvcmlnaW5hbE1lbnUtPnNldFBsYXRmb3JtRGVzY3JpcHRp b24obWVudUZyb21DbGllbnQpOwotICAgIG9yaWdpbmFsTWVudS0+YWRkSW5zcGVjdEVsZW1lbnRJ dGVtKCk7Ci0gICAgcmV0dXJuIG9yaWdpbmFsTWVudS0+cGxhdGZvcm1EZXNjcmlwdGlvbigpOwot fQotCiBITUVOVSBXZWJDb250ZXh0TWVudUNsaWVudDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0 SXRlbXMoQ29udGV4dE1lbnUqIG1lbnUpCiB7CiAgICAgQ09NUHRyPElXZWJVSURlbGVnYXRlPiB1 aURlbGVnYXRlOwpAQCAtMTA2LDcgKzY4LDcgQEAgSE1FTlUgV2ViQ29udGV4dE1lbnVDbGllbnQ6 OmdldEN1c3RvbU1lbgogICAgIC8vIEZJWE1FOiBXZSBuZWVkIHRvIGRlY2lkZSB3aGV0aGVyIHRv IGRvIHRoZSBkZWZhdWx0IGJlZm9yZSBjYWxsaW5nIHRoaXMgZGVsZWdhdGUgbWV0aG9kCiAgICAg aWYgKEZBSUxFRCh1aURlbGVnYXRlLT5jb250ZXh0TWVudUl0ZW1zRm9yRWxlbWVudChtX3dlYlZp ZXcsIHByb3BlcnR5QmFnLmdldCgpLCAoT0xFX0hBTkRMRSkoVUxPTkc2NCltZW51LT5wbGF0Zm9y bURlc2NyaXB0aW9uKCksIChPTEVfSEFORExFKikmbmV3TWVudSkpKQogICAgICAgICByZXR1cm4g bWVudS0+cGxhdGZvcm1EZXNjcmlwdGlvbigpOwotICAgIHJldHVybiBmaXhNZW51UmVjZWl2ZWRG cm9tT2xkU2FmYXJpKHVpRGVsZWdhdGUuZ2V0KCksIG1lbnUsIG5ld01lbnUpOworICAgIHJldHVy biBuZXdNZW51OwogfQogCiB2b2lkIFdlYkNvbnRleHRNZW51Q2xpZW50Ojpjb250ZXh0TWVudUl0 ZW1TZWxlY3RlZChDb250ZXh0TWVudUl0ZW0qIGl0ZW0sIGNvbnN0IENvbnRleHRNZW51KiBwYXJl bnRNZW51KQo=