50465 2010-12-03 11:04:21 -0800 The chunked update drawing area is flipped twice when drawing 2010-12-03 11:12:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca oldest_to_newest 316906 0 andersca 2010-12-03 11:04:21 -0800 The chunked update drawing area is flipped twice when drawing 316907 1 75514 andersca 2010-12-03 11:06:02 -0800 Created attachment 75514 Patch 316908 2 andersca 2010-12-03 11:06:36 -0800 <rdar://problem/8726836> 316909 3 75514 mitz 2010-12-03 11:09:40 -0800 Comment on attachment 75514 Patch I think you can save on a bunch of function calls here. Roll the translation into the origin of the parameter you pass to CGContextDrawImage, and instead of saving and restoring gstate, just apply the scale again. 316911 4 andersca 2010-12-03 11:12:36 -0800 Committed r73275: <http://trac.webkit.org/changeset/73275> 75514 2010-12-03 11:06:02 -0800 2010-12-03 11:09:40 -0800 Patch bug-50465-20101203110601.patch text/plain 2897 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NzM5N2ZiYjhkOWUwOGM3YmFiNWFlZjE2YjljYWZjYzUyOWIxZWE4Ni4uZGMxZTcwOTMyY2RiOTU5 MDI1ZmY3OTYwYTM2YzEzNmU3NGJmYThjNCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0wMyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjaHVua2VkIHVwZGF0ZSBkcmF3aW5nIGFy ZWEgaXMgZmxpcHBlZCB0d2ljZSB3aGVuIGRyYXdpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNDY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84 NzI2ODM2PgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9DaHVua2VkVXBkYXRlRHJhd2luZ0Fy ZWFQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVh UHJveHk6OnBsYXRmb3JtUGFpbnQpOgorICAgICAgICAoV2ViS2l0OjpDaHVua2VkVXBkYXRlRHJh d2luZ0FyZWFQcm94eTo6ZHJhd1VwZGF0ZUNodW5rSW50b0JhY2tpbmdTdG9yZSk6CisgICAgICAg IEZsaXAgdGhlIGRlc3RpbmF0aW9uIGNvbnRleHRzLCB0aHVzIHVuZmxpcHBpbmcgdGhlbS4gKFR1 cm5zIG91dCB0d28gd3JvbmdzIG1ha2UgYSByaWdodCBoZXJlKS4KKwogMjAxMC0xMi0wMyAgSmVz c2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh bSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvQ2h1bmtlZFVwZGF0 ZURyYXdpbmdBcmVhUHJveHlNYWMubW0gYi9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvQ2h1bmtlZFVw ZGF0ZURyYXdpbmdBcmVhUHJveHlNYWMubW0KaW5kZXggZmVhNTVlOTY0ZTRkN2QxZTFhMDUxNzkw MDJlMWVlYmY2NjhiMDYzNy4uMTVmODk1MWYyMzRjYjQ3ZGU0MzU0OGI5NDI5NzI1OGQ3NDgzY2Uy ZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL0NodW5rZWRVcGRhdGVEcmF3aW5n QXJlYVByb3h5TWFjLm1tCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL21hYy9DaHVua2VkVXBkYXRl RHJhd2luZ0FyZWFQcm94eU1hYy5tbQpAQCAtNjUsOCArNjUsMTYgQEAgdm9pZCBDaHVua2VkVXBk YXRlRHJhd2luZ0FyZWFQcm94eTo6cGxhdGZvcm1QYWludChjb25zdCBJbnRSZWN0JiByZWN0LCBD R0NvbnRleHQKICAgICBpZiAoIW1fYml0bWFwQ29udGV4dCkKICAgICAgICAgcmV0dXJuOwogCisg ICAgQ0dDb250ZXh0U2F2ZUdTdGF0ZShjb250ZXh0KTsKKworICAgIC8vIEZsaXAgdGhlIGRlc3Rp bmF0aW9uLgorICAgIENHQ29udGV4dFNjYWxlQ1RNKGNvbnRleHQsIDEsIC0xKTsKKyAgICBDR0Nv bnRleHRUcmFuc2xhdGVDVE0oY29udGV4dCwgMCwgLW1fc2l6ZS5oZWlnaHQoKSk7CisKICAgICBS ZXRhaW5QdHI8Q0dJbWFnZVJlZj4gaW1hZ2UoQWRvcHRDRiwgQ0dCaXRtYXBDb250ZXh0Q3JlYXRl SW1hZ2UobV9iaXRtYXBDb250ZXh0LmdldCgpKSk7CiAgICAgQ0dDb250ZXh0RHJhd0ltYWdlKGNv bnRleHQsIENHUmVjdE1ha2UoMCwgMCwgQ0dJbWFnZUdldFdpZHRoKGltYWdlLmdldCgpKSwgQ0dJ bWFnZUdldEhlaWdodChpbWFnZS5nZXQoKSkpLCBpbWFnZS5nZXQoKSk7CisKKyAgICBDR0NvbnRl eHRSZXN0b3JlR1N0YXRlKGNvbnRleHQpOwogfQogCiB2b2lkIENodW5rZWRVcGRhdGVEcmF3aW5n QXJlYVByb3h5OjpkcmF3VXBkYXRlQ2h1bmtJbnRvQmFja2luZ1N0b3JlKFVwZGF0ZUNodW5rKiB1 cGRhdGVDaHVuaykKQEAgLTc0LDEwICs4MiwxNiBAQCB2b2lkIENodW5rZWRVcGRhdGVEcmF3aW5n QXJlYVByb3h5OjpkcmF3VXBkYXRlQ2h1bmtJbnRvQmFja2luZ1N0b3JlKFVwZGF0ZUNodW5rKgog ICAgIGVuc3VyZUJhY2tpbmdTdG9yZSgpOwogCiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IGlt YWdlKHVwZGF0ZUNodW5rLT5jcmVhdGVJbWFnZSgpKTsKLSAgICBjb25zdCBJbnRSZWN0JiB1cGRh dGVDaHVua1JlY3QgPSB1cGRhdGVDaHVuay0+cmVjdCgpOworICAgIEludFJlY3QgdXBkYXRlQ2h1 bmtSZWN0ID0gdXBkYXRlQ2h1bmstPnJlY3QoKTsKKworICAgIC8vIEZsaXAgdGhlIGRlc3RpbmF0 aW9uLgorICAgIENHQ29udGV4dFNhdmVHU3RhdGUobV9iaXRtYXBDb250ZXh0LmdldCgpKTsKKyAg ICBDR0NvbnRleHRTY2FsZUNUTShtX2JpdG1hcENvbnRleHQuZ2V0KCksIDEsIC0xKTsKKyAgICBD R0NvbnRleHRUcmFuc2xhdGVDVE0obV9iaXRtYXBDb250ZXh0LmdldCgpLCAwLCAtKHVwZGF0ZUNo dW5rUmVjdC55KCkgKyB1cGRhdGVDaHVua1JlY3QuYm90dG9tKCkpKTsKKworICAgIENHQ29udGV4 dERyYXdJbWFnZShtX2JpdG1hcENvbnRleHQuZ2V0KCksIHVwZGF0ZUNodW5rUmVjdCwgaW1hZ2Uu Z2V0KCkpOworICAgIENHQ29udGV4dFJlc3RvcmVHU3RhdGUobV9iaXRtYXBDb250ZXh0LmdldCgp KTsKIAotICAgIENHQ29udGV4dERyYXdJbWFnZShtX2JpdG1hcENvbnRleHQuZ2V0KCksIENHUmVj dE1ha2UodXBkYXRlQ2h1bmtSZWN0LngoKSwgc2l6ZSgpLmhlaWdodCgpIC0gdXBkYXRlQ2h1bmtS ZWN0LmJvdHRvbSgpLCAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVwZGF0ZUNodW5rUmVjdC53aWR0aCgpLCB1cGRhdGVDaHVua1JlY3Qu aGVpZ2h0KCkpLCBpbWFnZS5nZXQoKSk7CiAgICAgW21fd2ViVmlldyBzZXROZWVkc0Rpc3BsYXlJ blJlY3Q6TlNSZWN0RnJvbUNHUmVjdCh1cGRhdGVDaHVua1JlY3QpXTsKIH0KIAo=