50462 2010-12-03 10:19:28 -0800 [GTK] webkit_soup_cache_clear() does not delete all entries in the cache 2010-12-06 01:44:01 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 svillar webkit-unassigned mrobinson oldest_to_newest 316875 0 svillar 2010-12-03 10:19:28 -0800 The problem is that we're removing entries in the callback of g_hash_table_foreach, something that is obviously wrong 316890 1 75510 svillar 2010-12-03 10:41:15 -0800 Created attachment 75510 Fix for the bug 317419 2 mrobinson 2010-12-05 15:48:04 -0800 Is it possible to simply use g_hash_table_remove_all? 317482 3 svillar 2010-12-06 01:09:52 -0800 (In reply to comment #2) > Is it possible to simply use g_hash_table_remove_all? Not really because it could happen that we might decide not to remove some item from the cache for example if some entry is dirty. We cannot also use g_hash_table_remove without changing the logic of webkit_soup_cache_entry_remove either. 317485 4 75510 mrobinson 2010-12-06 01:21:10 -0800 Comment on attachment 75510 Fix for the bug Yay! 317495 5 svillar 2010-12-06 01:44:01 -0800 Committed r73350: <http://trac.webkit.org/changeset/73350> 75510 2010-12-03 10:41:15 -0800 2010-12-06 01:21:09 -0800 Fix for the bug 0001-2010-12-03-Sergio-Villar-Senin-svillar-igalia.com.patch text/plain 4398 svillar RnJvbSBhMmYzOWUxYzhlODk5ZWUzNzFiNzk1MDFlZjRiNjk5NjRkMjkwYjlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IEZyaSwgMyBEZWMgMjAxMCAxOTozODo1MSArMDEwMApTdWJqZWN0OiBbUEFUQ0hd IDIwMTAtMTItMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+Cgog ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSB3ZWJraXRf c291cF9jYWNoZV9jbGVhcigpIGRvZXMgbm90IGRlbGV0ZSBhbGwgZW50cmllcyBpbiB0aGUgY2Fj aGUKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA0NjIK CiAgICAgICAgRG8gbm90IHVzZSBnX2hhc2hfdGFibGVfZm9yZWFjaCB0byByZW1vdmUgZW50cmll cyBmcm9tIHRoZSBjYWNoZQogICAgICAgIGVudHJpZXMgaGFzaHRhYmxlLiBJdGVyYXRlIG92ZXIg YSBsaXN0IG9mIGVudHJpZXMgdG8gcmVtb3ZlIHRoZW0KICAgICAgICBmcm9tIHRoZSBoYXNoIHRh YmxlLgoKICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAu Y3BwOgogICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNh Y2hlLmM6CiAgICAgICAgKHJlbW92ZV9jYWNoZV9pdGVtKToKICAgICAgICAod2Via2l0X3NvdXBf Y2FjaGVfZmluYWxpemUpOgogICAgICAgIChjbGVhcl9jYWNoZV9pdGVtKToKICAgICAgICAod2Vi a2l0X3NvdXBfY2FjaGVfY2xlYXIpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysrKwogLi4uL25ldHdvcmsvc291 cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jICAgICAgICAgfCAgIDMxICsrKysrKysrKysrKyst LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBhNWQyZWMwLi43MTVlNjQwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEwLTEyLTAzICBTZXJnaW8gVmls bGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIHdlYmtpdF9zb3VwX2NhY2hlX2NsZWFyKCkg ZG9lcyBub3QgZGVsZXRlIGFsbCBlbnRyaWVzIGluIHRoZSBjYWNoZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTA0NjIKKworICAgICAgICBEbyBub3Qg dXNlIGdfaGFzaF90YWJsZV9mb3JlYWNoIHRvIHJlbW92ZSBlbnRyaWVzIGZyb20gdGhlIGNhY2hl CisgICAgICAgIGVudHJpZXMgaGFzaHRhYmxlLiBJdGVyYXRlIG92ZXIgYSBsaXN0IG9mIGVudHJp ZXMgdG8gcmVtb3ZlIHRoZW0KKyAgICAgICAgZnJvbSB0aGUgaGFzaCB0YWJsZS4KKworICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1jYWNoZS5jOgorICAg ICAgICAocmVtb3ZlX2NhY2hlX2l0ZW0pOgorICAgICAgICAod2Via2l0X3NvdXBfY2FjaGVfZmlu YWxpemUpOgorICAgICAgICAoY2xlYXJfY2FjaGVfaXRlbSk6CisgICAgICAgICh3ZWJraXRfc291 cF9jYWNoZV9jbGVhcik6CisKIDIwMTAtMTItMDIgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292 QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNh Y2hlLmMgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS93ZWJraXQvc291cC1j YWNoZS5jCmluZGV4IGI5MTY0NjguLmE3OTM3ZGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYwpAQCAtMTA4NCwx MSArMTA4NCwxMiBAQCB3ZWJraXRfc291cF9jYWNoZV9pbml0IChXZWJLaXRTb3VwQ2FjaGUgKmNh Y2hlKQogfQogCiBzdGF0aWMgdm9pZAotcmVtb3ZlX2NhY2hlX2l0ZW0gKGdwb2ludGVyIGtleSwK LQkJICAgZ3BvaW50ZXIgdmFsdWUsCi0JCSAgIFdlYktpdFNvdXBDYWNoZSAqY2FjaGUpCityZW1v dmVfY2FjaGVfaXRlbSAoZ3BvaW50ZXIgZGF0YSwKKwkJICAgZ3BvaW50ZXIgdXNlcl9kYXRhKQog ewotCVdlYktpdFNvdXBDYWNoZUVudHJ5ICplbnRyeSA9IGdfaGFzaF90YWJsZV9sb29rdXAgKGNh Y2hlLT5wcml2LT5jYWNoZSwgKGNvbnN0IGdjaGFyICopa2V5KTsKKwlXZWJLaXRTb3VwQ2FjaGUg KmNhY2hlID0gKFdlYktpdFNvdXBDYWNoZSAqKSB1c2VyX2RhdGE7CisJV2ViS2l0U291cENhY2hl RW50cnkgKmVudHJ5ID0gKFdlYktpdFNvdXBDYWNoZUVudHJ5ICopIGRhdGE7CisKIAlpZiAod2Vi a2l0X3NvdXBfY2FjaGVfZW50cnlfcmVtb3ZlIChjYWNoZSwgZW50cnkpKQogCQl3ZWJraXRfc291 cF9jYWNoZV9lbnRyeV9mcmVlIChlbnRyeSwgRkFMU0UpOwogfQpAQCAtMTA5NywxMCArMTA5OCwx NSBAQCBzdGF0aWMgdm9pZAogd2Via2l0X3NvdXBfY2FjaGVfZmluYWxpemUgKEdPYmplY3QgKm9i amVjdCkKIHsKIAlXZWJLaXRTb3VwQ2FjaGVQcml2YXRlICpwcml2OworCUdMaXN0ICplbnRyaWVz OwogCiAJcHJpdiA9IFdFQktJVF9TT1VQX0NBQ0hFIChvYmplY3QpLT5wcml2OwogCi0JZ19oYXNo X3RhYmxlX2ZvcmVhY2ggKHByaXYtPmNhY2hlLCAoR0hGdW5jKXJlbW92ZV9jYWNoZV9pdGVtLCBv YmplY3QpOworCS8vIENhbm5vdCB1c2UgZ19oYXNoX3RhYmxlX2ZvcmVhY2ggYXMgY2FsbGJhY2tz IG11c3Qgbm90IG1vZGlmeSB0aGUgaGFzaCB0YWJsZQorCWVudHJpZXMgPSBnX2hhc2hfdGFibGVf Z2V0X3ZhbHVlcyAocHJpdi0+Y2FjaGUpOworCWdfbGlzdF9mb3JlYWNoIChlbnRyaWVzLCByZW1v dmVfY2FjaGVfaXRlbSwgb2JqZWN0KTsKKwlnX2xpc3RfZnJlZSAoZW50cmllcyk7CisKIAlnX2hh c2hfdGFibGVfZGVzdHJveSAocHJpdi0+Y2FjaGUpOwogCWdfZnJlZSAocHJpdi0+Y2FjaGVfZGly KTsKIApAQCAtMTQ0OSwxMSArMTQ1NSwxMiBAQCB3ZWJraXRfc291cF9jYWNoZV9mbHVzaCAoV2Vi S2l0U291cENhY2hlICpjYWNoZSkKIH0KIAogc3RhdGljIHZvaWQKLWNsZWFyX2NhY2hlX2l0ZW0g KGdwb2ludGVyIGtleSwKLQkJICBncG9pbnRlciB2YWx1ZSwKLQkJICBXZWJLaXRTb3VwQ2FjaGUg KmNhY2hlKQorY2xlYXJfY2FjaGVfaXRlbSAoZ3BvaW50ZXIgZGF0YSwKKwkJICBncG9pbnRlciB1 c2VyX2RhdGEpCiB7Ci0JV2ViS2l0U291cENhY2hlRW50cnkgKmVudHJ5ID0gZ19oYXNoX3RhYmxl X2xvb2t1cCAoY2FjaGUtPnByaXYtPmNhY2hlLCAoY29uc3QgZ2NoYXIgKilrZXkpOworCVdlYktp dFNvdXBDYWNoZSAqY2FjaGUgPSAoV2ViS2l0U291cENhY2hlICopIHVzZXJfZGF0YTsKKwlXZWJL aXRTb3VwQ2FjaGVFbnRyeSAqZW50cnkgPSAoV2ViS2l0U291cENhY2hlRW50cnkgKikgZGF0YTsK KwogCWlmICh3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9yZW1vdmUgKGNhY2hlLCBlbnRyeSkpCiAJ CXdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X2ZyZWUgKGVudHJ5LCBUUlVFKTsKIH0KQEAgLTE0Njks MTMgKzE0NzYsMTcgQEAgdm9pZAogd2Via2l0X3NvdXBfY2FjaGVfY2xlYXIgKFdlYktpdFNvdXBD YWNoZSAqY2FjaGUpCiB7CiAJR0hhc2hUYWJsZSAqaGFzaDsKKwlHTGlzdCAqZW50cmllczsKIAog CWdfcmV0dXJuX2lmX2ZhaWwgKFdFQktJVF9JU19TT1VQX0NBQ0hFIChjYWNoZSkpOwogCiAJaGFz aCA9IGNhY2hlLT5wcml2LT5jYWNoZTsKIAlnX3JldHVybl9pZl9mYWlsIChoYXNoKTsKIAotCWdf aGFzaF90YWJsZV9mb3JlYWNoIChoYXNoLCAoR0hGdW5jKWNsZWFyX2NhY2hlX2l0ZW0sIGNhY2hl KTsKKwkvLyBDYW5ub3QgdXNlIGdfaGFzaF90YWJsZV9mb3JlYWNoIGFzIGNhbGxiYWNrcyBtdXN0 IG5vdCBtb2RpZnkgdGhlIGhhc2ggdGFibGUKKwllbnRyaWVzID0gZ19oYXNoX3RhYmxlX2dldF92 YWx1ZXMgKGhhc2gpOworCWdfbGlzdF9mb3JlYWNoIChlbnRyaWVzLCBjbGVhcl9jYWNoZV9pdGVt LCBjYWNoZSk7CisJZ19saXN0X2ZyZWUgKGVudHJpZXMpOwogfQogCiBTb3VwTWVzc2FnZSAqCi0t IAoxLjcuMQoK