50439 2010-12-02 23:01:06 -0800 [chromium] PNG encoder leaks memory on png_write_row errors. 2010-12-03 00:54:03 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 noel.gordon webkit-unassigned commit-queue mdelaney7 oldest_to_newest 316687 0 noel.gordon 2010-12-02 23:01:06 -0800 Once the encoder setjmp() is called during initialization, any C++ objects created after that point won't have their destructors called on error due to the way setjmp() unwinds the stack. So in the error case, the OwnArrayPtr |rowPixels| leaks its memory. 316693 1 75467 noel.gordon 2010-12-02 23:29:07 -0800 Created attachment 75467 patch 316715 2 75467 commit-queue 2010-12-03 00:53:58 -0800 Comment on attachment 75467 patch Clearing flags on attachment: 75467 Committed r73250: <http://trac.webkit.org/changeset/73250> 316716 3 commit-queue 2010-12-03 00:54:03 -0800 All reviewed patches have been landed. Closing bug. 75467 2010-12-02 23:29:07 -0800 2010-12-03 00:53:58 -0800 patch git-diff.patch text/plain 4362 noel.gordon ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDJiMWFmMC4uNzM5NDk2MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAogMjAxMC0xMi0wMiAgTm9lbCBHb3Jkb24g IDxub2VsLmdvcmRvbkBnbWFpbC5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBQTkcgZW5jb2RlciBsZWFrcyBtZW1vcnkgb24g cG5nX3dyaXRlX3JvdyBlcnJvcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MDQzOQorCisgICAgICAgIE1vdmUgdGhlIGNyZWF0aW9uIG9mIG5lZWRl ZCBDKysgb2JqZWN0cyBiZWZvcmUgdGhlIHNldGptcCgpIHBvaW50IHNvCisgICAgICAgIHRob3Nl IG9iamVjdHMgaGF2ZSB0aGVpciBkZXN0cnVjdG9ycyBjYWxsZWQgaWYgbGlicG5nIGVycm9ycyBp bnZva2UKKyAgICAgICAgdGhlIHNldGptcCgpIHJldHVybiBwYXRoLgorICAgCisgICAgICAgIE90 aGVyIG1pbm9yIGNsZWFudXA6IHVzZSB0aGUgc2tpYSBiaXRtYXAgbG9ja2VyIGNsYXNzLCBhbmQg cmVtb3ZlIHRoZQorICAgICAgICBQTkdEZXN0cm95ZXIgY2xhc3MgLSBpbnN0ZWFkIGRpcmVjdGx5 IGNhbGwgcG5nX2Rlc3Ryb3lfd3JpdGVfc3RydWN0KCkKKyAgICAgICAgYXQgZWFjaCBvZiB0aGUg ZW5jb2RlSW1wbCgpIHJldHVybiBwb2ludHMuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2 aW91ciwgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZW5jb2Rl cnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZW5jb2RlSW1w bCk6CisgICAgICAgIChXZWJDb3JlOjpQTkdJbWFnZUVuY29kZXI6OmVuY29kZSk6CisKKzIwMTAt MTItMDIgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIExldmluLgogICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBkZWFkIGNv ZGUgZnJvbSBQTkcgZW5jb2RlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTAzNzcKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5j b2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9za2lhL1BOR0ltYWdlRW5jb2Rlci5jcHAKaW5kZXggZGM3ZDA2Ny4uNjk1YzFlOSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL1BOR0ltYWdl RW5jb2Rlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9za2lhL1BO R0ltYWdlRW5jb2Rlci5jcHAKQEAgLTgzLDI0ICs4Myw2IEBAIHZvaWQgZW5jb2RlcldyaXRlQ2Fs bGJhY2socG5nX3N0cnVjdHAgcG5nLCBwbmdfYnl0ZXAgZGF0YSwgcG5nX3NpemVfdCBzaXplKQog ICAgIG1lbWNweSgmKCpzdGF0ZS0+bV9vdXQpW29sZFNpemVdLCBkYXRhLCBzaXplKTsKIH0KIAot Ly8gQXV0b21hdGljYWxseSBkZXN0cm95cyB0aGUgZ2l2ZW4gd3JpdGUgc3RydWN0cyBvbiBkZXN0 cnVjdGlvbiB0byBtYWtlCi0vLyBjbGVhbnVwIGFuZCBlcnJvciBoYW5kbGluZyBjb2RlIGNsZWFu ZXIuCi1jbGFzcyBQTkdXcml0ZVN0cnVjdERlc3Ryb3llciB7Ci1wdWJsaWM6Ci0gICAgUE5HV3Jp dGVTdHJ1Y3REZXN0cm95ZXIocG5nX3N0cnVjdCoqIHBzLCBwbmdfaW5mbyoqIHBpKQotICAgICAg ICA6IG1fcG5nU3RydWN0KHBzKQotICAgICAgICAsIG1fcG5nSW5mbyhwaSkgewotICAgIH0KLQot ICAgIH5QTkdXcml0ZVN0cnVjdERlc3Ryb3llcigpIHsKLSAgICAgICAgcG5nX2Rlc3Ryb3lfd3Jp dGVfc3RydWN0KG1fcG5nU3RydWN0LCBtX3BuZ0luZm8pOwotICAgIH0KLQotcHJpdmF0ZToKLSAg ICBwbmdfc3RydWN0KiogbV9wbmdTdHJ1Y3Q7Ci0gICAgcG5nX2luZm8qKiBtX3BuZ0luZm87Ci19 OwotCiBzdGF0aWMgYm9vbCBlbmNvZGVJbXBsKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGlucHV0LAog ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBJbnRTaXplJiBzaXplLAogICAgICAgICAgICAg ICAgICAgICAgICBpbnQgYnl0ZXNQZXJSb3csCkBAIC0xMjcsMTcgKzEwOSwxNiBAQCBzdGF0aWMg Ym9vbCBlbmNvZGVJbXBsKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGlucHV0LAogICAgICAgICBwbmdf ZGVzdHJveV93cml0ZV9zdHJ1Y3QoJnBuZ1B0ciwgTlVMTCk7CiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICB9Ci0gICAgUE5HV3JpdGVTdHJ1Y3REZXN0cm95ZXIgZGVzdHJveWVyKCZwbmdQdHIs ICZpbmZvUHRyKTsKKworICAgIE93bkFycmF5UHRyPHVuc2lnbmVkIGNoYXI+IHJvd1BpeGVscyhu ZXcgdW5zaWduZWQgY2hhcltpbWFnZVNpemUud2lkdGgoKSAqIG91dHB1dENvbG9yQ29tcG9uZW50 c10pOworICAgIFBOR0VuY29kZXJTdGF0ZSBzdGF0ZShvdXRwdXQpOwogCiAgICAgaWYgKHNldGpt cChwbmdfam1wYnVmKHBuZ1B0cikpKSB7Ci0gICAgICAgIC8vIFRoZSBkZXN0cm95ZXIgd2lsbCBl bnN1cmUgdGhhdCB0aGUgc3RydWN0dXJlcyBhcmUgY2xlYW5lZCB1cCBpbiB0aGlzCi0gICAgICAg IC8vIGNhc2UsIGV2ZW4gdGhvdWdoIHdlIG1heSBnZXQgaGVyZSBhcyBhIGp1bXAgZnJvbSByYW5k b20gcGFydHMgb2YgdGhlCi0gICAgICAgIC8vIFBORyBsaWJyYXJ5IGNhbGxlZCBiZWxvdy4KKyAg ICAgICAgcG5nX2Rlc3Ryb3lfd3JpdGVfc3RydWN0KCZwbmdQdHIsICZpbmZvUHRyKTsKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAogICAgIC8vIFNldCBvdXIgY2FsbGJhY2sgZm9yIGxp YnBuZyB0byBnaXZlIHVzIHRoZSBkYXRhLgotICAgIFBOR0VuY29kZXJTdGF0ZSBzdGF0ZShvdXRw dXQpOwogICAgIHBuZ19zZXRfd3JpdGVfZm4ocG5nUHRyLCAmc3RhdGUsIGVuY29kZXJXcml0ZUNh bGxiYWNrLCBOVUxMKTsKIAogICAgIHBuZ19zZXRfSUhEUihwbmdQdHIsIGluZm9QdHIsIGltYWdl U2l6ZS53aWR0aCgpLCBpbWFnZVNpemUuaGVpZ2h0KCksIDgsIHBuZ091dHB1dENvbG9yVHlwZSwK QEAgLTE0NSwxMyArMTI2LDEzIEBAIHN0YXRpYyBib29sIGVuY29kZUltcGwoY29uc3QgdW5zaWdu ZWQgY2hhciogaW5wdXQsCiAgICAgICAgICAgICAgICAgIFBOR19GSUxURVJfVFlQRV9ERUZBVUxU KTsKICAgICBwbmdfd3JpdGVfaW5mbyhwbmdQdHIsIGluZm9QdHIpOwogCi0gICAgT3duQXJyYXlQ dHI8dW5zaWduZWQgY2hhcj4gcm93UGl4ZWxzKG5ldyB1bnNpZ25lZCBjaGFyW2ltYWdlU2l6ZS53 aWR0aCgpICogb3V0cHV0Q29sb3JDb21wb25lbnRzXSk7CiAgICAgZm9yIChpbnQgeSA9IDA7IHkg PCBpbWFnZVNpemUuaGVpZ2h0KCk7ICsreSkgewogICAgICAgICBwcmVNdWx0aXBsaWVkQkdSQXRv UkdCQSgmaW5wdXRbeSAqIGJ5dGVzUGVyUm93XSwgaW1hZ2VTaXplLndpZHRoKCksIHJvd1BpeGVs cy5nZXQoKSk7CiAgICAgICAgIHBuZ193cml0ZV9yb3cocG5nUHRyLCByb3dQaXhlbHMuZ2V0KCkp OwogICAgIH0KIAogICAgIHBuZ193cml0ZV9lbmQocG5nUHRyLCBpbmZvUHRyKTsKKyAgICBwbmdf ZGVzdHJveV93cml0ZV9zdHJ1Y3QoJnBuZ1B0ciwgJmluZm9QdHIpOwogICAgIHJldHVybiB0cnVl OwogfQogCkBAIC0xNjEsMTAgKzE0Miw4IEBAIGJvb2wgUE5HSW1hZ2VFbmNvZGVyOjplbmNvZGUo Y29uc3QgU2tCaXRtYXAmIGltYWdlLCBWZWN0b3I8dW5zaWduZWQgY2hhcj4qIG91dHB1CiAgICAg aWYgKGltYWdlLmNvbmZpZygpICE9IFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZykKICAgICAg ICAgcmV0dXJuIGZhbHNlOyAvLyBPbmx5IHN1cHBvcnQgQVJHQiAzMiBicHAgc2tpYSBiaXRtYXBz LgogCi0gICAgaW1hZ2UubG9ja1BpeGVscygpOwotICAgIGJvb2wgcmVzdWx0ID0gZW5jb2RlSW1w bChzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyKj4oaW1hZ2UuZ2V0UGl4ZWxzKCkpLCBJbnRTaXpl KGltYWdlLndpZHRoKCksIGltYWdlLmhlaWdodCgpKSwgaW1hZ2Uucm93Qnl0ZXMoKSwgb3V0cHV0 KTsKLSAgICBpbWFnZS51bmxvY2tQaXhlbHMoKTsKLSAgICByZXR1cm4gcmVzdWx0OworICAgIFNr QXV0b0xvY2tQaXhlbHMgYml0bWFwTG9jayhpbWFnZSk7CisgICAgcmV0dXJuIGVuY29kZUltcGwo c3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhcio+KGltYWdlLmdldFBpeGVscygpKSwgSW50U2l6ZShp bWFnZS53aWR0aCgpLCBpbWFnZS5oZWlnaHQoKSksIGltYWdlLnJvd0J5dGVzKCksIG91dHB1dCk7 CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK