50437 2010-12-02 21:13:06 -0800 [skia] ignore transform for canvas shadows 2010-12-13 21:53:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 mikelawther webkit-unassigned abarth dglazkov mihaip webkit.review.bot oldest_to_newest 316659 0 mikelawther 2010-12-02 21:13:06 -0800 [skia] ignore transform for canvas shadows 316661 1 75462 mikelawther 2010-12-02 21:18:19 -0800 Created attachment 75462 Patch 316960 2 75462 senorblanco 2010-12-03 12:24:44 -0800 Comment on attachment 75462 Patch Are there any canvas layout tests which cover this functionality (perhaps in canvas/philip)? If not, one should be included with this patch. 317413 3 mikelawther 2010-12-05 14:27:15 -0800 Sorry - I should have mentioned this. There are existing tests, but not in canvas/philip. The downstream chromium bug I'm addressing is http://code.google.com/p/chromium/issues/detail?id=64647. The tests are: fast/canvas/canvas-scale-fillRect-shadow.html fast/canvas/canvas-scale-fillPath-shadow.html fast/canvas/canvas-scale-strokePath-shadow.html 319913 4 76161 mikelawther 2010-12-09 21:21:30 -0800 Created attachment 76161 Patch 319914 5 mikelawther 2010-12-09 21:28:29 -0800 Correcting my previous comment - the test that this patch fixes (on Chromium Win/Linux) are: canvas/philip/tests/2d.shadow.transform.2.html fast/canvas/canvas-scale-fillRect-shadow.html fast/canvas/canvas-scale-fillPath-shadow.html fast/canvas/canvas-scale-strokePath-shadow.html now renders the shadow in the correct location, but the pixels don't render right due to another skia bug. 319915 6 webkit.review.bot 2010-12-09 21:36:03 -0800 Attachment 76161 did not build on chromium: Build output: http://queues.webkit.org/results/6911027 319917 7 mikelawther 2010-12-09 21:43:50 -0800 This is only expected to build as of Skia r631. Chromium's DEPS were updated in http://src.chromium.org/viewvc/chrome?view=rev&revision=68558. The bot's output says: "Failed to run "['WebKitTools/Scripts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2". I guess this is the reason the build failed? 319921 8 mikelawther 2010-12-09 21:46:55 -0800 Oops - I realise I can't tell whether the --update-chromium failed or not. Is there something else I need to do to make this patch compile for chromium? 319922 9 abarth 2010-12-09 21:48:28 -0800 Dunno. Mihaip recently changed how the EWS bot updates its DEPS. 319935 10 mihaip 2010-12-09 22:36:53 -0800 (In reply to comment #9) > Dunno. Mihaip recently changed how the EWS bot updates its DEPS. I don't think that should matter, when --update-chromium is passed the behavior is the same as it was before my change. In this case, the Chromium change that Mike mentions is r68558, but the DEPS file that lives in WebKit/chromium/DEPS is only at r67980: http://trac.webkit.org/browser/trunk/WebKit/chromium/DEPS. You also need to roll that forward so that upstream Chromium builds succeed. Upstream Chromium DEPS rolls are not as big of a deal as downstream WebKit rolls (i.e. they're done on-demand, there's no gardening), though it's probably a good idea to do it separately from this patch. 320957 11 76161 eric 2010-12-13 00:25:43 -0800 Comment on attachment 76161 Patch LGTM. I assume this is waiting on a Chromium DEPS update? You should probably post a new patch to make sure the cr-linux ews likes it. Currently there is no way to make the ewses retry patches. 321621 12 76486 mikelawther 2010-12-13 19:13:50 -0800 Created attachment 76486 Patch 321648 13 76491 mikelawther 2010-12-13 20:53:38 -0800 Created attachment 76491 Patch 321650 14 76491 mikelawther 2010-12-13 20:57:56 -0800 Comment on attachment 76491 Patch Original patch no longer applies - updated so it does. 321670 15 76491 dbates 2010-12-13 21:35:54 -0800 Comment on attachment 76491 Patch This change looks sane to me and seems sane to Eric Seidel as per comment 11. And the Chromium DEPs were updated in changeset 73995 <http://trac.webkit.org/changeset/73995> (bug #50984). 321675 16 76491 webkit.review.bot 2010-12-13 21:53:19 -0800 Comment on attachment 76491 Patch Clearing flags on attachment: 76491 Committed r74001: <http://trac.webkit.org/changeset/74001> 321676 17 webkit.review.bot 2010-12-13 21:53:25 -0800 All reviewed patches have been landed. Closing bug. 75462 2010-12-02 21:18:19 -0800 2010-12-09 21:21:24 -0800 Patch bug-50437-20101203161817.patch text/plain 2297 mikelawther ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU2MjVjNWVlMjc5NmYzNjU4OTk5OWNlMDEzMjViOGQ2M2UxY2I5NC4uY2FkMjkxYzQ1MjAzYmRm YWRmOWM4NTY4MzQxYjlmYjlkZWM3ZjdmYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0wMiAgTWlr ZSBMYXd0aGVyICA8bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtza2lhXSBpZ25vcmUgdHJhbnNmb3JtIGZv ciBjYW52YXMgc2hhZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTA0MzcKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhp Y3NDb250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnNl dFBsYXRmb3JtU2hhZG93KToKKwogMjAxMC0xMS0yOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNw cAppbmRleCA3YzBiY2QxNDhlMmFhZjI0NzYwNTc2Zjc2ZDMzN2Y0YzNlZDUxMzk0Li5kZmMxOWNl Njc0MWQxNjQ0OTI3NTYyYTYyYzExNzk3YjQ3OWEzMTAyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC0xMDYx LDEzICsxMDYxLDE1IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNoYWRvdyhj b25zdCBGbG9hdFNpemUmIHNpemUsCiAgICAgZG91YmxlIGhlaWdodCA9IHNpemUuaGVpZ2h0KCk7 CiAgICAgZG91YmxlIGJsdXIgPSBibHVyRmxvYXQ7CiAKLSAgICAvLyBUT0RPKHRjKTogVGhpcyBz dGlsbCBkb2VzIG5vdCBhZGRyZXNzIHRoZSBpc3N1ZSB0aGF0IHNoYWRvd3MKLSAgICAvLyB3aXRo aW4gY2FudmFzIGVsZW1lbnRzIHNob3VsZCBpZ25vcmUgdHJhbnNmb3Jtcy4KKyAgICBTa0JsdXJE cmF3TG9vcGVyOjpCbHVyRmxhZ3MgYmx1ckZsYWdzID0gU2tCbHVyRHJhd0xvb3Blcjo6a05vbmVf Qmx1ckZsYWc7CisKICAgICBpZiAobV9jb21tb24tPnN0YXRlLnNoYWRvd3NJZ25vcmVUcmFuc2Zv cm1zKSAgewogICAgICAgICAvLyBDdXJyZW50bHkgb25seSB0aGUgR3JhcGhpY3NDb250ZXh0IGFz c29jaWF0ZWQgd2l0aCB0aGUKICAgICAgICAgLy8gQ2FudmFzUmVuZGVyaW5nQ29udGV4dCBmb3Ig SFRNTENhbnZhc0VsZW1lbnQgaGF2ZSBzaGFkb3dzIGlnbm9yZQogICAgICAgICAvLyBUcmFuc2Zv cm1zLiBTbyB3aXRoIHRoaXMgZmxhZyBzZXQsIHdlIGtub3cgdGhpcyBzdGF0ZSBpcyBhc3NvY2lh dGVkCiAgICAgICAgIC8vIHdpdGggYSBDYW52YXNSZW5kZXJpbmdDb250ZXh0LgorICAgICAgICBi bHVyRmxhZ3MgPSBTa0JsdXJEcmF3TG9vcGVyOjprSWdub3JlVHJhbnNmb3JtX0JsdXJGbGFnOwor ICAgICAgICAKICAgICAgICAgLy8gQ0cgdXNlcyBuYXR1cmFsIG9yaWVudGF0aW9uIGZvciBZIGF4 aXMsIGJ1dCB0aGUgSFRNTDUgY2FudmFzIHNwZWMKICAgICAgICAgLy8gZG9lcyBub3QuCiAgICAg ICAgIC8vIFNvIHdlIG5vdyBmbGlwIHRoZSBoZWlnaHQgc2luY2UgaXQgd2FzIGZsaXBwZWQgaW4K QEAgLTEwODMsNyArMTA4NSw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNo YWRvdyhjb25zdCBGbG9hdFNpemUmIHNpemUsCiAKICAgICAvLyBUT0RPKHRjKTogU2hvdWxkIHdl IGhhdmUgYSBtYXggdmFsdWUgZm9yIHRoZSBibHVyPyAgQ0cgY2xhbXBzIGF0IDEwMDAuMAogICAg IC8vIGZvciBwZXJmIHJlYXNvbnMuCi0gICAgU2tEcmF3TG9vcGVyKiBkbCA9IG5ldyBTa0JsdXJE cmF3TG9vcGVyKGJsdXIgLyAyLCB3aWR0aCwgaGVpZ2h0LCBjKTsKKyAgICBTa0RyYXdMb29wZXIq IGRsID0gbmV3IFNrQmx1ckRyYXdMb29wZXIoYmx1ciAvIDIsIHdpZHRoLCBoZWlnaHQsIGMsIGJs dXJGbGFncyk7CiAgICAgcGxhdGZvcm1Db250ZXh0KCktPnNldERyYXdMb29wZXIoZGwpOwogICAg IGRsLT51bnJlZigpOwogfQo= 76161 2010-12-09 21:21:30 -0800 2010-12-13 19:13:43 -0800 Patch bug-50437-20101210162128.patch text/plain 3744 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAppbmRleCBhZWExYzRlNWUwZjRhZmUzNjI4ZTNjOGU2YzM1ZGExODUxNzVlNmVhLi5jMzZl NTYwMDczMmZkNGFkOTkyZmYxMTBiODIwOWQ4NzE0OWQ3YzM3IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yMzQ3LDcg KzIzNDcsNiBAQCBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu c2hhZG93LmltYWdlLnRyYW5zcGFyZW50LjIuaHRtbCA9CiBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6 IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LnBhdHRlcm4uYWxwaGEuaHRtbCA9IFRFWFQK IEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cucGF0 dGVybi5iYXNpYy5odG1sID0gVEVYVAogQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnNoYWRvdy5wYXR0ZXJuLnRyYW5zcGFyZW50LjIuaHRtbCA9IFRFWFQKLUJV R1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cudHJhbnNm b3JtLjIuaHRtbCA9IFRFWFQKIEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC50cmFuc2Zvcm1hdGlvbi5zZXRUcmFuc2Zvcm0uc2tld2VkLmh0bWwgPSBURVhUCiBC VUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQudHJhbnNmb3JtYXRp b24udHJhbnNmb3JtLnNrZXdlZC5odG1sID0gVEVYVAogCkBAIC0zMDgzLDggKzMwODIsNiBAQCBC VUdfTE9JU0xPIFdJTiBMSU5VWCA6IGZhc3QvY2FudmFzL2NhbnZhcy1kcmF3SW1hZ2Utc2hhZG93 Lmh0bWwgPSBURVhUCiAKIEJVR1dLNTAxMTIgV0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFz LWNyZWF0ZVBhdHRlcm4tZmlsbFJlY3Qtc2hhZG93Lmh0bWwgPSBURVhUCiAKLUJVR0NSNjQ2NDcg V0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFzLXNjYWxlLWZpbGxSZWN0LXNoYWRvdy5odG1s ID0gVEVYVAotQlVHQ1I2NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUt ZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBURVhUCiBCVUdDUjY0NjQ3IFdJTiBMSU5VWCA6IGZhc3Qv Y2FudmFzL2NhbnZhcy1zY2FsZS1zdHJva2VQYXRoLXNoYWRvdy5odG1sID0gVEVYVAogQlVHQ1I2 NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUtZHJhd0ltYWdlLXNoYWRv dy5odG1sID0gVEVYVAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGU0NjYzZTRjZTk1M2M3Mjg5NjgyMTg1Njg2NjRiMDE5ZmM4NTVjY2Mu LjM4NjAxYzFkN2NkY2JhMWViNTEzMGY1MzQyMzJhYTZkYWYwMzE5OGQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTItMDIgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbc2tpYV0gaWdu b3JlIHRyYW5zZm9ybSBmb3IgY2FudmFzIHNoYWRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNDM3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNoYWRvdyk6CisKIDIwMTAtMTItMDcgIElseWEgVGlr aG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBh dmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv R3JhcGhpY3NDb250ZXh0U2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv R3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKaW5kZXggODRiNDJmZjFjMzFhODE3YmYzMjZhNjUwN2Mx NTJkZTNjNmNkMWI1Yi4uMWYwYTZiYzU5ODIwZWJhYTEzMTY2OWM1YjE4MDc4ZDBhMzU1YTM5ZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4 dFNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHRTa2lhLmNwcApAQCAtMTA2OSwxMyArMTA2OSwxNSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6c2V0UGxhdGZvcm1TaGFkb3coY29uc3QgRmxvYXRTaXplJiBzaXplLAogICAgIGRvdWJsZSBo ZWlnaHQgPSBzaXplLmhlaWdodCgpOwogICAgIGRvdWJsZSBibHVyID0gYmx1ckZsb2F0OwogCi0g ICAgLy8gVE9ETyh0Yyk6IFRoaXMgc3RpbGwgZG9lcyBub3QgYWRkcmVzcyB0aGUgaXNzdWUgdGhh dCBzaGFkb3dzCi0gICAgLy8gd2l0aGluIGNhbnZhcyBlbGVtZW50cyBzaG91bGQgaWdub3JlIHRy YW5zZm9ybXMuCisgICAgU2tCbHVyRHJhd0xvb3Blcjo6Qmx1ckZsYWdzIGJsdXJGbGFncyA9IFNr Qmx1ckRyYXdMb29wZXI6OmtOb25lX0JsdXJGbGFnOworCiAgICAgaWYgKG1fY29tbW9uLT5zdGF0 ZS5zaGFkb3dzSWdub3JlVHJhbnNmb3JtcykgIHsKICAgICAgICAgLy8gQ3VycmVudGx5IG9ubHkg dGhlIEdyYXBoaWNzQ29udGV4dCBhc3NvY2lhdGVkIHdpdGggdGhlCiAgICAgICAgIC8vIENhbnZh c1JlbmRlcmluZ0NvbnRleHQgZm9yIEhUTUxDYW52YXNFbGVtZW50IGhhdmUgc2hhZG93cyBpZ25v cmUKICAgICAgICAgLy8gVHJhbnNmb3Jtcy4gU28gd2l0aCB0aGlzIGZsYWcgc2V0LCB3ZSBrbm93 IHRoaXMgc3RhdGUgaXMgYXNzb2NpYXRlZAogICAgICAgICAvLyB3aXRoIGEgQ2FudmFzUmVuZGVy aW5nQ29udGV4dC4KKyAgICAgICAgYmx1ckZsYWdzID0gU2tCbHVyRHJhd0xvb3Blcjo6a0lnbm9y ZVRyYW5zZm9ybV9CbHVyRmxhZzsKKyAgICAgICAgCiAgICAgICAgIC8vIENHIHVzZXMgbmF0dXJh bCBvcmllbnRhdGlvbiBmb3IgWSBheGlzLCBidXQgdGhlIEhUTUw1IGNhbnZhcyBzcGVjCiAgICAg ICAgIC8vIGRvZXMgbm90LgogICAgICAgICAvLyBTbyB3ZSBub3cgZmxpcCB0aGUgaGVpZ2h0IHNp bmNlIGl0IHdhcyBmbGlwcGVkIGluCkBAIC0xMDkxLDcgKzEwOTMsNyBAQCB2b2lkIEdyYXBoaWNz Q29udGV4dDo6c2V0UGxhdGZvcm1TaGFkb3coY29uc3QgRmxvYXRTaXplJiBzaXplLAogCiAgICAg Ly8gVE9ETyh0Yyk6IFNob3VsZCB3ZSBoYXZlIGEgbWF4IHZhbHVlIGZvciB0aGUgYmx1cj8gIENH IGNsYW1wcyBhdCAxMDAwLjAKICAgICAvLyBmb3IgcGVyZiByZWFzb25zLgotICAgIFNrRHJhd0xv b3BlciogZGwgPSBuZXcgU2tCbHVyRHJhd0xvb3BlcihibHVyIC8gMiwgd2lkdGgsIGhlaWdodCwg Yyk7CisgICAgU2tEcmF3TG9vcGVyKiBkbCA9IG5ldyBTa0JsdXJEcmF3TG9vcGVyKGJsdXIgLyAy LCB3aWR0aCwgaGVpZ2h0LCBjLCBibHVyRmxhZ3MpOwogICAgIHBsYXRmb3JtQ29udGV4dCgpLT5z ZXREcmF3TG9vcGVyKGRsKTsKICAgICBkbC0+dW5yZWYoKTsKIH0K 76486 2010-12-13 19:13:50 -0800 2010-12-13 20:53:31 -0800 Patch bug-50437-20101214141347.patch text/plain 3744 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAppbmRleCBhZWExYzRlNWUwZjRhZmUzNjI4ZTNjOGU2YzM1ZGExODUxNzVlNmVhLi5jMzZl NTYwMDczMmZkNGFkOTkyZmYxMTBiODIwOWQ4NzE0OWQ3YzM3IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yMzQ3LDcg KzIzNDcsNiBAQCBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu c2hhZG93LmltYWdlLnRyYW5zcGFyZW50LjIuaHRtbCA9CiBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6 IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LnBhdHRlcm4uYWxwaGEuaHRtbCA9IFRFWFQK IEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cucGF0 dGVybi5iYXNpYy5odG1sID0gVEVYVAogQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnNoYWRvdy5wYXR0ZXJuLnRyYW5zcGFyZW50LjIuaHRtbCA9IFRFWFQKLUJV R1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cudHJhbnNm b3JtLjIuaHRtbCA9IFRFWFQKIEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC50cmFuc2Zvcm1hdGlvbi5zZXRUcmFuc2Zvcm0uc2tld2VkLmh0bWwgPSBURVhUCiBC VUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQudHJhbnNmb3JtYXRp b24udHJhbnNmb3JtLnNrZXdlZC5odG1sID0gVEVYVAogCkBAIC0zMDgzLDggKzMwODIsNiBAQCBC VUdfTE9JU0xPIFdJTiBMSU5VWCA6IGZhc3QvY2FudmFzL2NhbnZhcy1kcmF3SW1hZ2Utc2hhZG93 Lmh0bWwgPSBURVhUCiAKIEJVR1dLNTAxMTIgV0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFz LWNyZWF0ZVBhdHRlcm4tZmlsbFJlY3Qtc2hhZG93Lmh0bWwgPSBURVhUCiAKLUJVR0NSNjQ2NDcg V0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFzLXNjYWxlLWZpbGxSZWN0LXNoYWRvdy5odG1s ID0gVEVYVAotQlVHQ1I2NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUt ZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBURVhUCiBCVUdDUjY0NjQ3IFdJTiBMSU5VWCA6IGZhc3Qv Y2FudmFzL2NhbnZhcy1zY2FsZS1zdHJva2VQYXRoLXNoYWRvdy5odG1sID0gVEVYVAogQlVHQ1I2 NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUtZHJhd0ltYWdlLXNoYWRv dy5odG1sID0gVEVYVAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGU0NjYzZTRjZTk1M2M3Mjg5NjgyMTg1Njg2NjRiMDE5ZmM4NTVjY2Mu LjM4NjAxYzFkN2NkY2JhMWViNTEzMGY1MzQyMzJhYTZkYWYwMzE5OGQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTItMDIgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbc2tpYV0gaWdu b3JlIHRyYW5zZm9ybSBmb3IgY2FudmFzIHNoYWRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNDM3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNoYWRvdyk6CisKIDIwMTAtMTItMDcgIElseWEgVGlr aG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBh dmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv R3JhcGhpY3NDb250ZXh0U2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv R3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKaW5kZXggODRiNDJmZjFjMzFhODE3YmYzMjZhNjUwN2Mx NTJkZTNjNmNkMWI1Yi4uMWYwYTZiYzU5ODIwZWJhYTEzMTY2OWM1YjE4MDc4ZDBhMzU1YTM5ZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4 dFNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0Nv bnRleHRTa2lhLmNwcApAQCAtMTA2OSwxMyArMTA2OSwxNSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6c2V0UGxhdGZvcm1TaGFkb3coY29uc3QgRmxvYXRTaXplJiBzaXplLAogICAgIGRvdWJsZSBo ZWlnaHQgPSBzaXplLmhlaWdodCgpOwogICAgIGRvdWJsZSBibHVyID0gYmx1ckZsb2F0OwogCi0g ICAgLy8gVE9ETyh0Yyk6IFRoaXMgc3RpbGwgZG9lcyBub3QgYWRkcmVzcyB0aGUgaXNzdWUgdGhh dCBzaGFkb3dzCi0gICAgLy8gd2l0aGluIGNhbnZhcyBlbGVtZW50cyBzaG91bGQgaWdub3JlIHRy YW5zZm9ybXMuCisgICAgU2tCbHVyRHJhd0xvb3Blcjo6Qmx1ckZsYWdzIGJsdXJGbGFncyA9IFNr Qmx1ckRyYXdMb29wZXI6OmtOb25lX0JsdXJGbGFnOworCiAgICAgaWYgKG1fY29tbW9uLT5zdGF0 ZS5zaGFkb3dzSWdub3JlVHJhbnNmb3JtcykgIHsKICAgICAgICAgLy8gQ3VycmVudGx5IG9ubHkg dGhlIEdyYXBoaWNzQ29udGV4dCBhc3NvY2lhdGVkIHdpdGggdGhlCiAgICAgICAgIC8vIENhbnZh c1JlbmRlcmluZ0NvbnRleHQgZm9yIEhUTUxDYW52YXNFbGVtZW50IGhhdmUgc2hhZG93cyBpZ25v cmUKICAgICAgICAgLy8gVHJhbnNmb3Jtcy4gU28gd2l0aCB0aGlzIGZsYWcgc2V0LCB3ZSBrbm93 IHRoaXMgc3RhdGUgaXMgYXNzb2NpYXRlZAogICAgICAgICAvLyB3aXRoIGEgQ2FudmFzUmVuZGVy aW5nQ29udGV4dC4KKyAgICAgICAgYmx1ckZsYWdzID0gU2tCbHVyRHJhd0xvb3Blcjo6a0lnbm9y ZVRyYW5zZm9ybV9CbHVyRmxhZzsKKyAgICAgICAgCiAgICAgICAgIC8vIENHIHVzZXMgbmF0dXJh bCBvcmllbnRhdGlvbiBmb3IgWSBheGlzLCBidXQgdGhlIEhUTUw1IGNhbnZhcyBzcGVjCiAgICAg ICAgIC8vIGRvZXMgbm90LgogICAgICAgICAvLyBTbyB3ZSBub3cgZmxpcCB0aGUgaGVpZ2h0IHNp bmNlIGl0IHdhcyBmbGlwcGVkIGluCkBAIC0xMDkxLDcgKzEwOTMsNyBAQCB2b2lkIEdyYXBoaWNz Q29udGV4dDo6c2V0UGxhdGZvcm1TaGFkb3coY29uc3QgRmxvYXRTaXplJiBzaXplLAogCiAgICAg Ly8gVE9ETyh0Yyk6IFNob3VsZCB3ZSBoYXZlIGEgbWF4IHZhbHVlIGZvciB0aGUgYmx1cj8gIENH IGNsYW1wcyBhdCAxMDAwLjAKICAgICAvLyBmb3IgcGVyZiByZWFzb25zLgotICAgIFNrRHJhd0xv b3BlciogZGwgPSBuZXcgU2tCbHVyRHJhd0xvb3BlcihibHVyIC8gMiwgd2lkdGgsIGhlaWdodCwg Yyk7CisgICAgU2tEcmF3TG9vcGVyKiBkbCA9IG5ldyBTa0JsdXJEcmF3TG9vcGVyKGJsdXIgLyAy LCB3aWR0aCwgaGVpZ2h0LCBjLCBibHVyRmxhZ3MpOwogICAgIHBsYXRmb3JtQ29udGV4dCgpLT5z ZXREcmF3TG9vcGVyKGRsKTsKICAgICBkbC0+dW5yZWYoKTsKIH0K 76491 2010-12-13 20:53:38 -0800 2010-12-13 21:53:19 -0800 Patch bug-50437-20101214155336.patch text/plain 3772 mikelawther ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAppbmRleCA4ZTA2YzU2ZTQ2ODhhZTZkOWQ5YTNlMmU0ZjM0YjMzZjliMDA2OTYwLi45NWZh Mjc0NmI2NDIwMWEwNGE5YzFmZjE3MTZhNTBmM2QyZjRlYjY3IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0yMzkwLDcg KzIzOTAsNiBAQCBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQu c2hhZG93LmltYWdlLnRyYW5zcGFyZW50LjIuaHRtbCA9CiBCVUdXSzQ1OTkxIExJTlVYIFdJTiA6 IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuc2hhZG93LnBhdHRlcm4uYWxwaGEuaHRtbCA9IFRFWFQK IEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cucGF0 dGVybi5iYXNpYy5odG1sID0gVEVYVAogQlVHV0s0NTk5MSBMSU5VWCBXSU4gOiBjYW52YXMvcGhp bGlwL3Rlc3RzLzJkLnNoYWRvdy5wYXR0ZXJuLnRyYW5zcGFyZW50LjIuaHRtbCA9IFRFWFQKLUJV R1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5zaGFkb3cudHJhbnNm b3JtLjIuaHRtbCA9IFRFWFQKIEJVR1dLNDU5OTEgTElOVVggV0lOIDogY2FudmFzL3BoaWxpcC90 ZXN0cy8yZC50cmFuc2Zvcm1hdGlvbi5zZXRUcmFuc2Zvcm0uc2tld2VkLmh0bWwgPSBURVhUCiBC VUdXSzQ1OTkxIExJTlVYIFdJTiA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQudHJhbnNmb3JtYXRp b24udHJhbnNmb3JtLnNrZXdlZC5odG1sID0gVEVYVAogCkBAIC0zMDMyLDggKzMwMzEsNiBAQCBC VUdfTE9JU0xPIFdJTiBMSU5VWCA6IGZhc3QvY2FudmFzL2NhbnZhcy1kcmF3SW1hZ2Utc2hhZG93 Lmh0bWwgPSBURVhUCiAKIEJVR1dLNTAxMTIgV0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFz LWNyZWF0ZVBhdHRlcm4tZmlsbFJlY3Qtc2hhZG93Lmh0bWwgPSBURVhUCiAKLUJVR0NSNjQ2NDcg V0lOIExJTlVYIDogZmFzdC9jYW52YXMvY2FudmFzLXNjYWxlLWZpbGxSZWN0LXNoYWRvdy5odG1s ID0gVEVYVAotQlVHQ1I2NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUt ZmlsbFBhdGgtc2hhZG93Lmh0bWwgPSBURVhUCiBCVUdDUjY0NjQ3IFdJTiBMSU5VWCA6IGZhc3Qv Y2FudmFzL2NhbnZhcy1zY2FsZS1zdHJva2VQYXRoLXNoYWRvdy5odG1sID0gVEVYVAogQlVHQ1I2 NDY0NyBXSU4gTElOVVggOiBmYXN0L2NhbnZhcy9jYW52YXMtc2NhbGUtZHJhd0ltYWdlLXNoYWRv dy5odG1sID0gVEVYVAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDJmZjI0MzExOTljYzNlNjQwODg0NWI2NjEzODhkMDFhZjE1OWYyNmQu LjMxZTdhMTY3YjY5YTk2MTdmYjUyMjU3ODMzMjgxNTI3YWFkMzVjNGMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTItMDIgIE1pa2UgTGF3dGhlciAgPG1pa2VsYXd0aGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbc2tpYV0gaWdu b3JlIHRyYW5zZm9ybSBmb3IgY2FudmFzIHNoYWRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwNDM3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0OjpzZXRQbGF0Zm9ybVNoYWRvdyk6CisKIDIwMTAtMTItMTMgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgR3JhcGhpY3NDb250ZXh0 UHJpdmF0ZS5oIHdhcyByZW1vdmVkLiBOdWtlIGl0IGZyb20gdGhlIHByb2plY3QuCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5j cHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5j cHAKaW5kZXggMjExM2ZkNjg2YmIwNWUwNzFlNDc1Y2E1ZTExYmRiNDYyNTA0MTViMi4uMWIyMTdl ZTlmZWIxNzdmYWVlM2YyYjllYmE3N2FmZGQ0NDAxZDRkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcApAQCAtMTA2 NiwxMyArMTA2NiwxNSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c2V0UGxhdGZvcm1TaGFkb3co Y29uc3QgRmxvYXRTaXplJiBzaXplLAogICAgIGRvdWJsZSBoZWlnaHQgPSBzaXplLmhlaWdodCgp OwogICAgIGRvdWJsZSBibHVyID0gYmx1ckZsb2F0OwogCi0gICAgLy8gVE9ETyh0Yyk6IFRoaXMg c3RpbGwgZG9lcyBub3QgYWRkcmVzcyB0aGUgaXNzdWUgdGhhdCBzaGFkb3dzCi0gICAgLy8gd2l0 aGluIGNhbnZhcyBlbGVtZW50cyBzaG91bGQgaWdub3JlIHRyYW5zZm9ybXMuCisgICAgU2tCbHVy RHJhd0xvb3Blcjo6Qmx1ckZsYWdzIGJsdXJGbGFncyA9IFNrQmx1ckRyYXdMb29wZXI6OmtOb25l X0JsdXJGbGFnOworCiAgICAgaWYgKG1fc3RhdGUuc2hhZG93c0lnbm9yZVRyYW5zZm9ybXMpICB7 CiAgICAgICAgIC8vIEN1cnJlbnRseSBvbmx5IHRoZSBHcmFwaGljc0NvbnRleHQgYXNzb2NpYXRl ZCB3aXRoIHRoZQogICAgICAgICAvLyBDYW52YXNSZW5kZXJpbmdDb250ZXh0IGZvciBIVE1MQ2Fu dmFzRWxlbWVudCBoYXZlIHNoYWRvd3MgaWdub3JlCiAgICAgICAgIC8vIFRyYW5zZm9ybXMuIFNv IHdpdGggdGhpcyBmbGFnIHNldCwgd2Uga25vdyB0aGlzIHN0YXRlIGlzIGFzc29jaWF0ZWQKICAg ICAgICAgLy8gd2l0aCBhIENhbnZhc1JlbmRlcmluZ0NvbnRleHQuCisgICAgICAgIGJsdXJGbGFn cyA9IFNrQmx1ckRyYXdMb29wZXI6OmtJZ25vcmVUcmFuc2Zvcm1fQmx1ckZsYWc7CisgICAgICAg IAogICAgICAgICAvLyBDRyB1c2VzIG5hdHVyYWwgb3JpZW50YXRpb24gZm9yIFkgYXhpcywgYnV0 IHRoZSBIVE1MNSBjYW52YXMgc3BlYwogICAgICAgICAvLyBkb2VzIG5vdC4KICAgICAgICAgLy8g U28gd2Ugbm93IGZsaXAgdGhlIGhlaWdodCBzaW5jZSBpdCB3YXMgZmxpcHBlZCBpbgpAQCAtMTA4 OCw3ICsxMDkwLDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OnNldFBsYXRmb3JtU2hhZG93KGNv bnN0IEZsb2F0U2l6ZSYgc2l6ZSwKIAogICAgIC8vIFRPRE8odGMpOiBTaG91bGQgd2UgaGF2ZSBh IG1heCB2YWx1ZSBmb3IgdGhlIGJsdXI/ICBDRyBjbGFtcHMgYXQgMTAwMC4wCiAgICAgLy8gZm9y IHBlcmYgcmVhc29ucy4KLSAgICBTa0RyYXdMb29wZXIqIGRsID0gbmV3IFNrQmx1ckRyYXdMb29w ZXIoYmx1ciAvIDIsIHdpZHRoLCBoZWlnaHQsIGMpOworICAgIFNrRHJhd0xvb3BlciogZGwgPSBu ZXcgU2tCbHVyRHJhd0xvb3BlcihibHVyIC8gMiwgd2lkdGgsIGhlaWdodCwgYywgYmx1ckZsYWdz KTsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+c2V0RHJhd0xvb3BlcihkbCk7CiAgICAgZGwtPnVu cmVmKCk7CiB9Cg==