50427 2010-12-02 17:15:35 -0800 Web Inspector: Heap profile isn't shown if profiles are selected in a particular order 2010-12-02 19:43:44 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mnaganov mnaganov apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 316541 0 mnaganov 2010-12-02 17:15:35 -0800 http://code.google.com/p/chromium/issues/detail?id=65201 What steps will reproduce the problem? 1. Open any page (say, google.com) 2. Open DevTools, go to "Profiles" page. 3. Take 3 heap snapshots; "Snapshot 1" will be selected automatically 4. Select "Snapshot 3" -- its contents will never be shown (although, clicking on "Snapshot 2" shows the contents). If in step 4., instead of jumping to "Snapshot 3", one will select "Snapshot 2", and then "Snapshot 3", all snapshots will be shown. 316548 1 75442 mnaganov 2010-12-02 17:25:08 -0800 Created attachment 75442 proposed fix 316549 2 75442 eric 2010-12-02 17:26:17 -0800 Comment on attachment 75442 proposed fix Seems you'll need someone who knows the inspector to look. You can use webkit-patch suggest-reviewers to find appropriate reviewers, or pass --suggest-reviewers to webkit-patch upload to have them automatically CC'd when you post a patch. 316550 3 eric 2010-12-02 17:26:46 -0800 Nevermind. With 10 people already CC'd you should be fine. :) I clearly started at the wrong end of the review queue. 316565 4 mnaganov 2010-12-02 17:38:41 -0800 Yep, there is a special template for Inspector bugs that includes all relevant people into CC list. 316579 5 75442 pfeldman 2010-12-02 18:08:05 -0800 Comment on attachment 75442 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review > WebCore/ChangeLog:5 > + Fix heap snapshots loading. Loading is now conducted by the Web Inspector: > WebCore/inspector/front-end/ProfilesPanel.js:419 > + if (profile._loaded) blank line above. 316582 6 75442 mnaganov 2010-12-02 18:13:12 -0800 Comment on attachment 75442 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=75442&action=review >> WebCore/ChangeLog:5 >> + Fix heap snapshots loading. Loading is now conducted by the > > Web Inspector: Done >> WebCore/inspector/front-end/ProfilesPanel.js:419 >> + if (profile._loaded) > > blank line above. Fixed here and below. 316628 7 mnaganov 2010-12-02 19:43:44 -0800 Manually committed: http://trac.webkit.org/changeset/73229 2010-12-02 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: Fix heap snapshots loading. Loading is now conducted by the Profiles panel which prevents accidental simultaneous attempts to load the same profile several times in parallel. https://bugs.webkit.org/show_bug.cgi?id=50427 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot): 75442 2010-12-02 17:25:08 -0800 2010-12-02 18:13:12 -0800 proposed fix fix-crbug-65201-patch text/plain 6134 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2QyYjUwZC4uZTUyNjljMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMi0wMiAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBoZWFwIHNuYXBzaG90cyBsb2FkaW5nLiBMb2FkaW5n IGlzIG5vdyBjb25kdWN0ZWQgYnkgdGhlCisgICAgICAgIFByb2ZpbGVzIHBhbmVsIHdoaWNoIHBy ZXZlbnRzIGFjY2lkZW50YWwgc2ltdWx0YW5lb3VzIGF0dGVtcHRzIHRvCisgICAgICAgIGxvYWQg dGhlIHNhbWUgcHJvZmlsZSBzZXZlcmFsIHRpbWVzIGluIHBhcmFsbGVsLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDQyNworCisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlLl9sb2FkUHJvZmlsZSk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUucHJvY2Vzc0xvYWRlZFNu YXBzaG90KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUubG9hZEhlYXBT bmFwc2hvdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUu YWRkSGVhcFNuYXBzaG90Q2h1bmspOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFu ZWwucHJvdG90eXBlLmZpbmlzaEhlYXBTbmFwc2hvdCk6CisKIDIwMTAtMTItMDIgIEppYW4gTGkg IDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVz c2VsbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3RWaWV3LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcu anMKaW5kZXggZDA5ZjkxZC4uZjM0OTM2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcuanMKQEAgLTI0Miw3ICsyNDIsNiBAQCBXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90VmlldyA9IGZ1bmN0aW9uKHBhcmVudCwgcHJvZmlsZSkKICAgICB0aGlz LnBlcmNlbnRCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9yLlN0YXR1c0JhckJ1dHRvbigiIiwgInBl cmNlbnQtdGltZS1zdGF0dXMtYmFyLWl0ZW0gc3RhdHVzLWJhci1pdGVtIik7CiAgICAgdGhpcy5w ZXJjZW50QnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fcGVyY2VudENsaWNr ZWQuYmluZCh0aGlzKSwgZmFsc2UpOwogCi0gICAgdGhpcy5fbG9hZGVkQ2FsbGJhY2tzID0gW107 CiAgICAgdGhpcy5fbG9hZFByb2ZpbGUodGhpcy5wcm9maWxlLCBwcm9maWxlQ2FsbGJhY2suYmlu ZCh0aGlzKSk7CiAKICAgICBmdW5jdGlvbiBwcm9maWxlQ2FsbGJhY2socHJvZmlsZSkKQEAgLTQz OSwxNCArNDM4LDYgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlID0g ewogICAgICAgICB0aGlzLl91cGRhdGVTdW1tYXJ5R3JhcGgoKTsKICAgICB9LAogCi0gICAgc25h cHNob3RMb2FkZWQ6IGZ1bmN0aW9uKHVpZCwgbG9hZGVkU25hcHNob3QpCi0gICAgewotICAgICAg ICBpZiAoIXRoaXMuX2xvYWRlZENhbGxiYWNrc1t1aWRdKQotICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICB0aGlzLl9sb2FkZWRDYWxsYmFja3NbdWlkXShsb2FkZWRTbmFwc2hvdCk7Ci0gICAg ICAgIGRlbGV0ZSB0aGlzLl9sb2FkZWRDYWxsYmFja3NbdWlkXTsKLSAgICB9LAotCiAgICAgX2No YW5nZUJhc2U6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGlmICh0aGlzLmJhc2VTbmFwc2hv dC51aWQgPT09IHRoaXMuX2dldFByb2ZpbGVzKClbdGhpcy5iYXNlU2VsZWN0RWxlbWVudC5zZWxl Y3RlZEluZGV4XS51aWQpCkBAIC00ODQsMjQgKzQ3NSwxNiBAQCBXZWJJbnNwZWN0b3IuSGVhcFNu YXBzaG90Vmlldy5wcm90b3R5cGUgPSB7CiAKICAgICBfbG9hZFByb2ZpbGU6IGZ1bmN0aW9uKHBy b2ZpbGUsIGNhbGxiYWNrKQogICAgIHsKLSAgICAgICAgaWYgKHByb2ZpbGUuX2xvYWRlZCkgewot ICAgICAgICAgICAgY2FsbGJhY2socHJvZmlsZSk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAg ICAgIH0KLQotICAgICAgICB0aGlzLl9sb2FkZWRDYWxsYmFja3NbcHJvZmlsZS51aWRdID0gcHJv Y2Vzc0xvYWRlZFNuYXBzaG90LmJpbmQodGhpcyk7Ci0gICAgICAgIEluc3BlY3RvckJhY2tlbmQu Z2V0UHJvZmlsZShwcm9maWxlLnR5cGVJZCwgcHJvZmlsZS51aWQpOworICAgICAgICBXZWJJbnNw ZWN0b3IucGFuZWxzLnByb2ZpbGVzLmxvYWRIZWFwU25hcHNob3QocHJvZmlsZS51aWQsIGNhbGxi YWNrKTsKKyAgICB9LAogCi0gICAgICAgIGZ1bmN0aW9uIHByb2Nlc3NMb2FkZWRTbmFwc2hvdChs b2FkZWRTbmFwc2hvdCkKLSAgICAgICAgewotICAgICAgICAgICAgdmFyIHNuYXBzaG90ID0gdGhp cy5fY29udmVydFNuYXBzaG90KGxvYWRlZFNuYXBzaG90KTsKLSAgICAgICAgICAgIHByb2ZpbGUu Y2hpbGRyZW4gPSBzbmFwc2hvdC5jaGlsZHJlbjsKLSAgICAgICAgICAgIHByb2ZpbGUuZW50cmll cyA9IHNuYXBzaG90LmVudHJpZXM7Ci0gICAgICAgICAgICBwcm9maWxlLmxvd2xldmVscyA9IHNu YXBzaG90Lmxvd2xldmVsczsKLSAgICAgICAgICAgIHRoaXMuX3ByZXBhcmVQcm9maWxlKHByb2Zp bGUpOwotICAgICAgICAgICAgcHJvZmlsZS5fbG9hZGVkID0gdHJ1ZTsKLSAgICAgICAgICAgIGNh bGxiYWNrKHByb2ZpbGUpOwotICAgICAgICB9CisgICAgcHJvY2Vzc0xvYWRlZFNuYXBzaG90OiBm dW5jdGlvbihwcm9maWxlLCBsb2FkZWRTbmFwc2hvdCkKKyAgICB7CisgICAgICAgIHZhciBzbmFw c2hvdCA9IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3LnByb3RvdHlwZS5fY29udmVydFNu YXBzaG90KGxvYWRlZFNuYXBzaG90KTsKKyAgICAgICAgcHJvZmlsZS5jaGlsZHJlbiA9IHNuYXBz aG90LmNoaWxkcmVuOworICAgICAgICBwcm9maWxlLmVudHJpZXMgPSBzbmFwc2hvdC5lbnRyaWVz OworICAgICAgICBwcm9maWxlLmxvd2xldmVscyA9IHNuYXBzaG90Lmxvd2xldmVsczsKKyAgICAg ICAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlLl9wcmVwYXJlUHJvZmls ZShwcm9maWxlKTsKICAgICB9LAogCiAgICAgX21vdXNlRG93bkluRGF0YUdyaWQ6IGZ1bmN0aW9u KGV2ZW50KQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVz UGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpp bmRleCA1MDc5NWU4Li44Y2FmNDhlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UHJvZmlsZXNQYW5lbC5qcwpAQCAtMTIzLDcgKzEyMyw2IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxl c1BhbmVsID0gZnVuY3Rpb24oKQogCiAgICAgdGhpcy5fcHJvZmlsZXMgPSBbXTsKICAgICB0aGlz Ll9wcm9maWxlckVuYWJsZWQgPSBQcmVmZXJlbmNlcy5wcm9maWxlckFsd2F5c0VuYWJsZWQ7Ci0g ICAgdGhpcy5fdGVtcEhlYXBTbmFwc2hvdHMgPSBbXTsKICAgICB0aGlzLl9yZXNldCgpOwogfQog CkBAIC00MTIsMjMgKzQxMSw0NSBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5 cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgfSwKIAorICAgIGxvYWRIZWFwU25hcHNob3Q6IGZ1 bmN0aW9uKHVpZCwgY2FsbGJhY2spCisgICAgeworICAgICAgICB2YXIgcHJvZmlsZSA9IHRoaXMu X3Byb2ZpbGVzSWRNYXBbdGhpcy5fbWFrZUtleSh1aWQsIFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RQcm9maWxlVHlwZS5UeXBlSWQpXTsKKyAgICAgICAgaWYgKCFwcm9maWxlKQorICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICBpZiAocHJvZmlsZS5fbG9hZGVkKQorICAgICAgICAgICAgY2Fs bGJhY2socHJvZmlsZSk7CisgICAgICAgIGVsc2UgaWYgKHByb2ZpbGUuX2lzX2xvYWRpbmcpCisg ICAgICAgICAgICBwcm9maWxlLl9jYWxsYmFja3MucHVzaChjYWxsYmFjayk7CisgICAgICAgIGVs c2UgeworICAgICAgICAgICAgcHJvZmlsZS5faXNfbG9hZGluZyA9IHRydWU7CisgICAgICAgICAg ICBwcm9maWxlLl9jYWxsYmFja3MgPSBbY2FsbGJhY2tdOworICAgICAgICAgICAgcHJvZmlsZS5f anNvbiA9ICIiOworICAgICAgICAgICAgSW5zcGVjdG9yQmFja2VuZC5nZXRQcm9maWxlKHByb2Zp bGUudHlwZUlkLCBwcm9maWxlLnVpZCk7CisgICAgICAgIH0KKyAgICB9LAorCiAgICAgYWRkSGVh cFNuYXBzaG90Q2h1bms6IGZ1bmN0aW9uKHVpZCwgY2h1bmspCiAgICAgewotICAgICAgICBpZiAo dGhpcy5fdGVtcEhlYXBTbmFwc2hvdHNbdWlkXSkKLSAgICAgICAgICAgIHRoaXMuX3RlbXBIZWFw U25hcHNob3RzW3VpZF0gKz0gY2h1bms7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHRoaXMu X3RlbXBIZWFwU25hcHNob3RzW3VpZF0gPSBjaHVuazsKKyAgICAgICAgdmFyIHByb2ZpbGUgPSB0 aGlzLl9wcm9maWxlc0lkTWFwW3RoaXMuX21ha2VLZXkodWlkLCBXZWJJbnNwZWN0b3IuSGVhcFNu YXBzaG90UHJvZmlsZVR5cGUuVHlwZUlkKV07CisgICAgICAgIGlmICghcHJvZmlsZSB8fCBwcm9m aWxlLl9sb2FkZWQgfHwgIXByb2ZpbGUuX2lzX2xvYWRpbmcpCisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIHByb2ZpbGUuX2pzb24gKz0gY2h1bms7CiAgICAgfSwKIAogICAgIGZpbmlzaEhl YXBTbmFwc2hvdDogZnVuY3Rpb24odWlkKQogICAgIHsKLSAgICAgICAgdmFyIHByb2ZpbGUgPQot ICAgICAgICAgICAgdGhpcy5fcHJvZmlsZXNJZE1hcFt0aGlzLl9tYWtlS2V5KHVpZCwgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdFByb2ZpbGVUeXBlLlR5cGVJZCldOwotICAgICAgICBpZiAocHJv ZmlsZSkgewotICAgICAgICAgICAgdmFyIHZpZXcgPSBwcm9maWxlLl9fcHJvZmlsZXNQYW5lbFBy b2ZpbGVUeXBlLnZpZXdGb3JQcm9maWxlKHByb2ZpbGUpOwotICAgICAgICAgICAgdmlldy5zbmFw c2hvdExvYWRlZCh1aWQsIEpTT04ucGFyc2UodGhpcy5fdGVtcEhlYXBTbmFwc2hvdHNbdWlkXSkp OwotICAgICAgICB9Ci0gICAgICAgIGRlbGV0ZSB0aGlzLl90ZW1wSGVhcFNuYXBzaG90c1t1aWRd OworICAgICAgICB2YXIgcHJvZmlsZSA9IHRoaXMuX3Byb2ZpbGVzSWRNYXBbdGhpcy5fbWFrZUtl eSh1aWQsIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RQcm9maWxlVHlwZS5UeXBlSWQpXTsKKyAg ICAgICAgaWYgKCFwcm9maWxlIHx8IHByb2ZpbGUuX2xvYWRlZCB8fCAhcHJvZmlsZS5faXNfbG9h ZGluZykKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdmFyIGNhbGxiYWNrcyA9IHByb2Zp bGUuX2NhbGxiYWNrczsKKyAgICAgICAgZGVsZXRlIHByb2ZpbGUuX2NhbGxiYWNrczsKKyAgICAg ICAgdmFyIGxvYWRlZFNuYXBzaG90ID0gSlNPTi5wYXJzZShwcm9maWxlLl9qc29uKTsKKyAgICAg ICAgZGVsZXRlIHByb2ZpbGUuX2pzb247CisgICAgICAgIGRlbGV0ZSBwcm9maWxlLl9pc19sb2Fk aW5nOworICAgICAgICBwcm9maWxlLl9sb2FkZWQgPSB0cnVlOworICAgICAgICBXZWJJbnNwZWN0 b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90b3R5cGUucHJvY2Vzc0xvYWRlZFNuYXBzaG90KHByb2Zp bGUsIGxvYWRlZFNuYXBzaG90KTsKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjYWxsYmFj a3MubGVuZ3RoOyArK2kpCisgICAgICAgICAgICBjYWxsYmFja3NbaV0ocHJvZmlsZSk7CiAgICAg fSwKIAogICAgIHNob3dWaWV3OiBmdW5jdGlvbih2aWV3KQo=