50397 2010-12-02 09:45:24 -0800 Style Fixes in WebPluginController 2010-12-02 10:08:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned eric.carlson joepeck simon.fraser oldest_to_newest 316218 0 joepeck 2010-12-02 09:45:24 -0800 There are some variable reuses for iterators and counters. That is confusing and not WebKit style. 316223 1 75389 joepeck 2010-12-02 09:58:45 -0800 Created attachment 75389 [PATCH] Style fixes 316224 2 joepeck 2010-12-02 10:08:12 -0800 Landed in r73149: http://trac.webkit.org/changeset/73149 75389 2010-12-02 09:58:45 -0800 2010-12-02 09:59:59 -0800 [PATCH] Style fixes style.patch text/plain 2765 joepeck ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggNzY0MjhhNC4uMjA0YmJkOSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0wMiAg Sm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0eWxlIEZpeGVzIGluIFdlYlBsdWdpbkNv bnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUwMzk3CisKKyAgICAgICAgKiBQbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xsZXIubW06CisgICAg ICAgICgtW1dlYlBsdWdpbkNvbnRyb2xsZXIgc3RhcnRBbGxQbHVnaW5zXSk6CisgICAgICAgICgt W1dlYlBsdWdpbkNvbnRyb2xsZXIgc3RvcEFsbFBsdWdpbnNdKToKKwogMjAxMC0xMi0wMSAgSmlh IFB1ICA8anB1QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJQbHVnaW5Db250cm9sbGVyLm1tIGIv V2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xsZXIubW0KaW5kZXggOWMwMzdjMi4u YzgwMmQ0YyAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xs ZXIubW0KKysrIGIvV2ViS2l0L21hYy9QbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xsZXIubW0KQEAg LTE3NCw4ICsxNzQsOCBAQCBzdGF0aWMgTlNNdXRhYmxlU2V0ICpwbHVnaW5WaWV3cyA9IG5pbDsK ICAgICBpZiAoW192aWV3cyBjb3VudF0gPiAwKQogICAgICAgICBMT0coUGx1Z2lucywgInN0YXJ0 aW5nIFdlYktpdCBwbHVnaW5zIDogJUAiLCBbX3ZpZXdzIGRlc2NyaXB0aW9uXSk7CiAgICAgCi0g ICAgaW50IGksIGNvdW50ID0gW192aWV3cyBjb3VudF07Ci0gICAgZm9yIChpID0gMDsgaSA8IGNv dW50OyBpKyspIHsKKyAgICBpbnQgY291bnQgPSBbX3ZpZXdzIGNvdW50XTsKKyAgICBmb3IgKGlu dCBpID0gMDsgaSA8IGNvdW50OyBpKyspIHsKICAgICAgICAgaWQgYVZpZXcgPSBbX3ZpZXdzIG9i amVjdEF0SW5kZXg6aV07CiAgICAgICAgIGlmIChbYVZpZXcgcmVzcG9uZHNUb1NlbGVjdG9yOkBz ZWxlY3Rvcih3ZWJQbHVnSW5TdGFydCldKSB7CiAgICAgICAgICAgICBKU0M6OkpTTG9jazo6RHJv cEFsbExvY2tzIGRyb3BBbGxMb2NrcyhKU0M6OlNpbGVuY2VBc3NlcnRpb25zT25seSk7CkBAIC0x OTcsMTMgKzE5NywxMyBAQCBzdGF0aWMgTlNNdXRhYmxlU2V0ICpwbHVnaW5WaWV3cyA9IG5pbDsK ICAgICAgICAgTE9HKFBsdWdpbnMsICJzdG9wcGluZyBXZWJLaXQgcGx1Z2luczogJUAiLCBbX3Zp ZXdzIGRlc2NyaXB0aW9uXSk7CiAgICAgfQogICAgIAotICAgIGludCBpLCBjb3VudCA9IFtfdmll d3MgY291bnRdOwotICAgIGZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKQorICAgIGludCB2aWV3 c0NvdW50ID0gW192aWV3cyBjb3VudF07CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCB2aWV3c0Nv dW50OyBpKyspCiAgICAgICAgIFtzZWxmIHN0b3BPbmVQbHVnaW46W192aWV3cyBvYmplY3RBdElu ZGV4OmldXTsKIAogI2lmIEVOQUJMRShQTFVHSU5fUFJPWFlfRk9SX1ZJREVPKQotICAgIGNvdW50 ID0gW192aWV3c05vdEluRG9jdW1lbnQgY291bnRdOwotICAgIGZvciAoaSA9IDA7IGkgPCBjb3Vu dDsgaSsrKQorICAgIGludCB2aWV3c05vdEluRG9jdW1lbnRDb3VudCA9IFtfdmlld3NOb3RJbkRv Y3VtZW50IGNvdW50XTsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IHZpZXdzTm90SW5Eb2N1bWVu dENvdW50OyBpKyspCiAgICAgICAgIFtzZWxmIHN0b3BPbmVQbHVnaW46W192aWV3c05vdEluRG9j dW1lbnQgb2JqZWN0QXRJbmRleDppXV07CiAjZW5kaWYKIApAQCAtMzMzLDggKzMzMyw4IEBAIHN0 YXRpYyB2b2lkIGNhbmNlbE91dHN0YW5kaW5nQ2hlY2soY29uc3Qgdm9pZCAqaXRlbSwgdm9pZCAq Y29udGV4dCkKIAogICAgIFtzZWxmIF9jYW5jZWxPdXRzdGFuZGluZ0NoZWNrc107CiAgICAgCi0g ICAgaW50IGksIGNvdW50ID0gW192aWV3cyBjb3VudF07Ci0gICAgZm9yIChpID0gMDsgaSA8IGNv dW50OyBpKyspIHsKKyAgICBpbnQgdmlld3NDb3VudCA9IFtfdmlld3MgY291bnRdOworICAgIGZv ciAoaW50IGkgPSAwOyBpIDwgdmlld3NDb3VudDsgaSsrKSB7CiAgICAgICAgIGlkIGFWaWV3ID0g W192aWV3cyBvYmplY3RBdEluZGV4OmldOwogICAgICAgICBbc2VsZiBkZXN0cm95T25lUGx1Z2lu OmFWaWV3XTsKICAgICAgICAgCkBAIC0zNDgsOCArMzQ4LDggQEAgc3RhdGljIHZvaWQgY2FuY2Vs T3V0c3RhbmRpbmdDaGVjayhjb25zdCB2b2lkICppdGVtLCB2b2lkICpjb250ZXh0KQogICAgIH0K IAogI2lmIEVOQUJMRShQTFVHSU5fUFJPWFlfRk9SX1ZJREVPKQotICAgIGNvdW50ID0gW192aWV3 c05vdEluRG9jdW1lbnQgY291bnRdOwotICAgIGZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKQor ICAgIGludCB2aWV3c05vdEluRG9jdW1lbnRDb3VudCA9IFtfdmlld3NOb3RJbkRvY3VtZW50IGNv dW50XTsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IHZpZXdzTm90SW5Eb2N1bWVudENvdW50OyBp KyspCiAgICAgICAgIFtzZWxmIGRlc3Ryb3lPbmVQbHVnaW46W192aWV3c05vdEluRG9jdW1lbnQg b2JqZWN0QXRJbmRleDppXV07CiAjZW5kaWYKIAo=