50373 2010-12-01 22:50:54 -0800 [Qt] Sub-Frame content is not updated when scrolling in certain circumstances 2011-05-04 12:59:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Major --- 45423 0 thomas.thrainer webkit-unassigned benjamin commit-queue diegohcg kenneth luiz tonikitoo webkit.review.bot oldest_to_newest 316021 0 75355 thomas.thrainer 2010-12-01 22:50:54 -0800 Created attachment 75355 Patch wich fixes the problem, but very inefficiently Steps to reproduce: * Start QtTestBrowser * Enable QGraphicsWebView * Enable Accelerated Compositing (not sure if that's needed) * Enable Resizes to Contents Mode (not sure if that's needed) * Enable Tiled Backing Store (needed) * go to images.google.com * Search for asdf * Click on one of the result images, make sure that the browser window is quite small * Google will display an iFrame in the lower part of the screen * If you try to scroll the iFrame content, only the scroll bar is updated, but not the content of the frame I attach a patch which fixes the bug, but which obviously is very inefficient. 318806 1 thomas.thrainer 2010-12-08 08:47:16 -0800 The previous patch did not work in all cases, so I'll attach the new one. It's also more efficient. 318808 2 75911 thomas.thrainer 2010-12-08 08:48:10 -0800 Created attachment 75911 New patch which invalidates the backing store more often and more efficiently 318810 3 thomas.thrainer 2010-12-08 08:51:28 -0800 BTW, I'm using QtWebkit 2.1 week 47 (plus a patch from week 48). 318841 4 75916 thomas.thrainer 2010-12-08 09:54:44 -0800 Created attachment 75916 New patch, this time avoiding to invalidate the backing store too often. The previous patch was somewhat premature and did invalidate the backing store way too often. Fixed in this version. BTW: I do know that I instead should enable frame flattening in order to work around this bug, but as frame flattening has its own problems (#50391), I need this to work too. 334310 5 benjamin 2011-01-14 08:06:38 -0800 Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs Otherwise bugs are not seen by us. Please follow http://trac.webkit.org/wiki/QtWebKitContrib to contribute patches. If you do not use the review flag, the reviewer will not see you patches. 335160 6 webkit.review.bot 2011-01-16 23:40:48 -0800 Attachment 75916 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 335490 7 75916 kling 2011-01-17 13:24:40 -0800 Comment on attachment 75916 New patch, this time avoiding to invalidate the backing store too often. Needs a ChangeLog entry. Please see http://trac.webkit.org/wiki/QtWebKitContrib for more information on how to contribute patches to QtWebKit. 356898 8 diegohcg 2011-02-24 05:09:26 -0800 Still reproducible with r79447 383253 9 89025 menard 2011-04-11 10:37:02 -0700 Created attachment 89025 Version with changelog and rebased. 383254 10 kenneth 2011-04-11 10:38:40 -0700 Doesn't it happen for div's with overflow as well? 383350 11 commit-queue 2011-04-11 12:11:10 -0700 The commit-queue encountered the following flaky tests while processing attachment 89025: animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 383356 12 89025 commit-queue 2011-04-11 12:14:54 -0700 Comment on attachment 89025 Version with changelog and rebased. Clearing flags on attachment: 89025 Committed r83473: <http://trac.webkit.org/changeset/83473> 383357 13 commit-queue 2011-04-11 12:14:59 -0700 All reviewed patches have been landed. Closing bug. 383364 14 tonikitoo 2011-04-11 12:22:28 -0700 No mention to Thomas Thrainer work? =/ in your changelog 383365 15 tonikitoo 2011-04-11 12:22:51 -0700 (In reply to comment #10) > Doesn't it happen for div's with overflow as well? afaik, div scrolling goes through invalidateContentsAndWindow codepath. 75355 2010-12-01 22:50:54 -0800 2010-12-08 08:48:10 -0800 Patch wich fixes the problem, but very inefficiently 0004_tiitoo_update_when_scrolling.patch text/plain 598 thomas.thrainer LS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAJMjAxMC0xMS0y OSAxMjozNjo0Mi44NTU1OTc5OTggKzAxMDAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1BhZ2VDbGllbnRRdC5jcHAJMjAxMC0xMi0wMSAxMjowOTowNi41NTQxNjg5OTggKzAxMDAKQEAg LTEyMyw2ICsxMjMsMTMgQEAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAg dXBkYXRlQ29tcG9zaXRpbmdTY3JvbGxQb3NpdGlvbigpOwogI2VuZGlmCisKKyNpZiBFTkFCTEUo VElMRURfQkFDS0lOR19TVE9SRSkKKyAgICBXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZSogYmFj a2luZ1N0b3JlID0gUVdlYkZyYW1lUHJpdmF0ZTo6Y29yZShwYWdlLT5tYWluRnJhbWUoKSktPnRp bGVkQmFja2luZ1N0b3JlKCk7CisgICAgaWYgKCFiYWNraW5nU3RvcmUpCisgICAgICAgIHJldHVy bjsKKyAgICBiYWNraW5nU3RvcmUtPmludmFsaWRhdGUoSW50UmVjdCgwLCAwLCAxMDAwMDAsIDEw MDAwMCkpOworI2VuZGlmCiB9CiAKIHZvaWQgUGFnZUNsaWVudFFHcmFwaGljc1dpZGdldDo6dXBk YXRlKGNvbnN0IFFSZWN0JiBkaXJ0eVJlY3QpCg== 75911 2010-12-08 08:48:10 -0800 2010-12-08 09:54:44 -0800 New patch which invalidates the backing store more often and more efficiently 0004_tiitoo_update_when_scrolling.patch text/plain 1265 thomas.thrainer LS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1BhZ2VDbGllbnRRdC5jcHAJMjAxMC0xMi0w MiAwOToyNjowMC4zNTQ3NDQwMDEgKzAxMDAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1BhZ2VDbGllbnRRdC5jcHAJMjAxMC0xMi0wOCAxNzozNjoxNi40MzQ3NjkwMDIgKzAxMDAKQEAg LTEyNCw2ICsxMjQsMTUgQEAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAg dXBkYXRlQ29tcG9zaXRpbmdTY3JvbGxQb3NpdGlvbigpOwogI2VuZGlmCisKKyNpZiBFTkFCTEUo VElMRURfQkFDS0lOR19TVE9SRSkKKyAgICBXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZSogYmFj a2luZ1N0b3JlID0gUVdlYkZyYW1lUHJpdmF0ZTo6Y29yZShwYWdlLT5tYWluRnJhbWUoKSktPnRp bGVkQmFja2luZ1N0b3JlKCk7CisgICAgaWYgKCFiYWNraW5nU3RvcmUpCisgICAgICAgIHJldHVy bjsKKyAgICBiYWNraW5nU3RvcmUtPmludmFsaWRhdGUoCisgICAgICAgICAgICBJbnRSZWN0KHJl Y3RUb1Njcm9sbC54KCksIHJlY3RUb1Njcm9sbC55KCksCisgICAgICAgICAgICAgICAgICAgIHJl Y3RUb1Njcm9sbC53aWR0aCgpLCByZWN0VG9TY3JvbGwuaGVpZ2h0KCkpKTsKKyNlbmRpZgogfQog CiB2b2lkIFBhZ2VDbGllbnRRR3JhcGhpY3NXaWRnZXQ6OnVwZGF0ZShjb25zdCBRUmVjdCYgZGly dHlSZWN0KQpAQCAtMTM4LDYgKzE0NywxNSBAQAogICAgIC8vIFRoaXMgbWlnaHQgYmUgYSBzbG93 LXNjcm9sbC4gV2UgZW5zdXJlIHRoYXQgdGhlIGNvbXBvc2l0aW5nIGxheWVycyBhcmUgaW4gdGhl IHJpZ2h0IHBvc2l0aW9uLgogICAgIHVwZGF0ZUNvbXBvc2l0aW5nU2Nyb2xsUG9zaXRpb24oKTsK ICNlbmRpZgorCisjaWYgRU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCisgICAgV2ViQ29yZTo6 VGlsZWRCYWNraW5nU3RvcmUqIGJhY2tpbmdTdG9yZSA9IFFXZWJGcmFtZVByaXZhdGU6OmNvcmUo cGFnZS0+bWFpbkZyYW1lKCkpLT50aWxlZEJhY2tpbmdTdG9yZSgpOworICAgIGlmICghYmFja2lu Z1N0b3JlKQorICAgICAgICByZXR1cm47CisgICAgYmFja2luZ1N0b3JlLT5pbnZhbGlkYXRlKAor ICAgICAgICAgICAgSW50UmVjdChkaXJ0eVJlY3QueCgpLCBkaXJ0eVJlY3QueSgpLAorICAgICAg ICAgICAgICAgICAgICBkaXJ0eVJlY3Qud2lkdGgoKSwgZGlydHlSZWN0LmhlaWdodCgpKSk7Cisj ZW5kaWYKIH0KIAogdm9pZCBQYWdlQ2xpZW50UUdyYXBoaWNzV2lkZ2V0OjpjcmVhdGVPckRlbGV0 ZU92ZXJsYXkoKQo= 75916 2010-12-08 09:54:44 -0800 2011-04-11 10:37:02 -0700 New patch, this time avoiding to invalidate the backing store too often. 0004_tiitoo_update_when_scrolling.patch text/plain 1414 thomas.thrainer LS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAkyMDEwLTEy LTAyIDA5OjI2OjAwLjM1NDc0NDAwMSArMDEwMAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvQ2hyb21lQ2xpZW50UXQuY3BwCTIwMTAtMTItMDggMTg6MzQ6NTIuNzg0NzY4OTk2ICswMTAw CkBAIC0zNzQsOSArMzc0LDE2IEBACiAjZW5kaWYKIH0KIAotdm9pZCBDaHJvbWVDbGllbnRRdDo6 aW52YWxpZGF0ZVdpbmRvdyhjb25zdCBJbnRSZWN0JiwgYm9vbCkKK3ZvaWQgQ2hyb21lQ2xpZW50 UXQ6OmludmFsaWRhdGVXaW5kb3coY29uc3QgSW50UmVjdCYgd2luZG93UmVjdCwgYm9vbCkKIHsK ICAgICBub3RJbXBsZW1lbnRlZCgpOworCisgICAgaWYgKHBsYXRmb3JtUGFnZUNsaWVudCgpKSB7 CisgICAgICAgIFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlKiBiYWNraW5nU3RvcmUgPSBRV2Vi RnJhbWVQcml2YXRlOjpjb3JlKG1fd2ViUGFnZS0+bWFpbkZyYW1lKCkpLT50aWxlZEJhY2tpbmdT dG9yZSgpOworICAgICAgICBpZiAoIWJhY2tpbmdTdG9yZSkKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgYmFja2luZ1N0b3JlLT5pbnZhbGlkYXRlKHdpbmRvd1JlY3QpOworICAgIH0KIH0K IAogdm9pZCBDaHJvbWVDbGllbnRRdDo6aW52YWxpZGF0ZUNvbnRlbnRzQW5kV2luZG93KGNvbnN0 IEludFJlY3QmIHdpbmRvd1JlY3QsIGJvb2wgaW1tZWRpYXRlKQotLS0gYS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcAkyMDEwLTEyLTAyIDA5OjI2OjAwLjM1NDc0NDAw MSArMDEwMAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUGFnZUNsaWVudFF0LmNwcAky MDEwLTEyLTA4IDE4OjM1OjAzLjE0NDc2OTAwMCArMDEwMApAQCAtMTI0LDYgKzEyNCwxNSBAQAog I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICB1cGRhdGVDb21wb3NpdGluZ1Nj cm9sbFBvc2l0aW9uKCk7CiAjZW5kaWYKKworI2lmIEVOQUJMRShUSUxFRF9CQUNLSU5HX1NUT1JF KQorICAgIFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlKiBiYWNraW5nU3RvcmUgPSBRV2ViRnJh bWVQcml2YXRlOjpjb3JlKHBhZ2UtPm1haW5GcmFtZSgpKS0+dGlsZWRCYWNraW5nU3RvcmUoKTsK KyAgICBpZiAoIWJhY2tpbmdTdG9yZSkKKyAgICAgICAgcmV0dXJuOworICAgIGJhY2tpbmdTdG9y ZS0+aW52YWxpZGF0ZSgKKyAgICAgICAgICAgIEludFJlY3QocmVjdFRvU2Nyb2xsLngoKSwgcmVj dFRvU2Nyb2xsLnkoKSwKKyAgICAgICAgICAgICAgICAgICAgcmVjdFRvU2Nyb2xsLndpZHRoKCks IHJlY3RUb1Njcm9sbC5oZWlnaHQoKSkpOworI2VuZGlmCiB9CiAKIHZvaWQgUGFnZUNsaWVudFFH cmFwaGljc1dpZGdldDo6dXBkYXRlKGNvbnN0IFFSZWN0JiBkaXJ0eVJlY3QpCg== 89025 2011-04-11 10:37:02 -0700 2011-04-11 12:14:54 -0700 Version with changelog and rebased. patch.diff text/plain 1830 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggMDljZGU1OS4uNTM2MDlmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMS0wNC0xMSAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3Bl bmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIFN1Yi1GcmFtZSBjb250ZW50IGlzIG5vdCB1cGRhdGVkIHdoZW4gc2Nyb2xsaW5n IGluIGNlcnRhaW4gY2lyY3Vtc3RhbmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTAzNzMKKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB3ZSBpbnZh bGlkYXRlIHRoZSBiYWNraW5nIHN0b3JlIHdoZW4gdXNpbmcgVElMRURfQkFDS0lOR19TVE9SRQor ICAgICAgICBhbmQgdGhlIHBhZ2UgY29udGFpbnMgc3ViIGZyYW1lcy4gVGhpcyBidWcgYXBwZWFy cyBvbmx5IHdoZW4gZnJhbWUgZmxhdHRlbmluZyBpcworICAgICAgICBkaXNhYmxlZCBhbmQgc2Ny b2xsYWJsZSBzdWJmcmFtZXMuCisKKyAgICAgICAgT3JpZ2luYWwgcGF0Y2ggZnJvbSBUaG9tYXMg VGhyYWluZXIuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnRRdDo6aW52YWxpZGF0ZVdpbmRvdyk6CisK IDIwMTEtMDQtMTEgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRRdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudFF0LmNwcAppbmRleCBmY2RkYjg5 Li5lYTJjODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudFF0LmNwcApAQCAtMzk5LDkgKzM5OSwxOCBAQCBJbnRSZWN0IENocm9tZUNsaWVu dFF0Ojp3aW5kb3dSZXNpemVyUmVjdCgpIGNvbnN0CiAjZW5kaWYKIH0KIAotdm9pZCBDaHJvbWVD bGllbnRRdDo6aW52YWxpZGF0ZVdpbmRvdyhjb25zdCBJbnRSZWN0JiwgYm9vbCkKK3ZvaWQgQ2hy b21lQ2xpZW50UXQ6OmludmFsaWRhdGVXaW5kb3coY29uc3QgSW50UmVjdCYgd2luZG93UmVjdCwg Ym9vbCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworI2lmIEVOQUJMRShUSUxFRF9CQUNLSU5H X1NUT1JFKQorICAgIGlmIChwbGF0Zm9ybVBhZ2VDbGllbnQoKSkgeworICAgICAgICBXZWJDb3Jl OjpUaWxlZEJhY2tpbmdTdG9yZSogYmFja2luZ1N0b3JlID0gUVdlYkZyYW1lUHJpdmF0ZTo6Y29y ZShtX3dlYlBhZ2UtPm1haW5GcmFtZSgpKS0+dGlsZWRCYWNraW5nU3RvcmUoKTsKKyAgICAgICAg aWYgKCFiYWNraW5nU3RvcmUpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIGJhY2tpbmdT dG9yZS0+aW52YWxpZGF0ZSh3aW5kb3dSZWN0KTsKKyAgICB9CisjZWxzZQorICAgIFFfVU5VU0VE KHdpbmRvd1JlY3QpOworI2VuZGlmCiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50UXQ6OmludmFsaWRh dGVDb250ZW50c0FuZFdpbmRvdyhjb25zdCBJbnRSZWN0JiB3aW5kb3dSZWN0LCBib29sIGltbWVk aWF0ZSkK