50359 2010-12-01 16:44:16 -0800 [chromium] force NRWT to use DRT 2010-12-08 11:00:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony dpranke ojan victorw oldest_to_newest 315938 0 tony 2010-12-01 16:44:16 -0800 [chromium] force NRWT to use DRT 315940 1 75333 tony 2010-12-01 16:44:41 -0800 Created attachment 75333 Patch 315941 2 tony 2010-12-01 16:45:51 -0800 This is intentionally small so when the canaries break, I can roll back. If it sticks, I'll make a follow up patch to remove the flag (and to remove the flag from the bots). 315942 3 dpranke 2010-12-01 16:47:08 -0800 Heh. LGTM! 316250 4 tony 2010-12-02 10:59:25 -0800 Just an fyi for victorw, the current gardener. 316252 5 tony 2010-12-02 11:00:23 -0800 Committed r73164: <http://trac.webkit.org/changeset/73164> 316449 6 tony 2010-12-02 15:20:44 -0800 Reverted r73164 for reason: broke debugger tests on win Committed r73207: <http://trac.webkit.org/changeset/73207> 318405 7 tony 2010-12-07 13:06:05 -0800 Committed r73456: <http://trac.webkit.org/changeset/73456> 318567 8 dpranke 2010-12-07 20:20:01 -0800 Okay, I should have caught this before, but realizing this now ... changing the default this way doesn't give us a way to run w/ TestShell anymore. We need to add a --no-use-drt flag (or a --use-test-shell or something). It's not hard to hack the RWT code to work around this, obviously, and we don't really want to encourage people to use this code, but as long as TestShell is being supported, I'd prefer we have a way to run this without local mods. Thoughts? Also, any thought as to when we might actually stop supporting TestShell and remove the code from the Tree? 318801 9 ojan 2010-12-08 08:39:58 -0800 This was the most expedient way we could think of making this change. The plan, if this sticks for the next day or two, is to fully remove all TestShell support. 318842 10 tony 2010-12-08 09:57:20 -0800 I'm going to write a patch today for --use-test-shell (jamesr's recommendation for testing for DRT specific failures). As mentioned in comment #2, this patch was intentionally small. 318891 11 dpranke 2010-12-08 11:00:53 -0800 (In reply to comment #10) > I'm going to write a patch today for --use-test-shell (jamesr's recommendation for testing for DRT specific failures). > > As mentioned in comment #2, this patch was intentionally small. Sure, I think keeping the patch small was a good thing to. Just a bit too small ;) 75333 2010-12-01 16:44:41 -0800 2010-12-01 17:00:59 -0800 Patch bug-50359-20101201164527.patch text/plain 1459 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkYjQ0N2EwNmU0YTNlMjg4Mzg0MjU4ZGFlZWIwMDM1Y2ZkNzY4M2I5Li44YThkZTcy YjU5MzcxYTU5MTE2MWI5OGRmMjdjOTQ1YjdjMjhmNDhhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTItMDEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZvcmNlIE5S V1QgdG8gdXNlIERSVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTAzNTkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMTItMDEgIE1paGFpIFBhcnBhcml0YSAgPG1paGFp cEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGY0ZTkyYTY4Njk4ZDRiMDY5MDMxZDZiYjFiMzc4ODJk YmFmMWZhZjUuLmYzYjFkYTA2NDZkNTdmODY5MWNiMDZhZTY1MDc4NDFlNmZiY2U1NGUgMTAwNzU1 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMTQzMiw4ICsxNDMyLDggQEAgZGVmIHBhcnNlX2Fy Z3MoYXJncz1Ob25lKToKICAgICAgICAgICAgIGRlZmF1bHQ9RmFsc2UsCiAgICAgICAgICAgICBo ZWxwPSJEb24ndCBjaGVjayB0aGUgc3lzdGVtIGRlcGVuZGVuY2llcyAodGhlbWVzKSIpLAogICAg ICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS11c2UtZHJ0IiwgYWN0aW9uPSJzdG9yZV90cnVl IiwKLSAgICAgICAgICAgIGRlZmF1bHQ9Tm9uZSwKLSAgICAgICAgICAgIGhlbHA9IlVzZSBEdW1w UmVuZGVyVHJlZSBpbnN0ZWFkIG9mIHRlc3Rfc2hlbGwiKSwKKyAgICAgICAgICAgIGRlZmF1bHQ9 VHJ1ZSwKKyAgICAgICAgICAgIGhlbHA9IihERVBSRUNBVEVEKSIpLAogICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbigiLS1hY2NlbGVyYXRlZC1jb21wb3NpdGluZyIsCiAgICAgICAgICAgICBh Y3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgaGVscD0iVXNlIGhhcmR3YXJlLWFjY2Vs YXRlZCBjb21wb3NpdGluZyBmb3IgcmVuZGVyaW5nIiksCg==