50342 2010-12-01 12:01:48 -0800 Unnecessary invalidation of copyright <span> on IE9 Flying Images demo 2010-12-14 17:40:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 NEW P2 Normal --- 1 fishd jamesr commit-queue eric hyatt jamesr mitz sam simon.fraser oldest_to_newest 315791 0 fishd 2010-12-01 12:01:48 -0800 Unnecessary invalidation of copyright <span> on IE9 Flying Images demo Watching invalidations that occur on the IE9 Flying Images demo (http://ie.microsoft.com/testdrive/Performance/FlyingImages/Default.html), I observe that the copyright span at the bottom of the page is continually invalidated. I reduced this down somewhat. See the attached test case. In the test case, if I give #board an explicit "left" and "top" coordinate, then the problem goes away. (If you are running Chromium, you can observe invalidations by running with the --show-paint-rects command line switch.) 315792 1 75300 fishd 2010-12-01 12:04:00 -0800 Created attachment 75300 testcase 315828 2 sam 2010-12-01 12:49:43 -0800 You can also observe this using QuartzDebug on OS X. 315832 3 simon.fraser 2010-12-01 12:56:26 -0800 To debug, see who's calling repaint() on the span 315853 4 jamesr 2010-12-01 13:21:06 -0800 render tree: RenderView 0x7ffff7ef1a98 #document 0x7ffff7ef8000 RenderBlock 0x7ffff7f30478 HTML 0x7fffeb51c800 * RenderBody 0x7ffff7f30ef8 BODY 0x7fffeb064240 RenderBlock (positioned) 0x7fffe6e78718 DIV 0x7fffeaa4cb00 RenderBlock (positioned) 0x7fffe6e78558 DIV 0x7fffeaa4ca80 STYLE=top: -300px; RenderBlock (positioned) 0x7fffe6e78478 SPAN 0x7fffeaa4c980 RenderText 0x7fffeaa4c918 #text 0x7fffeaa48540 "Blah, blah" RenderBlock::layoutInlineChildren() on the <body>'s RenderBlock is marking the <span> as m_normalChildNeedsLayout because the <span> has a percentage width. This means it later gets marked for repainting even though none of its children actually move. http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderBlockLineLayout.cpp#L552 seems a little pessimistic. 315962 5 75337 jamesr 2010-12-01 17:31:10 -0800 Created attachment 75337 Patch 316563 6 75337 eric 2010-12-02 17:38:02 -0800 Comment on attachment 75337 Patch This looks like a mitz/hyatt patch to review. :) 316568 7 jamesr 2010-12-02 17:44:34 -0800 Actually hyatt typed out the meat of this patch verbatim in IRC. I just added the comment, testcase, and verified that this doesn't cause all the other layout tests to explode. 316667 8 75337 commit-queue 2010-12-02 21:58:23 -0800 Comment on attachment 75337 Patch Rejecting patch 75337 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ning/auto ....... fast/blockflow ................................................ fast/body-propagation/background-color ..................... fast/body-propagation/background-image ......................... fast/body-propagation/overflow ................... fast/borders ... fast/borders/border-fit.html -> failed Exiting early after 1 failures. 5969 tests run. 105.41s total testing time 5968 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/6751028 321776 9 eric 2010-12-14 01:28:47 -0800 Seems this patch will need an update since it breaks a test. 322260 10 eric 2010-12-14 15:14:06 -0800 Attachment 75337 was posted by a committer and has review+, assigning to James Robinson for commit. 322391 11 75337 jamesr 2010-12-14 17:40:08 -0800 Comment on attachment 75337 Patch Clearing flags, patch was reverted. 75300 2010-12-01 12:04:00 -0800 2010-12-01 12:04:00 -0800 testcase images_reduced.html text/html 1077 fishd CjxzdHlsZT4KICAgICAgICBodG1sCiAgICAgICAgewogICAgICAgICAgICBvdmVyZmxvdzogaGlk ZGVuOwogICAgICAgIH0KICAgICAgICAKICAgICAgICBib2R5CiAgICAgICAgewogICAgICAgICAg ICBtYXJnaW46IDBweDsKICAgICAgICAgICAgcGFkZGluZzogMHB4OwogICAgICAgIH0gICAgICAg IAoKICAgICAgICAjYm9hcmQKICAgICAgICB7CiAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0 ZTsKICAgICAgICAgICAgd2lkdGg6IDFweDsKICAgICAgICAgICAgaGVpZ2h0OiAxcHg7CiAgICAg ICAgICAgIC8qCiAgICAgICAgICAgIHRvcDogMHB4OwogICAgICAgICAgICBsZWZ0OiAwcHg7CiAg ICAgICAgICAgICovCiAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGdyZWVuOwogICAgICAg IH0KCiAgICAgICAgI2xvZ28KICAgICAgICB7CiAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0 ZTsKICAgICAgICAgICAgd2lkdGg6IDEwMHB4OwogICAgICAgICAgICBoZWlnaHQ6IDEwMHB4Owog ICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiB5ZWxsb3c7CiAgICAgICAgfQoKICAgICAgICAj Y29weXJpZ2h0CiAgICAgICAgewogICAgICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAg ICAgICAgIGJvdHRvbTogM3B4OwogICAgICAgICAgICByaWdodDogNnB4OwogICAgICAgICAgICB3 aWR0aDogMTAwJTsKICAgICAgICB9Cjwvc3R5bGU+Cgo8c2NyaXB0Pgp2YXIgY291bnRlciA9IDA7 CnZhciBwb3NpdGlvbnMgPSBbIC0zMDAsIDMwMCBdOwoKZnVuY3Rpb24gQW5pbWF0ZSgpIHsKICB2 YXIgaW1nID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZ28iKTsKCiAgaW1nLnN0eWxlLnRv cCA9IHBvc2l0aW9uc1tjb3VudGVyXSArICJweCI7CiAgY291bnRlciA9ICsrY291bnRlciAlIDI7 Cn0Kc2V0SW50ZXJ2YWwoQW5pbWF0ZSwgNTAwKTsKPC9zY3JpcHQ+Cgo8Ym9keT4KICAgIDxkaXYg aWQ9ImJvYXJkIj48ZGl2IGlkPSJsb2dvIiBzdHlsZT0idG9wOiAzMDAiPjwvZGl2PjwvZGl2PgoK ICAgIDxzcGFuIGlkPSJjb3B5cmlnaHQiPkJsYWgsIGJsYWg8L3NwYW4+CjwvYm9keT4K 75337 2010-12-01 17:31:10 -0800 2010-12-14 17:40:08 -0800 Patch bug-50342-20101201173109.patch text/plain 9387 jamesr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5N2Y1YTI2MDNlNDA0ZDk4Y2JmMzhhNmUyMjZhY2NjYzE2MDVlNDQ0Li41YWU5YzM1 MGMyN2Y4ZTIzNDMxZGU4NDMwMTkxZWRlZWM0MjA5MWExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMTItMDEgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbm5lY2Vzc2FyeSBp bnZhbGlkYXRpb24gb2YgY29weXJpZ2h0IDxzcGFuPiBvbiBJRTkgRmx5aW5nIEltYWdlcyBkZW1v CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDM0Mgor CisgICAgICAgIEFkZHMgYSByZXBhaW50IHRlc3QgdG8gdmVyaWZ5IHRoYXQgd2UgZG9uJ3QgcmVw YWludCBhIHBvc2l0aW9uZWQgZWxlbWVudCB3aXRoCisgICAgICAgIHBlcmNlbnRhZ2Ugd2lkdGgg dW5uZWNlc3NhcmlseS4KKworICAgICAgICAqIGZhc3QvcmVwYWludC9wb3NpdGlvbmVkLXBlcmNl bnRhZ2Utd2lkdGgtc2libGluZy1pbnZhbGlkYXRpb24uaHRtbDogQWRkZWQuCisgICAgICAgICog cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorICAgICAgICAqIHBsYXRm b3JtL21hYy9mYXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmct aW52YWxpZGF0aW9uLWV4cGVjdGVkLmNoZWNrc3VtOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMvZmFzdC9yZXBhaW50L3Bvc2l0aW9uZWQtcGVyY2VudGFnZS13aWR0aC1zaWJsaW5nLWlu dmFsaWRhdGlvbi1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9m YXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0 aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisKIDIwMTAtMTItMDEgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEdyZWVuIHRyZWUuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRo LXNpYmxpbmctaW52YWxpZGF0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvcG9z aXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0aW9uLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uYzZlOGUxZTNlNTlkMGU5ZWI0Mjg4NjI3M2Q4OWM1NTNlNmJiY2I0MQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9wb3NpdGlvbmVkLXBlcmNlbnRhZ2Ut d2lkdGgtc2libGluZy1pbnZhbGlkYXRpb24uaHRtbApAQCAtMCwwICsxLDE1IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9yZXBhaW50LmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQ+CitmdW5jdGlvbiByZXBhaW50VGVzdCgpIHsKKyAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoInRhcmdldCIpLnN0eWxlLmxlZnQ9IjEwcHgiOworfQorPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blJlcGFpbnRUZXN0KCkiIHN0eWxlPSJvdmVyZmxvdzpo aWRkZW4iPgorPGRpdiBzdHlsZT0icG9zaXRpb246YWJzb2x1dGUiPgorICA8ZGl2IGlkPSJ0YXJn ZXQiIHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTsgd2lkdGg6NTBweDsgaGVpZ2h0OjUwcHg7IGJh Y2tncm91bmQtY29sb3I6Z3JlZW4iPjwvZGl2PgorPC9kaXY+Cis8ZGl2IHN0eWxlPSJwb3NpdGlv bjphYnNvbHV0ZTsgdG9wOjEwMHB4OyB3aWR0aDo1MCUiPjxzcGFuPi48L3NwYW4+PC9kaXY+Cis8 L2JvZHk+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4 cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQKaW5kZXggNGMzNWU4OGRiYmVmYzk4YmNiMzNlNGE4NTI2YmYzODNlOTNhY2Q4 Ny4uM2M1YTEzODYwNmI2MWVmMjI0NWQ4MjdiMDZhODdhOTcyZWRmZmEwNiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAt MzEzMiw2ICszMTMyLDkgQEAgQlVHVjhfOTUzIDogZmFzdC9yZWdleC9wY3JlLXRlc3QtMS5odG1s ID0gVElNRU9VVAogCiBCVUc1MDM0NyA6IHBsdWdpbnMvZ2V0LXVzZXItYWdlbnQtd2l0aC1udWxs LW5wcC1mcm9tLW5wcC1uZXcuaHRtbCA9IFRFWFQKIAorLy8gUHJvYmFibHkgbmVlZHMgbmV3IGJh c2VsaW5lcyBmb3IgZWFjaCBwbGF0Zm9ybQorQlVHSkFNRVNSIDogZmFzdC9yZXBhaW50L3Bvc2l0 aW9uZWQtcGVyY2VudGFnZS13aWR0aC1zaWJsaW5nLWludmFsaWRhdGlvbi5odG1sID0gSU1BR0Ug UEFTUworCiBCVUc1MDI4MiBNQUMgOiBmYXN0L2ltYWdlcy9pbWFnZW1hcC1jYXNlLmh0bWwgPSBJ TUFHRQogQlVHNTAyODIgTUFDIDogZmFzdC9pbWFnZXMvaW1hZ2VtYXAtZm9jdXMtcmluZy16b29t Lmh0bWwgPSBJTUFHRQogQlVHNTAyODIgTUFDIDogZmFzdC9pbWFnZXMvaW1hZ2VtYXAtZm9jdXMt cmluZy5odG1sID0gSU1BR0UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0 aW9uLWV4cGVjdGVkLmNoZWNrc3VtIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVw YWludC9wb3NpdGlvbmVkLXBlcmNlbnRhZ2Utd2lkdGgtc2libGluZy1pbnZhbGlkYXRpb24tZXhw ZWN0ZWQuY2hlY2tzdW0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTY5YzMzY2UxOTc5NDNlZGJkNmY0OWRlOThkNmM4 NmM4YjBjNTIyMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0 aW9uLWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0wLDAgKzEgQEAKK2M4Y2FkOGE1NjcyNjZlYWQ5ZGQ5 YTY2OGNhYTI2YzA1ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9wb3NpdGlvbmVkLXBlcmNlbnRhZ2Ut d2lkdGgtc2libGluZy1pbnZhbGlkYXRpb24tZXhwZWN0ZWQucG5nIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2Zhc3QvcmVwYWludC9wb3NpdGlvbmVkLXBlcmNlbnRhZ2Utd2lkdGgtc2libGlu Zy1pbnZhbGlkYXRpb24tZXhwZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjllMjE4YzY4ZTQyN2YxNTQ3 NzljMTVjZmNkODU1MWU5YmYyZjI3M2QKR0lUIGJpbmFyeSBwYXRjaApsaXRlcmFsIDExNDUzCnpj bWVITmRwTUw/ODJASVBeNXhiUDVuRnNEcD00RHFKeitrVjM2O1R3UW10Z2tEaCpPMTg2Vn1BJUgt WmU5K21BUAp6aylCbDJXN2VgJVdIbntUbnNLUmdyRXYqa00qQ0BIPUM5cXFfTWV7Zi08PFFEQDE1 VXlwWXdhKV5ad3FHO3pufisKemxHbGBuQVZ8c0MkJDxfKnZrKFgoWmlEQ0dHd2dgP1A8K3JJV04r ezBZO1RYYTlTR1NJNmRWOVNrJVI8fj02eCEqCnpzKn5vN3RBRmFrK3hJRCNOM3dMQ3leRFhMSn5O bGhfdUhxfnA8T3tgYExBKHFXdGhNMypTfXFxe0lhTFRoKT99awp6REU5QF5JYFlaaVdNamcxc3NY Pil6Xl9vPFNsR25hVHY3Q25eTXBDWHctfF5DaTRaX2EyY0U3UyFBTEthPmdnQmUKejJMJklzK2Jk M25QRzZYN3lMT3BwI3xONjs5TlN+ejxJI08+TjlNKXRAY0tQXjsmQSFsNjg2Jnl3JWw8RStVM1lA CnpIITIlWTUwbSNeS3VvcTA2ZEtrYWdheTVBZ0NFaz8oVmAtTXlGRzcoYio7RFZRUGotJU52ekE9 RWx0YX49ckplRAp6JSNrcDxPJiV7YmxlYWBKaF9VQzcySiE8fSowMSopYC19WXdeSnQleVNyNzd1 blkzR2NuO00tTzEmdEVRaFAkV0UKemtEUG8/PkRrP1Y+Mis8UV8yTlpsISgrWSs/YFUyZkdwa1lF TVJyKyEhNlU0Rm02OTtgaFF3PWRWfCp5ZkB7I3s7CnpFUFQ2QER7bkpudFRKaEtqNlA0THdDQXZ3 ZHZ7Y3ROK0FEUD1LJUV1dkdobWZDNW9EZ1kkWWMqR0xeSkR4NkJQcQp6dzkrKFBUWWlBRHcwTz1C OFBUZmA+RnZGTCg5aHdmWk02QWMpXzJANWJ5YGd0PSFSdzUtLWdyMHd2JEdzNF8ja0gKempYJk81 KjUpO3VTI3BrRElvUCRuPyR6MFFucCErPUx2T2Y/JihXLUI1Z0EoQHYjJj1Uc2JZVzdxPHErI1dC Tk1ZCnpFVWgtWVkoaStmRTJ9WmJAVDYqOHVqa09hT34oJnlIPzxISDFqbndvP3BmOG0+VUx7Kk5s TDFQKlNWWlAkekc/NAp6eyVjaGt1UlhfSWVNV0Boel4yLXRka2p0V0JUbj9gcX56NEM1fmpDcERw dSg2LUNxeXFYQylkdy1HNEA7X3VTVykKelR7VTl6Nko8eF9nQUs4WUJrcXxSalpaeU5NcV9KP3tN WTgrUXd8Wk9iPH5VMVV5aCNXRD07OU0xYX4hQHQ9enZRCnpZPUIlQ1B7YXRvS34lNDlpVFBCKSpt c2Q+REpFXlJEcG82QG4tdzVjZ3ZBal9OM2BBOz01bipNbzdUfmpSdSpKYgp6ekoyNkpaKj1SaHJf KmBNY21iUSNaa19lP2RtR1ZxbWItK3B4TngxX1h6a15WMFU0ckY7cnVkNThHVV5HST0hN3EKeihg PTIpNXJ1SDdCdmVqaFk2PTcpa2g2b1dNPG41NmBeezVYZnZWSU5qWmBlVDcyYWp0cFU3bHxEeWMj bUhMSGMkCnppeyQhSlJ2MEpNX3BVR0N4dDc8eD8taD1YX2g9SklGZDBFSGg9QmpGdmg2QmVFPl5D TnwybXFVdHxwT15EWHtEKwp6N1prSFBefTxBVmBZVWBMaWpBJDJqeFl8Rkx+N3Qoaz82YDgkQm9T VGNPelkkMUYlaHVYIXlTTl97aE1uRlUlTmoKenYqYXloYyZ0eCZuYkk7TE1WWXRvbExabjskeGwt R2hNUm5NSWZDfWJ0VEVBXzBUSnFqVnRKQi1UQ3soNWhHWG5ICnprM3NpRm8ycWhXSHBsVE01RHQ5 aU1wO2hue3ApVnlxS1UrcGUyWEUhWnhhTSE7QX5QdXlLNyYhNm5wPCVtPSFIKAp6T3IxT0pBUUdJ bmtQSDk7NH1KZTw9I3diWWlwaF96UD91NTwzM2NaUHUkfCgpe0xOQ1RVQlJHcnFIZTJtUW1ScEwK enN0SnB1KTx+JiM1dlNVbHFAaUZiKXpvcFMpcz88KGwyWXhvSmp9WU57cDZPRVlDQmNRaDxZe0tM SkdqcjJ0aUxYCnpFdF9TeT9+VmRNeihkcDcwaTI9I1c/N1hYJGBwP1kyVlh0VCRyJXQtWWZBKmZH UTE+QmxIeDM4SHsxeWtffUlpdwp6aVUmdkReQzthLXtGeipmVmpUQ2wheSE/bE4lT1JRWTtaJF5s YWglJDs9MlZwR0R9ZVRzPCRFTjxiKzlgcWV3JV8KelhZIWFmRitgZDVDNSlUNFU/IWEtQ15EUG1S SzdATiopfHd2QzBzaXY0R3IpbTQwMlhtSXVsT19MPEl0Ji0wZWB0CnpPdzU3ZUBMMktDUGZyVE1S fGk0V3R9JGYoaCgjcG9kN3FUQXgpUSYrKmdiY1YxfDw/NSNxPzZvJFhIRmxBbnotYwp6Jk5JO3RM LThvKFp6Xk44ajcmeHBKU31BNEl9ciUhRD51a2tSVTtEcDMqWUk+eiZBd0ReZzFXMFJnTjhzdEBQ LVcKemZlKU81MGpKO3g1dTZrZnBidHoyRiREcEU3NnNWe2dXXkMrQ1czbmsyP20hcEc2SFYyRDdm YjFBcmFJKnBkaUhTCnpPOzlEMWZwaEAkNmtKKlkoZ0JiVHJjXnYyOVJUUzdANj4mTihtXmsrbkZU Pn1uTngyOGZRU3cxQVcjUzRvZ1l2Swp6ZnlVVFdsTVUyQ3Bibzt7WWs/TGpzRHF8aj9FZ34+SDc9 SUc4UFc8PkBHUjJBcEN2PWlSR1B5TEpLeS1mMGh9bTQKQVVIfHw5CgpsaXRlcmFsIDAKSGNtVj9k MDAwMDEKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50 L3Bvc2l0aW9uZWQtcGVyY2VudGFnZS13aWR0aC1zaWJsaW5nLWludmFsaWRhdGlvbi1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L3Bvc2l0aW9uZWQt cGVyY2VudGFnZS13aWR0aC1zaWJsaW5nLWludmFsaWRhdGlvbi1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMjY5ODU2ZDJmYjA2OGUxN2Y2MGY0ODY0YTJjMTI0Nzc5NWJkYWRiNgotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvcG9zaXRpb25l ZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0aW9uLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxLDEyIEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBh dCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDgKKyAgUmVuZGVy QmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDgKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBh dCAoOCw4KSBzaXplIDc4NHgwCitsYXllciBhdCAoMTgsOCkgc2l6ZSA1MHg1MAorICBSZW5kZXJC bG9jayAocG9zaXRpb25lZCkge0RJVn0gYXQgKDEwLDApIHNpemUgNTB4NTAgW2JnY29sb3I9IzAw ODAwMF0KK2xheWVyIGF0ICg4LDEwMCkgc2l6ZSA0MDB4MTgKKyAgUmVuZGVyQmxvY2sgKHBvc2l0 aW9uZWQpIHtESVZ9IGF0ICg4LDEwMCkgc2l6ZSA0MDB4MTgKKyAgICBSZW5kZXJJbmxpbmUge1NQ QU59IGF0ICgwLDApIHNpemUgNHgxOAorICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDAp IHNpemUgNHgxOAorICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA0OiAiLiIKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFjOWE4 Y2U0ODlkYTdjNTM4M2NmZGE1MWFkNjQwZDdiYjVlNDEwMy4uYzUyNDUwMDFiMjE4N2NkM2EwMGM1 YjJmYTU0OGNlMzU0MzFhZWE4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMi0wMSAgSmFtZXMgUm9i aW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVubmVjZXNzYXJ5IGludmFsaWRhdGlvbiBvZiBjb3B5cmln aHQgPHNwYW4+IG9uIElFOSBGbHlpbmcgSW1hZ2VzIGRlbW8KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMzQyCisKKyAgICAgICAgSW4gUmVuZGVyQmxv Y2s6OmxheW91dElubGluZUNoaWxkcmVuKCkgd2Ugd2VyZSBtYXJraW5nIGFsbCBwb3NpdGlvbmVk CisgICAgICAgIGNoaWxkcmVuIGlmIHRoZSBibG9jaydzIGxvZ2ljYWwgd2lkdGggY2hhbmdlZCBf b3JfIGlmIHRoZSBjaGlsZCBoYWQgc3BlY2lmaWVkIHBlcmNlbnRhZ2UKKyAgICAgICAgd2lkdGgg b3IgaGVpZ2h0LiAgVGhpcyBwYXRjaCBmaXhlcyBpdCB0byBvbmx5IG1hcmsgY2hpbGRyZW4gaWYg dGhlIHBhcmVudCBibG9jaydzCisgICAgICAgIGxvZ2ljYWwgd2lkdGggaGFzIGNoYW5nZWQgYW5k IHRoZSBjaGlsZCBoYXMgYSBzcGVjaWZpZWQgcGVyY2VudGFnZSB3aWR0aCBpbiBob3Jpem9udGFs CisgICAgICAgIHdyaXRpbmcgbW9kZSBjb250ZW50IG9yIHNwZWNpZmllZCBwZXJjZW50YWdlIGhl aWdodCBpbiB2ZXJ0aWNhbCB3cml0aW5nIG1vZGUgY29udGVudC4KKworICAgICAgICBUZXN0OiBm YXN0L3JlcGFpbnQvcG9zaXRpb25lZC1wZXJjZW50YWdlLXdpZHRoLXNpYmxpbmctaW52YWxpZGF0 aW9uLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKToK KwogMjAxMC0xMi0wMSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tM aW5lTGF5b3V0LmNwcAppbmRleCBlOTY5YTJhOTRkNWUyNGU0MjU2ZTFlMGY0NDY1ZTNjMzI0MWQ0 YjhmLi5jYTQ0M2RjZDU1NTgyNGI5ZmZkNDc5YTM2ZmFlMzNiZDc5MzJkOGU5IDEwMDY0NAotLS0g YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTU0OCw4ICs1NDgsMTEg QEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0SW5saW5lQ2hpbGRyZW4oYm9vbCByZWxheW91dENo aWxkcmVuLCBpbnQmIHJlcGFpbnRMb2dpY2EKIAogICAgICAgICAgICAgaWYgKG8tPmlzUmVwbGFj ZWQoKSB8fCBvLT5pc0Zsb2F0aW5nKCkgfHwgby0+aXNQb3NpdGlvbmVkKCkpIHsKICAgICAgICAg ICAgICAgICBSZW5kZXJCb3gqIGJveCA9IHRvUmVuZGVyQm94KG8pOwotICAgICAgICAgICAgICAg IAotICAgICAgICAgICAgICAgIGlmIChyZWxheW91dENoaWxkcmVuIHx8IG8tPnN0eWxlKCktPndp ZHRoKCkuaXNQZXJjZW50KCkgfHwgby0+c3R5bGUoKS0+aGVpZ2h0KCkuaXNQZXJjZW50KCkpCisK KyAgICAgICAgICAgICAgICAvLyBJZiByZWxheW91dENoaWxkcmVuIGlzIHRydWUgdGhlbiB0aGlz IGJsb2NrIGhhcyBjaGFuZ2VkIHdpZHRoIChvciBoZWlnaHQgaW4gYSB2ZXJ0aWNhbCB3cml0aW5n IG1vZGUpLAorICAgICAgICAgICAgICAgIC8vIHNvIHdlIG5lZWQgdG8gaW52YWxpZGF0ZSBhbnkg Y2hpbGRyZW4gdGhhdCBoYXZlIGEgcGVyY2VudGFnZSB3aWR0aCAob3IgcGVyY2VudGFnZSBoZWln aHQgaWYgdGhpcyBibG9jayBpcyBpbiBhIHZlcnRpY2FsIHdyaXRpbmcgbW9kZSkuCisgICAgICAg ICAgICAgICAgaWYgKHJlbGF5b3V0Q2hpbGRyZW4gJiYgKChzdHlsZSgpLT5pc0hvcml6b250YWxX cml0aW5nTW9kZSgpICYmIG8tPnN0eWxlKCktPndpZHRoKCkuaXNQZXJjZW50KCkpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHx8ICghc3R5bGUoKS0+aXNIb3Jpem9u dGFsV3JpdGluZ01vZGUoKSAmJiBvLT5zdHlsZSgpLT5oZWlnaHQoKS5pc1BlcmNlbnQoKSkpKQog ICAgICAgICAgICAgICAgICAgICBvLT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUsIGZhbHNlKTsK ICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgLy8gSWYgcmVsYXlvdXRDaGls ZHJlbiBpcyBzZXQgYW5kIHdlIGhhdmUgcGVyY2VudGFnZSBwYWRkaW5nLCB3ZSBhbHNvIG5lZWQg dG8gaW52YWxpZGF0ZSB0aGUgY2hpbGQncyBwcmVmIHdpZHRocy4K