50340 2010-12-01 11:38:15 -0800 build-webkit --chromium always updates DEPS and re-generates project files 2010-12-01 16:58:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip abarth dbates eric tony webkit.review.bot oldest_to_newest 315773 0 mihaip 2010-12-01 11:38:15 -0800 build-webkit --chromium always updates DEPS and re-generates project files 315780 1 75298 mihaip 2010-12-01 11:47:12 -0800 Created attachment 75298 Patch 315783 2 75298 tony 2010-12-01 11:53:00 -0800 Comment on attachment 75298 Patch Yay! 315786 3 mihaip 2010-12-01 11:54:44 -0800 I'll give Adam and Eric a chance to say no :) 315816 4 eric 2010-12-01 12:36:43 -0800 I support this idea. :) 315822 5 75298 abarth 2010-12-01 12:46:17 -0800 Comment on attachment 75298 Patch This will break the Chromium EWS bot when folks modify GYP or DEPs files in their patch. Can you change the build command used by the bot to pass this new flag? 315877 6 75322 mihaip 2010-12-01 14:11:10 -0800 Created attachment 75322 Patch 315907 7 75322 abarth 2010-12-01 15:38:34 -0800 Comment on attachment 75322 Patch Thanks! I'm surprised that doesn't break any webkitpy unit tests. 315910 8 mihaip 2010-12-01 15:47:18 -0800 (In reply to comment #7) > I'm surprised that doesn't break any webkitpy unit tests. Ah, good point. WebKitPortTest.test_chromium_port did need to be updated. Will fix and land. 315927 9 mihaip 2010-12-01 16:04:16 -0800 Committed r73082: <http://trac.webkit.org/changeset/73082> 315944 10 webkit.review.bot 2010-12-01 16:49:03 -0800 http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests) 315949 11 mihaip 2010-12-01 16:58:03 -0800 (In reply to comment #10) > http://trac.webkit.org/changeset/73082 might have broken SnowLeopard Intel Release (Tests) fast/profiler/throw-exception-from-eval.html has diffs in the stack trace that's output, I don't see how this could cause that. 75298 2010-12-01 11:47:12 -0800 2010-12-01 14:11:06 -0800 Patch bug-50340-20101201114711.patch text/plain 2512 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxYThhYWQwODk1NWQyMWNkMGJhNDJhZjMzYjhmMDI2NjhiYmQ1YTNmLi4wOTczM2Mw YjAxNmNhYTYxNTAzZmRkOTVjNTlhNjFmYjExOWFjMjVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMTItMDEgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYnVpbGQtd2Via2l0 IC0tY2hyb21pdW0gYWx3YXlzIHVwZGF0ZXMgREVQUyBhbmQgcmUtZ2VuZXJhdGVzIHByb2plY3Qg ZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUw MzQwCisgICAgICAgIAorICAgICAgICBNYWtlIGJ1aWxkLXdlYmtpdCAtLWNocm9taXVtIGludm9r ZSB1cGRhdGUtd2Via2l0LWNocm9taXVtIG9ubHkgd2hlbgorICAgICAgICAtLXVwZGF0ZS1jaHJv bWl1bSBpcyBwYXNzZWQgaW4sIHNvIHRoYXQgd2UgZG9uJ3QgYWRkIDIwIHNlY29uZHMgdG8gYWxs CisgICAgICAgIGJ1aWxkcy4KKyAgICAgICAgCisgICAgICAgIE1ha2luZyBhbGwgaW52b2NhdGlv bnMgdXBkYXRlIHdhcyBhZGRlZCB3aXRoIHI2MTg4Mywgd2l0aCB0aGUgZ29hbCBvZgorICAgICAg ICBtYWtpbmcgRVdTIGJvdHMgYWx3YXlzIHVwZGF0ZS4gVGhlIGJvdHMgY2FuIHN3aXRjaCB0byB1 c2luZyB0aGlzIGZsYWcuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisKIDIw MTAtMTEtMzAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDFlNDc0 ZTJiYjgyZGM4NzU3NDIyNDdhNDRhNzZlZTQ2YTJiNmE3N2YuLjkwYTEyM2NjODQwN2I4N2VhODhk YWQ2ZDFhNDJmMzE5ZmJjYzc1NTYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTY4 MCwxNSArNjgwLDI2IEBAIHN1YiBkZXRlcm1pbmVRdEZlYXR1cmVEZWZhdWx0cygpCiBzdWIgY2hl Y2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWCiB7CiAgICAgbXkgJGFyZ1RvQ2hlY2sgPSBz aGlmdDsKLSAgICBmb3JlYWNoIG15ICRvcHQgKEBBUkdWKSB7CisgICAgcmV0dXJuIGNoZWNrRm9y QXJndW1lbnRBbmRSZW1vdmVGcm9tQXJyYXlSZWYoJGFyZ1RvQ2hlY2ssIFxAQVJHVik7Cit9CisK K3N1YiBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFycmF5UmVmCit7CisgICAgbXkgKCRh cmdUb0NoZWNrLCAkYXJyYXlSZWYpID0gQF87CisgICAgbXkgQGluZGljZXNUb1JlbW92ZTsKKyAg ICBmb3JlYWNoIG15ICRpbmRleCAoMCAuLiAkIyRhcnJheVJlZikgeworICAgICAgICBteSAkb3B0 ID0gJCRhcnJheVJlZlskaW5kZXhdOwogICAgICAgICBpZiAoJG9wdCA9fiAvXiRhcmdUb0NoZWNr JC9pICkgewotICAgICAgICAgICAgQEFSR1YgPSBncmVwKCEvXiRhcmdUb0NoZWNrJC9pLCBAQVJH Vik7Ci0gICAgICAgICAgICByZXR1cm4gMTsKKyAgICAgICAgICAgIHB1c2goQGluZGljZXNUb1Jl bW92ZSwgJGluZGV4KTsKICAgICAgICAgfQogICAgIH0KLSAgICByZXR1cm4gMDsKKyAgICBmb3Jl YWNoIG15ICRpbmRleCAoQGluZGljZXNUb1JlbW92ZSkgeworICAgICAgICBzcGxpY2UoQCRhcnJh eVJlZiwgJGluZGV4LCAxKTsKKyAgICB9CisgICAgcmV0dXJuICQjaW5kaWNlc1RvUmVtb3ZlID4g LTE7CiB9CiAKKwogc3ViIGRldGVybWluZUlzUXQoKQogewogICAgIHJldHVybiBpZiBkZWZpbmVk KCRpc1F0KTsKQEAgLTE2NzUsOSArMTY4NiwxMSBAQCBzdWIgYnVpbGRDaHJvbWl1bVZpc3VhbFN0 dWRpb1Byb2plY3QoJCQpCiBzdWIgYnVpbGRDaHJvbWl1bSgkQCkKIHsKICAgICBteSAoJGNsZWFu LCBAb3B0aW9ucykgPSBAXzsKLQorICAgIAogICAgICMgV2UgbWlnaHQgbmVlZCB0byB1cGRhdGUg REVQUyBvciByZS1ydW4gR1lQIGlmIHRoaW5ncyBoYXZlIGNoYW5nZWQuCi0gICAgc3lzdGVtKCJw ZXJsIiwgIldlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSIpID09IDAg b3IgZGllICQhOworICAgIGlmIChjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFycmF5UmVm KCItLXVwZGF0ZS1jaHJvbWl1bSIsIFxAb3B0aW9ucykpIHsKKyAgICAgICAgc3lzdGVtKCJwZXJs IiwgIldlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bSIpID09IDAgb3Ig ZGllICQhOworICAgIH0KIAogICAgIG15ICRyZXN1bHQgPSAxOwogICAgIGlmIChpc0Rhcndpbigp KSB7Cg== 75322 2010-12-01 14:11:10 -0800 2010-12-01 15:38:34 -0800 Patch bug-50340-20101201141109.patch text/plain 3250 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxYThhYWQwODk1NWQyMWNkMGJhNDJhZjMzYjhmMDI2NjhiYmQ1YTNmLi5mNjk1YTVk MGJhY2QyNDM1YzY5N2Y3MjU2ZmU5OTlkOWIwMmFhZWY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTAtMTItMDEgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYnVpbGQtd2Via2l0 IC0tY2hyb21pdW0gYWx3YXlzIHVwZGF0ZXMgREVQUyBhbmQgcmUtZ2VuZXJhdGVzIHByb2plY3Qg ZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUw MzQwCisgICAgICAgIAorICAgICAgICBNYWtlIGJ1aWxkLXdlYmtpdCAtLWNocm9taXVtIGludm9r ZSB1cGRhdGUtd2Via2l0LWNocm9taXVtIG9ubHkgd2hlbgorICAgICAgICAtLXVwZGF0ZS1jaHJv bWl1bSBpcyBwYXNzZWQgaW4sIHNvIHRoYXQgd2UgZG9uJ3QgYWRkIDIwIHNlY29uZHMgdG8gYWxs CisgICAgICAgIGJ1aWxkcy4KKyAgICAgICAgCisgICAgICAgIE1ha2luZyBhbGwgaW52b2NhdGlv bnMgdXBkYXRlIHdhcyBhZGRlZCB3aXRoIHI2MTg4Mywgd2l0aCB0aGUgZ29hbCBvZgorICAgICAg ICBtYWtpbmcgRVdTIGJvdHMgYWx3YXlzIHVwZGF0ZS4gVGhlIGJvdHMgd2lsbCBzd2l0Y2ggdG8g dXNpbmcgdGhpcyBmbGFnCisgICAgICAgIChhcyB3aWxsIGFsbCBvdGhlciB3ZWJraXQtcGF0Y2gg YnVpbGQgc3RlcHMpIHNvIG5vdGhpbmcgc2hvdWxkIGNoYW5nZQorICAgICAgICBmb3IgdGhlbS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHk6CisKIDIwMTAtMTEtMzAgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDFlNDc0ZTJiYjgyZGM4NzU3NDIyNDdhNDRh NzZlZTQ2YTJiNmE3N2YuLjczMjg4ZTBhM2ZhZTlkZDI3NWU1ODQxODAwMjcxNWIwYzJiMjk5MDgg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTY4MCwxNSArNjgwLDI2IEBAIHN1YiBk ZXRlcm1pbmVRdEZlYXR1cmVEZWZhdWx0cygpCiBzdWIgY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92 ZUZyb21BUkdWCiB7CiAgICAgbXkgJGFyZ1RvQ2hlY2sgPSBzaGlmdDsKLSAgICBmb3JlYWNoIG15 ICRvcHQgKEBBUkdWKSB7CisgICAgcmV0dXJuIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9t QXJyYXlSZWYoJGFyZ1RvQ2hlY2ssIFxAQVJHVik7Cit9CisKK3N1YiBjaGVja0ZvckFyZ3VtZW50 QW5kUmVtb3ZlRnJvbUFycmF5UmVmCit7CisgICAgbXkgKCRhcmdUb0NoZWNrLCAkYXJyYXlSZWYp ID0gQF87CisgICAgbXkgQGluZGljZXNUb1JlbW92ZTsKKyAgICBmb3JlYWNoIG15ICRpbmRleCAo MCAuLiAkIyRhcnJheVJlZikgeworICAgICAgICBteSAkb3B0ID0gJCRhcnJheVJlZlskaW5kZXhd OwogICAgICAgICBpZiAoJG9wdCA9fiAvXiRhcmdUb0NoZWNrJC9pICkgewotICAgICAgICAgICAg QEFSR1YgPSBncmVwKCEvXiRhcmdUb0NoZWNrJC9pLCBAQVJHVik7Ci0gICAgICAgICAgICByZXR1 cm4gMTsKKyAgICAgICAgICAgIHB1c2goQGluZGljZXNUb1JlbW92ZSwgJGluZGV4KTsKICAgICAg ICAgfQogICAgIH0KLSAgICByZXR1cm4gMDsKKyAgICBmb3JlYWNoIG15ICRpbmRleCAoQGluZGlj ZXNUb1JlbW92ZSkgeworICAgICAgICBzcGxpY2UoQCRhcnJheVJlZiwgJGluZGV4LCAxKTsKKyAg ICB9CisgICAgcmV0dXJuICQjaW5kaWNlc1RvUmVtb3ZlID4gLTE7CiB9CiAKKwogc3ViIGRldGVy bWluZUlzUXQoKQogewogICAgIHJldHVybiBpZiBkZWZpbmVkKCRpc1F0KTsKQEAgLTE2NzcsNyAr MTY4OCw5IEBAIHN1YiBidWlsZENocm9taXVtKCRAKQogICAgIG15ICgkY2xlYW4sIEBvcHRpb25z KSA9IEBfOwogCiAgICAgIyBXZSBtaWdodCBuZWVkIHRvIHVwZGF0ZSBERVBTIG9yIHJlLXJ1biBH WVAgaWYgdGhpbmdzIGhhdmUgY2hhbmdlZC4KLSAgICBzeXN0ZW0oInBlcmwiLCAiV2ViS2l0VG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtIikgPT0gMCBvciBkaWUgJCE7CisgICAg aWYgKGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQXJyYXlSZWYoIi0tdXBkYXRlLWNocm9t aXVtIiwgXEBvcHRpb25zKSkgeworICAgICAgICBzeXN0ZW0oInBlcmwiLCAiV2ViS2l0VG9vbHMv U2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtIikgPT0gMCBvciBkaWUgJCE7CisgICAgfQog CiAgICAgbXkgJHJlc3VsdCA9IDE7CiAgICAgaWYgKGlzRGFyd2luKCkpIHsKZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQppbmRleCBk MjY4ODY1ZDc1MDMwZmNkNmI1MjYyYWZlNzdmNzU1MzliNzc1NmYyLi41ZjE1ZTg4OTE3YTc1ZDNj N2E2MDE2ODZlMmEwYzYyMzYxYTFmZTRkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5CkBAIC0yMjEsNiArMjIxLDcgQEAgY2xh c3MgQ2hyb21pdW1Qb3J0KFdlYktpdFBvcnQpOgogICAgIGRlZiBidWlsZF93ZWJraXRfY29tbWFu ZChjbHMsIGJ1aWxkX3N0eWxlPU5vbmUpOgogICAgICAgICBjb21tYW5kID0gV2ViS2l0UG9ydC5i dWlsZF93ZWJraXRfY29tbWFuZChidWlsZF9zdHlsZT1idWlsZF9zdHlsZSkKICAgICAgICAgY29t bWFuZC5hcHBlbmQoIi0tY2hyb21pdW0iKQorICAgICAgICBjb21tYW5kLmFwcGVuZCgiLS11cGRh dGUtY2hyb21pdW0iKQogICAgICAgICByZXR1cm4gY29tbWFuZAogCiAgICAgQGNsYXNzbWV0aG9k Cg==