50324 2010-12-01 08:54:33 -0800 Fix clang warnings caused by -Wlogical-op-parentheses 2010-12-01 09:49:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thakis thakis oldest_to_newest 315672 0 thakis 2010-12-01 08:54:33 -0800 Fix clang warnings caused by -Wlogical-op-parentheses 315674 1 75277 thakis 2010-12-01 08:55:26 -0800 Created attachment 75277 Patch 315681 2 75277 dglazkov 2010-12-01 09:15:47 -0800 Comment on attachment 75277 Patch This clang thing is just a fad. It'll never catch on. 315698 3 75277 thakis 2010-12-01 09:49:39 -0800 Comment on attachment 75277 Patch r73032 75277 2010-12-01 08:55:26 -0800 2010-12-01 09:49:39 -0800 Patch bug-50324-20101201085525.patch text/plain 3241 thakis ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yjg0YWZmNzEzZTQyZDg5YmNkMjM4YzgzOWU1MzY2NTI3NTAwZWQ3OC4uMDUwMGUwNDhjNmIzZWZk YjJjMDFkYzRlOThiYTI3Zjg4NDg2ODJlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMi0wMSAgTmlj byBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNsYW5nIHdhcm5pbmdzIGNhdXNlZCBieSAtV2xv Z2ljYWwtb3AtcGFyZW50aGVzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTUwMzI0CisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRJdGVyYXRvci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZWFyY2hCdWZmZXI6OnNlYXJjaCk6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDb21wbGV4VGV4dENvbnRyb2xsZXI6OmFkanVzdEdseXBoc0FuZEFkdmFuY2VzKToK KwogMjAxMC0xMS0zMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9lZGl0aW5n L1RleHRJdGVyYXRvci5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAppbmRl eCAxYmM1NThhZDE1ODVhMDYzZTk4YzRhZTg0YzM0OWQxMTE5MmFjMDQ2Li45YTQ3ZWY1YmVkMDQy YzcxYTFlNGIxYzMwMzBiZTI5ZjhhNTUwZjQyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcv VGV4dEl0ZXJhdG9yLmNwcAorKysgYi9XZWJDb3JlL2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcApA QCAtMjE0Miw3ICsyMTQyLDcgQEAgbmV4dE1hdGNoOgogICAgIEFTU0VSVChtYXRjaFN0YXJ0ICsg bWF0Y2hlZExlbmd0aCA8PSBzaXplKTsKIAogICAgIC8vIElmIHRoaXMgbWF0Y2ggaXMgImJhZCIs IG1vdmUgb24gdG8gdGhlIG5leHQgbWF0Y2guCi0gICAgaWYgKGlzQmFkTWF0Y2gobV9idWZmZXIu ZGF0YSgpICsgbWF0Y2hTdGFydCwgbWF0Y2hlZExlbmd0aCkgfHwgbV9vcHRpb25zICYgQXRXb3Jk U3RhcnRzICYmICFpc1dvcmRTdGFydE1hdGNoKG1hdGNoU3RhcnQsIG1hdGNoZWRMZW5ndGgpKSB7 CisgICAgaWYgKGlzQmFkTWF0Y2gobV9idWZmZXIuZGF0YSgpICsgbWF0Y2hTdGFydCwgbWF0Y2hl ZExlbmd0aCkgfHwgKG1fb3B0aW9ucyAmIEF0V29yZFN0YXJ0cyAmJiAhaXNXb3JkU3RhcnRNYXRj aChtYXRjaFN0YXJ0LCBtYXRjaGVkTGVuZ3RoKSkpIHsKICAgICAgICAgbWF0Y2hTdGFydCA9IHVz ZWFyY2hfbmV4dChzZWFyY2hlciwgJnN0YXR1cyk7CiAgICAgICAgIEFTU0VSVChzdGF0dXMgPT0g VV9aRVJPX0VSUk9SKTsKICAgICAgICAgZ290byBuZXh0TWF0Y2g7CmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29tcGxleFRleHRDb250cm9sbGVyLmNwcAppbmRl eCBlNmE3YmVmZjQ0YTE2YjI5ZmNlNmZkOTliOTE5NDViYjFjOTVmOGZkLi5kMzUzZDU1ZDY3YmY5 NzEyZWU0N2JlNTE4YTRhOTkyNDkyN2RlODBkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAKQEAgLTQ2Miw3ICs0 NjIsNyBAQCB2b2lkIENvbXBsZXhUZXh0Q29udHJvbGxlcjo6YWRqdXN0R2x5cGhzQW5kQWR2YW5j ZXMoKQogICAgICAgICAgICAgaWYgKGNoID09ICdcdCcgJiYgbV9ydW4uYWxsb3dUYWJzKCkpIHsK ICAgICAgICAgICAgICAgICBmbG9hdCB0YWJXaWR0aCA9IG1fZm9udC50YWJXaWR0aCgqZm9udERh dGEpOwogICAgICAgICAgICAgICAgIGFkdmFuY2Uud2lkdGggPSB0YWJXaWR0aCAtIGZtb2RmKG1f cnVuLnhQb3MoKSArIG1fdG90YWxXaWR0aCArIHdpZHRoU2luY2VMYXN0Um91bmRpbmcsIHRhYldp ZHRoKTsKLSAgICAgICAgICAgIH0gZWxzZSBpZiAoY2ggPT0gemVyb1dpZHRoU3BhY2UgfHwgRm9u dDo6dHJlYXRBc1plcm9XaWR0aFNwYWNlKGNoKSAmJiAhdHJlYXRBc1NwYWNlKSB7CisgICAgICAg ICAgICB9IGVsc2UgaWYgKGNoID09IHplcm9XaWR0aFNwYWNlIHx8IChGb250Ojp0cmVhdEFzWmVy b1dpZHRoU3BhY2UoY2gpICYmICF0cmVhdEFzU3BhY2UpKSB7CiAgICAgICAgICAgICAgICAgYWR2 YW5jZS53aWR0aCA9IDA7CiAgICAgICAgICAgICAgICAgZ2x5cGggPSBmb250RGF0YS0+c3BhY2VH bHlwaCgpOwogICAgICAgICAgICAgfQpAQCAtNTE4LDcgKzUxOCw3IEBAIHZvaWQgQ29tcGxleFRl eHRDb250cm9sbGVyOjphZGp1c3RHbHlwaHNBbmRBZHZhbmNlcygpCiAKICAgICAgICAgICAgIC8v IENoZWNrIHRvIHNlZSBpZiB0aGUgbmV4dCBjaGFyYWN0ZXIgaXMgYSAicm91bmRpbmcgaGFjayBj aGFyYWN0ZXIiLCBpZiBzbywgYWRqdXN0IHRoZQogICAgICAgICAgICAgLy8gd2lkdGggc28gdGhh dCB0aGUgdG90YWwgcnVuIHdpZHRoIHdpbGwgYmUgb24gYW4gaW50ZWdlciBib3VuZGFyeS4KLSAg ICAgICAgICAgIGlmIChtX3J1bi5hcHBseVdvcmRSb3VuZGluZygpICYmICFsYXN0R2x5cGggJiYg Rm9udDo6aXNSb3VuZGluZ0hhY2tDaGFyYWN0ZXIobmV4dENoKSB8fCBtX3J1bi5hcHBseVJ1blJv dW5kaW5nKCkgJiYgbGFzdEdseXBoKSB7CisgICAgICAgICAgICBpZiAoKG1fcnVuLmFwcGx5V29y ZFJvdW5kaW5nKCkgJiYgIWxhc3RHbHlwaCAmJiBGb250Ojppc1JvdW5kaW5nSGFja0NoYXJhY3Rl cihuZXh0Q2gpKSB8fCAobV9ydW4uYXBwbHlSdW5Sb3VuZGluZygpICYmIGxhc3RHbHlwaCkpIHsK ICAgICAgICAgICAgICAgICBDR0Zsb2F0IHRvdGFsV2lkdGggPSB3aWR0aFNpbmNlTGFzdFJvdW5k aW5nICsgYWR2YW5jZS53aWR0aDsKICAgICAgICAgICAgICAgICB3aWR0aFNpbmNlTGFzdFJvdW5k aW5nID0gY2VpbENHRmxvYXQodG90YWxXaWR0aCk7CiAgICAgICAgICAgICAgICAgQ0dGbG9hdCBl eHRyYVdpZHRoID0gd2lkdGhTaW5jZUxhc3RSb3VuZGluZyAtIHRvdGFsV2lkdGg7Cg==