50306 2010-11-30 19:30:05 -0800 REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload() uses an uninitialized result value (breaks form submission with clang-built WebKit) 2011-02-12 19:35:34 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED http://www.cs.tut.fi/~jkorpela/forms/testing.html InRadar, Regression P1 Normal --- 1 jon ap andersca ap commit-queue mitz oldest_to_newest 315491 0 jon 2010-11-30 19:30:05 -0800 Building r72983 with clang Apple clang version 2.0 (tags/Apple/clang-121.4) (based on LLVM 2.9svn) works, but it seems to produce a failure with multipart/form-data forms. One that doesn't exist when building with gcc or llvm-gcc. And that doesn't seem to affect other form enctype's. The page I've linked isn't mine but has several form tests. All of them work correctly in shipping Safari but the multipart/form-data one fails when use the same Safari with WebKit built with clang. Ironically this bug also affects the WebKit bug entry form, so I have to submit this bug from shipping Safari. Strangely, some of the forms I've encountered with this issue can be fixed by removing the enctype parameter from the form declaration using the inspector. However, the one here isn't fixed, possibly because it actually needs the enctype to function properly. Whatever the case, removing the enctype parameter from the page I linked at least lets the form's submit button work, even if the results then differ from shipping Safari. 345259 1 jon 2011-02-03 19:23:52 -0800 This is still occuring for me using r77578 and Apple clang version 2.0 (tags/Apple/clang-134) (based on LLVM 2.9svn). The page I linked has a good test. Can someone take a look? I'd like to know if I've been hallucinating this bizarre bug for the past few months. 347908 2 jon 2011-02-08 19:42:37 -0800 During this failure Safari throws an exception. *** -[NSFileManager fileSystemRepresentationWithPath:]: nil or empty path argument Here's the stack: #0 0x00007fff8725f0da in objc_exception_throw () #1 0x00007fff840fa5d7 in +[NSException raise:format:arguments:] () #2 0x00007fff840fa564 in +[NSException raise:format:] () #3 0x00007fff8187d226 in -[NSFileManager fileSystemRepresentationWithPath:] () #4 0x0000000100159bf6 in ?? () #5 0x000000010015af45 in ?? () #6 0x00007fff840cf96c in __invoking___ () #7 0x00007fff840cf83d in -[NSInvocation invoke] () #8 0x00007fff840eb711 in -[NSInvocation invokeWithTarget:] () #9 0x00007fff840cc98c in ___forwarding___ () #10 0x00007fff840c8a68 in __forwarding_prep_0___ () #11 0x0000000100a11bf0 in WebChromeClient::shouldReplaceWithGeneratedFileForUpload (this=0x102e1b1f0, path=@0x119547058, generatedFilename=@0x7fff5fbfe480) at /Users/jshier/Programming/webkit/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:729 #12 0x0000000100ef4489 in WebCore::FormData::appendKeyValuePairItems (this=0x11b5ffd80, list=@0x11b590060, encoding=@0x11b590060, document=0x119362000) at /Users/jshier/Programming/webkit/Source/WebCore/platform/network/FormData.cpp:217 #13 0x0000000100ef4c2a in WebCore::FormData::createMultiPart (list=@0x11b590060, encoding=@0x11b590060, document=0x119362000) at /Users/jshier/Programming/webkit/Source/WebCore/platform/network/FormData.cpp:112 #14 0x0000000100efaae8 in WebCore::FormSubmission::create (form=0x11951f200, attributes=@0x3, trigger=WebCore::NotSubmittedByJavaScript) at /Users/jshier/Programming/webkit/Source/WebCore/loader/FormSubmission.cpp:196 #15 0x0000000100fa59c9 in WebCore::HTMLFormElement::submit (this=0x11951f200, event=0x11b564b58, formSubmissionTrigger=WebCore::NotSubmittedByJavaScript) at /Users/jshier/Programming/webkit/Source/WebCore/html/HTMLFormElement.cpp:337 #16 0x0000000100fa512e in WebCore::HTMLFormElement::prepareForSubmission (this=0x11951f200, event=0x11b564b58) at /Users/jshier/Programming/webkit/Source/WebCore/html/HTMLFormElement.cpp:285 #17 0x000000010150db01 in WebCore::SubmitInputType::handleDOMActivateEvent (this=0x11951f200, event=0x11b564b58) at /Users/jshier/Programming/webkit/Source/WebCore/html/SubmitInputType.cpp:73 #18 0x0000000100fb103e in WebCore::HTMLInputElement::defaultEventHandler (this=0x1190e1540, evt=0x11b564b58) at /Users/jshier/Programming/webkit/Source/WebCore/html/HTMLInputElement.cpp:1009 #19 0x000000010139532f in WebCore::Node::dispatchGenericEvent (this=0x11951f200) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2711 #20 0x0000000101394ecc in WebCore::Node::dispatchEvent (this=0x11951f200) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2607 #21 0x00000001014b6d27 in WebCore::ScopedEventQueue::dispatchEvent (this=0x11951f200) at /Users/jshier/Programming/webkit/Source/WebCore/dom/ScopedEventQueue.cpp:79 #22 0x00000001014b6cb1 in WebCore::ScopedEventQueue::enqueueEvent (this=0x11951f200) at /Users/jshier/Programming/webkit/Source/WebCore/dom/ScopedEventQueue.cpp:64 #23 0x00000001013955e5 in WebCore::Node::dispatchScopedEvent (this=0x11951f200) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2615 #24 0x000000010139594d in WebCore::Node::dispatchUIEvent (this=0x1190e1540, eventType=@0x102cd9d88, detail=1) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2761 #25 0x0000000101396ed1 in WebCore::Node::defaultEventHandler (this=0x1190e1540, event=0x11ca73f00) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2993 #26 0x0000000100fb1342 in WebCore::HTMLInputElement::defaultEventHandler (this=0x1190e1540, evt=0x11ca73f00) at /Users/jshier/Programming/webkit/Source/WebCore/html/HTMLInputElement.cpp:1069 #27 0x000000010139532f in WebCore::Node::dispatchGenericEvent (this=0x1190e1540) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2711 #28 0x0000000101394ecc in WebCore::Node::dispatchEvent (this=0x1190e1540) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2607 #29 0x0000000101395ebf in WebCore::Node::dispatchMouseEvent (this=0x1190e1540, eventType=@0x102cd9b60, button=0, detail=1, pageX=71, pageY=71, relatedTargetArg=0x0, screenY=707, screenX=71) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2885 #30 0x0000000101395b3c in WebCore::Node::dispatchMouseEvent (this=0x1190e1540, event=@0x7fff5fbfedb8, eventType=@0x102cd9b60, detail=1, relatedTarget=0x0) at /Users/jshier/Programming/webkit/Source/WebCore/dom/Node.cpp:2791 #31 0x0000000100ec6d36 in WebCore::EventHandler::dispatchMouseEvent (this=0x102cb21a8, eventType=@0x102cd9b60, targetNode=0x102cd9b60, clickCount=1, mouseEvent=@0x7fff5fbfef60) at /Users/jshier/Programming/webkit/Source/WebCore/page/EventHandler.cpp:1911 #32 0x0000000100ec844a in WebCore::EventHandler::handleMouseReleaseEvent (this=0x1190e1540, mouseEvent=@0x7fff5fbfef60) at /Users/jshier/Programming/webkit/Source/WebCore/page/EventHandler.cpp:1624 #33 0x0000000100eccbbf in WebCore::EventHandler::mouseUp (this=0x1190e1540, event=0x7fff5fbfef60) at /Users/jshier/Programming/webkit/Source/WebCore/page/mac/EventHandlerMac.mm:546 #34 0x0000000100a47d04 in -[WebHTMLView mouseUp:] (self=0x102e1d550, _cmd=0x102cd9b60, event=0x10298c130) at /Users/jshier/Programming/webkit/Source/WebKit/mac/WebView/WebHTMLView.mm:3764 #35 0x00007fff8312f3d9 in -[NSWindow sendEvent:] () #36 0x0000000100042489 in ?? () #37 0x0000000100042416 in ?? () #38 0x00007fff83064a86 in -[NSApplication sendEvent:] () #39 0x0000000100039146 in ?? () #40 0x00007fff82ffb4da in -[NSApplication run] () #41 0x00007fff82ff41a8 in NSApplicationMain () #42 0x000000010000a1c0 in ?? () Perhaps clang is intializing a variable differently than gcc? 347946 3 ap 2011-02-08 21:25:50 -0800 I don't know how to build WebKit with clang, but I think that I know what's going on. We do call -[NSFileManager fileSystemRepresentationWithPath:] with a nil argument, it raises an exception, and we end up returning from -[_WebSafeForwarder forwardInvocation:] with an uninitialized result. This use of uninitialized result is a regression from shipping WebKit, I can observe it with a gcc build - even though the form doesn't fail to submit for me. 347947 4 ap 2011-02-08 21:26:10 -0800 <rdar://problem/8976152> 347952 5 ap 2011-02-08 21:33:34 -0800 I didn't bisect builds to confirm, but this is likely due to r66452, which removed a check for path length in FormData::appendKeyValuePairItems(). 347959 6 ap 2011-02-08 21:43:46 -0800 > *** -[NSFileManager fileSystemRepresentationWithPath:]: nil or empty path argument Jon, do you also see the following line? *** WebKit discarded an uncaught exception in the webView:shouldReplaceUploadFile:usingGeneratedFilename: delegate: 347967 7 81747 ap 2011-02-08 21:50:38 -0800 Created attachment 81747 proposed fix I'm concerned that _WebSafeForwarder may have been bypassed somehow, or worked incorrectly. But I can't check that, and this patch should fix form submission. 348193 8 jon 2011-02-09 06:50:54 -0800 (In reply to comment #6) > > *** -[NSFileManager fileSystemRepresentationWithPath:]: nil or empty path argument > > Jon, do you also see the following line? > > *** WebKit discarded an uncaught exception in the webView:shouldReplaceUploadFile:usingGeneratedFilename: delegate: No, the NSFileManager exception is the only output I see. I'll try your patch. 348197 9 jon 2011-02-09 06:57:05 -0800 Patch works, as I'm now able to submit this Bugzilla form and comment on the bug. :) 348259 10 ap 2011-02-09 08:48:22 -0800 > No, the NSFileManager exception is the only output I see. That's confusing. It likely means that _WebSafeForwarder doesn't work, which is a big problem. > Patch works, as I'm now able to submit this Bugzilla form and comment on the bug. :) The problem should have only affected forms with file inputs - I don't think that commenting was broken. 348273 11 jon 2011-02-09 09:02:36 -0800 It affected all forms that were multipart/form-data, whether a file was attached or not. I've been building WebKit with clang with the Xcode 4 previews. 348639 12 81747 darin 2011-02-09 15:22:28 -0800 Comment on attachment 81747 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=81747&action=review > Source/WebCore/ChangeLog:24 > +2011-02-08 Alexey Proskuryakov <ap@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Need a short description and bug URL (OOPS!) > + > + No new tests. (OOPS!) > + > + * platform/network/FormData.cpp: > + (WebCore::FormData::appendKeyValuePairItems): > + Double change log. 348643 13 81747 ap 2011-02-09 15:25:28 -0800 Comment on attachment 81747 proposed fix Will need to upload a new patch due to double change log... 348645 14 81883 ap 2011-02-09 15:27:34 -0800 Created attachment 81883 patch for landing 348943 15 81883 commit-queue 2011-02-10 04:42:58 -0800 Comment on attachment 81883 patch for landing Clearing flags on attachment: 81883 Committed r78202: <http://trac.webkit.org/changeset/78202> 81747 2011-02-08 21:50:38 -0800 2011-02-09 15:25:28 -0800 proposed fix EmptyPath.txt text/plain 2815 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4MDE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDItMDggIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUwMzA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTc2MTUyPiBSRUdSRVNTSU9OOiBX ZWJDaHJvbWVDbGllbnQ6OnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVwbG9hZCgp CisgICAgICAgIHVzZXMgYW4gaW5pdGlhbGl6ZWQgcmVzdWx0IHZhbHVlIChicmVha3MgZm9ybSBz dWJtaXNzaW9uIHdpdGggY2xhbmctYnVpbHQgV2ViS2l0KQorCisgICAgICAgIE5vIG5ldyB0ZXN0 LCBiZWNhdXNlIEkgY2FuJ3QgcmVwcm9kdWNlIHRoZSBvYnNlcnZhYmxlIGVmZmVjdCB3aXRoIG15 IGdjYyBidWlsZC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRm9ybURhdGEuY3BwOiAo V2ViQ29yZTo6Rm9ybURhdGE6OmFwcGVuZEtleVZhbHVlUGFpckl0ZW1zKTogUmVzdG9yZSBhbgor ICAgICAgICBlbXB0eSBwYXRoIGNoZWNrIC0gYW4gZW1wdHkgcGF0aCB3YXMgY2F1c2luZyBhbiBl eGNlcHRpb24gaW4gRm91bmRhdGlvbi4KKworMjAxMS0wMi0wOCAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vbmV0 d29yay9Gb3JtRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb3JtRGF0YTo6YXBwZW5kS2V5 VmFsdWVQYWlySXRlbXMpOgorCiAyMDExLTAyLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAJKHJldmlzaW9uIDc3MDk2 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTIwOSwxNCArMjA5LDE2IEBAIHZvaWQgRm9ybURhdGE6OmFwcGVuZEtleVZh bHVlUGFpckl0ZW1zKGMKICAgICAgICAgICAgICAgICAgICAgbmFtZSA9IGZpbGUtPndlYmtpdFJl bGF0aXZlUGF0aCgpLmlzRW1wdHkoKSA/IGZpbGUtPm5hbWUoKSA6IGZpbGUtPndlYmtpdFJlbGF0 aXZlUGF0aCgpOwogI2Vsc2UKICAgICAgICAgICAgICAgICAgICAgbmFtZSA9IGZpbGUtPm5hbWUo KTsKLSNlbmRpZiAgICAgICAgICAgICAgICAgICAgCi0KKyNlbmRpZgogICAgICAgICAgICAgICAg ICAgICAvLyBMZXQgdGhlIGFwcGxpY2F0aW9uIHNwZWNpZnkgYSBmaWxlbmFtZSBpZiBpdCdzIGdv aW5nIHRvIGdlbmVyYXRlIGEgcmVwbGFjZW1lbnQgZmlsZSBmb3IgdGhlIHVwbG9hZC4KLSAgICAg ICAgICAgICAgICAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBkb2N1bWVudC0+cGFnZSgpKSB7Ci0gICAg ICAgICAgICAgICAgICAgICAgICBTdHJpbmcgZ2VuZXJhdGVkRmlsZU5hbWU7Ci0gICAgICAgICAg ICAgICAgICAgICAgICBzaG91bGRHZW5lcmF0ZUZpbGUgPSBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50 KCktPnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVwbG9hZChmaWxlLT5wYXRoKCks IGdlbmVyYXRlZEZpbGVOYW1lKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIGlmIChzaG91bGRH ZW5lcmF0ZUZpbGUpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgbmFtZSA9IGdlbmVyYXRl ZEZpbGVOYW1lOworICAgICAgICAgICAgICAgICAgICBjb25zdCBTdHJpbmcmIHBhdGggPSBmaWxl LT5wYXRoKCk7CisgICAgICAgICAgICAgICAgICAgIGlmICghcGF0aC5pc0VtcHR5KCkpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZG9jdW1lbnQtPnBhZ2UoKSkg eworICAgICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZyBnZW5lcmF0ZWRGaWxlTmFtZTsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaG91bGRHZW5lcmF0ZUZpbGUgPSBwYWdlLT5j aHJvbWUoKS0+Y2xpZW50KCktPnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVwbG9h ZChwYXRoLCBnZW5lcmF0ZWRGaWxlTmFtZSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg aWYgKHNob3VsZEdlbmVyYXRlRmlsZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bmFtZSA9IGdlbmVyYXRlZEZpbGVOYW1lOworICAgICAgICAgICAgICAgICAgICAgICAgfQogICAg ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAg ICAgICAgICAgLy8gRm9yIG5vbi1maWxlIGJsb2IsIHVzZSB0aGUgaWRlbnRpZmllciBwYXJ0IG9m IHRoZSBVUkwgYXMgdGhlIG5hbWUuCg== 81883 2011-02-09 15:27:34 -0800 2011-02-10 04:42:58 -0800 patch for landing EmptyPath.txt text/plain 2548 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NjY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUwMzA2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84OTc2MTUyPiBSRUdSRVNTSU9OOiBXZWJD aHJvbWVDbGllbnQ6OnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVwbG9hZCgpCisg ICAgICAgIHVzZXMgYW4gaW5pdGlhbGl6ZWQgcmVzdWx0IHZhbHVlIChicmVha3MgZm9ybSBzdWJt aXNzaW9uIHdpdGggY2xhbmctYnVpbHQgV2ViS2l0KQorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBi ZWNhdXNlIEkgY2FuJ3QgcmVwcm9kdWNlIHRoZSBvYnNlcnZhYmxlIGVmZmVjdCB3aXRoIG15IGdj YyBidWlsZC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvRm9ybURhdGEuY3BwOiAoV2Vi Q29yZTo6Rm9ybURhdGE6OmFwcGVuZEtleVZhbHVlUGFpckl0ZW1zKTogUmVzdG9yZSBhbgorICAg ICAgICBlbXB0eSBwYXRoIGNoZWNrIC0gYW4gZW1wdHkgcGF0aCB3YXMgY2F1c2luZyBhbiBleGNl cHRpb24gaW4gRm91bmRhdGlvbi4KKwogMjAxMS0wMi0wNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyIGFuZCBEYXZlIEh5 YXR0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Gb3JtRGF0YS5j cHAJKHJldmlzaW9uIDc3NjY4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9G b3JtRGF0YS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwOSwxNCArMjA5LDE2IEBAIHZvaWQgRm9y bURhdGE6OmFwcGVuZEtleVZhbHVlUGFpckl0ZW1zKGMKICAgICAgICAgICAgICAgICAgICAgbmFt ZSA9IGZpbGUtPndlYmtpdFJlbGF0aXZlUGF0aCgpLmlzRW1wdHkoKSA/IGZpbGUtPm5hbWUoKSA6 IGZpbGUtPndlYmtpdFJlbGF0aXZlUGF0aCgpOwogI2Vsc2UKICAgICAgICAgICAgICAgICAgICAg bmFtZSA9IGZpbGUtPm5hbWUoKTsKLSNlbmRpZiAgICAgICAgICAgICAgICAgICAgCi0KKyNlbmRp ZgogICAgICAgICAgICAgICAgICAgICAvLyBMZXQgdGhlIGFwcGxpY2F0aW9uIHNwZWNpZnkgYSBm aWxlbmFtZSBpZiBpdCdzIGdvaW5nIHRvIGdlbmVyYXRlIGEgcmVwbGFjZW1lbnQgZmlsZSBmb3Ig dGhlIHVwbG9hZC4KLSAgICAgICAgICAgICAgICAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBkb2N1bWVu dC0+cGFnZSgpKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICBTdHJpbmcgZ2VuZXJhdGVkRmls ZU5hbWU7Ci0gICAgICAgICAgICAgICAgICAgICAgICBzaG91bGRHZW5lcmF0ZUZpbGUgPSBwYWdl LT5jaHJvbWUoKS0+Y2xpZW50KCktPnNob3VsZFJlcGxhY2VXaXRoR2VuZXJhdGVkRmlsZUZvclVw bG9hZChmaWxlLT5wYXRoKCksIGdlbmVyYXRlZEZpbGVOYW1lKTsKLSAgICAgICAgICAgICAgICAg ICAgICAgIGlmIChzaG91bGRHZW5lcmF0ZUZpbGUpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgbmFtZSA9IGdlbmVyYXRlZEZpbGVOYW1lOworICAgICAgICAgICAgICAgICAgICBjb25zdCBT dHJpbmcmIHBhdGggPSBmaWxlLT5wYXRoKCk7CisgICAgICAgICAgICAgICAgICAgIGlmICghcGF0 aC5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIChQYWdlKiBwYWdlID0g ZG9jdW1lbnQtPnBhZ2UoKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZyBn ZW5lcmF0ZWRGaWxlTmFtZTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaG91bGRHZW5l cmF0ZUZpbGUgPSBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPnNob3VsZFJlcGxhY2VXaXRoR2Vu ZXJhdGVkRmlsZUZvclVwbG9hZChwYXRoLCBnZW5lcmF0ZWRGaWxlTmFtZSk7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKHNob3VsZEdlbmVyYXRlRmlsZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgbmFtZSA9IGdlbmVyYXRlZEZpbGVOYW1lOworICAgICAgICAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgfSBl bHNlIHsKICAgICAgICAgICAgICAgICAgICAgLy8gRm9yIG5vbi1maWxlIGJsb2IsIHVzZSB0aGUg aWRlbnRpZmllciBwYXJ0IG9mIHRoZSBVUkwgYXMgdGhlIG5hbWUuCg==