50304 2010-11-30 17:50:20 -0800 Web Inspector: do not make helpScreen.css lazily loaded. 2010-12-01 07:54:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 315455 0 pfeldman 2010-11-30 17:50:20 -0800 Otherwise it blinks. Patch to follow. helpScreen.css is only 150 lines, with primitive selectors only. 315456 1 75238 pfeldman 2010-11-30 17:52:50 -0800 Created attachment 75238 [PATCH] Proposed change 315505 2 timothy 2010-11-30 20:31:08 -0800 You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded. 315645 3 pfeldman 2010-12-01 07:54:41 -0800 (In reply to comment #2) > You could fix this by listening for the load event on the link element and aiting to show the help element until it is loaded. I am thinking of iframe-ifying parts of the inspector (i.e. hosting TextViewer in iframe as originally was with SourceFrame, hosting network log in iframe, maybe help screen). The rationale is that number of the css rules multiplied by the size of the dom makes us render slowly. Localized doms with localized styles will be a better fit... Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/HelpScreen.js M WebCore/inspector/front-end/inspector.html Committed r73021 75238 2010-11-30 17:52:50 -0800 2010-12-01 05:38:32 -0800 [PATCH] Proposed change help_screen text/plain 2636 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDAxOWI5Mi4uOGQzN2UzYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMC0xMS0zMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkbyBub3QgbWFrZSBoZWxwU2NyZWVu LmNzcyBsYXppbHkgbG9hZGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTAzMDQKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVscFNj cmVlbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWxwU2NyZWVuKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5IZWxwU2NyZWVuLnByb3RvdHlwZS5fb25CbHVyKToKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5odG1sOgorCisyMDEwLTExLTMwICBQYXZlbCBGZWxk bWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUg SHlhdHQuCiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW0NSQVNIXSBvbiAiUmV2ZXJ0IHRvIHRo aXMgcmV2aXNpb24iIG9mIHN0eWxlIHdpdGggaW1wb3J0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSGVscFNjcmVlbi5qcwppbmRleCBjYWQzOWQwLi5hMWJiZjFlIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcworKysgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSGVscFNjcmVlbi5qcwpAQCAtMzAsOCArMzAsNiBAQAogCiBXZWJJ bnNwZWN0b3IuSGVscFNjcmVlbiA9IGZ1bmN0aW9uKHRpdGxlKQogewotICAgIHRoaXMuX2FkZFN0 eWxlU2hlZXRJZk5lZWRlZCgiaGVscFNjcmVlbi5jc3MiKTsKLQogICAgIHRoaXMuX2VsZW1lbnQg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICB0aGlzLl9lbGVtZW50LmNsYXNz TmFtZSA9ICJoZWxwLXdpbmRvdy1vdXRlciI7CiAgICAgdGhpcy5fZWxlbWVudC5hZGRFdmVudExp c3RlbmVyKCJrZXlkb3duIiwgdGhpcy5fb25LZXlEb3duLmJpbmQodGhpcyksIGZhbHNlKTsKQEAg LTg2LDE3ICs4NCw1IEBAIFdlYkluc3BlY3Rvci5IZWxwU2NyZWVuLnByb3RvdHlwZSA9IHsKICAg ICAgICAgIC8vIFByZXRlbmQgd2UncmUgbW9kYWwsIGdyYWIgZm9jdXMgYmFjayBpZiB3ZSdyZSBz dGlsbCBzaG93bi4KICAgICAgICAgaWYgKHRoaXMuX2lzU2hvd24pCiAgICAgICAgICAgICBXZWJJ bnNwZWN0b3IuY3VycmVudEZvY3VzRWxlbWVudCA9IHRoaXMuY29udGVudEVsZW1lbnQ7Ci0gICAg fSwKLQotICAgIF9hZGRTdHlsZVNoZWV0SWZOZWVkZWQ6IGZ1bmN0aW9uKGhyZWYpCi0gICAgewot ICAgICAgICBpZiAoV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4uX3N0eWxlU2hlZXRBZGRlZCkKLSAg ICAgICAgICAgIHJldHVybjsKLSAgICAgICAKLSAgICAgICAgV2ViSW5zcGVjdG9yLkhlbHBTY3Jl ZW4uX3N0eWxlU2hlZXRBZGRlZCA9IHRydWU7Ci0gICAgICAgIHZhciBsaW5rID0gZG9jdW1lbnQu aGVhZC5jcmVhdGVDaGlsZCgibGluayIpOwotICAgICAgICBsaW5rLnR5cGUgPSAidGV4dC9jc3Mi OwotICAgICAgICBsaW5rLnJlbCA9ICJzdHlsZXNoZWV0IjsKLSAgICAgICAgbGluay5ocmVmID0g aHJlZjsKICAgICB9Ci19OworfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5odG1sIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rv ci5odG1sCmluZGV4IDJkNDc0NzQuLjY3ZmQwODEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuaHRtbAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvaW5zcGVjdG9yLmh0bWwKQEAgLTM1LDYgKzM1LDcgQEAgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAgICA8bGlu ayByZWw9InN0eWxlc2hlZXQiIHR5cGU9InRleHQvY3NzIiBocmVmPSJpbnNwZWN0b3IuY3NzIj4K ICAgICA8bGluayByZWw9InN0eWxlc2hlZXQiIHR5cGU9InRleHQvY3NzIiBocmVmPSJpbnNwZWN0 b3JTeW50YXhIaWdobGlnaHQuY3NzIj4KICAgICA8bGluayByZWw9InN0eWxlc2hlZXQiIHR5cGU9 InRleHQvY3NzIiBocmVmPSJuZXR3b3JrUGFuZWwuY3NzIj4KKyAgICA8bGluayByZWw9InN0eWxl c2hlZXQiIHR5cGU9InRleHQvY3NzIiBocmVmPSJoZWxwU2NyZWVuLmNzcyI+CiAgICAgPGxpbmsg cmVsPSJzdHlsZXNoZWV0IiB0eXBlPSJ0ZXh0L2NzcyIgaHJlZj0icG9wb3Zlci5jc3MiPgogICAg IDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgdHlwZT0idGV4dC9jc3MiIGhyZWY9InRleHRWaWV3ZXIu Y3NzIj4KICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJ1dGlsaXRpZXMu anMiPjwvc2NyaXB0Pgo=