50292 2010-11-30 16:42:25 -0800 Port PCRE regex tests to JSC harness / ECMA syntax 2010-12-01 11:45:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned ap oldest_to_newest 315400 0 barraclough 2010-11-30 16:42:25 -0800 LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites. There are two key problems with these tests: * They use their own harness, and cannot be run from jsc without building all of WebKit. * They expect PCRE expression syntax, including extended syntax, backwards assertions, etc. Rewrite all tests to comply to ECMA compatible syntax (ish - we support octal escapes), and use the normal 'shouldBe' test style. 315457 1 barraclough 2010-11-30 17:52:54 -0800 Fixed in r72990. 315544 2 ap 2010-11-30 22:41:13 -0800 Gavin, did you check upstream PCRE for any interesting tests that were added since we imported the suite? 315779 3 barraclough 2010-12-01 11:45:08 -0800 No, I didn't have time to look at this. My guess is that this would be an inefficient way to get high quality JS tests (since most of the PCRE tests seemed to focus on features not supported by ECMAScript). But feel free to give this a shot, if you disagree & think it may be worthwhile.