5029 2005-09-17 15:03:53 -0700 Assertion failure in -[NSPasteboard(WebExtras) _web_writeImage:URL:title:archive:types:] when trying to drag an image from a site with no favicon 2005-10-14 14:52:04 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 VERIFIED FIXED http://forever.dreamers.com/hp/cos/gargamel.gif P2 Normal --- 1 mitz vicki oldest_to_newest 19810 0 mitz 2005-09-17 15:03:53 -0700 Development build of WebKit crashes with the message ASSERTION FAILED: [[[WebImageRendererFactory sharedFactory] supportedMIMETypes] containsObject: [resource MIMEType]] (WebKit/Misc.subproj/WebNSPasteboardExtras.m:245 -[NSPasteboard(WebExtras) _web_writeImage:URL:title:archive:types:]) when opening the image in the URL in Safari and then trying to drag it out of the window. This happens whenever the site hosting the image has sent text/html content (e.g. a 404 page) as its / favicon.ico. 19839 1 ap 2005-09-18 01:58:51 -0700 I cannot reproduce the assertion with ToT. However, I have seen this assertion previously with a site that used 302 Found redirection and lied about content type. Perhaps, one needs to navigate to this picture through the site in order to reproduce the problem? 19861 2 mitz 2005-09-18 08:06:06 -0700 (In reply to comment #1) > Perhaps, one needs to navigate to this picture through the site in order to reproduce the > problem? My experience is that you can go straight to the picture as well. You should not drag immediately, though, but rather wait a couple of seconds to let WebKit fetch the favicon (you can use tcpdump or something to see when it's done so). 21890 3 mitz 2005-10-12 05:28:57 -0700 It's not just the assert that fails, you end up with the wrong resource if you're dragging into a TextEdit document. Instead of the image, you get a Safari HTML file icon. The root cause is that the favicon is added as a subresource to the image if it happens not to be loaded by the image (i.e. if it is not already in the cache), so the situation with valid favicons is no different. Even though the assertion doesn't fail, if you drag such an image from Safari into a TextEdit document, you end up with the favicon instead of the image. 21891 4 mitz 2005-10-12 05:31:17 -0700 s/happens not/happens 21895 5 4324 mitz 2005-10-12 06:25:44 -0700 Created attachment 4324 Prefer the main resource if it is an image This is an ugly fix that doesn't address the root cause, which is that the icon loader adds the favicon as a subresource. However, I see no easy way to change that behavior or to reject it in addSubResource. 22058 6 4324 mjs 2005-10-14 00:30:35 -0700 Comment on attachment 4324 Prefer the main resource if it is an image r=me 22101 7 vicki 2005-10-14 13:28:05 -0700 I committed this change. 4324 2005-10-12 06:25:44 -0700 2005-10-14 00:30:35 -0700 Prefer the main resource if it is an image 5029_r1.patch text/plain 1613 mitz SW5kZXg6IE1pc2Muc3VicHJvai9XZWJOU1Bhc3RlYm9hcmRFeHRyYXMubQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD UyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L01pc2Muc3VicHJvai9XZWJOU1Bhc3RlYm9hcmRFeHRy YXMubSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40OApkaWZmIC1wIC11IC1yMS40OCBXZWJOU1Bh c3RlYm9hcmRFeHRyYXMubQotLS0gTWlzYy5zdWJwcm9qL1dlYk5TUGFzdGVib2FyZEV4dHJhcy5t CTE2IEF1ZyAyMDA1IDE5OjAzOjI5IC0wMDAwCTEuNDgKKysrIE1pc2Muc3VicHJvai9XZWJOU1Bh c3RlYm9hcmRFeHRyYXMubQkxMiBPY3QgMjAwNSAxMzowMzo0OCAtMDAwMApAQCAtMjM4LDExICsy MzgsMTMgQEAgc3RhdGljIE5TQXJyYXkgKl93cml0YWJsZVR5cGVzRm9ySW1hZ2VXaQogICAgICAg ICBpZiAoW3R5cGVzIGNvbnRhaW5zT2JqZWN0Ok5TUlRGRFBib2FyZFR5cGVdKSB7CiAgICAgICAg ICAgICAvLyBUaGlzIGltYWdlIGRhdGEgaXMgZWl0aGVyIHRoZSBvbmx5IHN1YnJlc291cmNlIG9m IGFuIGFyY2hpdmUgKEhUTUwgaW1hZ2UgY2FzZSkKICAgICAgICAgICAgIC8vIG9yIHRoZSBtYWlu IHJlc291cmNlIChzdGFuZGFsb25lIGltYWdlIGNhc2UpLgorICAgICAgICAgICAgTlNBcnJheSAq aW1hZ2VUeXBlcyA9IFtbV2ViSW1hZ2VSZW5kZXJlckZhY3Rvcnkgc2hhcmVkRmFjdG9yeV0gc3Vw cG9ydGVkTUlNRVR5cGVzXTsKICAgICAgICAgICAgIE5TQXJyYXkgKnN1YnJlc291cmNlcyA9IFth cmNoaXZlIHN1YnJlc291cmNlc107Ci0gICAgICAgICAgICBXZWJSZXNvdXJjZSAqcmVzb3VyY2Ug PSBbc3VicmVzb3VyY2VzIGNvdW50XSA+IDAgPyAoV2ViUmVzb3VyY2UgKilbc3VicmVzb3VyY2Vz IG9iamVjdEF0SW5kZXg6MF0gOiBbYXJjaGl2ZSBtYWluUmVzb3VyY2VdOworICAgICAgICAgICAg V2ViUmVzb3VyY2UgKm1haW5SZXNvdXJjZSA9IFthcmNoaXZlIG1haW5SZXNvdXJjZV07CisgICAg ICAgICAgICBXZWJSZXNvdXJjZSAqcmVzb3VyY2UgPSAhW2ltYWdlVHlwZXMgY29udGFpbnNPYmpl Y3Q6W21haW5SZXNvdXJjZSBNSU1FVHlwZV1dICYmIFtzdWJyZXNvdXJjZXMgY291bnRdID4gMCA/ IChXZWJSZXNvdXJjZSAqKVtzdWJyZXNvdXJjZXMgb2JqZWN0QXRJbmRleDowXSA6IG1haW5SZXNv dXJjZTsKICAgICAgICAgICAgIEFTU0VSVChyZXNvdXJjZSAhPSBuaWwpOwogICAgICAgICAgICAg Ci0gICAgICAgICAgICBBU1NFUlQoW1tbV2ViSW1hZ2VSZW5kZXJlckZhY3Rvcnkgc2hhcmVkRmFj dG9yeV0gc3VwcG9ydGVkTUlNRVR5cGVzXSBjb250YWluc09iamVjdDpbcmVzb3VyY2UgTUlNRVR5 cGVdXSk7CisgICAgICAgICAgICBBU1NFUlQoW2ltYWdlVHlwZXMgY29udGFpbnNPYmplY3Q6W3Jl c291cmNlIE1JTUVUeXBlXV0pOwogICAgICAgICAgICAgW3NlbGYgX3dlYl93cml0ZUZpbGVXcmFw cGVyQXNSVEZEQXR0YWNobWVudDpbcmVzb3VyY2UgX2ZpbGVXcmFwcGVyUmVwcmVzZW50YXRpb25d XTsKICAgICAgICAgfQogICAgICAgICBpZiAoW3R5cGVzIGNvbnRhaW5zT2JqZWN0OldlYkFyY2hp dmVQYm9hcmRUeXBlXSkgewo=