50285 2010-11-30 16:21:04 -0800 [chromium] histograms api updated in WebKitClient and added to ChromiumBridge 2010-12-02 08:33:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scheib webkit-unassigned commit-queue fishd oldest_to_newest 315377 0 scheib 2010-11-30 16:21:04 -0800 [chromium] histograms api updated in WebKitClient and added to ChromiumBridge 315406 1 75225 scheib 2010-11-30 16:47:46 -0800 Created attachment 75225 Patch 315741 2 75225 fishd 2010-12-01 10:56:04 -0800 Comment on attachment 75225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review > WebCore/platform/chromium/ChromiumBridge.h:242 > + static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount); Why the "custom" modifier? Why not just call this histogramCounts? 315843 3 75225 scheib 2010-12-01 13:09:55 -0800 Comment on attachment 75225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75225&action=review >> WebCore/platform/chromium/ChromiumBridge.h:242 >> + static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount); > > Why the "custom" modifier? Why not just call this histogramCounts? This mimics the low level api name used in Chromium HISTOGRAM_CUSTOM_COUNTS, the name HISTOGRAM_COUNTS is used with only two parameters (name, sample). 315850 4 75225 fishd 2010-12-01 13:15:08 -0800 Comment on attachment 75225 Patch Ah, R=me 316167 5 commit-queue 2010-12-02 08:31:39 -0800 The commit-queue encountered the following flaky tests while processing attachment 75225: http/tests/misc/copy-resolves-urls.html Please file bugs against the tests. These tests were authored by tony@chromium.org. The commit-queue is continuing to process your patch. 316169 6 75225 commit-queue 2010-12-02 08:33:27 -0800 Comment on attachment 75225 Patch Clearing flags on attachment: 75225 Committed r73137: <http://trac.webkit.org/changeset/73137> 316170 7 commit-queue 2010-12-02 08:33:32 -0800 All reviewed patches have been landed. Closing bug. 75225 2010-11-30 16:47:46 -0800 2010-12-02 08:33:27 -0800 Patch bug-50285-20101130164745.patch text/plain 5939 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWI0YzJmOGViMTJiZDcyMGUyYTljMzFhY2QzNmU1YzM4YmIzMDRmMi4uOGYxMGYwYWZkMGJmNmM2 N2Y3YWVhYzUwMDBmMGU2MWZkYjBlZDQwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0zMCAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gaGlzdG9ncmFtcyBhcGkgdXBk YXRlZCBpbiBXZWJLaXRDbGllbnQgYW5kIGFkZGVkIHRvIENocm9taXVtQnJpZGdlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDI4NQorCisgICAgICAg IFRlc3QgYnkgbG9hZGluZyAiYWJvdXQ6aGlzdG9ncmFtcyIgYWZ0ZXIgbmF2aWdhdGluZyB0byBh Y2NlbGVyYXRlZCBwYWdlcy4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVt QnJpZGdlLmg6IGFwaSB1cGRhdGUuCisKIDIwMTAtMTEtMjkgIE1pa2hhaWwgTmFnYW5vdiAgPG1u YWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFu LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5o IGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bUJyaWRnZS5oCmluZGV4IDhjYTY0 MzQ5YzdiZTU2ZjE5N2FiODc5MTZiODQ4NDRkODVlZjE0ODEuLmFiNjg5OTc4ZDYxOWQ1ZmZhODkx NmEyNWEwZDc2Mjc4NjM2MjRlZjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vQ2hyb21pdW1CcmlkZ2UuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9t aXVtQnJpZGdlLmgKQEAgLTIzOSw2ICsyMzksOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIC8vIFN0YXRzQ291bnRlcnMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCiAgICAgICAgIHN0YXRpYyB2b2lkIGRlY3JlbWVudFN0YXRzQ291 bnRlcihjb25zdCBjaGFyKiBuYW1lKTsKICAgICAgICAgc3RhdGljIHZvaWQgaW5jcmVtZW50U3Rh dHNDb3VudGVyKGNvbnN0IGNoYXIqIG5hbWUpOworICAgICAgICBzdGF0aWMgdm9pZCBoaXN0b2dy YW1DdXN0b21Db3VudHMoY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IG1pbiwgaW50 IG1heCwgaW50IGJ1Y2tldENvdW50KTsKKyAgICAgICAgc3RhdGljIHZvaWQgaGlzdG9ncmFtRW51 bWVyYXRpb24oY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IGJvdW5kYXJ5VmFsdWUp OwogCiAgICAgICAgIC8vIFN1ZGRlbiBUZXJtaW5hdGlvbgogICAgICAgICBzdGF0aWMgdm9pZCBz dWRkZW5UZXJtaW5hdGlvbkNoYW5nZWQoYm9vbCBlbmFibGVkKTsKZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDNm OWVmYzk5ZTJkM2YzYjQzNzg3OWUwZjNjNDA3MzgyMGRiM2MyYzQuLmZlNWI4Yzg0NzBjNTdkNWZm NmI5Njk3ZTNkNzgyMmFhMzc5OTBiOTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisy MDEwLTExLTMwICBWaW5jZW50IFNjaGVpYiAgPHNjaGVpYkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBoaXN0 b2dyYW1zIGFwaSB1cGRhdGVkIGluIFdlYktpdENsaWVudC9DaHJvbWl1bUJyaWRnZSBhbmQgaGlz dG9ncmFtICJHUFUuc2V0SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlIiBhZGRlZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjg1CisKKyAg ICAgICAgVGVzdCBieSBsb2FkaW5nICJhYm91dDpoaXN0b2dyYW1zIiBhZnRlciBuYXZpZ2F0aW5n IHRvIGFjY2VsZXJhdGVkIHBhZ2VzLgorCisgICAgICAgICogcHVibGljL1dlYktpdENsaWVudC5o OgorICAgICAgICAoV2ViS2l0OjpXZWJLaXRDbGllbnQ6Omhpc3RvZ3JhbUN1c3RvbUNvdW50cyk6 IGFwaSB1cGRhdGUuCisgICAgICAgIChXZWJLaXQ6OldlYktpdENsaWVudDo6aGlzdG9ncmFtRW51 bWVyYXRpb24pOiBhcGkgdXBkYXRlLgorICAgICAgICAqIHNyYy9DaHJvbWl1bUJyaWRnZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6aGlzdG9ncmFtQ3VzdG9tQ291bnRz KTogYXBpIHVwZGF0ZS4KKyAgICAgICAgKFdlYkNvcmU6OkNocm9taXVtQnJpZGdlOjpoaXN0b2dy YW1FbnVtZXJhdGlvbik6IGFwaSB1cGRhdGUuCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldElzQWNjZWxlcmF0ZWRDb21wb3Np dGluZ0FjdGl2ZSk6ICJHUFUuc2V0SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlIiBhZGRl ZC4KKwogMjAxMC0xMS0yOSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViS2l0 Q2xpZW50LmgKaW5kZXggMGM0MDIwZjc0MDdiOGEyYmQzMDdiZDJmMDA2ODA2ZDRjNzM1ZDhkYy4u ZDE2OGQzMjBkMGQ2MWZmMDg5ZjU5OWFhMWJhMjBhODY2Zjc1MmYzOCAxMDA2NDQKLS0tIGEvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYktpdENsaWVudC5oCkBAIC0yMTAsMTAgKzIxMCwxMSBAQCBwdWJsaWM6CiAgICAg dmlydHVhbCB2b2lkIHRyYWNlRXZlbnRCZWdpbihjb25zdCBjaGFyKiBuYW1lLCB2b2lkKiBpZCwg Y29uc3QgY2hhciogZXh0cmEpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB0cmFjZUV2ZW50RW5kKGNv bnN0IGNoYXIqIG5hbWUsIHZvaWQqIGlkLCBjb25zdCBjaGFyKiBleHRyYSkgeyB9CiAKLSAgICAv LyBHZW5lcmljIGNhbGxiYWNrIGZvciByZXBvcnRpbmcgaGlzdG9ncmFtIGRhdGEuIFJhbmdlIGlz IGlkZW50aWZpZWQgYnkgdGhlIG1pbiwgbWF4IHBhaXIuCi0gICAgLy8gQnkgZGVmYXVsdCwgaGlz dG9ncmFtIGlzIGV4cG9uZW50aWFsLCBzbyB0aGF0IG1pbj0xLCBtYXg9MTAwMDAwMCwgYnVja2V0 Q291bnQ9NTAgd291bGQgZG8uIFNldHRpbmcKLSAgICAvLyBsaW5lYXIgdG8gdHJ1ZSB3b3VsZCBy ZXF1aXJlIGJ1Y2tldCBjb3VudCB0byBjb3ZlciB3aG9sZSBtaW4tbWF4IHJhbmdlLgotICAgIHZp cnR1YWwgdm9pZCBoaXN0b2dyYW1Db3VudHMoY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBpbnQgc2Ft cGxlLCBpbnQgbWluLCBpbnQgbWF4LCBpbnQgYnVja2V0Q291bnQsIGJvb2wgbGluZWFyKSB7IH0K KyAgICAvLyBDYWxsYmFja3MgZm9yIHJlcG9ydGluZyBoaXN0b2dyYW0gZGF0YS4KKyAgICAvLyBD dXN0b21Db3VudHMgaGlzdG9ncmFtIGhhcyBleHBvbmVudGlhbCBidWNrZXQgc2l6ZXMsIHNvIHRo YXQgbWluPTEsIG1heD0xMDAwMDAwLCBidWNrZXRDb3VudD01MCB3b3VsZCBkby4KKyAgICB2aXJ0 dWFsIHZvaWQgaGlzdG9ncmFtQ3VzdG9tQ291bnRzKGNvbnN0IGNoYXIqIG5hbWUsIGludCBzYW1w bGUsIGludCBtaW4sIGludCBtYXgsIGludCBidWNrZXRDb3VudCkgeyB9CisgICAgLy8gRW51bWVy YXRpb24gaGlzdG9ncmFtIGJ1Y2tldHMgYXJlIGxpbmVhciwgYm91bmRhcnlWYWx1ZSBzaG91bGQg YmUgbGFyZ2VyIHRoYW4gYW55IHBvc3NpYmxlIHNhbXBsZSB2YWx1ZS4KKyAgICB2aXJ0dWFsIHZv aWQgaGlzdG9ncmFtRW51bWVyYXRpb24oY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50 IGJvdW5kYXJ5VmFsdWUpIHsgfQogCiAKICAgICAvLyBSZXNvdXJjZXMgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBh L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAKaW5kZXggNGFjM2Y2ZjY4YzgxYjAzZGNkOTZlYTM5NzNk MjFlNWM1ZDYxMTVmOC4uZTlkMWRhNjE2NjFiOTk4YTA4OGRiY2QxODhhYmFiNTIyOWQ4ZWFiZiAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAKKysrIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWl1bUJyaWRnZS5jcHAKQEAgLTY3OSw2ICs2NzksMTYg QEAgdm9pZCBDaHJvbWl1bUJyaWRnZTo6aW5jcmVtZW50U3RhdHNDb3VudGVyKGNvbnN0IGNoYXIq IG5hbWUpCiAgICAgd2ViS2l0Q2xpZW50KCktPmluY3JlbWVudFN0YXRzQ291bnRlcihuYW1lKTsK IH0KIAordm9pZCBDaHJvbWl1bUJyaWRnZTo6aGlzdG9ncmFtQ3VzdG9tQ291bnRzKGNvbnN0IGNo YXIqIG5hbWUsIGludCBzYW1wbGUsIGludCBtaW4sIGludCBtYXgsIGludCBidWNrZXRDb3VudCkK K3sKKyAgICB3ZWJLaXRDbGllbnQoKS0+aGlzdG9ncmFtQ3VzdG9tQ291bnRzKG5hbWUsIHNhbXBs ZSwgbWluLCBtYXgsIGJ1Y2tldENvdW50KTsKK30KKwordm9pZCBDaHJvbWl1bUJyaWRnZTo6aGlz dG9ncmFtRW51bWVyYXRpb24oY29uc3QgY2hhciogbmFtZSwgaW50IHNhbXBsZSwgaW50IGJvdW5k YXJ5VmFsdWUpCit7CisgICAgd2ViS2l0Q2xpZW50KCktPmhpc3RvZ3JhbUVudW1lcmF0aW9uKG5h bWUsIHNhbXBsZSwgYm91bmRhcnlWYWx1ZSk7Cit9CisKIC8vIFN1ZGRlbiBUZXJtaW5hdGlvbiAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K IAogdm9pZCBDaHJvbWl1bUJyaWRnZTo6c3VkZGVuVGVybWluYXRpb25DaGFuZ2VkKGJvb2wgZW5h YmxlZCkKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggYzZmMjI3ZWMyYmM1ZjEy OTExMjA2OWU0MzM0MjE3YjlmYzg4NTJkNS4uM2MxZDFkZWVkNjY5YzIyNDk5YWM0NDQ2MTE1N2Ji YWQwZjVhMjQ5OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5j cHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTM1LDYgKzM1 LDcgQEAKICNpbmNsdWRlICJBWE9iamVjdENhY2hlLmgiCiAjaW5jbHVkZSAiQmFja0ZvcndhcmRM aXN0SW1wbC5oIgogI2luY2x1ZGUgIkNocm9tZS5oIgorI2luY2x1ZGUgIkNocm9taXVtQnJpZGdl LmgiCiAjaW5jbHVkZSAiQ29sb3JTcGFjZS5oIgogI2luY2x1ZGUgIkNvbXBvc2l0aW9uVW5kZXJs aW5lVmVjdG9yQnVpbGRlci5oIgogI2luY2x1ZGUgIkNvbnRleHRNZW51LmgiCkBAIC0yMzc2LDYg KzIzNzcsOCBAQCB2b2lkIFdlYlZpZXdJbXBsOjppbnZhbGlkYXRlUm9vdExheWVyUmVjdChjb25z dCBJbnRSZWN0JiByZWN0KQogCiB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29t cG9zaXRpbmdBY3RpdmUoYm9vbCBhY3RpdmUpCiB7CisgICAgQ2hyb21pdW1CcmlkZ2U6Omhpc3Rv Z3JhbUVudW1lcmF0aW9uKCJHUFUuc2V0SXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlIiwg YWN0aXZlICogMiArIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlLCA0KTsKKwogICAg IGlmIChtX2lzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSA9PSBhY3RpdmUpCiAgICAgICAg IHJldHVybjsKIAo=