50284 2010-11-30 16:12:36 -0800 [WINCE] Remove "current path" of GraphicsContext 2010-12-02 12:37:53 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 48516 1 paroga paroga commit-queue eric oldest_to_newest 315372 0 paroga 2010-11-30 16:12:36 -0800 see patch 315375 1 75220 paroga 2010-11-30 16:15:50 -0800 Created attachment 75220 Patch 315569 2 75220 kling 2010-12-01 01:24:01 -0800 Comment on attachment 75220 Patch Awesome! r=me 316109 3 75220 paroga 2010-12-02 06:34:26 -0800 Comment on attachment 75220 Patch patch won't apply, I'll commit it manually 316117 4 commit-queue 2010-12-02 06:47:09 -0800 The commit-queue encountered the following flaky tests while processing attachment 75220: fast/images/load-img-with-empty-src.html compositing/reflections/nested-reflection-animated.html Please file bugs against the tests. These tests were authored by mitz@webkit.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 316205 5 eric 2010-12-02 09:30:40 -0800 It seems like it does apply if it's hititng flaky tests. :) But manual commits are alway sifne. The tree is very very bad these days, which is much of why the cq has so much trouble. 316265 6 paroga 2010-12-02 11:15:12 -0800 (In reply to comment #5) > It seems like it does apply if it's hititng flaky tests. :) But manual commits are alway sifne. But the SVN commit will fail, because the WX patch was first: http://trac.webkit.org/changeset/73129 ;-) 316348 7 75220 paroga 2010-12-02 12:37:22 -0800 Comment on attachment 75220 Patch Clearing flags on attachment: 75220 Manually committed r73183: <http://trac.webkit.org/changeset/73183> 316349 8 paroga 2010-12-02 12:37:53 -0800 All reviewed patches have been landed. Closing bug. 75220 2010-11-30 16:15:50 -0800 2010-12-02 12:37:22 -0800 Patch bug-50284.patch text/plain 6427 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjM5ZGE4OC4uZThkYmVhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0zMCAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbV0lOQ0VdIFJlbW92ZSAiY3VycmVudCBwYXRoIiBvZiBHcmFw aGljc0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUwMjg0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9HcmFwaGljc0NvbnRleHRXaW5D RS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmZpbGxQYXRoKToKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c3Ryb2tlUGF0aCk6CisKIDIwMTAtMTEt MzAgIENocmlzIEd1aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dC5oCmluZGV4IDk0MjViZjYuLmFiODFjMDEgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAtMzAxLDcgKzMwMSw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2b2lkIHNldENvbXBvc2l0ZU9wZXJhdGlvbihD b21wb3NpdGVPcGVyYXRvcik7CiAKLSNpZiBQTEFURk9STShTS0lBKSB8fCBQTEFURk9STShXWCkg fHwgUExBVEZPUk0oT1BFTlZHKSB8fCBPUyhXSU5DRSkKKyNpZiBQTEFURk9STShTS0lBKSB8fCBQ TEFURk9STShXWCkgfHwgUExBVEZPUk0oT1BFTlZHKQogICAgICAgICB2b2lkIGJlZ2luUGF0aCgp OwogICAgICAgICB2b2lkIGFkZFBhdGgoY29uc3QgUGF0aCYpOwogI2VuZGlmCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbmNlL0dyYXBoaWNzQ29udGV4dFdpbkNFLmNw cCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luQ0Uu Y3BwCmluZGV4IDRmYWEyOWQuLjhjNmUxN2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luQ0UuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvd2luY2UvR3JhcGhpY3NDb250ZXh0V2luQ0UuY3BwCkBAIC0xNzMsNyAr MTczLDYgQEAgcHVibGljOgogCiAgICAgQWZmaW5lVHJhbnNmb3JtIG1fdHJhbnNmb3JtOwogICAg IGZsb2F0IG1fb3BhY2l0eTsKLSAgICBWZWN0b3I8UGF0aD4gbV9wYXRoczsKIH07CiAKIGVudW0g QWxwaGFQYWludFR5cGUgewpAQCAtMTE4MiwxNiArMTE4MSw2IEBAIHZvaWQgR3JhcGhpY3NDb250 ZXh0OjpzZXRDb21wb3NpdGVPcGVyYXRpb24oQ29tcG9zaXRlT3BlcmF0b3Igb3ApCiAgICAgbm90 SW1wbGVtZW50ZWQoKTsKIH0KIAotdm9pZCBHcmFwaGljc0NvbnRleHQ6OmJlZ2luUGF0aCgpCi17 Ci0gICAgbV9kYXRhLT5tX3BhdGhzLmNsZWFyKCk7Ci19Ci0KLXZvaWQgR3JhcGhpY3NDb250ZXh0 OjphZGRQYXRoKGNvbnN0IFBhdGgmIHBhdGgpCi17Ci0gICAgbV9kYXRhLT5tX3BhdGhzLmFwcGVu ZChwYXRoKTsKLX0KLQogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNsaXAoY29uc3QgUGF0aCYgcGF0 aCkKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwpAQCAtMTMyNywxMCArMTMxNiw2IEBAIENvbG9y IGdyYWRpZW50QXZlcmFnZUNvbG9yKGNvbnN0IEdyYWRpZW50KiBncmFkaWVudCkKIAogdm9pZCBH cmFwaGljc0NvbnRleHQ6OmZpbGxQYXRoKGNvbnN0IFBhdGgmIHBhdGgpCiB7Ci0gICAgLy8gRklY TUU6IEJlIHNtYXJ0ZXIgYWJvdXQgdGhpcy4KLSAgICBiZWdpblBhdGgoKTsKLSAgICBhZGRQYXRo KHBhdGgpOwotCiAgICAgQ29sb3IgYyA9IG1fY29tbW9uLT5zdGF0ZS5maWxsR3JhZGllbnQKICAg ICAgICAgPyBncmFkaWVudEF2ZXJhZ2VDb2xvcihtX2NvbW1vbi0+c3RhdGUuZmlsbEdyYWRpZW50 LmdldCgpKQogICAgICAgICA6IGZpbGxDb2xvcigpOwpAQCAtMTM0NSwyNyArMTMzMCwyNCBAQCB2 b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFBhdGgoY29uc3QgUGF0aCYgcGF0aCkKICAgICBPd25Q dHI8SEJSVVNIPiBicnVzaCA9IGNyZWF0ZUJydXNoKGMpOwogCiAgICAgaWYgKG1fZGF0YS0+bV9v cGFjaXR5IDwgMS4wZiB8fCBtX2RhdGEtPmhhc0FscGhhKCkpIHsKLSAgICAgICAgZm9yIChWZWN0 b3I8UGF0aD46OmNvbnN0X2l0ZXJhdG9yIGkgPSBtX2RhdGEtPm1fcGF0aHMuYmVnaW4oKTsgaSAh PSBtX2RhdGEtPm1fcGF0aHMuZW5kKCk7ICsraSkgewotICAgICAgICAgICAgSW50UmVjdCB0clJl Y3QgPSBlbmNsb3NpbmdJbnRSZWN0KG1fZGF0YS0+bWFwUmVjdChpLT5ib3VuZGluZ1JlY3QoKSkp OwotICAgICAgICAgICAgdHJSZWN0LmluZmxhdGUoMSk7Ci0gICAgICAgICAgICBUcmFuc3BhcmVu dExheWVyREMgdHJhbnNwYXJlbnREQyhtX2RhdGEsIHRyUmVjdCk7Ci0gICAgICAgICAgICBIREMg ZGMgPSB0cmFuc3BhcmVudERDLmhkYygpOwotICAgICAgICAgICAgaWYgKCFkYykKLSAgICAgICAg ICAgICAgICBjb250aW51ZTsKLQotICAgICAgICAgICAgQWZmaW5lVHJhbnNmb3JtIHRyID0gbV9k YXRhLT5tX3RyYW5zZm9ybTsKLSAgICAgICAgICAgIHRyLnRyYW5zbGF0ZSh0cmFuc3BhcmVudERD LnRvU2hpZnQoKS53aWR0aCgpLCB0cmFuc3BhcmVudERDLnRvU2hpZnQoKS5oZWlnaHQoKSk7Ci0K LSAgICAgICAgICAgIFNlbGVjdE9iamVjdChkYywgR2V0U3RvY2tPYmplY3QoTlVMTF9QRU4pKTsK LSAgICAgICAgICAgIEhHRElPQkogb2xkQnJ1c2ggPSBTZWxlY3RPYmplY3QoZGMsIGJydXNoLmdl dCgpKTsKLSAgICAgICAgICAgIGktPnBsYXRmb3JtUGF0aCgpLT5maWxsUGF0aChkYywgJnRyKTsK LSAgICAgICAgICAgIFNlbGVjdE9iamVjdChkYywgb2xkQnJ1c2gpOwotICAgICAgICB9CisgICAg ICAgIEludFJlY3QgdHJSZWN0ID0gZW5jbG9zaW5nSW50UmVjdChtX2RhdGEtPm1hcFJlY3QocGF0 aC5ib3VuZGluZ1JlY3QoKSkpOworICAgICAgICB0clJlY3QuaW5mbGF0ZSgxKTsKKyAgICAgICAg VHJhbnNwYXJlbnRMYXllckRDIHRyYW5zcGFyZW50REMobV9kYXRhLCB0clJlY3QpOworICAgICAg ICBIREMgZGMgPSB0cmFuc3BhcmVudERDLmhkYygpOworICAgICAgICBpZiAoIWRjKQorICAgICAg ICAgICAgY29udGludWU7CisKKyAgICAgICAgQWZmaW5lVHJhbnNmb3JtIHRyID0gbV9kYXRhLT5t X3RyYW5zZm9ybTsKKyAgICAgICAgdHIudHJhbnNsYXRlKHRyYW5zcGFyZW50REMudG9TaGlmdCgp LndpZHRoKCksIHRyYW5zcGFyZW50REMudG9TaGlmdCgpLmhlaWdodCgpKTsKKworICAgICAgICBT ZWxlY3RPYmplY3QoZGMsIEdldFN0b2NrT2JqZWN0KE5VTExfUEVOKSk7CisgICAgICAgIEhHRElP Qkogb2xkQnJ1c2ggPSBTZWxlY3RPYmplY3QoZGMsIGJydXNoLmdldCgpKTsKKyAgICAgICAgcGF0 aC5wbGF0Zm9ybVBhdGgoKS0+ZmlsbFBhdGgoZGMsICZ0cik7CisgICAgICAgIFNlbGVjdE9iamVj dChkYywgb2xkQnJ1c2gpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFNlbGVjdE9iamVjdChtX2Rh dGEtPm1fZGMsIEdldFN0b2NrT2JqZWN0KE5VTExfUEVOKSk7CiAgICAgICAgIEhHRElPQkogb2xk QnJ1c2ggPSBTZWxlY3RPYmplY3QobV9kYXRhLT5tX2RjLCBicnVzaC5nZXQoKSk7Ci0gICAgICAg IGZvciAoVmVjdG9yPFBhdGg+Ojpjb25zdF9pdGVyYXRvciBpID0gbV9kYXRhLT5tX3BhdGhzLmJl Z2luKCk7IGkgIT0gbV9kYXRhLT5tX3BhdGhzLmVuZCgpOyArK2kpCi0gICAgICAgICAgICBpLT5w bGF0Zm9ybVBhdGgoKS0+ZmlsbFBhdGgobV9kYXRhLT5tX2RjLCAmbV9kYXRhLT5tX3RyYW5zZm9y bSk7CisgICAgICAgIHBhdGgucGxhdGZvcm1QYXRoKCktPmZpbGxQYXRoKG1fZGF0YS0+bV9kYywg Jm1fZGF0YS0+bV90cmFuc2Zvcm0pOwogICAgICAgICBTZWxlY3RPYmplY3QobV9kYXRhLT5tX2Rj LCBvbGRCcnVzaCk7CiAgICAgfQogfQpAQCAtMTM4MCwzNCArMTM2MiwyNyBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDo6c3Ryb2tlUGF0aCgpCiAgICAgaWYgKCFtX2RhdGEtPm1fZGMpCiAgICAgICAg IHJldHVybjsKIAotICAgIC8vIEZJWE1FOiBCZSBzbWFydGVyIGFib3V0IHRoaXMuCi0gICAgYmVn aW5QYXRoKCk7Ci0gICAgYWRkUGF0aChwYXRoKTsKLQogICAgIE93blB0cjxIUEVOPiBwZW4gPSBj cmVhdGVQZW4oc3Ryb2tlQ29sb3IoKSwgc3Ryb2tlVGhpY2tuZXNzKCksIHN0cm9rZVN0eWxlKCkp OwogCiAgICAgaWYgKG1fZGF0YS0+bV9vcGFjaXR5IDwgMS4wZiB8fCBtX2RhdGEtPmhhc0FscGhh KCkpIHsKLSAgICAgICAgZm9yIChWZWN0b3I8UGF0aD46OmNvbnN0X2l0ZXJhdG9yIGkgPSBtX2Rh dGEtPm1fcGF0aHMuYmVnaW4oKTsgaSAhPSBtX2RhdGEtPm1fcGF0aHMuZW5kKCk7ICsraSkgewot ICAgICAgICAgICAgSW50UmVjdCB0clJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KG1fZGF0YS0+bWFw UmVjdChpLT5ib3VuZGluZ1JlY3QoKSkpOwotICAgICAgICAgICAgdHJSZWN0LmluZmxhdGUoMSk7 Ci0gICAgICAgICAgICBUcmFuc3BhcmVudExheWVyREMgdHJhbnNwYXJlbnREQyhtX2RhdGEsIHRy UmVjdCk7Ci0gICAgICAgICAgICBIREMgZGMgPSB0cmFuc3BhcmVudERDLmhkYygpOwotICAgICAg ICAgICAgaWYgKCFkYykKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAgICAgICAg QWZmaW5lVHJhbnNmb3JtIHRyID0gbV9kYXRhLT5tX3RyYW5zZm9ybTsKLSAgICAgICAgICAgIHRy LnRyYW5zbGF0ZSh0cmFuc3BhcmVudERDLnRvU2hpZnQoKS53aWR0aCgpLCB0cmFuc3BhcmVudERD LnRvU2hpZnQoKS5oZWlnaHQoKSk7Ci0KLSAgICAgICAgICAgIFNlbGVjdE9iamVjdChkYywgR2V0 U3RvY2tPYmplY3QoTlVMTF9CUlVTSCkpOwotICAgICAgICAgICAgSEdESU9CSiBvbGRQZW4gPSBT ZWxlY3RPYmplY3QoZGMsIHBlbi5nZXQoKSk7Ci0gICAgICAgICAgICBpLT5wbGF0Zm9ybVBhdGgo KS0+c3Ryb2tlUGF0aChkYywgJnRyKTsKLSAgICAgICAgICAgIFNlbGVjdE9iamVjdChkYywgb2xk UGVuKTsKLSAgICAgICAgfQorICAgICAgICBJbnRSZWN0IHRyUmVjdCA9IGVuY2xvc2luZ0ludFJl Y3QobV9kYXRhLT5tYXBSZWN0KHBhdGguYm91bmRpbmdSZWN0KCkpKTsKKyAgICAgICAgdHJSZWN0 LmluZmxhdGUoMSk7CisgICAgICAgIFRyYW5zcGFyZW50TGF5ZXJEQyB0cmFuc3BhcmVudERDKG1f ZGF0YSwgdHJSZWN0KTsKKyAgICAgICAgSERDIGRjID0gdHJhbnNwYXJlbnREQy5oZGMoKTsKKyAg ICAgICAgaWYgKCFkYykKKyAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAgIEFmZmluZVRy YW5zZm9ybSB0ciA9IG1fZGF0YS0+bV90cmFuc2Zvcm07CisgICAgICAgIHRyLnRyYW5zbGF0ZSh0 cmFuc3BhcmVudERDLnRvU2hpZnQoKS53aWR0aCgpLCB0cmFuc3BhcmVudERDLnRvU2hpZnQoKS5o ZWlnaHQoKSk7CisKKyAgICAgICAgU2VsZWN0T2JqZWN0KGRjLCBHZXRTdG9ja09iamVjdChOVUxM X0JSVVNIKSk7CisgICAgICAgIEhHRElPQkogb2xkUGVuID0gU2VsZWN0T2JqZWN0KGRjLCBwZW4u Z2V0KCkpOworICAgICAgICBwYXRoLnBsYXRmb3JtUGF0aCgpLT5zdHJva2VQYXRoKGRjLCAmdHIp OworICAgICAgICBTZWxlY3RPYmplY3QoZGMsIG9sZFBlbik7CiAgICAgfSBlbHNlIHsKICAgICAg ICAgU2VsZWN0T2JqZWN0KG1fZGF0YS0+bV9kYywgR2V0U3RvY2tPYmplY3QoTlVMTF9CUlVTSCkp OwogICAgICAgICBIR0RJT0JKIG9sZFBlbiA9IFNlbGVjdE9iamVjdChtX2RhdGEtPm1fZGMsIHBl bi5nZXQoKSk7Ci0gICAgICAgIGZvciAoVmVjdG9yPFBhdGg+Ojpjb25zdF9pdGVyYXRvciBpID0g bV9kYXRhLT5tX3BhdGhzLmJlZ2luKCk7IGkgIT0gbV9kYXRhLT5tX3BhdGhzLmVuZCgpOyArK2kp Ci0gICAgICAgICAgICBpLT5wbGF0Zm9ybVBhdGgoKS0+c3Ryb2tlUGF0aChtX2RhdGEtPm1fZGMs ICZtX2RhdGEtPm1fdHJhbnNmb3JtKTsKKyAgICAgICAgcGF0aC5wbGF0Zm9ybVBhdGgoKS0+c3Ry b2tlUGF0aChtX2RhdGEtPm1fZGMsICZtX2RhdGEtPm1fdHJhbnNmb3JtKTsKICAgICAgICAgU2Vs ZWN0T2JqZWN0KG1fZGF0YS0+bV9kYywgb2xkUGVuKTsKICAgICB9CiB9Cg==